[Freeipa-devel] [freeipa PR#578][edited] Coverity: fix bad use of null-like value in cert.py

2017-03-14 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/578 Author: tomaskrizek Title: #578: Coverity: fix bad use of null-like value in cert.py Action: edited Changed field: body Original value: """ http://cov01.lab.eng.brq.redhat.com/covscanhub/task/38300/log/fixed.html#def2 """ -- Manage your

[Freeipa-devel] [freeipa PR#574][comment] ipa-replica-prepare fix

2017-03-14 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/574 Title: #574: ipa-replica-prepare fix stlaz commented: """ @MartinBasti should be fixed in https://github.com/freeipa/freeipa/pull/580 """ See the full comment at https://github.com/freeipa/freeipa/pull/574#issuecomment-286352636 -- Manage your

[Freeipa-devel] [freeipa PR#580][opened] Fix KDC certificates export on DL0

2017-03-14 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/580 Author: stlaz Title: #580: Fix KDC certificates export on DL0 Action: opened PR body: """ I don't know since when this has been broken but my guess is - for a long time. """ To pull the PR as Git branch: git remote add ghfreeipa

[Freeipa-devel] [freeipa PR#559][synchronized] WebUI: Certificate login

2017-03-14 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/559 Author: pvomacka Title: #559: WebUI: Certificate login Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/559/head:pr559 git checkout pr559 From

[Freeipa-devel] [freeipa PR#559][synchronized] WebUI: Certificate login

2017-03-14 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/559 Author: pvomacka Title: #559: WebUI: Certificate login Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/559/head:pr559 git checkout pr559 From

[Freeipa-devel] [freeipa PR#567][comment] Configure KDC to use certs after they are deployed

2017-03-14 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/567 Title: #567: Configure KDC to use certs after they are deployed martbab commented: """ @simo5 actually I found multiple issues during review and concluded that setting up PKINIT on DL1 replica never worked correctly actually. Will open

[Freeipa-devel] [freeipa PR#580][synchronized] Fix KDC certificates export on DL0

2017-03-14 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/580 Author: stlaz Title: #580: Fix KDC certificates export on DL0 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/580/head:pr580 git checkout pr580 From

[Freeipa-devel] [freeipa PR#574][+ack] ipa-replica-prepare fix

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/574 Title: #574: ipa-replica-prepare fix Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#578][comment] Coverity: fix bad use of null-like value in cert.py

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/578 Title: #578: Coverity: fix bad use of null-like value in cert.py MartinBasti commented: """ But this is about `principal_obj`, I don't see it in step 2, but I see `principal_obj = None` in step 11 """ See the full comment at

Re: [Freeipa-devel] [DRAFT] Release notes FreeIPA 4.5.0

2017-03-14 Thread Standa Laznicka
On 03/14/2017 04:21 PM, Rob Crittenden wrote: Standa Laznicka wrote: On 03/14/2017 03:14 PM, Martin Basti wrote: On 14.03.2017 14:56, Luc de Louw wrote: My 3 cents... "Please note that FIPS 140-2 support may not work on some platforms" -> Does is work in Fedora? Should be worth mention it

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-14 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution martbab commented: """ Ok thanks for explanation. """ See the full comment at https://github.com/freeipa/freeipa/pull/573#issuecomment-286464608 -- Manage your

[Freeipa-devel] [freeipa PR#586][opened] Ignore ipapython/.DEFAULT_PLUGINS

2017-03-14 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/586 Author: tiran Title: #586: Ignore ipapython/.DEFAULT_PLUGINS Action: opened PR body: """ Signed-off-by: Christian Heimes """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git

Re: [Freeipa-devel] [DRAFT] Release notes FreeIPA 4.5.0

2017-03-14 Thread Petr Vobornik
On 03/14/2017 04:24 PM, Martin Basti wrote: On 14.03.2017 14:50, Jakub Hrozek wrote: On Tue, Mar 14, 2017 at 01:51:19PM +0100, Martin Basti wrote: Hello, DRAFT for FreeIPA 4.5.0 release notes is ready http://www.freeipa.org/page/Releases/4.5.0 Please update/let me know what is missing,

[Freeipa-devel] [freeipa PR#585][+ack] Remove allow_constrained_delegation from gssproxy.conf

2017-03-14 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/585 Title: #585: Remove allow_constrained_delegation from gssproxy.conf Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#559][comment] WebUI: Certificate login

2017-03-14 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/559 Title: #559: WebUI: Certificate login pvomacka commented: """ Removed in https://github.com/freeipa/freeipa/pull/585 once it will be pushed I will close this one again. """ See the full comment at

[Freeipa-devel] [freeipa PR#502][synchronized] Make pylint and jsl optional

2017-03-14 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/502 Author: tiran Title: #502: Make pylint and jsl optional Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/502/head:pr502 git checkout pr502 From

Re: [Freeipa-devel] [DRAFT] Release notes FreeIPA 4.5.0

2017-03-14 Thread Rob Crittenden
Standa Laznicka wrote: > On 03/14/2017 03:14 PM, Martin Basti wrote: >> On 14.03.2017 14:56, Luc de Louw wrote: >>> My 3 cents... >>> >>> "Please note that FIPS 140-2 support may not work on some platforms" >>> >>> -> Does is work in Fedora? Should be worth mention it so people are >>> more

[Freeipa-devel] [freeipa PR#583][comment] ipaplatform/debian/services: Fix is_running arguments.

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/583 Title: #583: ipaplatform/debian/services: Fix is_running arguments. MartinBasti commented: """ master: * 1a47fcd3ee7fe2878c77de0729e422c40a457600 ipaplatform/debian/services: Fix is_running arguments. * 71db8c264e38502e80f05e9cb234185049450b62

[Freeipa-devel] [freeipa PR#583][+pushed] ipaplatform/debian/services: Fix is_running arguments.

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/583 Title: #583: ipaplatform/debian/services: Fix is_running arguments. Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#502][synchronized] Make pylint and jsl optional

2017-03-14 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/502 Author: tiran Title: #502: Make pylint and jsl optional Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/502/head:pr502 git checkout pr502 From

[Freeipa-devel] [freeipa PR#585][comment] Remove allow_constrained_delegation from gssproxy.conf

2017-03-14 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/585 Title: #585: Remove allow_constrained_delegation from gssproxy.conf simo5 commented: """ Please change commit message to: The Apache process *must* not allowed to use constrained delegation to contact services because it is already allowed to

[Freeipa-devel] [freeipa PR#531][+ack] httpinstance: disable system trust module in /etc/httpd/alias

2017-03-14 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/531 Title: #531: httpinstance: disable system trust module in /etc/httpd/alias Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#581][+ack] Backup KDC certificate pair

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/581 Title: #581: Backup KDC certificate pair Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#581][closed] Backup KDC certificate pair

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/581 Author: stlaz Title: #581: Backup KDC certificate pair Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/581/head:pr581 git checkout pr581 -- Manage your

[Freeipa-devel] [freeipa PR#581][comment] Backup KDC certificate pair

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/581 Title: #581: Backup KDC certificate pair MartinBasti commented: """ master: * ee6d031a6a0939c1f51a874b1f8f9b19ec727203 Backup KDC certificate pair """ See the full comment at https://github.com/freeipa/freeipa/pull/581#issuecomment-286471815

[Freeipa-devel] [freeipa PR#581][+pushed] Backup KDC certificate pair

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/581 Title: #581: Backup KDC certificate pair Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-14 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution martbab commented: """ PR rebased, I have fixed bugs in ID view objectclass handling and re-used the trusted domain retrieval code in certmap plugin. This is a separate

[Freeipa-devel] [freeipa PR#538][synchronized] Run test_ipaclient test suite

2017-03-14 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/538 Author: tiran Title: #538: Run test_ipaclient test suite Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/538/head:pr538 git checkout pr538 From

[Freeipa-devel] [freeipa PR#531][comment] httpinstance: disable system trust module in /etc/httpd/alias

2017-03-14 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/531 Title: #531: httpinstance: disable system trust module in /etc/httpd/alias stlaz commented: """ I rebased your patchset on current master and put the uninstallation of `ipa_memcached` into a multipass block and all seems to work now. """ See

[Freeipa-devel] [freeipa PR#577][synchronized] WebUI: Add support for AD users short name resolution

2017-03-14 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/577 Author: pvomacka Title: #577: WebUI: Add support for AD users short name resolution Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/577/head:pr577 git

[Freeipa-devel] [freeipa PR#531][comment] httpinstance: disable system trust module in /etc/httpd/alias

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/531 Title: #531: httpinstance: disable system trust module in /etc/httpd/alias MartinBasti commented: """ master: * f037bfa48356a5fb28eebdb76f9dbd5cb461c2d2 httpinstance: disable system trust module in /etc/httpd/alias """ See the full comment at

[Freeipa-devel] [freeipa PR#559][-ack] WebUI: Certificate login

2017-03-14 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/559 Title: #559: WebUI: Certificate login Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#502][synchronized] Make pylint and jsl optional

2017-03-14 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/502 Author: tiran Title: #502: Make pylint and jsl optional Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/502/head:pr502 git checkout pr502 From

[Freeipa-devel] [freeipa PR#583][+ack] ipaplatform/debian/services: Fix is_running arguments.

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/583 Title: #583: ipaplatform/debian/services: Fix is_running arguments. Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#585][synchronized] Remove allow_constrained_delegation from gssproxy.conf

2017-03-14 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/585 Author: pvomacka Title: #585: Remove allow_constrained_delegation from gssproxy.conf Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/585/head:pr585 git

Re: [Freeipa-devel] [DRAFT] Release notes FreeIPA 4.5.0

2017-03-14 Thread Martin Basti
On 14.03.2017 14:50, Jakub Hrozek wrote: > On Tue, Mar 14, 2017 at 01:51:19PM +0100, Martin Basti wrote: >> Hello, >> >> DRAFT for FreeIPA 4.5.0 release notes is ready >> http://www.freeipa.org/page/Releases/4.5.0 >> >> Please update/let me know what is missing, what is extra. > Please update

[Freeipa-devel] [freeipa PR#583][synchronized] ipaplatform/debian/services: Fix is_running arguments.

2017-03-14 Thread tjaalton
URL: https://github.com/freeipa/freeipa/pull/583 Author: tjaalton Title: #583: ipaplatform/debian/services: Fix is_running arguments. Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/583/head:pr583 git

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-14 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution abbra commented: """ Yes, it is expected too. Remember that 'Default Trust View' is a view that applies globally. You have already global setting to apply. """ See the

[Freeipa-devel] [freeipa PR#584][opened] Improve the implementation of PKINIT certificate retrieval

2017-03-14 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/584 Author: martbab Title: #584: Improve the implementation of PKINIT certificate retrieval Action: opened PR body: """ The original PKINIT cert request code contained numerous defects, namely: * nearly absent handling of rejected requests and

[Freeipa-devel] [freeipa PR#538][+ack] Run test_ipaclient test suite

2017-03-14 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/538 Title: #538: Run test_ipaclient test suite Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#583][closed] ipaplatform/debian/services: Fix is_running arguments.

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/583 Author: tjaalton Title: #583: ipaplatform/debian/services: Fix is_running arguments. Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/583/head:pr583 git checkout

[Freeipa-devel] [freeipa PR#538][closed] Run test_ipaclient test suite

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/538 Author: tiran Title: #538: Run test_ipaclient test suite Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/538/head:pr538 git checkout pr538 -- Manage your

[Freeipa-devel] [freeipa PR#538][comment] Run test_ipaclient test suite

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/538 Title: #538: Run test_ipaclient test suite MartinBasti commented: """ master: * 08fc9d7a68220fc147177e6f757387823fea0f43 Run test_ipaclient test suite """ See the full comment at

[Freeipa-devel] [freeipa PR#538][+pushed] Run test_ipaclient test suite

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/538 Title: #538: Run test_ipaclient test suite Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#587][comment] Python 3: Fix session storage

2017-03-14 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/587 Title: #587: Python 3: Fix session storage tiran commented: """ @simo5 is UTF-8 correct or are keys and values ASCII only? """ See the full comment at https://github.com/freeipa/freeipa/pull/587#issuecomment-286495619 -- Manage your

[Freeipa-devel] [freeipa PR#573][+ack] Provide centralized management of user short name resolution

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#587][opened] Python 3: Fix session storage

2017-03-14 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/587 Author: tiran Title: #587: Python 3: Fix session storage Action: opened PR body: """ ctypes can only handle bytes, not text. Encode and decode all incoming and outgoing text from UTF-8 to bytes. Signed-off-by: Christian Heimes

[Freeipa-devel] [freeipa PR#559][reopened] WebUI: Certificate login

2017-03-14 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/559 Author: pvomacka Title: #559: WebUI: Certificate login Action: reopened To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/559/head:pr559 git checkout pr559 -- Manage your

[Freeipa-devel] [freeipa PR#559][comment] WebUI: Certificate login

2017-03-14 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/559 Title: #559: WebUI: Certificate login simo5 commented: """ You need to wait to get th gssproxy fix I've been developing today and set the minimum gssproxy version to the one with the fix once we get to publish it """ See the full comment at

[Freeipa-devel] [freeipa PR#559][comment] WebUI: Certificate login

2017-03-14 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/559 Title: #559: WebUI: Certificate login simo5 commented: """ NACK NACK NACK Pleas revert the change to the gssproxy template, it undoes half the work done in privilege separation """ See the full comment at

[Freeipa-devel] [freeipa PR#585][opened] Remove allow_constrained_delegation from gssproxy.conf

2017-03-14 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/585 Author: pvomacka Title: #585: Remove allow_constrained_delegation from gssproxy.conf Action: opened PR body: """ This change reverts option which breaks priviledge separation. https://pagure.io/freeipa/issue/6225 """ To pull the PR as Git

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-14 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional tiran commented: """ The PR got three +1 / heart and not -1. I propose to get it merged for 4.5 today. """ See the full comment at https://github.com/freeipa/freeipa/pull/502#issuecomment-286487177 --

[Freeipa-devel] [freeipa PR#585][synchronized] Remove allow_constrained_delegation from gssproxy.conf

2017-03-14 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/585 Author: pvomacka Title: #585: Remove allow_constrained_delegation from gssproxy.conf Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/585/head:pr585 git

[Freeipa-devel] [freeipa PR#433][comment] csrgen: Allow some certificate fields to be specified by the user

2017-03-14 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/433 Title: #433: csrgen: Allow some certificate fields to be specified by the user tiran commented: """ @LiptonB please resolve conflicts """ See the full comment at https://github.com/freeipa/freeipa/pull/433#issuecomment-286489002 -- Manage your

[Freeipa-devel] [freeipa PR#586][comment] Ignore ipapython/.DEFAULT_PLUGINS

2017-03-14 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/586 Title: #586: Ignore ipapython/.DEFAULT_PLUGINS HonzaCholasta commented: """ LGTM. Please use https://pagure.io/freeipa/issue/6597 as ticket link in the commit message. """ See the full comment at

<    1   2