Re: [Freeipa-devel] [PATCH] 360 be smarter about decoding certs

2010-01-28 Thread John Dennis
On 01/28/2010 10:30 PM, Rob Crittenden wrote: John Dennis wrote: On 01/28/2010 04:15 PM, Rob Crittenden wrote: Gah, got the description mixed up with the last patch :-( Be a bit smarter about decoding certificates that might be base64 encoded. First see if it only contains those characters all

Re: [Freeipa-devel] [PATCH] 355 allow named to use ldapi

2010-01-28 Thread Jason Gerard DeRose
On Wed, 2010-01-27 at 14:53 -0500, Rob Crittenden wrote: > Add SELinux rules so named can communicate to the DS over ldapi. > > This should fix the installation error when --setup-dns is set and > SELinux is enforcing. > > rob I'm trying to test this out, but I'm not sure what I need to enter f

Re: [Freeipa-devel] [PATCH] 360 be smarter about decoding certs

2010-01-28 Thread Rob Crittenden
John Dennis wrote: On 01/28/2010 04:15 PM, Rob Crittenden wrote: Gah, got the description mixed up with the last patch :-( Be a bit smarter about decoding certificates that might be base64 encoded. First see if it only contains those characters allowed before trying to decode it. This reduces t

Re: [Freeipa-devel] [PATCH] Fix File parameter validation when prompting.

2010-01-28 Thread John Dennis
I've been thinking about this a bit more. I wonder if part of the inelegance is due to the fact we're trying to shoehorn two distinct concepts into one item when a proper relationship does not exist. It does not seem logical that a file is a subclass of a string which is how this is set up now

Re: [Freeipa-devel] [PATCH] Fix File parameter validation when prompting.

2010-01-28 Thread John Dennis
On 01/28/2010 06:56 PM, Jason Gerard DeRose wrote: On Wed, 2010-01-27 at 17:53 +0100, Pavel Zuna wrote: cli.prompt_interactively now loads files before validating the parameter value. It also populates a list of already loaded files, so that cli.load_files knows when a parameter already contains

Re: [Freeipa-devel] [PATCH] Fix File parameter validation when prompting.

2010-01-28 Thread Jason Gerard DeRose
On Wed, 2010-01-27 at 17:53 +0100, Pavel Zuna wrote: > cli.prompt_interactively now loads files before validating the parameter > value. > It also populates a list of already loaded files, so that cli.load_files > knows > when a parameter already contains the file contents. > > Fix #557163 >

[Freeipa-devel] [PATCH 363 find all group pwd policy

2010-01-28 Thread Rob Crittenden
Provide pwpolicy-find command to display all group-specific password policies. find is a bit of a misnomer since you can't provide any terms to limit the search scope, but it's a start. I'm not sure this is the kind of thing we need/want to be able to query things like "give me all the polici

[Freeipa-devel] [PATCH] 362 remove group pwd policy on group deletion

2010-01-28 Thread Rob Crittenden
Try to remove a group password policy when a group is deleted. No need to leave that hanging around. rob freeipa-362-group.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/list

Re: [Freeipa-devel] [PATCH] 359 allow cert renewal

2010-01-28 Thread John Dennis
On 01/28/2010 04:16 PM, Rob Crittenden wrote: Rob Crittenden wrote: Be a bit smarter about decoding certificates that might be base64 encoded. First see if it only contains those characters allowed before trying to decode it. This reduces the number of false positives. rob Er, duh, I got thi

Re: [Freeipa-devel] [PATCH] 360 be smarter about decoding certs

2010-01-28 Thread John Dennis
On 01/28/2010 04:15 PM, Rob Crittenden wrote: Gah, got the description mixed up with the last patch :-( Be a bit smarter about decoding certificates that might be base64 encoded. First see if it only contains those characters allowed before trying to decode it. This reduces the number of false p

[Freeipa-devel] [PATCH] 361 fix cert tests

2010-01-28 Thread Rob Crittenden
This fixes some problems with the cert plugin tests. - It checks to see if a self-signed CA is available in ~/.ipa/alias. If not the tests are skipped - Be a bit smarter about cleaning up by moving it to a separate test - This relies on patch the service fix in 360. Some binary certs were bein

Re: [Freeipa-devel] [PATCH] 359 allow cert renewal

2010-01-28 Thread Rob Crittenden
Rob Crittenden wrote: Be a bit smarter about decoding certificates that might be base64 encoded. First see if it only contains those characters allowed before trying to decode it. This reduces the number of false positives. rob Er, duh, I got this description goofed up. This patch is relat

[Freeipa-devel] [PATCH] 360 be smarter about decoding certs

2010-01-28 Thread Rob Crittenden
Gah, got the description mixed up with the last patch :-( Be a bit smarter about decoding certificates that might be base64 encoded. First see if it only contains those characters allowed before trying to decode it. This reduces the number of false positives. rob freeipa-360-service.patch D

[Freeipa-devel] [PATCH] 359 be smarter about decoding certs

2010-01-28 Thread Rob Crittenden
Be a bit smarter about decoding certificates that might be base64 encoded. First see if it only contains those characters allowed before trying to decode it. This reduces the number of false positives. rob freeipa-359-cert.patch Description: application/mbox __

Re: [Freeipa-devel] [PATCH] Remove (un)wrap_binary_data cruft from */ipautil.py

2010-01-28 Thread Rob Crittenden
John Dennis wrote: Remove SAFE_STRING_PATTERN, safe_string_re, needs_base64(), wrap_binary_data(), unwrap_binary_data() from both instances of ipautil.py. This code is no longer in use and the SAFE_STRING_PATTERN regular expression string was causing xgettext to abort because it wasn't a valid AS

[Freeipa-devel] [PATCH] 358 remove files on uninstall

2010-01-28 Thread Rob Crittenden
Remove some IPA configuration files when doing an uninstallation. rob freeipa-358-remove.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] jderose 036 Remove PluginProxy hold-overs

2010-01-28 Thread Rob Crittenden
Jason Gerard DeRose wrote: This patch removes some cruft left over from when we were still using my ill-fated PluginProxy to wrap Plugin instances. This patch: 1. Removes special __public__ class attribute from Plugin and its descendants 2. Removes special __proxy__ class attribute

[Freeipa-devel] [PATCH] fix error message to be i18n translator friendly

2010-01-28 Thread John Dennis
This error message was producing a warning from xgettext because there were multiple substations in the string. In some languages it may be necessary to reorder the substitutions for a proper translation, this is only possible if the substitutions use named values. --- ipaserver/plugins/selfsign.

[Freeipa-devel] [PATCH] Remove (un)wrap_binary_data cruft from */ipautil.py

2010-01-28 Thread John Dennis
Remove SAFE_STRING_PATTERN, safe_string_re, needs_base64(), wrap_binary_data(), unwrap_binary_data() from both instances of ipautil.py. This code is no longer in use and the SAFE_STRING_PATTERN regular expression string was causing xgettext to abort because it wasn't a valid ASCII string. --- ipa

Re: [Freeipa-devel] [PATCH] convert SAFE_STRING_PATTERN (was: Why do we have so much duplicated code?)

2010-01-28 Thread John Dennis
On 01/27/2010 10:30 PM, Rob Crittenden wrote: Is this code used by anything any more? This was part of the old XML-RPC server. It was used to determine whether a data type needed to be the XML-RPC Binary type or not. In v2 Jason wrote a similar function that bases the output type based on the py