Re: [Freeipa-devel] admiyo-freeipa-0039-language-as-a-list.patch
Adam Young wrote: The previous I18N patch only works if a single language is set in the headers. Typically, this header is a list, comma separated. THis version parsese the list and selects the first language. nack. You should make sure there isn't a weight on the language too. >>> lang='en-us,en;q=0.5' >>> lang.split(',')[0].split(';')[0] 'en-us' >>> lang='en-us;q=1.0,en;q=0.5' >>> lang.split(',')[0].split(';')[0] 'en-us' rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Rolegroups tab.
On 09/20/2010 04:40 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks. The Makefile.am and index.xhtml has been modified to include rolegroup.js. The webui.js has been modified to register the rolegroup tab. The rolegroup.js defines the rolegroup's search, add, and details pages. Sample data for some rolegroup operations have been added. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Rolegroups tab.
On 09/20/2010 04:40 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks. The Makefile.am and index.xhtml has been modified to include rolegroup.js. The webui.js has been modified to register the rolegroup tab. The rolegroup.js defines the rolegroup's search, add, and details pages. Sample data for some rolegroup operations have been added. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] SUDOer LDIFs
Hi Dmitri, Here some of the ldap rules I have in an openldap server, hope you find them useful. Thanks. -- Tony http://blog.tonyskapunk.net sudo_example.ldif Description: Binary data ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] admiyo-freeipa-0039-language-as-a-list.patch
The previous I18N patch only works if a single language is set in the headers. Typically, this header is a list, comma separated. THis version parsese the list and selects the first language. >From 6f6ab56c0479faed3a1ae2474121891fd6983277 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 20 Sep 2010 16:44:50 -0400 Subject: [PATCH] language as a list Now parsing the list of languages set in the http header, and selecting the first. --- ipaserver/rpcserver.py |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ipaserver/rpcserver.py b/ipaserver/rpcserver.py index f17fe7d..7b2c7f2 100644 --- a/ipaserver/rpcserver.py +++ b/ipaserver/rpcserver.py @@ -35,6 +35,7 @@ from ipalib.compat import json from wsgiref.util import shift_path_info import base64 import os +import string _not_found_template = """ 404 Not Found @@ -195,7 +196,8 @@ class WSGIExecutioner(Executioner): lang= os.environ['LANG'] try: if ('HTTP_ACCEPT_LANGUAGE' in environ): -os.environ['LANG']=environ['HTTP_ACCEPT_LANGUAGE'] +os.environ['LANG']=string.split( +environ['HTTP_ACCEPT_LANGUAGE'],",")[0] if ( environ.get('CONTENT_TYPE', '').startswith(self.content_type) and environ['REQUEST_METHOD'] == 'POST' -- 1.7.1 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] Rolegroups tab.
Hi, Please review the attached patch. Thanks. The Makefile.am and index.xhtml has been modified to include rolegroup.js. The webui.js has been modified to register the rolegroup tab. The rolegroup.js defines the rolegroup's search, add, and details pages. Sample data for some rolegroup operations have been added. -- Endi S. Dewata >From 09cc9d1ceb6259472739afdc767cc502ff9f2484 Mon Sep 17 00:00:00 2001 From: Endi Sukma Dewata Date: Mon, 20 Sep 2010 20:05:03 -0400 Subject: [PATCH] Rolegroups tab. The Makefile.am and index.xhtml has been modified to include rolegroup.js. The webui.js has been modified to register the rolegroup tab. The rolegroup.js defines the rolegroup's search, add, and details pages. Sample data for some rolegroup operations have been added. --- install/static/Makefile.am |1 + install/static/index.xhtml |1 + install/static/rolegroup.js| 111 install/static/sampledata/rolegroup_add.json | 22 +++ .../static/sampledata/rolegroup_add_member.json| 27 +++ install/static/sampledata/rolegroup_del.json |9 + install/static/sampledata/rolegroup_find.json | 185 .../static/sampledata/rolegroup_remove_member.json | 24 +++ install/static/sampledata/rolegroup_show.json | 20 ++ install/static/webui.js|1 + 10 files changed, 401 insertions(+), 0 deletions(-) create mode 100644 install/static/rolegroup.js create mode 100644 install/static/sampledata/rolegroup_add.json create mode 100644 install/static/sampledata/rolegroup_add_member.json create mode 100644 install/static/sampledata/rolegroup_del.json create mode 100644 install/static/sampledata/rolegroup_find.json create mode 100644 install/static/sampledata/rolegroup_remove_member.json create mode 100644 install/static/sampledata/rolegroup_show.json diff --git a/install/static/Makefile.am b/install/static/Makefile.am index 9bd327c..7d7c27d 100644 --- a/install/static/Makefile.am +++ b/install/static/Makefile.am @@ -28,6 +28,7 @@ app_DATA = \ navigation.js \ netgroup.js \ service.js \ + rolegroup.js \ search.js \ details.js \ entity.js \ diff --git a/install/static/index.xhtml b/install/static/index.xhtml index 98e2495..3fcb5f6 100644 --- a/install/static/index.xhtml +++ b/install/static/index.xhtml @@ -25,6 +25,7 @@ + diff --git a/install/static/rolegroup.js b/install/static/rolegroup.js new file mode 100644 index 000..2e52f10 --- /dev/null +++ b/install/static/rolegroup.js @@ -0,0 +1,111 @@ +/* Authors: + *Endi Sukma Dewata + * + * Copyright (C) 2010 Red Hat + * see file 'COPYING' for use and warranty information + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 only + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +/* REQUIRES: ipa.js, details.js, search.js, add.js, entity.js */ + +ipa_entity_set_search_definition('rolegroup', [ +['cn', 'Role-group name', null], +['description', 'Description', null], +['quick_links', 'Quick Links', rolegroup_render_quick_links] +]); + +ipa_entity_set_add_definition('rolegroup', [ +'dialog-add-rolegroup', 'Add New Rolegroup', [ +['cn', 'Name', null], +['description', 'Description', null], +] +]); + +ipa_entity_set_details_definition('rolegroup', [ +['identity', 'Rolegroup Details', [ +['cn', 'Name', null], +['description', 'Description', null], +]] +]); + +function rolegroup_render_quick_links(tr, attr, value, entry_attrs) { + +var td = $(""); +tr.append(td); + +$("", { +href: "jslink", +html: $(""), +click: function() { +var state = {}; +state['rolegroup-facet'] = 'details'; +state['rolegroup-pkey'] = entry_attrs['cn'][0]; +$.bbq.pushState(state); +return false; +} +}).appendTo(td); + +$("", { +href: "jslink", +html: $(""), +click: function() { +var state = {}; +state['rolegroup-facet'] = 'associate'; +state['rolegroup-enroll'] = 'user'; +state['rolegroup-pkey'] = entry_attrs['cn'][0]; +$.bbq.pushState(state); +return false; +} +}).appendTo(td); + +$("", { +href: "j
Re: [Freeipa-devel] [PATCH] 532 unenroll when a client is uninstalled
Adam Young wrote: On 09/17/2010 09:44 PM, Rob Crittenden wrote: Unenroll a host when a client is uninstalled. This means we bind using the host credentials and disable our own keytab. This will let the client be re-enrolled without requiring admin input (used to have to either delete the host or disable the keytab as admin). I also did some other cleanup in ipa-join and added a fair bit of info to the ipa-getkeytab and ipa-join man pages. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 531 make DNS autodiscovery smarter
Adam Young wrote: On 09/17/2010 09:33 PM, Rob Crittenden wrote: Better distinguish between when DNS discovery works and search more domains. Passing domain and server on the command-line used to be considered as DNS autodiscovery worked. This was problematic if there was in fact no SRV records because krb5.conf would be configured without a specific KDC causing all Kerberos ops to fail. Now if you pass in a domain/server it still tries to see if they are discoverable and if so won't hardcode a server, but will fall back to doing so if necessary. Also be a lot more aggressive on looking for the SRV records. Use the search and domain values from /etc/resolv.conf on the chance that the SRV records aren't in the domain of the hostname of the machine. An example of this would be if your laptop is in dhcp.example.com and your company's SRV records are in corp.example.com. Searching dhcp.example.com and example.com won't find the SRV records but the user is likely to have corp.redhat.com in the search list, at least. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 529 ipaUniqueId enforcement
Adam Young wrote: On 09/15/2010 01:23 PM, Rob Crittenden wrote: Enforce that ipaUniqueId is a unique attribute via the DS uniqueness plugin and prevent updates to the attribute once it is written. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 523 add 2 missing man pages
Adam Young wrote: On 09/09/2010 06:00 PM, Rob Crittenden wrote: Add missing man pages for ipa-dns-install and ipa-upgradeconfig. tickets 130 and 131 rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 537 add --zonemgr option to installer
Add option to set the zone mgr e-mail address during install. rob freeipa-537-zonemgr.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] admiyo-freeipa-0038-I18N-of-RPC.patch
On 09/20/2010 03:18 PM, Rob Crittenden wrote: Adam Young wrote: This is the simplest, most global approach to I18N. It does complete I18N on the server side by setting the locale on each request, based on the value in the http header. If we go this route, I can remove the parameter as a parameter on the metadata plugin To test this: curl -H "Content-Type:application/json" -H "Accept:applicaton/json" -H "Accept-Language:uk" --negotiate -u : --cacert /etc/ipa/ca.crt -d '{"method":"plugin_metadata","params":[[""],{"all":true}],"id":6}' -X POST http://localhost:/ipa/json | grep label And note that is should work for any RPC. For example :"user_find","params":[[""],{"all":true}],"id":6}' -X POST http://localhost:/ipa/json | grep summary % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 13114 0 13114 0 58 42902 189 --:--:-- --:--:-- --:--:-- 42996 "summary": "\u0432\u0441\u0442\u0430\u043d\u043e\u0432\u043b\u0435\u043d\u043e \u0432\u0456\u0434\u043f\u043e\u0432\u0456\u0434\u043d\u0456\u0441\u0442\u044c 7 \u043a\u043e\u0440\u0438\u0441\u0442\u0443\u0432\u0430\u0447\u0456\u0432", [ayo...@ipa freeipa]$ curl -H "Content-Type:application/json" -H "Accept:applicaton/json" -H "Accept-Language:es" --negotiate -u : --cacert /etc/ipa/ca.crt -d '{"method":"user_find","params":[[""],{"all":true}],"id":6}' -X POST http://localhost:/ipa/json | grep summary % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 12917 0 12917 0 58 48572 218 --:--:-- --:--:-- --:--:-- 48743 "summary": "7 usuarios coincidentes", ack. We'll need to ensure that Apache is running in forking mode to be safe, we have a separate ticket open on that. rob 0038 pushed to master. I'll redo the original patch without the expliciet I18N support ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] admiyo-freeipa-0038-I18N-of-RPC.patch
Adam Young wrote: This is the simplest, most global approach to I18N. It does complete I18N on the server side by setting the locale on each request, based on the value in the http header. If we go this route, I can remove the parameter as a parameter on the metadata plugin To test this: curl -H "Content-Type:application/json" -H "Accept:applicaton/json" -H "Accept-Language:uk" --negotiate -u : --cacert /etc/ipa/ca.crt -d '{"method":"plugin_metadata","params":[[""],{"all":true}],"id":6}' -X POST http://localhost:/ipa/json | grep label And note that is should work for any RPC. For example :"user_find","params":[[""],{"all":true}],"id":6}' -X POST http://localhost:/ipa/json | grep summary % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 13114 0 13114 0 58 42902 189 --:--:-- --:--:-- --:--:-- 42996 "summary": "\u0432\u0441\u0442\u0430\u043d\u043e\u0432\u043b\u0435\u043d\u043e \u0432\u0456\u0434\u043f\u043e\u0432\u0456\u0434\u043d\u0456\u0441\u0442\u044c 7 \u043a\u043e\u0440\u0438\u0441\u0442\u0443\u0432\u0430\u0447\u0456\u0432", [ayo...@ipa freeipa]$ curl -H "Content-Type:application/json" -H "Accept:applicaton/json" -H "Accept-Language:es" --negotiate -u : --cacert /etc/ipa/ca.crt -d '{"method":"user_find","params":[[""],{"all":true}],"id":6}' -X POST http://localhost:/ipa/json | grep summary % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 12917 0 12917 0 58 48572 218 --:--:-- --:--:-- --:--:-- 48743 "summary": "7 usuarios coincidentes", ack. We'll need to ensure that Apache is running in forking mode to be safe, we have a separate ticket open on that. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 532 unenroll when a client is uninstalled
On 09/17/2010 09:44 PM, Rob Crittenden wrote: Unenroll a host when a client is uninstalled. This means we bind using the host credentials and disable our own keytab. This will let the client be re-enrolled without requiring admin input (used to have to either delete the host or disable the keytab as admin). I also did some other cleanup in ipa-join and added a fair bit of info to the ipa-getkeytab and ipa-join man pages. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 531 make DNS autodiscovery smarter
On 09/17/2010 09:33 PM, Rob Crittenden wrote: Better distinguish between when DNS discovery works and search more domains. Passing domain and server on the command-line used to be considered as DNS autodiscovery worked. This was problematic if there was in fact no SRV records because krb5.conf would be configured without a specific KDC causing all Kerberos ops to fail. Now if you pass in a domain/server it still tries to see if they are discoverable and if so won't hardcode a server, but will fall back to doing so if necessary. Also be a lot more aggressive on looking for the SRV records. Use the search and domain values from /etc/resolv.conf on the chance that the SRV records aren't in the domain of the hostname of the machine. An example of this would be if your laptop is in dhcp.example.com and your company's SRV records are in corp.example.com. Searching dhcp.example.com and example.com won't find the SRV records but the user is likely to have corp.redhat.com in the search list, at least. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] admiyo-freeipa-0038-I18N-of-RPC.patch
This is the simplest, most global approach to I18N. It does complete I18N on the server side by setting the locale on each request, based on the value in the http header. If we go this route, I can remove the parameter as a parameter on the metadata plugin To test this: curl -H "Content-Type:application/json" -H "Accept:applicaton/json" -H "Accept-Language:uk"--negotiate -u : --cacert /etc/ipa/ca.crt -d '{"method":"plugin_metadata","params":[[""],{"all":true}],"id":6}' -X POST http://localhost:/ipa/json | grep label And note that is should work for any RPC. For example :"user_find","params":[[""],{"all":true}],"id":6}' -X POST http://localhost:/ipa/json | grep summary % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 131140 13114058 42902189 --:--:-- --:--:-- --:--:-- 42996 "summary": "\u0432\u0441\u0442\u0430\u043d\u043e\u0432\u043b\u0435\u043d\u043e \u0432\u0456\u0434\u043f\u043e\u0432\u0456\u0434\u043d\u0456\u0441\u0442\u044c 7 \u043a\u043e\u0440\u0438\u0441\u0442\u0443\u0432\u0430\u0447\u0456\u0432", [ayo...@ipa freeipa]$ curl -H "Content-Type:application/json" -H "Accept:applicaton/json" -H "Accept-Language:es"--negotiate -u : --cacert /etc/ipa/ca.crt -d '{"method":"user_find","params":[[""],{"all":true}],"id":6}' -X POST http://localhost:/ipa/json | grep summary % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 129170 12917058 48572218 --:--:-- --:--:-- --:--:-- 48743 "summary": "7 usuarios coincidentes", >From a072a382825ca98028dcdc0eb333163752fd4e3f Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 20 Sep 2010 14:11:32 -0400 Subject: [PATCH] I18N of RPC Uses the HTTP header to perform set the LANG environment variable in Python, used for the gettext translations Author:adam --- ipaserver/rpcserver.py |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/ipaserver/rpcserver.py b/ipaserver/rpcserver.py index 71d5544..f17fe7d 100644 --- a/ipaserver/rpcserver.py +++ b/ipaserver/rpcserver.py @@ -34,7 +34,7 @@ from ipalib.util import make_repr from ipalib.compat import json from wsgiref.util import shift_path_info import base64 - +import os _not_found_template = """ 404 Not Found @@ -192,7 +192,10 @@ class WSGIExecutioner(Executioner): result = None error = None _id = None +lang= os.environ['LANG'] try: +if ('HTTP_ACCEPT_LANGUAGE' in environ): +os.environ['LANG']=environ['HTTP_ACCEPT_LANGUAGE'] if ( environ.get('CONTENT_TYPE', '').startswith(self.content_type) and environ['REQUEST_METHOD'] == 'POST' @@ -211,6 +214,8 @@ class WSGIExecutioner(Executioner): 'non-public: %s: %s', e.__class__.__name__, str(e) ) error = InternalError() +finally: +os.environ['LANG']=lang return self.marshal(result, error, _id) def simple_unmarshal(self, environ): -- 1.7.1 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 536 throw and catch CertificateOperationError properly in replica preparer
Properly handle CertificateOperationErrors in replication prepration. The problem here was two-fold: the certs manager was raising an error it didn't know about and ipa-replica-prepare wasn't catching it. rob freeipa-536-certs.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 535 add hbac example of creating service and service group
Try to tie together the hbac and hbacsvc/hbacsvcgroup plugins better via an example. rob freeipa-535-example.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 534 updates to spec file
Drop Requires on python-configobj. It is a leftover from TurboGears. Remove ipa-ldap-updater message. It was meant to detect when an upgrade is required, we're doing this differently in v2. rob freeipa-534-spec.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 533 add hostname resolver
Basic "here is a hostname see if it is in DNS" resolver. I put it as part of the DNS plugin because it seemed more of a natural fit there. It will work whether IPA is configured with a DNS server or not. It uses a pure DNS resolver library to find a host. It will append the default IPA domain name if one appears to not be included but it doesn't do anything smarter than that. rob freeipa-533-lookup.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0034-2-Metadata-I18N.patch
On 09/20/2010 10:44 AM, John Dennis wrote: On 09/20/2010 10:19 AM, Adam Young wrote: On 09/20/2010 10:07 AM, Rob Crittenden wrote: And a small nit. The help for the argument says 2-character language code. This ignores the language subtags (e.g. en-US). If we get to the point that we are differentiating between en_US and en_AS, we will have won this battle. I'll update the Docs once we start doing locale specific files! FYI, I have seen i18n fail when the country code (i.e. dialect) is omitted and only the language code is used. One might expect simply setting the language code would be sufficient and a default country code would be selected by default but there seem to parts of the system which can't deal with this. I saw the problem when setting the LANG environment variable and glibc's locale function failed to work correctly. Not sure if the same problem would exist in GNU gettext when selecting the message catalog, but why take the chance? This covers the doc string >From 48b4e658733d9dcdac9946414b710fe99a0637dd Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 20 Sep 2010 10:46:39 -0400 Subject: [PATCH] Locale for language Corrected the doc string to signify that the language field is the local used to for translation. --- ipalib/plugins/internal.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ipalib/plugins/internal.py b/ipalib/plugins/internal.py index 3a0178d..9a7137d 100644 --- a/ipalib/plugins/internal.py +++ b/ipalib/plugins/internal.py @@ -79,7 +79,7 @@ class plugin_metadata(Command): takes_options = ( Str('language?', -doc=_('Two Letter Code for Language Translation'), +doc=_('Locale used for Translation, in Posix form. Example: Australian English is en_AU'), ), ) -- 1.7.1 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0036-links-and-facet-icons.patch
On 09/20/2010 08:29 AM, Pavel Zuna wrote: On 09/18/2010 02:36 AM, Adam Young wrote: This patch makes use of the previous patch to put the icons in the facets and quick links It looks OK, but I can't test it because the required patch 30 doesn't apply for me. Pavel ACKed in IRC by edewata, pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch
On 09/20/2010 11:30 AM, Endi Sukma Dewata wrote: - "Adam Young" wrote: On 09/20/2010 08:10 AM, Pavel Zuna wrote: On 09/17/2010 04:38 PM, Adam Young wrote: moved images up Adding an 'images' subdir was proliferating changes throughout the build system this seemed easier Submitted as a separate patch to signify where wea re departing from what is generated by theme-roller Doesn't apply for me. Missing some image files and doesn't apply on jquery-ui.css. I applied all your patches I could find before this one, but I can't find number 28 on the list. Maybe that's the reason. Pavel admiyo-freeipa-0028-theme.patch ACK. -- Endi S. Dewata Pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Icons
On 09/17/2010 08:35 PM, Adam Young wrote: THese are just place holder icons until we get the offical ones from UXD. They look roughly like the finished product, with have some rough points. They will be used by the next patch to Generate the quick links and facets. THis is a huga patch, but it is all binary files. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0033-pointer-cursor-for-facets.patch
On 09/20/2010 07:58 AM, Pavel Zuna wrote: On 09/17/2010 04:43 PM, Adam Young wrote: Changes the mouse icon for facets to a the pointer, signifying clickability ACK. Pavel Pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0032-css-cleanup.patch
On 09/20/2010 07:57 AM, Pavel Zuna wrote: On 09/17/2010 04:42 PM, Adam Young wrote: Fixes many of the CSS issues introduced by jquery.ui.tabs. Not all, but it looks a lot better ACK. Pavel Pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0031-unbroke-the-facets-link.patch
On 09/20/2010 07:57 AM, Pavel Zuna wrote: On 09/17/2010 04:41 PM, Adam Young wrote: This has a fix for a previous patch which turned the facets into a hortizontal list, but broke the clickability. ACK. Pavel Pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0027-fix-sampledata.patch
On 09/20/2010 07:23 AM, Pavel Zuna wrote: On 09/17/2010 04:34 PM, Adam Young wrote: URL needs to be relative, not absolute in order for in tree development ACK. Pavel Pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0029-css-tabs-and-facets.patch
On 09/17/2010 10:39 AM, Adam Young wrote: On 09/17/2010 10:36 AM, Adam Young wrote: css tabs and facets includes Makfile changes to get images to deploy Note that the Makefile changes are undone by a later patch. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0028-theme.patch
On 09/20/2010 09:33 AM, Adam Young wrote: On 09/20/2010 09:19 AM, Adam Young wrote: admiyo-freeipa-0028-theme.patch Use customized theme and images that is closer to the UX suggested look and feel This is required to get patch 30 to apply as well. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Posted the patch in the wrong email, sse the thread about patch 30 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0025-remove-pagaparams.patch
On 09/17/2010 04:03 PM, Endi Sukma Dewata wrote: - "Adam Young" wrote: Fixes a minor glitch in pzuna-freeipa-0022-4-BIG which re-introduced the pageparams.js entry into the Makefile.am ACK -- Endi S. Dewata Pushed top master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0026-fixed-formatting-of-search-table.patch
On 09/20/2010 07:22 AM, Pavel Zuna wrote: On 09/17/2010 04:33 PM, Adam Young wrote: admiyo-freeipa-0026-fixed-formatting-of-search-table.patch ACK. Pavel Pushed to Master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch
On 09/20/2010 12:14 PM, Endi Sukma Dewata wrote: - "Adam Young" wrote: moved images up Adding an 'images' subdir was proliferating changes throughout the build system this seemed easier Submitted as a separate patch to signify where wea re departing from what is generated by theme-roller admiyo-freeipa-0030-moved-images-up.patch ACK with a few notes: - If the number of images is getting large, it's better to use a separate folder for images. - If the theme needs to be regenerated, the files need to be modified& rearranged again. - To support customizable UI, the file needs to be modified& rearranged again. -- Endi S. Dewata Pushed to master. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Big webUI patch.
On 09/13/2010 03:48 PM, Pavel Zůna wrote: very simplified summary: - introduce jQuery UI and jQuery BBQ libraries to the project - code restructuring There are so many changes, there's no place to list them here. See freeipa-devel list: "webUI code restructuring [wall of text, diagrams, ... you have been warned!]" on 2010-09-07. This is the first shot. The patch is gigantic. I'll try to integrate Endi's service patch(es) into the new code tomorrow. I didn't manage to do it today and it's getting a bit late, sorry. Pavel Updated version pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch
- "Adam Young" wrote: > moved images up > Adding an 'images' subdir was proliferating changes throughout the > build system > this seemed easier > > Submitted as a separate patch to signify where wea re departing from > what is generated by theme-roller admiyo-freeipa-0030-moved-images-up.patch ACK with a few notes: - If the number of images is getting large, it's better to use a separate folder for images. - If the theme needs to be regenerated, the files need to be modified & rearranged again. - To support customizable UI, the file needs to be modified & rearranged again. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Add jQuery UI and jQuery BBQ libraries to the project
On 09/17/2010 01:28 PM, Pavel Zůna wrote: On 2010-09-16 17:10, Pavel Zuna wrote: This adds the minimized version - the ones we want to ship to the end user. For development you can still use the non-minimized versions just by renaming files in your index. Pavel Latest version attached. Pavel Pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Adding quick links in user and group search results.
On 09/15/2010 03:04 PM, Adam Young wrote: On 09/15/2010 01:48 PM, Endi Sukma Dewata wrote: - "Adam Young" wrote: ACK, but change the Column heading to Quick Links first OK, fixed. Thanks. -- Endi S. Dewata I've pushed my version of Pavel's patch to my Fedora people repo: THe branch is called tabs-modal and the patch is commit de85ed06855a2a5b17b4d80bae9445eb3fec6275. Note that I havea bunch of other work in that branch as well, but it should not affect you, and you don't want those commits. Please fetch this, cherry pick just that commit, and then add your commit on top of it, and push to a branch your repo. We'll start to craft the end state of the patch as a group. I expect to see an updated patch from Pavel shortly, with the JQuery assets in it. Once we get that, we can rebase our work on top of that patch and the one he sent out earlier today. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch
- "Adam Young" wrote: > On 09/20/2010 08:10 AM, Pavel Zuna wrote: > > On 09/17/2010 04:38 PM, Adam Young wrote: > >> moved images up > >> Adding an 'images' subdir was proliferating changes throughout the > build > >> system > >> this seemed easier > >> > >> Submitted as a separate patch to signify where wea re departing > from > >> what is generated by theme-roller > >> > > > > Doesn't apply for me. Missing some image files and doesn't apply on > > > jquery-ui.css. > > > > I applied all your patches I could find before this one, but I can't > > > find number 28 on the list. Maybe that's the reason. > > > > Pavel admiyo-freeipa-0028-theme.patch ACK. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0034-2-Metadata-I18N.patch
On 09/20/2010 10:19 AM, Adam Young wrote: On 09/20/2010 10:07 AM, Rob Crittenden wrote: And a small nit. The help for the argument says 2-character language code. This ignores the language subtags (e.g. en-US). If we get to the point that we are differentiating between en_US and en_AS, we will have won this battle. I'll update the Docs once we start doing locale specific files! FYI, I have seen i18n fail when the country code (i.e. dialect) is omitted and only the language code is used. One might expect simply setting the language code would be sufficient and a default country code would be selected by default but there seem to parts of the system which can't deal with this. I saw the problem when setting the LANG environment variable and glibc's locale function failed to work correctly. Not sure if the same problem would exist in GNU gettext when selecting the message catalog, but why take the chance? -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0034-2-Metadata-I18N.patch
Adam Young wrote: On 09/20/2010 10:07 AM, Rob Crittenden wrote: Adam Young wrote: On 09/17/2010 02:24 PM, Adam Young wrote: Metadata I18N Created a clone of the json_metadata plugin called plugin_metadata It is identical in all reagards to the json_metadata plugin, except it performs the gettext transalation based on the 'language' parameter Once this is accepted, the next step is to change over to using this plugin, ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel I was doing an improper check for the presence of a key in the dictionary of env vars ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel It would be nice to be able to use the Accept-Language header provided by the browser. The wsgi environ variable holds the headers as a dictionary and it'll look something like: 'HTTP_ACCEPT_LANGUAGE': 'en-us,en;q=0.5' So this means my browser accepts en-us and en (and prefer en-us over en). See full definition at http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.4 I'm aware, I just wasn't certain if this info was available to the plugins It isn't yet, you need to add it to the request context. We should be able to stick the accepts-language value into the request context and evaluate it later. See in ipaserver/rpcserver.py the call to create_context(). How is the javascript call going to know what language to request? JS has acces to the header info, and could also let the user save their preference in a cookie. I'd like to have both options, and so think we should only evaluate the parameter if it is present, and use the header info as the default. I'd prefer to leave it a preference for the browser, this is what tha languages support is for. And a small nit. The help for the argument says 2-character language code. This ignores the language subtags (e.g. en-US). If we get to the point that we are differentiating between en_US and en_AS, we will have won this battle. I'll update the Docs once we start doing locale specific files! We have one now, zh_CN. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0034-2-Metadata-I18N.patch
On 09/20/2010 10:07 AM, Rob Crittenden wrote: Adam Young wrote: On 09/17/2010 02:24 PM, Adam Young wrote: Metadata I18N Created a clone of the json_metadata plugin called plugin_metadata It is identical in all reagards to the json_metadata plugin, except it performs the gettext transalation based on the 'language' parameter Once this is accepted, the next step is to change over to using this plugin, ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel I was doing an improper check for the presence of a key in the dictionary of env vars ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel It would be nice to be able to use the Accept-Language header provided by the browser. The wsgi environ variable holds the headers as a dictionary and it'll look something like: 'HTTP_ACCEPT_LANGUAGE': 'en-us,en;q=0.5' So this means my browser accepts en-us and en (and prefer en-us over en). See full definition at http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.4 I'm aware, I just wasn't certain if this info was available to the plugins We should be able to stick the accepts-language value into the request context and evaluate it later. See in ipaserver/rpcserver.py the call to create_context(). How is the javascript call going to know what language to request? JS has acces to the header info, and could also let the user save their preference in a cookie. I'd like to have both options, and so think we should only evaluate the parameter if it is present, and use the header info as the default. And a small nit. The help for the argument says 2-character language code. This ignores the language subtags (e.g. en-US). If we get to the point that we are differentiating between en_US and en_AS, we will have won this battle. I'll update the Docs once we start doing locale specific files! rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0034-2-Metadata-I18N.patch
Adam Young wrote: On 09/17/2010 02:24 PM, Adam Young wrote: Metadata I18N Created a clone of the json_metadata plugin called plugin_metadata It is identical in all reagards to the json_metadata plugin, except it performs the gettext transalation based on the 'language' parameter Once this is accepted, the next step is to change over to using this plugin, ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel I was doing an improper check for the presence of a key in the dictionary of env vars ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel It would be nice to be able to use the Accept-Language header provided by the browser. The wsgi environ variable holds the headers as a dictionary and it'll look something like: 'HTTP_ACCEPT_LANGUAGE': 'en-us,en;q=0.5' So this means my browser accepts en-us and en (and prefer en-us over en). See full definition at http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.4 We should be able to stick the accepts-language value into the request context and evaluate it later. See in ipaserver/rpcserver.py the call to create_context(). How is the javascript call going to know what language to request? And a small nit. The help for the argument says 2-character language code. This ignores the language subtags (e.g. en-US). rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0028-theme.patch
On 09/20/2010 09:19 AM, Adam Young wrote: admiyo-freeipa-0028-theme.patch Use customized theme and images that is closer to the UX suggested look and feel This is required to get patch 30 to apply as well. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Posted the patch in the wrong email, sse the thread about patch 30 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] admiyo-freeipa-0028-theme.patch
admiyo-freeipa-0028-theme.patch Use customized theme and images that is closer to the UX suggested look and feel This is required to get patch 30 to apply as well. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0036-links-and-facet-icons.patch
On 09/18/2010 02:36 AM, Adam Young wrote: This patch makes use of the previous patch to put the icons in the facets and quick links It looks OK, but I can't test it because the required patch 30 doesn't apply for me. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0030-moved-images-up.patch
On 09/17/2010 04:38 PM, Adam Young wrote: moved images up Adding an 'images' subdir was proliferating changes throughout the build system this seemed easier Submitted as a separate patch to signify where wea re departing from what is generated by theme-roller Doesn't apply for me. Missing some image files and doesn't apply on jquery-ui.css. I applied all your patches I could find before this one, but I can't find number 28 on the list. Maybe that's the reason. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Icons
On 09/18/2010 02:35 AM, Adam Young wrote: THese are just place holder icons until we get the offical ones from UXD. They look roughly like the finished product, with have some rough points. They will be used by the next patch to Generate the quick links and facets. THis is a huga patch, but it is all binary files. ACK. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0033-pointer-cursor-for-facets.patch
On 09/17/2010 04:43 PM, Adam Young wrote: Changes the mouse icon for facets to a the pointer, signifying clickability ACK. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0032-css-cleanup.patch
On 09/17/2010 04:42 PM, Adam Young wrote: Fixes many of the CSS issues introduced by jquery.ui.tabs. Not all, but it looks a lot better ACK. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0031-unbroke-the-facets-link.patch
On 09/17/2010 04:41 PM, Adam Young wrote: This has a fix for a previous patch which turned the facets into a hortizontal list, but broke the clickability. ACK. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0027-fix-sampledata.patch
On 09/17/2010 04:34 PM, Adam Young wrote: URL needs to be relative, not absolute in order for in tree development ACK. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0026-fixed-formatting-of-search-table.patch
On 09/17/2010 04:33 PM, Adam Young wrote: admiyo-freeipa-0026-fixed-formatting-of-search-table.patch ACK. Pavel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel