Re: [Freeipa-devel] [PATCH] 018 Normalize and convert default params, too

2010-12-02 Thread Adam Young
This seems to make sense. Can you provide some context before I ACK? On 12/02/2010 09:21 AM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 https://fedorahosted.org/freeipa/ticket/555 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG

Re: [Freeipa-devel] [PATCH] 018 Normalize and convert default params, too

2010-12-02 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/02/2010 03:33 PM, Adam Young wrote: This seems to make sense. Can you provide some context before I ACK? We're discussing it with Rob in the ticket, too: https://fedorahosted.org/freeipa/ticket/555 -BEGIN PGP SIGNATURE- Version: GnuPG

Re: [Freeipa-devel] [PATCH] Multicolumn enrollment dialog

2010-12-02 Thread Adam Young
On 12/01/2010 08:56 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/112/ The enrollment dialog has been modified to use scrollable tables that supports multiple columns to display the search results and selected entries. The

Re: [Freeipa-devel] [PATCH] 622 fix passwd output

2010-12-02 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/30/2010 09:13 PM, Rob Crittenden wrote: A couple of Password attributes had no label so prompting looked bad. When printing exceptions we need to convert the label and error to unicode so translations work. Use standard output routines

[Freeipa-devel] [PATCH] 625 Provide attrs for ACI UI

2010-12-02 Thread Rob Crittenden
Provide available attributes for all objects for use in creating permissions (ACIs). This is provided in the meta data call. Also tell whether an object is bindable (has password or kerberos key) for use in the future selfservice plugin. rob From 7ccf39c8797b74853d279f1c6698b33d06a1e319 Mon

Re: [Freeipa-devel] [PATCH] 619 more aci target docs

2010-12-02 Thread Rob Crittenden
David O'Brien wrote: Rob Crittenden wrote: I added some more documentation and examples to the aci plugin on targets. ticket 310 rob NACK Running behind with reviews, sorry. Just a few minor fixes: s/targetted/targeted/ s/This is primarily meant to be able to allow users to add/remove

[Freeipa-devel] [PATCH] admiyo-0108-remove-task-and-role-groups

2010-12-02 Thread Adam Young
These will be replaced with the new ACI entities shortly. But they have to be removed, as they break the webUI as is. From cd40488cbb4bee3a06c9adc3a9d35ce3fa1aca08 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Thu, 2 Dec 2010 11:39:33 -0500 Subject: [PATCH] remove task and

Re: [Freeipa-devel] [PATCH] admiyo-0108-remove-task-and-role-groups

2010-12-02 Thread Endi Sukma Dewata
On 12/2/2010 10:41 AM, Adam Young wrote: These will be replaced with the new ACI entities shortly. But they have to be removed, as they break the webUI as is. ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] Certificate management with self-signed CA

2010-12-02 Thread Adam Young
On 12/02/2010 12:02 AM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! The certificate_status_widget has been modified to check for the environment variable ra_plugin to determine the CA used by IPA server. If self-signed CA is used, some operations will not be

Re: [Freeipa-devel] [PATCH] Multicolumn enrollment dialog

2010-12-02 Thread Adam Young
On 12/02/2010 10:19 AM, Adam Young wrote: On 12/01/2010 08:56 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/112/ The enrollment dialog has been modified to use scrollable tables that supports multiple columns to display the

[Freeipa-devel] [PATCH] admiyo-0106-associate-search

2010-12-02 Thread Adam Young
Had this one ready for review, but Endi's recent association changes meant I had to rebase it. Hence the -2. patch version From 14a5910c6ef56a212fbac3a8c76467e17d9b7719 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Thu, 2 Dec 2010 12:35:37 -0500 Subject: [PATCH] associate

Re: [Freeipa-devel] [PATCH] admiyo-0106-associate-search

2010-12-02 Thread Endi Sukma Dewata
On 12/2/2010 11:37 AM, Adam Young wrote: Had this one ready for review, but Endi's recent association changes meant I had to rebase it. Hence the -2. patch version ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 619 more aci target docs

2010-12-02 Thread Rob Crittenden
Rob Crittenden wrote: David O'Brien wrote: Rob Crittenden wrote: I added some more documentation and examples to the aci plugin on targets. ticket 310 rob NACK Running behind with reviews, sorry. Just a few minor fixes: s/targetted/targeted/ s/This is primarily meant to be able to allow

Re: [Freeipa-devel] [PATCH] UI for host managedby

2010-12-02 Thread Adam Young
On 12/01/2010 09:39 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! A custom facet has been added to manage the host's managedby attribute. The facet defines the add and remove methods, the columns for the association table and enrollment dialog, and the link for the

Re: [Freeipa-devel] [PATCH] 618 handle membership better

2010-12-02 Thread Simo Sorce
On Tue, 23 Nov 2010 15:14:27 -0500 Rob Crittenden rcrit...@redhat.com wrote: Use better description for group names in help and always prompt for members When running foo-[add|remove]-member completely interactively it didn't prompt for managing membership, it just reported that 0 members

Re: [Freeipa-devel] [PATCH] 018 Normalize and convert default params, too

2010-12-02 Thread Rob Crittenden
Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/02/2010 03:33 PM, Adam Young wrote: This seems to make sense. Can you provide some context before I ACK? We're discussing it with Rob in the ticket, too: https://fedorahosted.org/freeipa/ticket/555 It works for me,

Re: [Freeipa-devel] [PATCH] Some fixes in HBAC module

2010-12-02 Thread Rob Crittenden
Jan Zelený wrote: I'm posting two patches fixing some issues with the HBAC plugin: https://fedorahosted.org/freeipa/ticket/487 https://fedorahosted.org/freeipa/ticket/494 https://fedorahosted.org/freeipa/ticket/495 Ack patch 0007, pushed to master. rob

Re: [Freeipa-devel] [PATCH] 618 handle membership better

2010-12-02 Thread Rob Crittenden
Simo Sorce wrote: On Tue, 23 Nov 2010 15:14:27 -0500 Rob Crittendenrcrit...@redhat.com wrote: Use better description for group names in help and always prompt for members When runningfoo-[add|remove]-member completely interactively it didn't prompt for managing membership, it just reported

Re: [Freeipa-devel] [PATCH] 621 drop install/tools/README

2010-12-02 Thread Rob Crittenden
Jakub Hrozek wrote: On Tue, Nov 30, 2010 at 02:02:00PM -0500, Rob Crittenden wrote: The README in install/tools is really for v1 and contains almost nothing useful for v2 so I'm proposing to drop it altogether. I'm also adding a link to the QuickStart guide on the trac wiki. The guide itself

Re: [Freeipa-devel] [PATCH] 622 fix passwd output

2010-12-02 Thread Rob Crittenden
Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/30/2010 09:13 PM, Rob Crittenden wrote: A couple of Password attributes had no label so prompting looked bad. When printing exceptions we need to convert the label and error to unicode so translations work. Use standard

Re: [Freeipa-devel] [PATCH] Do not create reverse zone by default

2010-12-02 Thread Simo Sorce
On Mon, 15 Nov 2010 12:53:22 +0100 Jakub Hrozek jhro...@redhat.com wrote: Prompt for creation of reverse zone, with the default for unattended installations being False. https://fedorahosted.org/freeipa/ticket/418 ACK and pushed to master. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [Freeipa-devel] [PATCH] admiyo-0110-tooltips

2010-12-02 Thread Endi Sukma Dewata
On 12/2/2010 3:43 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] Fixed association links

2010-12-02 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/113/ The create_association_facets() has been modified such that it does not generate duplicate links. This is done by assigning the proper labels and hiding non-assignable associations. Each association will

[Freeipa-devel] [PATCH] Fixed buttons in enrollment dialog

2010-12-02 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! The Find, Add, and Remove buttons in the enrollment dialog have been replaced with ipa_buttons. -- Endi S. Dewata From d70d1e1293d851ca738235b14ce9922361aa0f35 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Thu, 2 Dec 2010

Re: [Freeipa-devel] [PATCH] Fixed buttons in enrollment dialog

2010-12-02 Thread Adam Young
On 12/02/2010 09:50 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! The Find, Add, and Remove buttons in the enrollment dialog have been replaced with ipa_buttons. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com