Re: [Freeipa-devel] [PATCH] 142 Moved entity builder registration into webui.js.

2011-04-20 Thread Adam Young
On 04/19/2011 06:50 PM, Endi Sukma Dewata wrote: The entity builder registration have been moved into webui.js. This allows the WebUI to control which entities will be loaded. For instance, the entitlement should be loaded only if the plugin is enabled. This is done by checking the metadata.

Re: [Freeipa-devel] [PATCH] 142 Moved entity builder registration into webui.js.

2011-04-20 Thread Adam Young
On 04/20/2011 12:28 PM, Endi Sukma Dewata wrote: On 4/20/2011 9:43 AM, Adam Young wrote: On 04/19/2011 06:50 PM, Endi Sukma Dewata wrote: The entity builder registration have been moved into webui.js. This allows the WebUI to control which entities will be loaded. For instance, the

Re: [Freeipa-devel] [PATCH] 771 include rights for all aci components in permission_show

2011-04-20 Thread Rob Crittenden
Martin Kosek wrote: On Wed, 2011-04-13 at 11:34 -0400, Rob Crittenden wrote: Provide attributelevelrights for the aci components in permission_show. Since the broken-out components are just part of the aci just copy right access rights for aci. ticket 943 rob NACK. Works fine for

Re: [Freeipa-devel] [PATCH] 23 Optimize and dynamically verify group membership

2011-04-20 Thread Rob Crittenden
JR Aquino wrote: On Apr 12, 2011, at 10:55 AM, Rob Crittenden wrote: JR Aquino wrote: On Apr 7, 2011, at 7:08 PM, JR Aquino wrote: On Apr 7, 2011, at 4:04 PM, JR Aquino wrote: On Apr 7, 2011, at 3:42 PM, JR Aquino wrote: On Mar 31, 2011, at 2:16 PM, JR Aquino wrote: On Mar 31, 2011,

Re: [Freeipa-devel] [PATCH] 23 Optimize and dynamically verify group membership

2011-04-20 Thread JR Aquino
On Apr 20, 2011, at 10:32 AM, Rob Crittenden wrote: ... Seems to work as advertised, I just have a couple of requests: - Some of the comments are really long, can you limit to ~75 chars per line? - In this code block: for r in results: direct.append(r[0])

Re: [Freeipa-devel] [PATCH] 12 Remove unused classes

2011-04-20 Thread Rob Crittenden
Jan Cholasta wrote: Removes unused classes NSPRConnection and NSPRHTTP from ipapython.nsslib. ack, pushed to master and ipa-2-0 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 13 Final lint fixes

2011-04-20 Thread Rob Crittenden
Jan Cholasta wrote: Fixes additional false positives found in install/po/test_i18n.py and a missing import in ipa-nis-manage. This should be the last patch dealing with pylint-discovered issues. ack, pushed to master and ipa-2-0. FYI, I amended the commit message to be a bit more specific.

Re: [Freeipa-devel] [PATCH] 3 Add ability to specify netmask with IP addresses during installation

2011-04-20 Thread Rob Crittenden
Jan Cholasta wrote: On 11.4.2011 12:48, Jan Cholasta wrote: On 8.4.2011 16:26, Rob Crittenden wrote: Jan Cholasta wrote: On 29.3.2011 22:15, Rob Crittenden wrote: Jan Cholasta wrote: Sorry, forgot to attach the patch. Is this why you have some blind excepts?

Re: [Freeipa-devel] [PATCH] 142 Moved entity builder registration into webui.js.

2011-04-20 Thread Endi Sukma Dewata
On 4/20/2011 11:50 AM, Adam Young wrote: Leave the factories as the top level object. For the factory name, say 'entitle' check that the object is in the metadata. If not, don't create the entity. Then, when processing the tabs, if the entity does not exist, drop the tab from the tab set. The

Re: [Freeipa-devel] [PATCH] 142 Moved entity builder registration into webui.js.

2011-04-20 Thread Endi Sukma Dewata
On 4/20/2011 4:32 PM, Endi Sukma Dewata wrote: On 4/20/2011 11:50 AM, Adam Young wrote: Leave the factories as the top level object. For the factory name, say 'entitle' check that the object is in the metadata. If not, don't create the entity. Then, when processing the tabs, if the entity does