[Freeipa-devel] [PATCH] 265 Fixed layout problem in permission adder dialog.

2011-09-07 Thread Endi Sukma Dewata
In order to maintain consistent layout between details page and dialog boxes the IPA.details_list_section has been replaced with IPA.details_table_section which is based on table. The IPA.target_section and other subclasses of IPA.details_list_section have been converted to use IPA.details_table_

Re: [Freeipa-devel] [PATCH] 1 Add ipa-adtrust-install utility

2011-09-07 Thread Simo Sorce
On Tue, 2011-08-30 at 16:40 +0200, Sumit Bose wrote: > I don't think that we should run winbind. > > I also changed the path to the smb.conf file from /etc/ipa > to /etc/samba > which makes the change to /etc/sysconfig/samba unnecessary. > > Thanks for review. > Ok tested this today, after I was

[Freeipa-devel] [PATCH] 264 Fixed unit test for entity select widget.

2011-09-07 Thread Endi Sukma Dewata
The unit test for IPA.entity_select_widget has been fixed to check the options after loading the record. Pushed under one-liner/trivial rule. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/list

Re: [Freeipa-devel] [PATCH] 013 Fixed: JavaScript type error in entitlement page

2011-09-07 Thread Endi Sukma Dewata
On 9/7/2011 11:24 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1767 Opening IPA Server/Entitlements causes: "Uncaught TypeError: Cannot call method 'addClass' of undefined" error - Details.js:489 ACK. Pushed to master and ipa-2-1. -- Endi S. Dewata __

Re: [Freeipa-devel] [PATCH] 012 Fixed inconsistency in enabling delete buttons

2011-09-07 Thread Endi Sukma Dewata
On 9/7/2011 7:16 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1640 On the HBAC Rules page, where the rules are listed, if no rule is selected, the "Delete" button is not enabled, and cannot be clicked on. But edit a Rule, and Delete button is enabled in the available sections

[Freeipa-devel] [PATCH] 013 Fixed: JavaScript type error in entitlement page

2011-09-07 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/1767 Opening IPA Server/Entitlements causes: "Uncaught TypeError: Cannot call method 'addClass' of undefined" error - Details.js:489 -- Petr Vobornik From 17a3dbed887a75fa1ff0198edb5ae9873b1b35a3 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 7

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-09-07 Thread Stephen Gallagher
On Wed, 2011-09-07 at 16:15 +0300, Alexander Bokovoy wrote: > Hi! > > When modifying SSSD configuration, attempt to add new domain rather > than replacing whole configuration file. > > Only replace file in case it is impossible to parse it by current SSSD > version. > > https://fedorahosted.or

Re: [Freeipa-devel] [PATCH] 118 Fix permissions in installers

2011-09-07 Thread Alexander Bokovoy
On Wed, 07 Sep 2011, Martin Kosek wrote: > > > > Related question: should we also mark these generated files in > > /usr/share/ipa/html/ as %ghost in freeipa.spec.in? > > Good idea, then these files could be erased when our package is removed. > Can you please create a ticket? I have created tick

[Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-09-07 Thread Alexander Bokovoy
Hi! When modifying SSSD configuration, attempt to add new domain rather than replacing whole configuration file. Only replace file in case it is impossible to parse it by current SSSD version. https://fedorahosted.org/freeipa/ticket/1750 -- / Alexander Bokovoy >From d09127943967e1760bd2f8a61

Re: [Freeipa-devel] [PATCH] 45 Check that install hostname matches the server hostname

2011-09-07 Thread Rob Crittenden
Jan Cholasta wrote: On 6.9.2011 19:49, Rob Crittenden wrote: Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/1717 Honza nack, what if there are multiple interfaces and you want IPA to use one (that doesn't happen to be the system hostname one)? rob Then the user configures the

[Freeipa-devel] [PATCH] 012 Fixed inconsistency in enabling delete buttons

2011-09-07 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/1640 On the HBAC Rules page, where the rules are listed, if no rule is selected, the "Delete" button is not enabled, and cannot be clicked on. But edit a Rule, and Delete button is enabled in the available sections - regardless of, if an object is selecte

Re: [Freeipa-devel] [PATCH] 118 Fix permissions in installers

2011-09-07 Thread Martin Kosek
On Tue, 2011-09-06 at 13:59 +0300, Alexander Bokovoy wrote: > On 06.09.2011 13:52, Martin Kosek wrote: > > On Tue, 2011-09-06 at 13:12 +0300, Alexander Bokovoy wrote: > >> On 05.09.2011 17:24, Martin Kosek wrote: > >>> How to test: > >>> 1) on server: > >>> - check that files in /usr/share/ipa/html

Re: [Freeipa-devel] [PATCH] 119 Fix typos

2011-09-07 Thread Martin Kosek
On Tue, 2011-09-06 at 13:16 +0300, Alexander Bokovoy wrote: > On 05.09.2011 17:37, Martin Kosek wrote: > > Kudos to Yuri Chornoivan who submitted the patch. > > > > I just created the commit message and prepared separate patches for > > master/ipa-2-1 branches as there was a conflict. > > > > ---

Re: [Freeipa-devel] [PATCH] 117 Improve ipa-join man page

2011-09-07 Thread Martin Kosek
On Tue, 2011-09-06 at 13:00 +0300, Alexander Bokovoy wrote: > On 05.09.2011 13:38, Martin Kosek wrote: > > Make it clear in man pages that ipa-join -u does not remove keytab. > > > > https://fedorahosted.org/freeipa/ticket/1317 > ACK for both ipa-2-1 and master. > > Pushed to master, ipa-2-1.

Re: [Freeipa-devel] [PATCH] 116 Improve man pages structure

2011-09-07 Thread Martin Kosek
On Tue, 2011-09-06 at 14:08 +0300, Alexander Bokovoy wrote: > On 05.09.2011 12:29, Martin Kosek wrote: > > There are too many options in ipa-*-install scripts which makes it > > difficult to read. This patch adds subsections to install script > > online help and man pages to improve readability. No