[Freeipa-devel] [PATCH] 991/992 fix migration issues

2012-03-20 Thread Rob Crittenden
Fix a couple of issues found with migration. I made a second patch just to keep things separate even though its just a one-liner. 991 fixes a problem where we have attributes which point to other entries and these weren't being migrated. This is things like secretary and manager. This was actu

Re: [Freeipa-devel] [PATCH] Try to reacquire keytab file if host already joined

2012-03-20 Thread Lars Sjöström
> Lars Sjöström wrote: >> >> Hi, >> >> Understood! Would it be ok to add an optional flag then? >> like --reacquire ? >> >> like so: >> # run only if force and reacquire is set >> if options.force and options.reacquire: >>   # try to fetch keytab... >> >> Cheers, >> Lars > > > That sounds reasonabl

[Freeipa-devel] [PATCH] 985 no longer shell escape for pkisilent

2012-03-20 Thread Rob Crittenden
pkisilent now shell escapes its arguments so we no longer need to do so, and in fact, if we do it ends up with double-escaping breaking all installs of IPA with a dogtag CA. rob >From e47c2786f37827b75b897abdd9cd4b3ed4f6b9b6 Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Tue, 13 Mar 2012

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-03-20 Thread Rob Crittenden
Petr Viktorin wrote: On 03/16/2012 12:55 PM, Petr Viktorin wrote: On 03/15/2012 08:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2227 (Unable to add certain sudo commands to groups). What an interesting bug to get :) One problem with our CSV splitt

Re: [Freeipa-devel] [PATCH] Try to reacquire keytab file if host already joined

2012-03-20 Thread Rob Crittenden
Lars Sjöström wrote: Hi, Understood! Would it be ok to add an optional flag then? like --reacquire ? like so: # run only if force and reacquire is set if options.force and options.reacquire: # try to fetch keytab... Cheers, Lars That sounds reasonable. In what case would you want to re-en

Re: [Freeipa-devel] [PATCH] 0015 Only split CSV strings once

2012-03-20 Thread Petr Viktorin
On 03/16/2012 12:55 PM, Petr Viktorin wrote: On 03/15/2012 08:55 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2227 (Unable to add certain sudo commands to groups). What an interesting bug to get :) One problem with our CSV splitting is that it's not i

[Freeipa-devel] [PATCH] 71 Propagate SIGINT to child process in ipautil.run

2012-03-20 Thread Jan Cholasta
Propagate SIGINT to child process in ipautil.run. Wait for the child process to terminate before continuing. Do cleanup on KeyboardInterrupt rather than in custom SIGINT handler in ipa-replica-conncheck. https://fedorahosted.org/freeipa/ticket/2127 Honza -- Jan Cholasta >From a4941a69f28858

Re: [Freeipa-devel] [PATCH] 112 Added mac address to host page

2012-03-20 Thread Petr Vobornik
On 03/19/2012 04:47 PM, Endi Sukma Dewata wrote: On 3/19/2012 9:05 AM, Petr Vobornik wrote: Part of support for ether maps. https://fedorahosted.org/freeipa/ticket/2548 ACK. Pushed to master, ipa-2-2. -- Petr Vobornik ___ Freeipa-devel mailing l

Re: [Freeipa-devel] [PATCH] 102-103 UI part of 'Add last missing bits in new bind-dyndb-ldap'

2012-03-20 Thread Petr Vobornik
On 03/09/2012 05:29 AM, Endi Sukma Dewata wrote: ACK. There are some minor issues. Pushed to master, ipa-2-2. On 3/7/2012 10:10 AM, Petr Vobornik wrote: 1) Add support of new options in dnsconfig dnsconfig was extended of new attributes, so reflecting it in UI. New attributes: * idnsForwa

[Freeipa-devel] [PATCH] 489 Fix coverity issues

2012-03-20 Thread Simo Sorce
There is one memory leak in case of an unlikely error condition, most others are just changes to silence coverity where we know that the condition cannot really happen. Simo. -- Simo Sorce * Red Hat, Inc * New York >From a95eff3dd9cd896cfe1e14cc3fc58fc30bc4c2e8 Mon Sep 17 00:00:00 2001 From: Sim

Re: [Freeipa-devel] [PATCH] 227-228 Add last missing bits in new bind-dyndb-ldap

2012-03-20 Thread Martin Kosek
On Tue, 2012-03-20 at 10:27 -0400, Rob Crittenden wrote: > Martin Kosek wrote: > > On Tue, 2012-03-13 at 10:54 +0100, Petr Spacek wrote: > >> On 03/12/2012 07:10 PM, Rob Crittenden wrote: > >>> Martin Kosek wrote: > On Thu, 2012-03-01 at 13:19 +0100, Martin Kosek wrote: > > These 2 patches

Re: [Freeipa-devel] [PATCH] 227-228 Add last missing bits in new bind-dyndb-ldap

2012-03-20 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2012-03-13 at 10:54 +0100, Petr Spacek wrote: On 03/12/2012 07:10 PM, Rob Crittenden wrote: Martin Kosek wrote: On Thu, 2012-03-01 at 13:19 +0100, Martin Kosek wrote: These 2 patches changes the DNS API to support the last missing bits in new bind-dyndb-ldap: 1) B

Re: [Freeipa-devel] [PATCH] Try to reacquire keytab file if host already joined

2012-03-20 Thread Lars Sjöström
Hi, Understood! Would it be ok to add an optional flag then? like --reacquire ? like so: # run only if force and reacquire is set if options.force and options.reacquire: # try to fetch keytab... Cheers, Lars Den 20 mars 2012 13:44 skrev Simo Sorce : > On Tue, 2012-03-20 at 13:00 +0100, Lars S

Re: [Freeipa-devel] [PATCH] Try to reacquire keytab file if host already joined

2012-03-20 Thread Simo Sorce
On Tue, 2012-03-20 at 13:00 +0100, Lars Sjöström wrote: > Hello fellow devs, > > I have a proposed patch for ticket #2106 > (https://fedorahosted.org/freeipa/ticket/2106) > > if return code is 13 (Host already joined) of ipa-join command the > host will try to reacquire the keytab file. > > Feed

Re: [Freeipa-devel] FreeIPA beta1: SELinux prohibits memcached

2012-03-20 Thread Martin Kosek
On Tue, 2012-03-20 at 13:14 +0100, Marco Pizzoli wrote: > Hi Martin, > > On Tue, Mar 20, 2012 at 1:02 PM, Martin Kosek > wrote: > On Tue, 2012-03-20 at 12:44 +0100, Marco Pizzoli wrote: > > Hi guys, > > I don't know if you already know this, but in my logs I can >

Re: [Freeipa-devel] FreeIPA beta1: SELinux prohibits memcached

2012-03-20 Thread Marco Pizzoli
Hi Martin, On Tue, Mar 20, 2012 at 1:02 PM, Martin Kosek wrote: > On Tue, 2012-03-20 at 12:44 +0100, Marco Pizzoli wrote: > > Hi guys, > > I don't know if you already know this, but in my logs I can find this: > > > > > > Mar 20 12:14:47 freeipa01 setroubleshoot: SELinux is > > preventing /usr/b

Re: [Freeipa-devel] FreeIPA beta1: SELinux prohibits memcached

2012-03-20 Thread Martin Kosek
On Tue, 2012-03-20 at 12:44 +0100, Marco Pizzoli wrote: > Hi guys, > I don't know if you already know this, but in my logs I can find this: > > > Mar 20 12:14:47 freeipa01 setroubleshoot: SELinux is > preventing /usr/bin/memcached from create access on the sock_file > ipa_memcached. For complete

[Freeipa-devel] [PATCH] Try to reacquire keytab file if host already joined

2012-03-20 Thread Lars Sjöström
Hello fellow devs, I have a proposed patch for ticket #2106 (https://fedorahosted.org/freeipa/ticket/2106) if return code is 13 (Host already joined) of ipa-join command the host will try to reacquire the keytab file. Feedback appreciated! Cheers, Lars From 96d58f994ea097d9e62c7aae831066e4a25b0

[Freeipa-devel] FreeIPA beta1: SELinux prohibits memcached

2012-03-20 Thread Marco Pizzoli
Hi guys, I don't know if you already know this, but in my logs I can find this: Mar 20 12:14:47 freeipa01 setroubleshoot: SELinux is preventing /usr/bin/memcached from create access on the sock_file ipa_memcached. For complete SELinux messages. run sealert -l 85b51f4e-3f2e-4e7d-819f-1efb04836de3

Re: [Freeipa-devel] [PATCH] 0016 Fixes for{add, set, del}attr with managed attributes

2012-03-20 Thread Petr Viktorin
On 03/16/2012 08:01 PM, Petr Viktorin wrote: On 03/16/2012 06:35 PM, Petr Viktorin wrote: On 03/16/2012 06:33 PM, Rob Crittenden wrote: Rob Crittenden wrote: Petr Viktorin wrote: On 03/15/2012 09:24 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 02/29/2012 04:34 PM, Petr Viktorin wrote:

Re: [Freeipa-devel] [PATCH] 990 attribute name in exceptions

2012-03-20 Thread Martin Kosek
On Mon, 2012-03-19 at 15:41 -0400, Rob Crittenden wrote: > Martin Kosek wrote: > > On Mon, 2012-03-19 at 14:43 -0400, Rob Crittenden wrote: > >> Petr Viktorin wrote: > >>> On 03/19/2012 03:02 PM, Rob Crittenden wrote: > Petr Viktorin wrote: > > On 03/16/2012 10:23 PM, Rob Crittenden wrote: