Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-11 Thread Martin Kosek
On Tue, 2012-04-10 at 13:56 -0400, Dmitri Pal wrote: On 04/10/2012 01:48 PM, Rob Crittenden wrote: [snip] The use case I would see is the extensibility. Say a customer wants to extend a schema and add an attribute X to the user object. He would still be able to manage users using CLI without

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-11 Thread Jan Cholasta
On 10.4.2012 19:56, Dmitri Pal wrote: On 04/10/2012 01:48 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 04/10/2012 07:07 PM, Martin Kosek wrote: On Tue, 2012-04-10 at 17:03 +0200, Jan Cholasta wrote: On 10.4.2012 16:00, Petr Viktorin wrote: I'm aware that we have backwards compatibility

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-11 Thread Jan Cholasta
On 11.4.2012 09:27, Martin Kosek wrote: On Wed, 2012-04-11 at 09:18 +0200, Jan Cholasta wrote: On 10.4.2012 19:56, Dmitri Pal wrote: On 04/10/2012 01:48 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 04/10/2012 07:07 PM, Martin Kosek wrote: On Tue, 2012-04-10 at 17:03 +0200, Jan Cholasta

Re: [Freeipa-devel] [PATCH] 0034 Limit permission and selfservice names

2012-04-11 Thread Petr Viktorin
On 04/10/2012 08:06 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 04/10/2012 03:46 PM, Rob Crittenden wrote: Petr Viktorin wrote: ... pattern_errmsg should probably be removed from API.txt. We've been paring back the amount of data to validate slowly as we've run into these questionable

Re: [Freeipa-devel] [PATCH] 21 Unable to rename permission object

2012-04-11 Thread Ondrej Hamada
On 04/10/2012 09:35 PM, Rob Crittenden wrote: Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2571 The update was failing because of the case insensitivity of permission object DN. Can you wrap the error in _() and add a couple of test cases for this, say one for the case

Re: [Freeipa-devel] [PATCH] 0034 Limit permission and selfservice names

2012-04-11 Thread Rob Crittenden
Petr Viktorin wrote: On 04/10/2012 08:06 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 04/10/2012 03:46 PM, Rob Crittenden wrote: Petr Viktorin wrote: ... pattern_errmsg should probably be removed from API.txt. We've been paring back the amount of data to validate slowly as we've run

Re: [Freeipa-devel] [PATCH 69] Use indexed format specifiers in i18n strings

2012-04-11 Thread Rob Crittenden
John Dennis wrote: On 04/04/2012 09:01 AM, Petr Viktorin wrote: On 04/02/2012 03:15 PM, Rob Crittenden wrote: John Dennis wrote: Translators need to reorder messages to suit the needs of the target language. The conventional positional format specifiers (e.g. %s %d) do not permit reordering

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-04-11 Thread Rob Crittenden
Petr Viktorin wrote: On 04/09/2012 05:24 PM, John Dennis wrote: On 03/30/2012 08:57 AM, Petr Viktorin wrote: On 03/30/2012 02:41 AM, John Dennis wrote: On 03/28/2012 04:40 AM, Petr Viktorin wrote: Can install/po/Makefile just call test_i18n.py from the tests/ tree? It doesn't import any IPA

Re: [Freeipa-devel] [RANT] --setattr validation is a minefield.

2012-04-11 Thread Dmitri Pal
On 04/11/2012 03:42 AM, Jan Cholasta wrote: On 11.4.2012 09:27, Martin Kosek wrote: On Wed, 2012-04-11 at 09:18 +0200, Jan Cholasta wrote: On 10.4.2012 19:56, Dmitri Pal wrote: On 04/10/2012 01:48 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 04/10/2012 07:07 PM, Martin Kosek wrote: On

[Freeipa-devel] param type issues

2012-04-11 Thread John Dennis
I recently tried to add a new parameter class (i.e. derived from Param), it did not go smoothly. I presume the problems I ran into were coding oversights in our current base, not intentional limitations but I like to confirm that. 1) Default values are not converted to the type of the parameter

Re: [Freeipa-devel] param type issues

2012-04-11 Thread Rob Crittenden
John Dennis wrote: I recently tried to add a new parameter class (i.e. derived from Param), it did not go smoothly. I presume the problems I ran into were coding oversights in our current base, not intentional limitations but I like to confirm that. 1) Default values are not converted to the

Re: [Freeipa-devel] param type issues

2012-04-11 Thread John Dennis
On 04/11/2012 01:44 PM, Rob Crittenden wrote: John Dennis wrote: The default value should be treated just as if the user had supplied the value passing through all the same normization and conversion steps. Params have always been rather primitive types so this has never come up. It seems

Re: [Freeipa-devel] [PATCH] 0033 Pass make-test arguments through to Nose + Test coverage

2012-04-11 Thread Rob Crittenden
Petr Viktorin wrote: Currently, our test script forwards a select few command line arguments to nosetests. This patch removes the filtering, passing all arguments through. This allows things like disabling output redirection (--nocapture), dropping into a debugger (--pdb, --pdb-failures),

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-11 Thread John Dennis
Revised patch attached. We'll leave the DN parameter changes till later. This is essentially the same as the original patch with the addition of the fixes necessary to support passing an empty container arg, an issue Martin discovered in his review. FWIW the answer was not to make the param