Re: [Freeipa-devel] [PATCH] 1037 optimize restoring SELinux booleans

2012-10-01 Thread Rob Crittenden
Petr Viktorin wrote: On 10/01/2012 04:41 PM, Rob Crittenden wrote: The web uninstall step can be very long because we restore two SELinux booleans individually. This patch combines them into a single step, and skips setting them if the values won't actually change. rob Is there a reason to

Re: [Freeipa-devel] [PATCH 0016] Adds port to connection error message in ipa-client-install

2012-10-01 Thread Tomas Babej
On 09/26/2012 09:32 PM, Rob Crittenden wrote: Tomas Babej wrote: Hi, Connection error message in ipa-client-install now warns the user about the need of opening 389 port for directory server. https://fedorahosted.org/freeipa/ticket/2816 I think this can be pushed as a one-liner. I think we

Re: [Freeipa-devel] [PATCH] 0081 Support both unified samba and samba/samba4-packages

2012-10-01 Thread Alexander Bokovoy
On Mon, 01 Oct 2012, Martin Kosek wrote: +%else Requires: samba4-python Requires: samba4 -Requires: libsss_idmap Requires: samba4-winbind +%endif +Requires: libsss_idmap < :) Thanks. I was not looking properly. ACK Pushed to master, ipa-3-0. I just added ticket #3118 to patch descr

Re: [Freeipa-devel] [PATCH] 0081 Support both unified samba and samba/samba4-packages

2012-10-01 Thread Martin Kosek
On 10/01/2012 04:54 PM, Alexander Bokovoy wrote: > On Mon, 01 Oct 2012, Martin Kosek wrote: >> On 10/01/2012 04:35 PM, Alexander Bokovoy wrote: >>> On Mon, 01 Oct 2012, Martin Kosek wrote: On 10/01/2012 11:24 AM, Alexander Bokovoy wrote: > Hi, > > The patch attached fixes Fedora bu

[Freeipa-devel] [PATCH] 319 Make ipakrbprincipal objectclass optional

2012-10-01 Thread Martin Kosek
>From IPA 3.0, services have by default ipakrbprincipal objectclass which allows ipakrbprincipalalias attribute used for case-insensitive principal searches. However, as services created in previous version do not have this objectclass (and attribute), they are not listed in service list produced b

Re: [Freeipa-devel] [PATCH] Changes to use a single database for dogtag and IPA

2012-10-01 Thread Ade Lee
On Mon, 2012-10-01 at 16:09 +0200, Martin Kosek wrote: > On 10/01/2012 03:35 PM, Petr Viktorin wrote: > > On 09/27/2012 10:26 AM, Petr Viktorin wrote: > >> On 09/20/2012 05:58 AM, Ade Lee wrote: > >>> Changes to use a single database for dogtag and IPA > >>> > >>> New servers that are installe

Re: [Freeipa-devel] [PATCH] 0081 Support both unified samba and samba/samba4-packages

2012-10-01 Thread Alexander Bokovoy
On Mon, 01 Oct 2012, Martin Kosek wrote: On 10/01/2012 04:35 PM, Alexander Bokovoy wrote: On Mon, 01 Oct 2012, Martin Kosek wrote: On 10/01/2012 11:24 AM, Alexander Bokovoy wrote: Hi, The patch attached fixes Fedora build system issue with unified samba package (samba/samba4 packages got merg

Re: [Freeipa-devel] [PATCH] 1037 optimize restoring SELinux booleans

2012-10-01 Thread Petr Viktorin
On 10/01/2012 04:41 PM, Rob Crittenden wrote: The web uninstall step can be very long because we restore two SELinux booleans individually. This patch combines them into a single step, and skips setting them if the values won't actually change. rob Is there a reason to not reuse the code tha

Re: [Freeipa-devel] [PATCH] 0081 Support both unified samba and samba/samba4-packages

2012-10-01 Thread Martin Kosek
On 10/01/2012 04:35 PM, Alexander Bokovoy wrote: > On Mon, 01 Oct 2012, Martin Kosek wrote: >> On 10/01/2012 11:24 AM, Alexander Bokovoy wrote: >>> Hi, >>> >>> The patch attached fixes Fedora build system issue with unified samba >>> package (samba/samba4 packages got merged in Fedora 18 and Rawhid

[Freeipa-devel] [PATCH] 1037 optimize restoring SELinux booleans

2012-10-01 Thread Rob Crittenden
The web uninstall step can be very long because we restore two SELinux booleans individually. This patch combines them into a single step, and skips setting them if the values won't actually change. rob >From f9cfa7252e7a5d967ca0786c56431589b4489660 Mon Sep 17 00:00:00 2001 From: Rob Crittenden

Re: [Freeipa-devel] [PATCH] 0081 Support both unified samba and samba/samba4-packages

2012-10-01 Thread Alexander Bokovoy
On Mon, 01 Oct 2012, Martin Kosek wrote: On 10/01/2012 11:24 AM, Alexander Bokovoy wrote: Hi, The patch attached fixes Fedora build system issue with unified samba package (samba/samba4 packages got merged in Fedora 18 and Rawhide recently) since we depend on a wbclient.h header file path to wh

Re: [Freeipa-devel] [PATCH] Changes to use a single database for dogtag and IPA

2012-10-01 Thread Martin Kosek
On 10/01/2012 03:35 PM, Petr Viktorin wrote: > On 09/27/2012 10:26 AM, Petr Viktorin wrote: >> On 09/20/2012 05:58 AM, Ade Lee wrote: >>> Changes to use a single database for dogtag and IPA >>> >>> New servers that are installed with dogtag 10 instances will use >>> a single database inst

Re: [Freeipa-devel] [PATCH] 0081 Support both unified samba and samba/samba4-packages

2012-10-01 Thread Martin Kosek
On 10/01/2012 11:24 AM, Alexander Bokovoy wrote: > Hi, > > The patch attached fixes Fedora build system issue with unified samba > package (samba/samba4 packages got merged in Fedora 18 and Rawhide > recently) since we depend on a wbclient.h header file path to which > included versioned directory

Re: [Freeipa-devel] [PATCH 0014] Improve user addition to default group in host-add

2012-10-01 Thread Tomas Babej
On 09/26/2012 04:12 PM, Martin Kosek wrote: On 09/26/2012 03:23 PM, Tomas Babej wrote: On 09/25/2012 12:37 PM, Tomas Babej wrote: Hi, On adding new user, host-add tries to make it a member of default user group. This, however, can raise AlreadyGroupMember when the user is already member of thi

Re: [Freeipa-devel] [PATCH] Changes to use a single database for dogtag and IPA

2012-10-01 Thread Petr Viktorin
On 09/27/2012 10:26 AM, Petr Viktorin wrote: On 09/20/2012 05:58 AM, Ade Lee wrote: Changes to use a single database for dogtag and IPA New servers that are installed with dogtag 10 instances will use a single database instance for dogtag and IPA, albeit with different suffixes.

Re: [Freeipa-devel] [PATCH] 317 Improve StrEnum validation error message

2012-10-01 Thread Martin Kosek
On 10/01/2012 11:16 AM, Jan Cholasta wrote: > Dne 1.10.2012 10:05, Martin Kosek napsal(a): >> On 10/01/2012 09:19 AM, Jan Cholasta wrote: >>> Dne 27.9.2012 14:28, Martin Kosek napsal(a): Do not print list of possible values as "%r" but simply as a list of quoted values which should make i

[Freeipa-devel] [PATCH] 0081 Support both unified samba and samba/samba4-packages

2012-10-01 Thread Alexander Bokovoy
Hi, The patch attached fixes Fedora build system issue with unified samba package (samba/samba4 packages got merged in Fedora 18 and Rawhide recently) since we depend on a wbclient.h header file path to which included versioned directory name previously (samba-4.0/ vs samba/). -- / Alexander Boko

Re: [Freeipa-devel] [PATCH] 317 Improve StrEnum validation error message

2012-10-01 Thread Jan Cholasta
Dne 1.10.2012 10:05, Martin Kosek napsal(a): On 10/01/2012 09:19 AM, Jan Cholasta wrote: Dne 27.9.2012 14:28, Martin Kosek napsal(a): Do not print list of possible values as "%r" but simply as a list of quoted values which should make it easier to read for users. Also add a special case when th

Re: [Freeipa-devel] [PATCH] 317 Improve StrEnum validation error message

2012-10-01 Thread Martin Kosek
On 10/01/2012 09:19 AM, Jan Cholasta wrote: > Dne 27.9.2012 14:28, Martin Kosek napsal(a): >> Do not print list of possible values as "%r" but simply as a list >> of quoted values which should make it easier to read for users. >> Also add a special case when there is just one allowed value. >> >> h

Re: [Freeipa-devel] [PATCH] 317 Improve StrEnum validation error message

2012-10-01 Thread Jan Cholasta
Dne 27.9.2012 14:28, Martin Kosek napsal(a): Do not print list of possible values as "%r" but simply as a list of quoted values which should make it easier to read for users. Also add a special case when there is just one allowed value. https://fedorahosted.org/freeipa/ticket/2869 Examples of