Re: [Freeipa-devel] [PATCH] 1077 fix ipa-join --unenroll crash

2012-12-07 Thread Martin Kosek
On 12/06/2012 10:30 PM, Rob Crittenden wrote: There were a number of code paths where we would try to call xmlrpc_env_clean() without having first called xmlrpc_env_init() Re-order the code so we always initialize the XML-RPC client first. I also noticed a place where the return value of

Re: [Freeipa-devel] [PATCH] 350 Configuring CA with ConfigParser.

2012-12-07 Thread Petr Viktorin
On 12/05/2012 01:54 PM, Petr Viktorin wrote: On 12/04/2012 10:51 PM, Endi Sukma Dewata wrote: On 12/4/2012 3:16 PM, Endi Sukma Dewata wrote: The configuration code has been modified to use the ConfigParser to set the parameters in the CA section in the deployment configuration. This allows IPA

Re: [Freeipa-devel] [PATCH] 1075 wrap password change in transaction

2012-12-07 Thread Martin Kosek
On 12/06/2012 05:33 AM, Rob Crittenden wrote: Wrap the password change extop in a 389-ds transaction and ensure that administratively set passwords are always considered expired. I also removed an extraneous init from the betxn conversion. This was causing an error to be raised in the 389-ds

[Freeipa-devel] [PATCH] 341 Bump 389-ds-base minimum in our spec file

2012-12-07 Thread Martin Kosek
Our code needs both Requires and BuildRequires set to 389-ds-base which supports transactions. -- This patch is for master branch only. Martin From 426f66ea8bcce0ffbb4a6bbe79adc99d68c9d0f7 Mon Sep 17 00:00:00 2001 From: Martin Kosek mko...@redhat.com Date: Fri, 7 Dec 2012 12:21:52 +0100

Re: [Freeipa-devel] [PATCH] 335 Stop and disable conflicting timedate services

2012-12-07 Thread Martin Kosek
On 11/15/2012 10:49 PM, Simo Sorce wrote: On Thu, 2012-11-15 at 17:33 +0100, Martin Kosek wrote: On 11/15/2012 03:22 PM, Simo Sorce wrote: On Thu, 2012-11-15 at 12:34 +0100, Martin Kosek wrote: Fedora 16 introduced chrony as default client timedate synchronization service:

Re: [Freeipa-devel] [PATCH] 341 Bump 389-ds-base minimum in our spec file

2012-12-07 Thread Sumit Bose
On Fri, Dec 07, 2012 at 01:00:16PM +0100, Martin Kosek wrote: On 12/07/2012 12:26 PM, Martin Kosek wrote: Our code needs both Requires and BuildRequires set to 389-ds-base which supports transactions. -- This patch is for master branch only. Martin Attaching a patch with

Re: [Freeipa-devel] [PATCH] 341 Bump 389-ds-base minimum in our spec file

2012-12-07 Thread Martin Kosek
On 12/07/2012 01:49 PM, Sumit Bose wrote: On Fri, Dec 07, 2012 at 01:00:16PM +0100, Martin Kosek wrote: On 12/07/2012 12:26 PM, Martin Kosek wrote: Our code needs both Requires and BuildRequires set to 389-ds-base which supports transactions. -- This patch is for master branch only.

Re: [Freeipa-devel] [PATCH] 335 Stop and disable conflicting timedate services

2012-12-07 Thread Simo Sorce
On Fri, 2012-12-07 at 13:14 +0100, Martin Kosek wrote: On 11/15/2012 10:49 PM, Simo Sorce wrote: On Thu, 2012-11-15 at 17:33 +0100, Martin Kosek wrote: On 11/15/2012 03:22 PM, Simo Sorce wrote: On Thu, 2012-11-15 at 12:34 +0100, Martin Kosek wrote: Fedora 16 introduced chrony as default

Re: [Freeipa-devel] [PATCH] 1077 fix ipa-join --unenroll crash

2012-12-07 Thread Rob Crittenden
Martin Kosek wrote: On 12/06/2012 10:30 PM, Rob Crittenden wrote: There were a number of code paths where we would try to call xmlrpc_env_clean() without having first called xmlrpc_env_init() Re-order the code so we always initialize the XML-RPC client first. I also noticed a place where the

Re: [Freeipa-devel] [PATCH] 335 Stop and disable conflicting timedate services

2012-12-07 Thread Martin Kosek
On 12/07/2012 02:51 PM, Simo Sorce wrote: On Fri, 2012-12-07 at 13:14 +0100, Martin Kosek wrote: On 11/15/2012 10:49 PM, Simo Sorce wrote: On Thu, 2012-11-15 at 17:33 +0100, Martin Kosek wrote: On 11/15/2012 03:22 PM, Simo Sorce wrote: On Thu, 2012-11-15 at 12:34 +0100, Martin Kosek wrote:

Re: [Freeipa-devel] [PATCH] 340 Add OCSP and CRL URIs to certificates

2012-12-07 Thread Rob Crittenden
Martin Kosek wrote: On 12/06/2012 08:35 PM, Rob Crittenden wrote: Martin Kosek wrote: On 12/06/2012 04:48 PM, Martin Kosek wrote: On 12/06/2012 04:45 PM, Martin Kosek wrote: Modify the default IPA CA certificate profile to include CRL and OCSP extensions which will add URIs to IPA CRLOCSP to

Re: [Freeipa-devel] [PATCH] 335 Stop and disable conflicting timedate services

2012-12-07 Thread Simo Sorce
On Fri, 2012-12-07 at 16:50 +0100, Martin Kosek wrote: Ok, I see your point now. Sending an updated version. During server installation, user is warned when running conflicting time service. Installation then enforces ntpd configuration. During client installation, user is also warned,

Re: [Freeipa-devel] [PATCH] 0096 support Windows Server 2012

2012-12-07 Thread Simo Sorce
On Wed, 2012-12-05 at 23:01 +0200, Alexander Bokovoy wrote: New patch attached. It filters out statically compiled in list of well-known SID prefixes and SIDs belonging to our own domain. Tested and work as expected against Windows 2012 Trusted domain. ACK. I'll add fetching the white

Re: [Freeipa-devel] [PATCH 82] Compliant client side session cookie behavior

2012-12-07 Thread John Dennis
On 11/12/2012 12:39 PM, Petr Viktorin wrote: On 11/11/2012 11:18 PM, John Dennis wrote: In the future please do not quote the entire patch in the email. It makes it much too difficult to respond. It took me a long time to remove all the unnecessary text for this reply. New patch following

Re: [Freeipa-devel] [PATCH 82] Compliant client side session cookie behavior

2012-12-07 Thread John Dennis
On 11/13/2012 07:39 AM, Petr Viktorin wrote: Continuing from yesterday. I tried building the RPMs, installing a server, running the tests, and checking the Web UI. Each of these steps failed. On 11/11/2012 11:18 PM, John Dennis wrote: Note: This has been tested with both the command line api

Re: [Freeipa-devel] [PATCH] 335 Stop and disable conflicting timedate services

2012-12-07 Thread Rob Crittenden
Martin Kosek wrote: On 12/07/2012 02:51 PM, Simo Sorce wrote: On Fri, 2012-12-07 at 13:14 +0100, Martin Kosek wrote: On 11/15/2012 10:49 PM, Simo Sorce wrote: On Thu, 2012-11-15 at 17:33 +0100, Martin Kosek wrote: On 11/15/2012 03:22 PM, Simo Sorce wrote: On Thu, 2012-11-15 at 12:34 +0100,

Re: [Freeipa-devel] [PATCH] 0096 support Windows Server 2012

2012-12-07 Thread Rob Crittenden
Simo Sorce wrote: On Wed, 2012-12-05 at 23:01 +0200, Alexander Bokovoy wrote: New patch attached. It filters out statically compiled in list of well-known SID prefixes and SIDs belonging to our own domain. Tested and work as expected against Windows 2012 Trusted domain. ACK. I'll add

Re: [Freeipa-devel] [PATCH 82] Compliant client side session cookie behavior

2012-12-07 Thread Rob Crittenden
John Dennis wrote: Revised patch attached. Why catch exceptions from client_session_keyring_keyname() when it doesn't raise any? In store_session_cookie() shouldn't we log an error if a cookie can't be parsed, not a debug? In apply_session_cookie() I think we should log

Re: [Freeipa-devel] [PATCH 82] Compliant client side session cookie behavior

2012-12-07 Thread John Dennis
On 12/07/2012 03:44 PM, Rob Crittenden wrote: John Dennis wrote: Revised patch attached. Why catch exceptions from client_session_keyring_keyname() when it doesn't raise any? It may not explicitly raise an exception but one can still be raised if either KEYRING_COOKIE_NAME or principal is

Re: [Freeipa-devel] [PATCH 82] Compliant client side session cookie behavior

2012-12-07 Thread Simo Sorce
On Fri, 2012-12-07 at 16:21 -0500, John Dennis wrote: On 12/07/2012 03:44 PM, Rob Crittenden wrote: John Dennis wrote: Revised patch attached. Why catch exceptions from client_session_keyring_keyname() when it doesn't raise any? It may not explicitly raise an exception but one can