Re: [Freeipa-devel] [PATCHES] 165-166 Clean up ipa-server-certinstall CLI options

2013-08-28 Thread Petr Viktorin
On 08/27/2013 06:28 PM, Jan Cholasta wrote: Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/3869. Note that I made a slight change to the design page to reflect what ipa-server-certinstall actually does: The -d and -w options are allowed to be used simultaneously to

[Freeipa-devel] [PATCH] 119 CLDAP: make sure an empty reply is returned on any error

2013-08-28 Thread Sumit Bose
Hi, this patch fixes an issue in the CLDAP plugin found by Coverity. bye, Sumit From c993567c2c23857df361c527a4abd185b1f01a1e Mon Sep 17 00:00:00 2001 From: Sumit Bose sb...@redhat.com Date: Wed, 28 Aug 2013 10:10:52 +0200 Subject: [PATCH] CLDAP: make sure an empty reply is returned on any error

Re: [Freeipa-devel] [PATCHES] Fixes for some coverity errors

2013-08-28 Thread Sumit Bose
On Tue, Aug 27, 2013 at 02:27:08PM -0400, Simo Sorce wrote: Tickets 3882, 3883, 3884 Minor coverity issues, but should all be pushed to master and current release tree where appropriate. The memory leak is particularly important to fix for the OTP case. ACK to all three. bye, Sumit

Re: [Freeipa-devel] FreeIPA server package group

2013-08-28 Thread Tomas Babej
On 08/26/2013 10:14 AM, Tomas Babej wrote: On Mon 26 Aug 2013 10:12:09 AM CEST, Petr Vobornik wrote: On 08/26/2013 09:54 AM, Tomas Babej wrote: Hi, I cooked up a patch for comps that adds a FreeIPA package group. Please chime in if you're OK with package selection / description. For

Re: [Freeipa-devel] FreeIPA server package group

2013-08-28 Thread Petr Viktorin
On 08/28/2013 11:46 AM, Tomas Babej wrote: On 08/26/2013 10:14 AM, Tomas Babej wrote: On Mon 26 Aug 2013 10:12:09 AM CEST, Petr Vobornik wrote: On 08/26/2013 09:54 AM, Tomas Babej wrote: Hi, I cooked up a patch for comps that adds a FreeIPA package group. Please chime in if you're OK with

Re: [Freeipa-devel] FreeIPA server package group

2013-08-28 Thread Tomas Babej
On 08/28/2013 12:03 PM, Petr Viktorin wrote: On 08/28/2013 11:46 AM, Tomas Babej wrote: On 08/26/2013 10:14 AM, Tomas Babej wrote: On Mon 26 Aug 2013 10:12:09 AM CEST, Petr Vobornik wrote: On 08/26/2013 09:54 AM, Tomas Babej wrote: Hi, I cooked up a patch for comps that adds a FreeIPA

Re: [Freeipa-devel] [PATCH] 0269 Add man pages for testing tools

2013-08-28 Thread Petr Viktorin
On 08/28/2013 12:02 AM, Rob Crittenden wrote: Petr Viktorin wrote: Hello, This patch adds man pages for testing tools. As far as I can see, we use autotools for installing man pages. I added the autotools machinery to ipatests/man only. I'd appreciate if an autotools expert could check if this

Re: [Freeipa-devel] [PATCHES] Fixes for some coverity errors

2013-08-28 Thread Petr Viktorin
On 08/28/2013 10:57 AM, Sumit Bose wrote: On Tue, Aug 27, 2013 at 02:27:08PM -0400, Simo Sorce wrote: Tickets 3882, 3883, 3884 Minor coverity issues, but should all be pushed to master and current release tree where appropriate. The memory leak is particularly important to fix for the OTP

Re: [Freeipa-devel] [PATCH 0087] Log proper error message when defaultNamingContext not found

2013-08-28 Thread Rob Crittenden
Tomas Babej wrote: Hi, When adding a trust using trust-add with misconfigured DNS, an improper LDAP entry might be returned. Log a proper error message. https://fedorahosted.org/freeipa/ticket/3690 I think this should this include which KeyError was raised to help diagnose the problem.

Re: [Freeipa-devel] [PATCH] 446 Update idrange search facet after trust creation

2013-08-28 Thread Ana Krivokapic
On 08/22/2013 04:11 PM, Petr Vobornik wrote: Adding a trust creates a range - range search facet should be marked as expired. https://fedorahosted.org/freeipa/ticket/3874 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH 0087] Log proper error message when defaultNamingContext not found

2013-08-28 Thread Tomas Babej
On 08/28/2013 01:22 PM, Rob Crittenden wrote: Tomas Babej wrote: Hi, When adding a trust using trust-add with misconfigured DNS, an improper LDAP entry might be returned. Log a proper error message. https://fedorahosted.org/freeipa/ticket/3690 I think this should this include which KeyError

Re: [Freeipa-devel] [PATCH] 446 Update idrange search facet after trust creation

2013-08-28 Thread Petr Viktorin
On 08/28/2013 02:07 PM, Ana Krivokapic wrote: On 08/22/2013 04:11 PM, Petr Vobornik wrote: Adding a trust creates a range - range search facet should be marked as expired. https://fedorahosted.org/freeipa/ticket/3874 ___ Freeipa-devel mailing list

[Freeipa-devel] [PATCH] 0272 Add missing license header to ipa-test-config

2013-08-28 Thread Petr Viktorin
I'm sorry for the omission. -- PetrĀ³ From 9d1b244987666b1d66fecd782448798aac34ffe9 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Wed, 28 Aug 2013 14:31:46 +0200 Subject: [PATCH] Add missing license header to ipa-test-config --- ipatests/ipa-test-config | 19

Re: [Freeipa-devel] [PATCH] 0272 Add missing license header to ipa-test-config

2013-08-28 Thread Rob Crittenden
Petr Viktorin wrote: I'm sorry for the omission. ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0272 Add missing license header to ipa-test-config

2013-08-28 Thread Petr Viktorin
On 08/28/2013 02:38 PM, Rob Crittenden wrote: Petr Viktorin wrote: I'm sorry for the omission. ACK Pushed to master: fed7e7b23182ef0355cdaf6a712d8cce84382872 ipa-3-3: 023385510a1b9ce6b40e40b788044ba853463696 -- PetrĀ³ ___ Freeipa-devel mailing

Re: [Freeipa-devel] [PATCH] 0055 Fix tests which fail after ipa-adtrust-install

2013-08-28 Thread Tomas Babej
On 08/26/2013 09:38 AM, Ana Krivokapic wrote: On 08/22/2013 06:13 PM, Tomas Babej wrote: On 08/20/2013 04:14 PM, Ana Krivokapic wrote: On 08/09/2013 05:35 PM, Tomas Babej wrote: On 08/09/2013 04:03 PM, Ana Krivokapic wrote: On 08/09/2013 09:39 AM, Tomas Babej wrote: On 08/08/2013 04:09 PM,

[Freeipa-devel] [PATCH] 0058 Add integration tests for forced client re-enrollment

2013-08-28 Thread Ana Krivokapic
Hello, This patch adds integration tests for the forced client re-enrollment feature, according to the test plan at: http://www.freeipa.org/page/V3/Forced_client_re-enrollment#Test_Plan https://fedorahosted.org/freeipa/ticket/3832 -- Regards, Ana Krivokapic Associate Software Engineer

Re: [Freeipa-devel] [PATCH] 0257 Add initial CA-less installation tests

2013-08-28 Thread Jan Cholasta
On 27.8.2013 10:16, Petr Viktorin wrote: On 08/26/2013 09:23 AM, Jan Cholasta wrote: On 22.8.2013 09:46, Petr Viktorin wrote: On 08/16/2013 07:13 PM, Petr Viktorin wrote: On 07/30/2013 05:47 PM, Petr Viktorin wrote: Hello, This patch implements the first batch of integration tests for

[Freeipa-devel] [PATCH] 1104 move NULL check

2013-08-28 Thread Rob Crittenden
Move a NULL check in the lockout plugin to address something Coverity found. There is no risk of a crash here but it there is also no point calling something if we know the values are NULL. rob From 6d490529b6d96838e0eaa3b29ac5c5f651b59875 Mon Sep 17 00:00:00 2001 From: Rob Crittenden

Re: [Freeipa-devel] [PATCH] 0055 Fix tests which fail after ipa-adtrust-install

2013-08-28 Thread Petr Viktorin
On 08/28/2013 03:03 PM, Tomas Babej wrote: On 08/26/2013 09:38 AM, Ana Krivokapic wrote: On 08/22/2013 06:13 PM, Tomas Babej wrote: On 08/20/2013 04:14 PM, Ana Krivokapic wrote: On 08/09/2013 05:35 PM, Tomas Babej wrote: On 08/09/2013 04:03 PM, Ana Krivokapic wrote: On 08/09/2013 09:39 AM,

Re: [Freeipa-devel] [PATCH] 0257 Add initial CA-less installation tests

2013-08-28 Thread Jan Cholasta
On 28.8.2013 17:15, Petr Viktorin wrote: On 08/28/2013 03:23 PM, Jan Cholasta wrote: Thanks. The service-disable and host-disable tests fail with AlreadyInactive, because the certificate is removed with service-mod and host-mod in earlier tests. I think the service and host command tests

Re: [Freeipa-devel] [PATCH] 0257 Add initial CA-less installation tests

2013-08-28 Thread Jan Cholasta
On 28.8.2013 19:39, Petr Viktorin wrote: On 08/28/2013 06:24 PM, Jan Cholasta wrote: On 28.8.2013 17:15, Petr Viktorin wrote: On 08/28/2013 03:23 PM, Jan Cholasta wrote: Thanks. The service-disable and host-disable tests fail with AlreadyInactive, because the certificate is removed with

Re: [Freeipa-devel] [PATCH] 0257 Add initial CA-less installation tests

2013-08-28 Thread Petr Viktorin
On 08/28/2013 08:10 PM, Jan Cholasta wrote: On 28.8.2013 19:39, Petr Viktorin wrote: On 08/28/2013 06:24 PM, Jan Cholasta wrote: On 28.8.2013 17:15, Petr Viktorin wrote: On 08/28/2013 03:23 PM, Jan Cholasta wrote: Thanks. The service-disable and host-disable tests fail with AlreadyInactive,