On 08/28/2013 12:03 PM, Petr Viktorin wrote:
On 08/28/2013 11:46 AM, Tomas Babej wrote:
On 08/26/2013 10:14 AM, Tomas Babej wrote:
On Mon 26 Aug 2013 10:12:09 AM CEST, Petr Vobornik wrote:
On 08/26/2013 09:54 AM, Tomas Babej wrote:
Hi,

I cooked up a patch for comps that adds a FreeIPA package group.

Please chime in if you're OK with package selection / description.

For illustration, see the attached image. FreeIPA will be added as an
add-on in an installer under the Infrastructure server environment,
that means, in the included images it will be at the same level
as DNS or FTP server.

It will also appear in the Software Selection tool (PackageKit).

It should also be available under as yum groupinstall "FreeIPA server",
and in PackageKit, as I understand comps is also source for that too.

https://fedoraproject.org/wiki/How_to_use_and_edit_comps.xml_for_package_groups




https://fedorahosted.org/freeipa/ticket/3630



IMO the Audit part in the description is false advertisement. Same
issue is in package descriptions.

I know, it's taken directly from there.

I'd rather have it consistent, if we're going to change it here, we
should do
there too, so that we do not end up with multiple (seemingly incomplete)
descriptions at various places.

Anybody else does have any other concerns? We need to move with this
effort since string freeze for F20 is coming.

I'm particulary dubious about including the freeipa-tests package.

I don't think that should be included, developer tests are unnecessary for a server.

It was marked as optional in the initial proposal, but I agree it's unnecessary for
it to be there at all.
We discussed the A (as Audit) part in the description with Rob. The fact is that this is taken from the freeipa-server package description and nobody
complained in 7 years.


Updated tests attached.

--
Tomas Babej
Associate Software Engeneer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org

From 6a6e84935213c38ce28b8767417c5037d25d0e95 Mon Sep 17 00:00:00 2001
From: Tomas Babej <tba...@redhat.com>
Date: Mon, 26 Aug 2013 09:26:23 +0200
Subject: [PATCH] Add FreeIPA server package group

---
 comps-f20.xml.in | 15 +++++++++++++++
 comps-f21.xml.in | 15 +++++++++++++++
 2 files changed, 30 insertions(+)

diff --git a/comps-f20.xml.in b/comps-f20.xml.in
index b0820461c95ff5f20827adb432c04faefffad738..a84300d4f297ee67b19efa12956652e417eacd1e 100644
--- a/comps-f20.xml.in
+++ b/comps-f20.xml.in
@@ -2358,6 +2358,19 @@
     </packagelist>
   </group>
   <group>
+    <id>freeipa-server</id>
+    <_name>FreeIPA Server</_name>
+    <_description>Integrated solution to provide centrally managed Identity, Policy and Audit.</_description>
+    <default>false</default>
+    <uservisible>true</uservisible>
+    <packagelist>
+      <packagereq type="mandatory">freeipa-server</packagereq>
+      <packagereq type="default">freeipa-server-strict</packagereq>
+      <packagereq type="default">freeipa-server-trust-ad</packagereq>
+      <packagereq type="optional">freeipa-tests</packagereq>
+    </packagelist>
+  </group>
+  <group>
     <id>finnish-support</id>
     <_name>Finnish Support</_name>
     <_description/>
@@ -6374,6 +6387,7 @@
     <optionlist>
       <groupid>dogtag</groupid>
       <groupid>dns-server</groupid>
+      <groupid>freeipa-server</groupid>
       <groupid>ftp-server</groupid>
       <groupid>mail-server</groupid>
       <groupid>network-server</groupid>
@@ -6590,6 +6604,7 @@
       <groupid>directory-server</groupid>
       <groupid>dns-server</groupid>
       <groupid>dogtag</groupid>
+      <groupid>freeipa-server</groupid>
       <groupid>ftp-server</groupid>
       <groupid>ha</groupid>
       <groupid>haproxy</groupid>
diff --git a/comps-f21.xml.in b/comps-f21.xml.in
index bd990709a347ff37ee354743317d11b55a983f5c..30aabe18d8c9f0dff91028734628d32025c85cdd 100644
--- a/comps-f21.xml.in
+++ b/comps-f21.xml.in
@@ -2358,6 +2358,19 @@
     </packagelist>
   </group>
   <group>
+    <id>freeipa-server</id>
+    <_name>FreeIPA Server</_name>
+    <_description>Integrated solution to provide centrally managed Identity, Policy and Audit.</_description>
+    <default>false</default>
+    <uservisible>true</uservisible>
+    <packagelist>
+      <packagereq type="mandatory">freeipa-server</packagereq>
+      <packagereq type="default">freeipa-server-strict</packagereq>
+      <packagereq type="default">freeipa-server-trust-ad</packagereq>
+      <packagereq type="optional">freeipa-tests</packagereq>
+    </packagelist>
+  </group>
+  <group>
     <id>finnish-support</id>
     <_name>Finnish Support</_name>
     <_description/>
@@ -6387,6 +6400,7 @@
     <optionlist>
       <groupid>dogtag</groupid>
       <groupid>dns-server</groupid>
+      <groupid>freeipa-server</groupid>
       <groupid>ftp-server</groupid>
       <groupid>mail-server</groupid>
       <groupid>network-server</groupid>
@@ -6603,6 +6617,7 @@
       <groupid>directory-server</groupid>
       <groupid>dns-server</groupid>
       <groupid>dogtag</groupid>
+      <groupid>freeipa-server</groupid>
       <groupid>ftp-server</groupid>
       <groupid>ha</groupid>
       <groupid>haproxy</groupid>
-- 
1.8.3.1

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to