Re: [Freeipa-devel] [PATCH] 441 Consolidate .gitignore entries

2013-12-10 Thread Petr Viktorin
On 12/09/2013 05:43 PM, Martin Kosek wrote: Clean up the .gitignore file: - Remove no longer used .gitignore entries, like .bzr files - Do not repeat autotools generated files over and over again - Whitelist existent Makefiles in the repository - Better separate the .gitignore entries

Re: [Freeipa-devel] [PATCH] 211 Fix internal error in the user-status command

2013-12-10 Thread Petr Viktorin
On 12/05/2013 02:45 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4066. Honza Patch looks good, ACK. I've added a small regression test for this, does it look OK? -- Petr³ From bb333401aa551f84a16192d2d42de20bd5633f84 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] 0333 test_webui: Allow False values in configuration for no_ca, no_dns, has_trusts

2013-12-10 Thread Petr Vobornik
On 6.12.2013 16:52, Petr Viktorin wrote: Hello, As I'm consolidating test job configuration, I learned that the line no_dns: False in WebUI test config has the same effect as `no_dns: True`. This is confusing, and it complicates generating the config. Patch is untested because I don't have

[Freeipa-devel] [PATCHES] 213-224 Use old entry state in LDAP mods

2013-12-10 Thread Jan Cholasta
Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/3488. Honza -- Jan Cholasta From 7fa3ca5c581b54bfb3d8b6c904d33bde0c3845da Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Tue, 10 Dec 2013 11:09:56 +0100 Subject: [PATCH 01/12] Rename LDAPEntry method

Re: [Freeipa-devel] [PATCH] 211 Fix internal error in the user-status command

2013-12-10 Thread Jan Cholasta
On 10.12.2013 12:18, Petr Viktorin wrote: On 12/05/2013 02:45 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4066. Honza Patch looks good, ACK. I've added a small regression test for this, does it look OK? Thanks, it looks OK except I don't

[Freeipa-devel] [PATCH] 0335 ipa-replica-install: Move check for existing host before DNS resolution check

2013-12-10 Thread Petr Viktorin
See commit message ticket for details. https://fedorahosted.org/freeipa/ticket/3889 -- Petr³ From 0c159673b1df2b31ce693398536ff31ebf4bb53a Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Tue, 10 Dec 2013 13:00:16 +0100 Subject: [PATCH] ipa-replica-install: Move check for

Re: [Freeipa-devel] [PATCH] 211 Fix internal error in the user-status command

2013-12-10 Thread Petr Viktorin
On 12/10/2013 02:15 PM, Jan Cholasta wrote: On 10.12.2013 12:18, Petr Viktorin wrote: On 12/05/2013 02:45 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4066. Honza Patch looks good, ACK. I've added a small regression test for this, does it

Re: [Freeipa-devel] [PATCH] 211 Fix internal error in the user-status command

2013-12-10 Thread Jan Cholasta
On 10.12.2013 15:18, Petr Viktorin wrote: On 12/10/2013 02:15 PM, Jan Cholasta wrote: On 10.12.2013 12:18, Petr Viktorin wrote: On 12/05/2013 02:45 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4066. Honza Patch looks good, ACK. I've added a

Re: [Freeipa-devel] [PATCH] 211 Fix internal error in the user-status command

2013-12-10 Thread Petr Viktorin
On 12/10/2013 03:23 PM, Jan Cholasta wrote: On 10.12.2013 15:18, Petr Viktorin wrote: On 12/10/2013 02:15 PM, Jan Cholasta wrote: On 10.12.2013 12:18, Petr Viktorin wrote: On 12/05/2013 02:45 PM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4066.

Re: [Freeipa-devel] [PATCH] 0333 test_webui: Allow False values in configuration for no_ca, no_dns, has_trusts

2013-12-10 Thread Petr Viktorin
On 12/10/2013 02:00 PM, Petr Vobornik wrote: On 6.12.2013 16:52, Petr Viktorin wrote: Hello, As I'm consolidating test job configuration, I learned that the line no_dns: False in WebUI test config has the same effect as `no_dns: True`. This is confusing, and it complicates generating the

[Freeipa-devel] [PATCH] 0336 rpcserver: Consolidate __call__ in xmlclient and jsonclient_kerb

2013-12-10 Thread Petr Viktorin
See commit message ticket. https://fedorahosted.org/freeipa/ticket/4069 -- Petr³ From f2eaff6f9965331d83a2213161100ae21cd9a26a Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Tue, 10 Dec 2013 17:36:32 +0100 Subject: [PATCH] rpcserver: Consolidate __call__ in xmlclient