Re: [Freeipa-devel] [PATCH] 0023 Fix typo causing certmonger is provided with wrong path to, ipa-submit.

2014-10-16 Thread Martin Kosek
On 10/15/2014 04:29 PM, Jan Cholasta wrote: Hi, Dne 15.10.2014 v 12:55 David Kupka napsal(a): I forget to attach patch for ipa-4-0 branch. Attaching both now. On 10/15/2014 11:08 AM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4624 The code could be more robust, but given

Re: [Freeipa-devel] [PATCH] 761 keytab manipulation permission management

2014-10-16 Thread Jan Cholasta
Dne 13.10.2014 v 12:42 Petr Vobornik napsal(a): On 8.10.2014 18:51, Petr Vobornik wrote: On 1.10.2014 18:15, Petr Vobornik wrote: Hello list, Patch for: https://fedorahosted.org/freeipa/ticket/4419 New revisions of 761 and 763 with updated API and ACIs: ipa host-allow-operation HOSTNAME

Re: [Freeipa-devel] [PATCH] 353 Allow specifying signing algorithm of the IPA CA cert in ipa-ca-install

2014-10-16 Thread Jan Cholasta
Dne 15.10.2014 v 16:42 Petr Vobornik napsal(a): On 8.10.2014 13:35, Jan Cholasta wrote: Hi, the attached patch provides an additional fix for https://fedorahosted.org/freeipa/ticket/4447. Honza Requires rebase because of `ca_type=options.external_ca_type)`. Works fine with older version.

[Freeipa-devel] FreeIPA 4.0.4

2014-10-16 Thread Martin Kosek
Hello all! I think we have all the bits and pieces ready to release next stabilization release of FreeIPA 4.0 - FreeIPA 4.0.4! There were a lot of bug fixes or minor enhancements, let us offer it for others to use. I created the first version of release notes on the wiki, updates welcome:

Re: [Freeipa-devel] [PATCH] 761 keytab manipulation permission management

2014-10-16 Thread Petr Vobornik
On 16.10.2014 09:54, Jan Cholasta wrote: Dne 13.10.2014 v 12:42 Petr Vobornik napsal(a): On 8.10.2014 18:51, Petr Vobornik wrote: On 1.10.2014 18:15, Petr Vobornik wrote: Hello list, Patch for: https://fedorahosted.org/freeipa/ticket/4419 New revisions of 761 and 763 with updated API and

Re: [Freeipa-devel] [PATCH] 761 keytab manipulation permission management

2014-10-16 Thread Jan Cholasta
Dne 16.10.2014 v 11:24 Petr Vobornik napsal(a): On 16.10.2014 09:54, Jan Cholasta wrote: Dne 13.10.2014 v 12:42 Petr Vobornik napsal(a): On 8.10.2014 18:51, Petr Vobornik wrote: On 1.10.2014 18:15, Petr Vobornik wrote: Hello list, Patch for: https://fedorahosted.org/freeipa/ticket/4419

Re: [Freeipa-devel] [PATCH] 0004 permission-add gives confusing error when adding ACI to generated tree

2014-10-16 Thread thierry bordaz
On 10/15/2014 04:33 PM, Martin Kosek wrote: On 10/15/2014 01:57 PM, thierry bordaz wrote: On 10/15/2014 01:26 PM, Martin Kosek wrote: On 10/15/2014 01:08 PM, thierry bordaz wrote: https://fedorahosted.org/freeipa/ticket/4523 I see 2 issues with the patch: 1) Patch description should not

Re: [Freeipa-devel] [PATCH] 761 keytab manipulation permission management

2014-10-16 Thread Petr Vobornik
On 16.10.2014 11:53, Jan Cholasta wrote: Dne 16.10.2014 v 11:24 Petr Vobornik napsal(a): On 16.10.2014 09:54, Jan Cholasta wrote: Dne 13.10.2014 v 12:42 Petr Vobornik napsal(a): On 8.10.2014 18:51, Petr Vobornik wrote: On 1.10.2014 18:15, Petr Vobornik wrote: Hello list, Patch for:

Re: [Freeipa-devel] [PATCH] 0004 permission-add gives confusing error when adding ACI to generated tree

2014-10-16 Thread Martin Kosek
On 10/16/2014 12:08 PM, thierry bordaz wrote: On 10/15/2014 04:33 PM, Martin Kosek wrote: On 10/15/2014 01:57 PM, thierry bordaz wrote: On 10/15/2014 01:26 PM, Martin Kosek wrote: On 10/15/2014 01:08 PM, thierry bordaz wrote: https://fedorahosted.org/freeipa/ticket/4523 I see 2 issues with

Re: [Freeipa-devel] [PATCH] 353 Allow specifying signing algorithm of the IPA CA cert in ipa-ca-install

2014-10-16 Thread Petr Vobornik
On 16.10.2014 10:00, Jan Cholasta wrote: Dne 15.10.2014 v 16:42 Petr Vobornik napsal(a): On 8.10.2014 13:35, Jan Cholasta wrote: Hi, the attached patch provides an additional fix for https://fedorahosted.org/freeipa/ticket/4447. Honza Requires rebase because of

[Freeipa-devel] isolated pkcs11 module

2014-10-16 Thread Nikos Mavrogiannopoulos
Hi, Concerning: https://bugs.freedesktop.org/show_bug.cgi?id=51949#c3 What are your requirements? We currently have working code (but not yet merged) for an isolated security module via p11-kit. Our requirements are to protect private keys by keeping them outside a process' boundary. The main

Re: [Freeipa-devel] [PATCH] 0004 permission-add gives confusing error when adding ACI to generated tree

2014-10-16 Thread thierry bordaz
On 10/16/2014 12:45 PM, Martin Kosek wrote: On 10/16/2014 12:08 PM, thierry bordaz wrote: On 10/15/2014 04:33 PM, Martin Kosek wrote: On 10/15/2014 01:57 PM, thierry bordaz wrote: On 10/15/2014 01:26 PM, Martin Kosek wrote: On 10/15/2014 01:08 PM, thierry bordaz wrote:

Re: [Freeipa-devel] [PATCH] 0004 permission-add gives confusing error when adding ACI to generated tree

2014-10-16 Thread Martin Kosek
On 10/16/2014 03:32 PM, thierry bordaz wrote: On 10/16/2014 12:45 PM, Martin Kosek wrote: On 10/16/2014 12:08 PM, thierry bordaz wrote: On 10/15/2014 04:33 PM, Martin Kosek wrote: On 10/15/2014 01:57 PM, thierry bordaz wrote: On 10/15/2014 01:26 PM, Martin Kosek wrote: On 10/15/2014 01:08

Re: [Freeipa-devel] [PATCHES] 349-350 Add ipa-client-install switch --request-cert to request cert for the host

2014-10-16 Thread Petr Vobornik
On 8.10.2014 10:38, Jan Cholasta wrote: Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/4550. Honza Works fine. Just minor ones: 1. The new option deserves a 'help' text. basic_group.add_option(--request-cert, dest=request_cert,

Re: [Freeipa-devel] [PATCHES] 349-350 Add ipa-client-install switch --request-cert to request cert for the host

2014-10-16 Thread Jan Cholasta
Dne 16.10.2014 v 16:28 Petr Vobornik napsal(a): On 8.10.2014 10:38, Jan Cholasta wrote: Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/4550. Honza Works fine. Just minor ones: 1. The new option deserves a 'help' text. basic_group.add_option(--request-cert,

Re: [Freeipa-devel] [PATCH 0071] Display token type when viewing token

2014-10-16 Thread Martin Kosek
On 10/15/2014 06:32 PM, Nathaniel McCallum wrote: When viewing a token from the CLI or UI, the type of the token should be displayed. https://fedorahosted.org/freeipa/ticket/4563 Adding objectclass to default_attributes is unprecedented and something we should not do before release. It would

Re: [Freeipa-devel] [PATCH] 347 Fix CA cert validity check for CA-less and external CA installer options

2014-10-16 Thread Jan Cholasta
Dne 7.10.2014 v 18:22 Jan Cholasta napsal(a): Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4612. Honza Attached a patch with a proper fix. -- Jan Cholasta From 97ce0324d02bb07fc1e012d9b0441bbef399449a Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com

Re: [Freeipa-devel] [PATCHES] 349-350 Add ipa-client-install switch --request-cert to request cert for the host

2014-10-16 Thread Jan Cholasta
Dne 16.10.2014 v 17:29 Jan Cholasta napsal(a): Dne 16.10.2014 v 16:28 Petr Vobornik napsal(a): On 8.10.2014 10:38, Jan Cholasta wrote: Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/4550. Honza Works fine. Just minor ones: 1. The new option deserves a 'help' text.

Re: [Freeipa-devel] [PATCH 0070] Remove token ID from self-service UI

2014-10-16 Thread Petr Vobornik
On 15.10.2014 16:59, Nathaniel McCallum wrote: Also, fix labels to properly use i18n strings for token types. ACK Pushed to: master: c5f7ca58a1b74344c3d39493a9b0645a8f4b64a7 ipa-4-1: 0f69e753bda8ee44d5580967f1c877d2db5d22a5 -- Petr Vobornik ___

Re: [Freeipa-devel] [PATCH 0072] Remove token vendor, model and serial defaults

2014-10-16 Thread Petr Vobornik
On 15.10.2014 18:33, Nathaniel McCallum wrote: These defaults are pretty useless and cause more confusion than they are worth. The serial default never worked anyway. And now that we are displaying the token type separately, there is no reason to doubly record these data points. ACK Pushed

Re: [Freeipa-devel] [PATCH] [WIP] DNSSEC support - preview

2014-10-16 Thread Martin Basti
On 10/10/14 09:17, Martin Kosek wrote: On 10/09/2014 03:57 PM, Petr Spacek wrote: Hello, it would be great if people could look at current state of DNSSEC patches for FreeIPA. It consist of several relatively independent parts: - python-pkcs#11 interface written by Martin Basti:

Re: [Freeipa-devel] [PATCH] 347 Fix CA cert validity check for CA-less and external CA installer options

2014-10-16 Thread Martin Kosek
On 10/16/2014 05:40 PM, Jan Cholasta wrote: Dne 7.10.2014 v 18:22 Jan Cholasta napsal(a): Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4612. Honza Attached a patch with a proper fix. This version works fine, ACK. Pushed to: master:

Re: [Freeipa-devel] [PATCH] 761 keytab manipulation permission management

2014-10-16 Thread Petr Vobornik
On 16.10.2014 11:53, Jan Cholasta wrote: Dne 16.10.2014 v 11:24 Petr Vobornik napsal(a): On 16.10.2014 09:54, Jan Cholasta wrote: Dne 13.10.2014 v 12:42 Petr Vobornik napsal(a): On 8.10.2014 18:51, Petr Vobornik wrote: On 1.10.2014 18:15, Petr Vobornik wrote: Hello list, Patch for:

Re: [Freeipa-devel] [PATCHES] 349-350 Add ipa-client-install switch --request-cert to request cert for the host

2014-10-16 Thread Petr Vobornik
On 16.10.2014 17:47, Jan Cholasta wrote: Dne 16.10.2014 v 17:29 Jan Cholasta napsal(a): Dne 16.10.2014 v 16:28 Petr Vobornik napsal(a): On 8.10.2014 10:38, Jan Cholasta wrote: Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/4550. Honza Updated rebased patches

Re: [Freeipa-devel] [PATCH] [WIP] DNSSEC support - preview

2014-10-16 Thread Jan Cholasta
Hi, Dne 16.10.2014 v 17:59 Martin Basti napsal(a): On 10/10/14 09:17, Martin Kosek wrote: On 10/09/2014 03:57 PM, Petr Spacek wrote: Hello, it would be great if people could look at current state of DNSSEC patches for FreeIPA. It consist of several relatively independent parts: -

Re: [Freeipa-devel] [PATCH] [WIP] DNSSEC support - preview

2014-10-16 Thread Petr Spacek
On 16.10.2014 19:43, Jan Cholasta wrote: Dne 16.10.2014 v 17:59 Martin Basti napsal(a): On 10/10/14 09:17, Martin Kosek wrote: On 10/09/2014 03:57 PM, Petr Spacek wrote: Hello, it would be great if people could look at current state of DNSSEC patches for FreeIPA. It consist of several

Re: [Freeipa-devel] [PATCH] 761 keytab manipulation permission management

2014-10-16 Thread Martin Kosek
On 10/16/2014 07:03 PM, Petr Vobornik wrote: On 16.10.2014 11:53, Jan Cholasta wrote: Dne 16.10.2014 v 11:24 Petr Vobornik napsal(a): On 16.10.2014 09:54, Jan Cholasta wrote: Dne 13.10.2014 v 12:42 Petr Vobornik napsal(a): On 8.10.2014 18:51, Petr Vobornik wrote: On 1.10.2014 18:15, Petr

Re: [Freeipa-devel] [PATCH] [WIP] DNSSEC support - preview

2014-10-16 Thread Martin Kosek
On 10/16/2014 08:01 PM, Petr Spacek wrote: 1) I'm not sure if failing on DNSSEC-disabled forwarders by default is a good idea. Perhaps there could be some auto-detection code? Something along the lines of: if forwarders_support_dnssec: if not options.no_dnssec_validation:

Re: [Freeipa-devel] [PATCH] [WIP] DNSSEC support - preview

2014-10-16 Thread Simo Sorce
On Thu, 16 Oct 2014 20:39:05 +0200 Martin Kosek mko...@redhat.com wrote: On 10/16/2014 08:01 PM, Petr Spacek wrote: 1) I'm not sure if failing on DNSSEC-disabled forwarders by default is a good idea. Perhaps there could be some auto-detection code? Something along the lines of:

Re: [Freeipa-devel] [PATCH] [WIP] DNSSEC support - preview

2014-10-16 Thread Petr Spacek
On 16.10.2014 21:32, Simo Sorce wrote: On Thu, 16 Oct 2014 20:39:05 +0200 Martin Kosek mko...@redhat.com wrote: On 10/16/2014 08:01 PM, Petr Spacek wrote: 1) I'm not sure if failing on DNSSEC-disabled forwarders by default is a good idea. Perhaps there could be some auto-detection code?

Re: [Freeipa-devel] [PATCH] 353 Added initial vault implementation.

2014-10-16 Thread Endi Sukma Dewata
On 10/15/2014 10:59 PM, Endi Sukma Dewata wrote: The NSSConnection class has to be modified not to shutdown existing database because some of the vault clients (e.g. vault-archive and vault-retrieve) also use a database to encrypt/decrypt the secret. The problem is described in more detail in

Re: [Freeipa-devel] [PATCH 0071] Display token type when viewing token

2014-10-16 Thread Nathaniel McCallum
On Thu, 2014-10-16 at 17:35 +0200, Martin Kosek wrote: On 10/15/2014 06:32 PM, Nathaniel McCallum wrote: When viewing a token from the CLI or UI, the type of the token should be displayed. https://fedorahosted.org/freeipa/ticket/4563 Adding objectclass to default_attributes is

Re: [Freeipa-devel] [PATCH 0064] Create ipa-otp-decrement 389DS plugin

2014-10-16 Thread Nathaniel McCallum
On Thu, 2014-10-16 at 21:02 +0200, Martin Kosek wrote: On 10/15/2014 09:22 AM, Martin Kosek wrote: On 10/14/2014 09:01 PM, Nathaniel McCallum wrote: On Thu, 2014-10-09 at 18:48 +0200, thierry bordaz wrote: On 10/09/2014 05:51 PM, Nathaniel McCallum wrote: On Thu, 2014-10-09 at 11:44