Re: [Freeipa-devel] [PATCH] 0003-3 User life cycle: new stageuser plugin with add verb

2015-03-18 Thread Jan Cholasta
Dne 18.3.2015 v 19:39 thierry bordaz napsal(a): On 03/17/2015 08:01 AM, Jan Cholasta wrote: Dne 16.3.2015 v 12:06 David Kupka napsal(a): On 03/06/2015 07:30 PM, thierry bordaz wrote: On 02/19/2015 04:19 PM, Martin Basti wrote: On 19/02/15 13:01, thierry bordaz wrote: On 02/04/2015 05:14 PM,

[Freeipa-devel] [PROPOSAL] FreeIPA Test Plan Workflow

2015-03-18 Thread Martin Koci
Hi, working with Test Plans for 4.2 features I'd like to outline workflow for test plans. The main aim is to have something documented and more clear. So I'd like to start with track ticket options. For better tracking and managing tickets we could consider 3 new fields in the track ticket. - Fi

Re: [Freeipa-devel] [PATCH] 0003-3 User life cycle: new stageuser plugin with add verb

2015-03-18 Thread thierry bordaz
On 03/17/2015 08:01 AM, Jan Cholasta wrote: Dne 16.3.2015 v 12:06 David Kupka napsal(a): On 03/06/2015 07:30 PM, thierry bordaz wrote: On 02/19/2015 04:19 PM, Martin Basti wrote: On 19/02/15 13:01, thierry bordaz wrote: On 02/04/2015 05:14 PM, Jan Cholasta wrote: Hi, Dne 4.2.2015 v 15:25 Da

Re: [Freeipa-devel] [PATCH 142] extdom: fix memory leak

2015-03-18 Thread Jan Cholasta
Dne 10.3.2015 v 12:14 Tomas Babej napsal(a): On 03/10/2015 12:10 PM, Sumit Bose wrote: On Tue, Mar 10, 2015 at 11:59:45AM +0100, Tomas Babej wrote: On 03/05/2015 08:00 AM, Alexander Bokovoy wrote: On Wed, 04 Mar 2015, Nathan Kinder wrote: On 03/04/2015 10:34 PM, Alexander Bokovoy wrote: On

Re: [Freeipa-devel] [PATCH] extdom: return LDAP_NO_SUCH_OBJECT to the client

2015-03-18 Thread Jan Cholasta
Dne 10.3.2015 v 11:57 Tomas Babej napsal(a): On 03/05/2015 07:28 AM, Alexander Bokovoy wrote: On Wed, 04 Mar 2015, Sumit Bose wrote: Hi, with this patch the extdom plugin will properly indicate to a client if the search object does not exist instead of returning a generic error. This is impor

Re: [Freeipa-devel] topology plugin - again need for input

2015-03-18 Thread Ludwig Krispenz
On 03/18/2015 02:28 PM, Simo Sorce wrote: On Wed, 2015-03-18 at 12:18 +0100, Ludwig Krispenz wrote: Hi, I need your feedback on a problem with implementing the topology plugin: marking an replication agreement, this seems to be a never ending story We want o mark an agreement when it is creqa

Re: [Freeipa-devel] topology plugin - again need for input

2015-03-18 Thread Simo Sorce
On Wed, 2015-03-18 at 12:18 +0100, Ludwig Krispenz wrote: > Hi, > > I need your feedback on a problem with implementing the topology plugin: > marking an replication agreement, this seems to be a never ending story > > We want o mark an agreement when it is creqated by the plugin or put > under

Re: [Freeipa-devel] [PATCH 140] extdom: migrate check-based test to cmocka

2015-03-18 Thread Sumit Bose
On Wed, Mar 18, 2015 at 01:36:44PM +0100, Martin Kosek wrote: > On 03/18/2015 01:32 PM, Sumit Bose wrote: > > On Wed, Mar 18, 2015 at 12:53:04PM +0100, Martin Kosek wrote: > >> On 03/18/2015 11:22 AM, Jakub Hrozek wrote: > >>> On Wed, Mar 18, 2015 at 11:01:35AM +0100, Sumit Bose wrote: > On Fr

Re: [Freeipa-devel] [PATCH 0203] Remove unused PRE_SCHEMA upgrade

2015-03-18 Thread Martin Kosek
On 03/18/2015 01:11 PM, Martin Basti wrote: > On 12/03/15 17:30, Martin Basti wrote: >> On 12/03/15 17:08, Rob Crittenden wrote: >>> Martin Basti wrote: On 12/03/15 16:22, Rob Crittenden wrote: > David Kupka wrote: >> On 03/06/2015 04:52 PM, Martin Basti wrote: >>> This upgrade ste

Re: [Freeipa-devel] [PATCH 140] extdom: migrate check-based test to cmocka

2015-03-18 Thread Martin Kosek
On 03/18/2015 01:32 PM, Sumit Bose wrote: > On Wed, Mar 18, 2015 at 12:53:04PM +0100, Martin Kosek wrote: >> On 03/18/2015 11:22 AM, Jakub Hrozek wrote: >>> On Wed, Mar 18, 2015 at 11:01:35AM +0100, Sumit Bose wrote: On Fri, Mar 13, 2015 at 03:14:55PM +0100, Jakub Hrozek wrote: > On Fri, M

Re: [Freeipa-devel] [PATCH 140] extdom: migrate check-based test to cmocka

2015-03-18 Thread Sumit Bose
On Wed, Mar 18, 2015 at 12:53:04PM +0100, Martin Kosek wrote: > On 03/18/2015 11:22 AM, Jakub Hrozek wrote: > > On Wed, Mar 18, 2015 at 11:01:35AM +0100, Sumit Bose wrote: > >> On Fri, Mar 13, 2015 at 03:14:55PM +0100, Jakub Hrozek wrote: > >>> On Fri, Mar 13, 2015 at 11:56:46AM +0100, Sumit Bose w

Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings

2015-03-18 Thread Tomas Babej
On 03/18/2015 01:10 PM, Alexander Bokovoy wrote: On Wed, 18 Mar 2015, Tomas Babej wrote: On 03/12/2015 01:58 PM, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Petr Vobornik wrote: On 03/06/2015 03:13 PM, Alexander Bokovoy wrote: On Fri, 06 Ma

Re: [Freeipa-devel] [PATCH 0203] Remove unused PRE_SCHEMA upgrade

2015-03-18 Thread Martin Basti
On 12/03/15 17:30, Martin Basti wrote: On 12/03/15 17:08, Rob Crittenden wrote: Martin Basti wrote: On 12/03/15 16:22, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 04:52 PM, Martin Basti wrote: This upgrade step is not used anymore. Required by: https://fedorahosted.org/freeipa/ti

Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings

2015-03-18 Thread Alexander Bokovoy
On Wed, 18 Mar 2015, Tomas Babej wrote: On 03/12/2015 01:58 PM, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Petr Vobornik wrote: On 03/06/2015 03:13 PM, Alexander Bokovoy wrote: On Fri, 06 Mar 2015, Lukas Slebodnik wrote: On (05/03/15 16:20),

Re: [Freeipa-devel] [PATCHES 137-139] extdom: add err_msg member to request context

2015-03-18 Thread Tomas Babej
On 03/18/2015 11:23 AM, Jakub Hrozek wrote: On Wed, Mar 18, 2015 at 10:58:51AM +0100, Sumit Bose wrote: Please find attached a new version where the typo is fixed. bye, Sumit ACK I think the IPA gatekeepers shoudl feel free to just fix these trivial errors before pushing in the future. Pu

Re: [Freeipa-devel] [PATCH 140] extdom: migrate check-based test to cmocka

2015-03-18 Thread Martin Kosek
On 03/18/2015 11:22 AM, Jakub Hrozek wrote: > On Wed, Mar 18, 2015 at 11:01:35AM +0100, Sumit Bose wrote: >> On Fri, Mar 13, 2015 at 03:14:55PM +0100, Jakub Hrozek wrote: >>> On Fri, Mar 13, 2015 at 11:56:46AM +0100, Sumit Bose wrote: On Wed, Mar 04, 2015 at 06:42:05PM +0100, Sumit Bose wrote:

Re: [Freeipa-devel] [PATCHES] SPEC: Require python2 version of sssd bindings

2015-03-18 Thread Tomas Babej
On 03/12/2015 01:58 PM, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Alexander Bokovoy wrote: On Thu, 12 Mar 2015, Petr Vobornik wrote: On 03/06/2015 03:13 PM, Alexander Bokovoy wrote: On Fri, 06 Mar 2015, Lukas Slebodnik wrote: On (05/03/15 16:20), Petr Vobornik wrote: On 03/05/2015 11:2

Re: [Freeipa-devel] [PATCHES 134-136] extdom: handle ERANGE return code for getXXYYY_r()

2015-03-18 Thread Martin Kosek
On 03/09/2015 02:49 PM, Tomas Babej wrote: > > On 03/06/2015 01:08 PM, Alexander Bokovoy wrote: >> On Thu, 05 Mar 2015, Sumit Bose wrote: >>> On Thu, Mar 05, 2015 at 09:16:36AM +0100, Sumit Bose wrote: On Wed, Mar 04, 2015 at 06:14:53PM +0100, Sumit Bose wrote: > On Wed, Mar 04, 2015 at

Re: [Freeipa-devel] [PATCH] 0041 Always reload StateFile before getting or modifying the, stored values.

2015-03-18 Thread Tomas Babej
On 03/17/2015 10:29 AM, Martin Basti wrote: On 16/03/15 13:54, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4901 ACK, it works as expected Pushed to master: 082c55fb9cf87263f1f585a1adeda464a9d7328a -- Manage your subscription for the Freeipa-devel mailing list: https://www.re

Re: [Freeipa-devel] [PATCHES 0018-0020] ipa-dns-install: Use LDAPI for all DS connections

2015-03-18 Thread Tomas Babej
On 03/16/2015 05:01 PM, Martin Basti wrote: On 16/03/15 14:26, Martin Babinsky wrote: On 03/16/2015 01:44 PM, Martin Basti wrote: On 12/03/15 17:15, Martin Babinsky wrote: On 03/12/2015 03:59 PM, Martin Babinsky wrote: On 03/11/2015 03:13 PM, Martin Basti wrote: On 11/03/15 13:00, Martin B

Re: [Freeipa-devel] [PATCH] extop: For printf formatting warning

2015-03-18 Thread Jakub Hrozek
On Wed, Mar 18, 2015 at 11:39:15AM +0100, Sumit Bose wrote: > On Wed, Mar 18, 2015 at 11:25:14AM +0100, Jakub Hrozek wrote: > > I could swear I sent the patch last time when I was reviewing Sumit's > > patches but apparently not. > > > > It's better to use %zu instead of %d for size_t formatting w

[Freeipa-devel] topology plugin - again need for input

2015-03-18 Thread Ludwig Krispenz
Hi, I need your feedback on a problem with implementing the topology plugin: marking an replication agreement, this seems to be a never ending story We want o mark an agreement when it is creqated by the plugin or put under control of the plugin by raising the domain level. The first idea was

Re: [Freeipa-devel] [PATCH] extop: For printf formatting warning

2015-03-18 Thread Sumit Bose
On Wed, Mar 18, 2015 at 11:25:14AM +0100, Jakub Hrozek wrote: > I could swear I sent the patch last time when I was reviewing Sumit's > patches but apparently not. > > It's better to use %zu instead of %d for size_t formatting with recent > compilers. > >From a088e8c8a9bd29b4c22f1579f2c3705652bf2

[Freeipa-devel] [PATCH] extop: For printf formatting warning

2015-03-18 Thread Jakub Hrozek
I could swear I sent the patch last time when I was reviewing Sumit's patches but apparently not. It's better to use %zu instead of %d for size_t formatting with recent compilers. >From a088e8c8a9bd29b4c22f1579f2c3705652bf2730 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 18 Mar 2015 11:

Re: [Freeipa-devel] [PATCHES 137-139] extdom: add err_msg member to request context

2015-03-18 Thread Jakub Hrozek
On Wed, Mar 18, 2015 at 10:58:51AM +0100, Sumit Bose wrote: > Please find attached a new version where the typo is fixed. > > bye, > Sumit ACK I think the IPA gatekeepers shoudl feel free to just fix these trivial errors before pushing in the future. -- Manage your subscription for the Freeipa

Re: [Freeipa-devel] [PATCH 140] extdom: migrate check-based test to cmocka

2015-03-18 Thread Jakub Hrozek
On Wed, Mar 18, 2015 at 11:01:35AM +0100, Sumit Bose wrote: > On Fri, Mar 13, 2015 at 03:14:55PM +0100, Jakub Hrozek wrote: > > On Fri, Mar 13, 2015 at 11:56:46AM +0100, Sumit Bose wrote: > > > On Wed, Mar 04, 2015 at 06:42:05PM +0100, Sumit Bose wrote: > > > > Hi, > > > > > > > > this is the firs

Re: [Freeipa-devel] [PATCH 140] extdom: migrate check-based test to cmocka

2015-03-18 Thread Sumit Bose
On Fri, Mar 13, 2015 at 03:14:55PM +0100, Jakub Hrozek wrote: > On Fri, Mar 13, 2015 at 11:56:46AM +0100, Sumit Bose wrote: > > On Wed, Mar 04, 2015 at 06:42:05PM +0100, Sumit Bose wrote: > > > Hi, > > > > > > this is the first patch for https://fedorahosted.org/freeipa/ticket/4922 > > > which con

Re: [Freeipa-devel] [PATCHES 137-139] extdom: add err_msg member to request context

2015-03-18 Thread Sumit Bose
On Fri, Mar 13, 2015 at 03:17:10PM +0100, Jakub Hrozek wrote: > On Fri, Mar 13, 2015 at 11:55:09AM +0100, Sumit Bose wrote: > > On Wed, Mar 04, 2015 at 06:35:22PM +0100, Sumit Bose wrote: > > > Hi, > > > > > > this patch series improves error reporting of the extdom plugin > > > especially on the

[Freeipa-devel] [PATCH 0022] migrate-ds: proper treatment of unsuccessful migrations

2015-03-18 Thread Martin Babinsky
This is a proper fix to both https://fedorahosted.org/freeipa/ticket/4846 and https://fedorahosted.org/freeipa/ticket/4952. To do this I had to throw out some unused parameters from _update_default_group function (particularly the pesky pkey causing bug #4846 to pop out). I did not test the