Re: [Freeipa-devel] [PATCH 0400] update_uniqueness plugin: fix possible referenced before assignment error

2016-01-07 Thread Martin Babinsky
On 01/06/2016 08:32 PM, Martin Basti wrote: Variable 'update' might be undefined if a plugin configuration cannot be migrated to new format. Patch attached. ACK -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [patch 0029, 0030] fixes for install tasks in integration tests

2016-01-07 Thread Milan Kubík
On 01/07/2016 10:12 AM, Martin Basti wrote: On 07.01.2016 10:03, Oleg Fayans wrote: Hi Milan, There is already a more generic method in tasks.py, that does the same: prepare_reverse_zone You can just call it from apply_common_fixes. That way, it will work not only in 10.0.0.0/16 networks.

Re: [Freeipa-devel] [patch 0029, 0030] fixes for install tasks in integration tests

2016-01-07 Thread Oleg Fayans
Hi Milan, There is already a more generic method in tasks.py, that does the same: prepare_reverse_zone You can just call it from apply_common_fixes. That way, it will work not only in 10.0.0.0/16 networks. On 01/07/2016 09:36 AM, Milan Kubík wrote: > 0029: Add 10.in-addr.arpa. zone to ipa >

Re: [Freeipa-devel] [PATCHES] 0753-0759

2016-01-07 Thread Petr Viktorin
On 01/06/2016 03:47 PM, Rob Crittenden wrote: > Petr Viktorin wrote: >> Hello, >> >> Patches 0753-0757 fix remaining warnings from `pylint --py3k`, except >> "no-absolute-import" (which seems redundant to me) and the ones in >> contrib/RHEL4. >> >> As for contrib/RHEL4, I found a mail [0] from

Re: [Freeipa-devel] [patch 0029, 0030] fixes for install tasks in integration tests

2016-01-07 Thread Martin Basti
On 07.01.2016 10:21, Milan Kubík wrote: On 01/07/2016 10:12 AM, Martin Basti wrote: On 07.01.2016 10:03, Oleg Fayans wrote: Hi Milan, There is already a more generic method in tasks.py, that does the same: prepare_reverse_zone You can just call it from apply_common_fixes. That way, it

Re: [Freeipa-devel] [patch 0028] ipatests: Fix configuration problems in dns tests

2016-01-07 Thread Martin Basti
On 07.01.2016 10:23, Milan Kubík wrote: On 01/07/2016 09:31 AM, Oleg Fayans wrote: Hi Milan, As we are eventialy going to move to python3, I would make the code python3-compatible: 1. from __future__ import unicode_literals 2. get rid of all u's in front of the strings On the other hand,

Re: [Freeipa-devel] [PATCH] 0048 Decode HTTP reason phrase as iso-8859-1

2016-01-07 Thread Fraser Tweedale
On Thu, Jan 07, 2016 at 07:56:15AM +0100, Jan Cholasta wrote: > Hi, > > On 6.1.2016 05:26, Fraser Tweedale wrote: > >Happy new year, all. > > > >The attached patch fixes a unicode decode error triggered in some > >locales, which causes failure of installation (and probably other > >oprations, if

Re: [Freeipa-devel] [patch 0028] ipatests: Fix configuration problems in dns tests

2016-01-07 Thread Oleg Fayans
Hi Milan, As we are eventialy going to move to python3, I would make the code python3-compatible: 1. from __future__ import unicode_literals 2. get rid of all u's in front of the strings On the other hand, we can make a separate commit with only py3-related changes. On 01/07/2016 09:26 AM,

Re: [Freeipa-devel] [PATCH 0072-0081] DNSSEC: fixes

2016-01-07 Thread Martin Basti
On 07.01.2016 14:38, Martin Basti wrote: On 07.01.2016 12:19, Martin Basti wrote: On 06.01.2016 18:49, Martin Basti wrote: On 22.12.2015 14:32, Petr Spacek wrote: On 21.12.2015 18:56, Martin Basti wrote: On 21.12.2015 15:45, Martin Basti wrote: On 21.12.2015 15:33, Petr Spacek

Re: [Freeipa-devel] [PATCHES] 0753-0759

2016-01-07 Thread Rob Crittenden
Petr Viktorin wrote: > On 01/06/2016 03:47 PM, Rob Crittenden wrote: >> Petr Viktorin wrote: >>> Hello, >>> >>> Patches 0753-0757 fix remaining warnings from `pylint --py3k`, except >>> "no-absolute-import" (which seems redundant to me) and the ones in >>> contrib/RHEL4. >>> >>> As for

Re: [Freeipa-devel] [PATCH 027] Require Dogtag 10.2.6-13 to fix KRA uninstall

2016-01-07 Thread Martin Basti
On 07.01.2016 07:37, Jan Cholasta wrote: On 6.1.2016 20:37, Martin Basti wrote: On 06.01.2016 11:21, Martin Babinsky wrote: On 01/05/2016 01:49 PM, Lukas Slebodnik wrote: On (05/01/16 12:24), Christian Heimes wrote: The combination of a bug in Dogtag's sslget command and a new feature in

[Freeipa-devel] [PATCH 0121] consider IPA master removed from topology when request for host TGT fails

2016-01-07 Thread Martin Babinsky
https://fedorahosted.org/freeipa/ticket/5584 -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 559] Fix kadmin for new users

2016-01-07 Thread Martin Basti
On 06.01.2016 09:49, Petr Vobornik wrote: On 01/06/2016 08:42 AM, Martin Kosek wrote: On 01/06/2016 08:37 AM, Martin Babinsky wrote: On 11/25/2015 03:41 PM, Martin Kosek wrote: On 11/25/2015 03:32 PM, Simo Sorce wrote: On Wed, 2015-11-25 at 14:13 +0100, Tomas Babej wrote: On 11/25/2015

Re: [Freeipa-devel] [PATCH 0121] consider IPA master removed from topology when request for host TGT fails

2016-01-07 Thread Martin Babinsky
On 01/07/2016 05:37 PM, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5584 And the patch is here. -- Martin^3 Babinsky From 43617fe3bbd4e72626bdf9f3c228c3585cc37d4b Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Thu, 7 Jan 2016 16:48:11 +0100

Re: [Freeipa-devel] [PATCH 0118] fix Py3 incompatible exception instantiation in replica install code

2016-01-07 Thread Martin Babinsky
On 01/04/2016 09:02 AM, Martin Babinsky wrote: I have created ticket to patch and added it to commit message: https://fedorahosted.org/freeipa/ticket/5585 -- Martin^3 Babinsky From 8d2779da21b2110ad879e413a2434c4b7e702d35 Mon Sep 17 00:00:00 2001 From: Martin Babinsky

Re: [Freeipa-devel] [PATCH 0086] Migrate OTP import script to python-cryptography

2016-01-07 Thread Martin Basti
On 29.09.2015 12:00, Martin Babinsky wrote: On 09/25/2015 07:05 PM, Nathaniel McCallum wrote: On Fri, 2015-09-25 at 18:29 +0200, Martin Babinsky wrote: On 09/25/2015 04:53 PM, Nathaniel McCallum wrote: On Mon, 2015-08-31 at 11:08 -0400, Nathaniel McCallum wrote: