[Freeipa-devel] [PATCHES] 0761-0769 More Python3 fixes

2016-01-27 Thread Petr Viktorin
Hello, Here is a mixed bag of Python 3 fixes. They fix some tests, and they should enable you to use `python3 /usr/bin/ipa`. -- Petr Viktorin From 7d6bb7fe8d548e564d7bd941439fa405f0f92742 Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Mon, 21 Sep 2015 13:22:17 +0200 Subject: [PATCH] test_p

Re: [Freeipa-devel] [PATCH 0399] ipa-getkeytab: Handle the possibility of not obtaining a result

2016-01-27 Thread Tomas Babej
On 01/27/2016 05:03 PM, Martin Babinsky wrote: > On 01/26/2016 05:48 PM, Tomas Babej wrote: >> Hi, >> >> The ldap_result operation can time out, returning a NULL result, >> which in turn causes the parsing operation to crash. >> >> https://fedorahosted.org/freeipa/ticket/5642 >> >> Tomas >> >> >>

Re: [Freeipa-devel] [PATCH 0399] ipa-getkeytab: Handle the possibility of not obtaining a result

2016-01-27 Thread Martin Babinsky
On 01/26/2016 05:48 PM, Tomas Babej wrote: Hi, The ldap_result operation can time out, returning a NULL result, which in turn causes the parsing operation to crash. https://fedorahosted.org/freeipa/ticket/5642 Tomas ACK -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-dev

Re: [Freeipa-devel] [PATCH] 950 webui: remove moot error from webui build

2016-01-27 Thread Petr Vobornik
On 01/27/2016 04:01 PM, Gabe Alford wrote: Ack. Works as expected. Thanks for review. Pushed to: master: e668b06231553457df64eb43bef8918b21b4ebdc ipa-4-3: b9573f968a13d1373020be91a50786db81c1f1a3 Gabe On Wed, Jan 27, 2016 at 7:39 AM, Petr Vobornik wrote: add module 'libs/d3' to a list o

Re: [Freeipa-devel] [PATCH 155] ipa-kdb: get_authz_data_types() make sure entry can be NULL

2016-01-27 Thread Tomas Babej
On 01/27/2016 04:04 PM, Tomas Babej wrote: > > > On 01/06/2016 12:15 PM, Sumit Bose wrote: >> Hi, >> >> this patch fixes and issue found by Simo when he called >> get_authz_data_types() with the second argument being NULL. >> This function determines which type of authorization data should be >

Re: [Freeipa-devel] [PATCH 155] ipa-kdb: get_authz_data_types() make sure entry can be NULL

2016-01-27 Thread Tomas Babej
On 01/06/2016 12:15 PM, Sumit Bose wrote: > Hi, > > this patch fixes and issue found by Simo when he called > get_authz_data_types() with the second argument being NULL. > This function determines which type of authorization data should be > added to the Kerberos ticket. There are global default

Re: [Freeipa-devel] [PATCH] 950 webui: remove moot error from webui build

2016-01-27 Thread Gabe Alford
Ack. Works as expected. Gabe On Wed, Jan 27, 2016 at 7:39 AM, Petr Vobornik wrote: > add module 'libs/d3' to a list of modules provided by third party libraries > > it is provided by d3 library in libs directory > > https://fedorahosted.org/freeipa/ticket/5641 > -- > Petr Vobornik > > -- > Mana

Re: [Freeipa-devel] [PATCH 0128] ipalib/cli.py: pythonify Collector class

2016-01-27 Thread Martin Babinsky
On 01/18/2016 06:43 PM, Martin Babinsky wrote: A little patch that should make some future pylint errors disappear. Attaching updated patch that does not promote direct molestation of instance dictionaries. -- Martin^3 Babinsky From fdb04f6a15c6a8983706916c52bfee407cb1509c Mon Sep 17 00:00:

[Freeipa-devel] [PATCH] 950 webui: remove moot error from webui build

2016-01-27 Thread Petr Vobornik
add module 'libs/d3' to a list of modules provided by third party libraries it is provided by d3 library in libs directory https://fedorahosted.org/freeipa/ticket/5641 -- Petr Vobornik From c62297be98972fbd1ea5c0903fb5263e7130ebdb Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 27 Jan 2

Re: [Freeipa-devel] [PATCH 540] cert renewal: import all external CA certs on IPA CA cert renewal

2016-01-27 Thread Tomas Babej
On 01/27/2016 02:53 PM, Jan Cholasta wrote: > On 27.1.2016 14:41, Tomas Babej wrote: >> >> >> On 01/27/2016 08:06 AM, Martin Babinsky wrote: >>> On 01/25/2016 08:19 AM, Jan Cholasta wrote: On 22.1.2016 12:28, Jan Cholasta wrote: > On 22.1.2016 10:34, Martin Babinsky wrote: >> On 01/2

Re: [Freeipa-devel] [PATCH 540] cert renewal: import all external CA certs on IPA CA cert renewal

2016-01-27 Thread Jan Cholasta
On 27.1.2016 14:41, Tomas Babej wrote: On 01/27/2016 08:06 AM, Martin Babinsky wrote: On 01/25/2016 08:19 AM, Jan Cholasta wrote: On 22.1.2016 12:28, Jan Cholasta wrote: On 22.1.2016 10:34, Martin Babinsky wrote: On 01/21/2016 10:27 AM, Jan Cholasta wrote: Hi, the attached patch fixes

Re: [Freeipa-devel] [PATCH 540] cert renewal: import all external CA certs on IPA CA cert renewal

2016-01-27 Thread Tomas Babej
On 01/27/2016 08:06 AM, Martin Babinsky wrote: > On 01/25/2016 08:19 AM, Jan Cholasta wrote: >> On 22.1.2016 12:28, Jan Cholasta wrote: >>> On 22.1.2016 10:34, Martin Babinsky wrote: On 01/21/2016 10:27 AM, Jan Cholasta wrote: > Hi, > > the attached patch fixes >

Re: [Freeipa-devel] [PATCH 543] CA install: explicitly set dogtag_version to 10

2016-01-27 Thread Tomas Babej
On 01/27/2016 12:10 PM, Martin Babinsky wrote: > On 01/27/2016 09:27 AM, Jan Cholasta wrote: >> On 26.1.2016 10:23, Martin Babinsky wrote: >>> On 01/26/2016 10:14 AM, Martin Babinsky wrote: On 01/25/2016 08:56 AM, Alexander Bokovoy wrote: > On Mon, 25 Jan 2016, Jan Cholasta wrote: >>

Re: [Freeipa-devel] [PATCH] webui: 949 crash nicely if sessionStorage is not available

2016-01-27 Thread Tomas Babej
On 01/26/2016 06:59 PM, Tomas Babej wrote: > ACK > > On 01/26/2016 06:57 PM, Petr Vobornik wrote: >> https://fedorahosted.org/freeipa/ticket/5643 >> >> > Pushed to master: 6e1eb5bc8f83faa38203bd308896d0b15f359b24 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redha

Re: [Freeipa-devel] [PATCH] 0002 Add support for user parameter for /ipa/ui/reset_password.html

2016-01-27 Thread Petr Vobornik
On 01/25/2016 03:10 PM, Pavel Vomacka wrote: Hello again, another patch is ready for reviewing. Now it is the patch which adds support for user parameter for /ipa/ui/reset_password.html page. That means that you can prefill username field by using url parameter 'user'. Here is the ticket link: h

Re: [Freeipa-devel] New tool tips for Refresh, Revert, Undo and Undo All buttons

2016-01-27 Thread Petr Vobornik
On 01/25/2016 01:55 PM, Pavel Vomacka wrote: Hello everyone, I just made a patch for the https://fedorahosted.org/freeipa/ticket/5428 ticket. The patch adds tool tips to the buttons in detail views. The text of new tool tips is written in the comment of the ticket. Pavel Vomacka Intern ACK

Re: [Freeipa-devel] [PATCH 0031] ipatests: fix the install of external ca

2016-01-27 Thread Martin Basti
On 27.01.2016 11:02, Martin Babinsky wrote: On 01/19/2016 05:56 PM, Milan Kubík wrote: On 01/19/2016 05:31 PM, Milan Kubík wrote: Patch attached. This actually has a ticket opened. Patch with fixed commit message. ;) -- Milan Kubik ACK Pushed to: master: 8f6fb7b4eaa74e9478f946a3be8

Re: [Freeipa-devel] [PATCH 0409] Warn user when ipa *-find reach search limit

2016-01-27 Thread Martin Basti
On 27.01.2016 09:16, Petr Spacek wrote: On 26.1.2016 15:38, Gabe Alford wrote: On Tue, Jan 26, 2016 at 7:33 AM, Martin Basti wrote: On 26.01.2016 15:17, Petr Spacek wrote: On 26.1.2016 15:06, Martin Basti wrote: On 26.01.2016 15:00, Gabe Alford wrote: On Tue, Jan 26, 2016 at 6:56 AM,

Re: [Freeipa-devel] [PATCH 543] CA install: explicitly set dogtag_version to 10

2016-01-27 Thread Martin Babinsky
On 01/27/2016 09:27 AM, Jan Cholasta wrote: On 26.1.2016 10:23, Martin Babinsky wrote: On 01/26/2016 10:14 AM, Martin Babinsky wrote: On 01/25/2016 08:56 AM, Alexander Bokovoy wrote: On Mon, 25 Jan 2016, Jan Cholasta wrote: Hi, the attached patch fixes

Re: [Freeipa-devel] [PATCH] 0760 - Split ipa-client/ into ipaclient/ and client/

2016-01-27 Thread Jan Cholasta
On 25.1.2016 14:49, Petr Viktorin wrote: On 01/25/2016 02:12 PM, Jan Cholasta wrote: On 14.1.2016 17:49, Petr Viktorin wrote: On 01/14/2016 11:09 AM, Jan Cholasta wrote: On 14.1.2016 10:48, Petr Viktorin wrote: On 01/14/2016 07:55 AM, Jan Cholasta wrote: Hi, On 13.1.2016 13:03, Martin Babin

Re: [Freeipa-devel] [TEST][Patch 0021] Fixed recent replica installation issues in the lab

2016-01-27 Thread Oleg Fayans
Sorry, trailing whitespace detected. This version passes lint On 01/27/2016 09:23 AM, Oleg Fayans wrote: > Hi, > > On 01/21/2016 04:41 PM, Petr Spacek wrote: >> Hello, >> >> On 21.1.2016 13:42, Oleg Fayans wrote: >>> freeipa-ofayans-0021-Removed-ip-address-option-from-replica-installation.patch >

Re: [Freeipa-devel] [PATCH 0031] ipatests: fix the install of external ca

2016-01-27 Thread Martin Babinsky
On 01/19/2016 05:56 PM, Milan Kubík wrote: On 01/19/2016 05:31 PM, Milan Kubík wrote: Patch attached. This actually has a ticket opened. Patch with fixed commit message. ;) -- Milan Kubik ACK -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://

Re: [Freeipa-devel] [PATCH 543] CA install: explicitly set dogtag_version to 10

2016-01-27 Thread Jan Cholasta
On 26.1.2016 10:23, Martin Babinsky wrote: On 01/26/2016 10:14 AM, Martin Babinsky wrote: On 01/25/2016 08:56 AM, Alexander Bokovoy wrote: On Mon, 25 Jan 2016, Jan Cholasta wrote: Hi, the attached patch fixes . Note that this is a 4.2-specific fi

Re: [Freeipa-devel] [TEST][Patch 0021] Fixed recent replica installation issues in the lab

2016-01-27 Thread Oleg Fayans
Hi, On 01/21/2016 04:41 PM, Petr Spacek wrote: > Hello, > > On 21.1.2016 13:42, Oleg Fayans wrote: >> freeipa-ofayans-0021-Removed-ip-address-option-from-replica-installation.patch >> >> >> From d7ab06a4dcddb919fda351b983d478f1b6968578 Mon Sep 17 00:00:00 2001 >> From: Oleg Fayans >> Date: Thu,

Re: [Freeipa-devel] [TEST][Patch 0020] Enabled recreation of test directory during ipa reinstallation

2016-01-27 Thread Oleg Fayans
Hi guys, Any chance this can be reviewed any time soon? On 01/21/2016 12:59 PM, Oleg Fayans wrote: > > > -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to

Re: [Freeipa-devel] [PATCH 0409] Warn user when ipa *-find reach search limit

2016-01-27 Thread Petr Spacek
On 26.1.2016 15:38, Gabe Alford wrote: > On Tue, Jan 26, 2016 at 7:33 AM, Martin Basti wrote: > >> >> >> On 26.01.2016 15:17, Petr Spacek wrote: >> >>> On 26.1.2016 15:06, Martin Basti wrote: >>> On 26.01.2016 15:00, Gabe Alford wrote: > On Tue, Jan 26, 2016 at 6:56 AM, Martin

Re: [Freeipa-devel] [PATCH 542] replica install: validate DS and HTTP server certificates

2016-01-27 Thread Martin Babinsky
On 01/25/2016 08:29 AM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza You may need to rebase the patch on top of ipa-4-2, otherwise ACK. -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://ww