[Freeipa-devel] WFH 2014-10-01

2014-10-01 Thread Tomas Babej
-- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH 0283] idviews: Fix typo in upgrade handling of the Default Trust

2014-09-30 Thread Tomas Babej
Hi, Fixed missing comma. Also removes leading spaces from the ldif, since this is not stripped by the updater. Part of: https://fedorahosted.org/freeipa/ticket/3979 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >F

Re: [Freeipa-devel] [PATCH 0271] baseldap: Properly handle the case of renaming object to the

2014-09-29 Thread Tomas Babej
On 09/18/2014 02:10 AM, Rob Crittenden wrote: > Tomas Babej wrote: >> Hi, >> >> When renaming a object to the same name, errors.EmptyModList is raised. >> This is not properly handled, and can cause other modifications in the >> LDAPUpdate command to be ignore

Re: [Freeipa-devel] [PATCHES] 0631-0632 Integration tests for backup & restore

2014-09-23 Thread Tomas Babej
the restore? Are all the services up and running? However, this does not block the patches, I think they can be pushed now (this means a ACK from me) in their current form and extended later. If you agree, I can file a ticket. -- Tomas Babej Associate Software Engineer | Red

Re: [Freeipa-devel] [PATCHES] 0264-0267 backup, restore: Don't overwrite /etc/{passwd, group}

2014-09-23 Thread Tomas Babej
;>> >>>> >>>> The fourth patch adds a log entry I find very useful in testing >>>> backup/restore. >> >> >> Rebased onto current master. > > Rebased again. > > > > > ___ > Fre

[Freeipa-devel] [PATCH 0271] baseldap: Properly handle the case of renaming object to the

2014-09-17 Thread Tomas Babej
Hi, When renaming a object to the same name, errors.EmptyModList is raised. This is not properly handled, and can cause other modifications in the LDAPUpdate command to be ignored. https://fedorahosted.org/freeipa/ticket/4548 -- Tomas Babej Associate Software Engineer | Red Hat | Identity

[Freeipa-devel] [PATCH 0269] ipalib: host_del: Extend LDAPDelete's takes_options instead

2014-09-16 Thread Tomas Babej
Hi, The host-del command did not accept --continue option, since the takes_options was overriden and did not take the options from LDAPDelete. Fix the behaviour. https://fedorahosted.org/freeipa/ticket/4473 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno

[Freeipa-devel] Required descriptions

2014-09-15 Thread Tomas Babej
(nothing stops you from entering meaningless description). -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.red

Re: [Freeipa-devel] [PATCH 0260] ipa-client-install: Do not add already configured sources to

2014-09-04 Thread Tomas Babej
Minor fix regarding default_value being None converted to list. On 09/04/2014 12:45 PM, Tomas Babej wrote: > Also I made explicit conversion to list for default values upon Petr's > request. > > On 09/04/2014 12:32 PM, Tomas Babej wrote: >> On 09/03/2014 04:53 PM, Petr Vi

Re: [Freeipa-devel] [PATCH 0260] ipa-client-install: Do not add already configured sources to

2014-09-04 Thread Tomas Babej
Also I made explicit conversion to list for default values upon Petr's request. On 09/04/2014 12:32 PM, Tomas Babej wrote: > On 09/03/2014 04:53 PM, Petr Viktorin wrote: >> On 09/03/2014 03:53 PM, Tomas Babej wrote: >>> Hi, >>> >>> Makes sure that any

Re: [Freeipa-devel] [PATCH 0260] ipa-client-install: Do not add already configured sources to

2014-09-04 Thread Tomas Babej
On 09/03/2014 04:53 PM, Petr Viktorin wrote: > On 09/03/2014 03:53 PM, Tomas Babej wrote: >> Hi, >> >> Makes sure that any new sources added are not already present >> in the entry. >> >> https://fedorahosted.org/freeipa/ticket/4508 > > It works fine

Re: [Freeipa-devel] [PATCH 0242] Set the default attributes for RootDSE

2014-09-03 Thread Tomas Babej
On 07/28/2014 03:03 PM, Petr Viktorin wrote: > On 07/15/2014 09:13 AM, Tomas Babej wrote: >> Hi, >> >> With 389 DS 1.3.3 upwards we can leverage the >> nsslapd-return-default-opattr >> attribute to enumerate the list of attributes that should be returned >>

[Freeipa-devel] [PATCH 0260] ipa-client-install: Do not add already configured sources to

2014-09-03 Thread Tomas Babej
Hi, Makes sure that any new sources added are not already present in the entry. https://fedorahosted.org/freeipa/ticket/4508 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 6cd6f5d523e11a70cd51788dd669cbd2e628e

Re: [Freeipa-devel] [PATCHES] 0629-0630 test_integration.task: Add DNS A records when installing a master

2014-08-04 Thread Tomas Babej
some fixes to our integration tests. > > -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com

[Freeipa-devel] [PATCHES 247-259] ID views - management part

2014-08-01 Thread Tomas Babej
lpful documentation, I am working on that. -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 00289142b3eff9474cbb6672c17abad1c6b63005 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Thu, 31 Jul 2014 11:57:53 +0200 Subject

Re: [Freeipa-devel] [PATCH 0246] baseldap: Fix undefined variable reference in

2014-07-24 Thread Tomas Babej
On 07/24/2014 12:35 PM, Tomas Babej wrote: > Hi, > > on receiving a PublicError we fail with InternalError since msg is not > defined. > > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.re

[Freeipa-devel] [PATCH 0246] baseldap: Fix undefined variable reference in

2014-07-24 Thread Tomas Babej
Hi, on receiving a PublicError we fail with InternalError since msg is not defined. -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From d81984981a2de72aa820feb710fec1ccb8e5 Mon Sep 17 00:00:00 2001 From: To

[Freeipa-devel] [PATCH 0245] baseldap: Remove redundant search from LDAPAddReverseMember

2014-07-23 Thread Tomas Babej
Hi, when poking in the depths of the baseldap, I found this seemingly redundant search. -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 24773eaded8f0216f24f4e3b1250f8633484f9c7 Mon Sep 17 00:00:00 2001 From: To

Re: [Freeipa-devel] [PATCH] Enable debug pid in smb.conf

2014-07-17 Thread Tomas Babej
a-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel Thanks, ACK. -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org __

Re: [Freeipa-devel] [PATCH 0244] ipatests: test_trust: Add test to cover lookup of trusdomains

2014-07-17 Thread Tomas Babej
On 07/17/2014 01:20 PM, Tomas Babej wrote: > Hi, > > Adds an integration tests that checks that all trustdomains are > able to be found by trustdomain-find command right after the > trust has been established. > > Also moves some code to allow easier adding common test cases

[Freeipa-devel] [PATCH 0244] ipatests: test_trust: Add test to cover lookup of trusdomains

2014-07-17 Thread Tomas Babej
/ticket/4208 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From b8c8d93c90afffd68b546f05960b1d2480a8c90e Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Mon, 16 Jun 2014 17:25:04 +0200 Subject: [PATCH] ipate

[Freeipa-devel] [PATCH 0243] ipalib: idrange: Make non-implemented range types fail the

2014-07-16 Thread Tomas Babej
Hi, The ipa-ipa-trust and ipa-ad-winsync ID Range types were allowed to pass the validation tests, however, they are not implemented nor checked by the 389 server plugin. https://fedorahosted.org/freeipa/ticket/4323 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management

Re: [Freeipa-devel] [PATCH 0241] trusts: Make cn=adtrust agents sysaccount nestedgroup

2014-07-15 Thread Tomas Babej
On 07/14/2014 05:00 PM, Jan Cholasta wrote: > Hi, > > On 14.7.2014 11:50, Tomas Babej wrote: >> Hi, >> >> Since recent permissions work references this entry, we need to be >> able to have memberOf attributes created on this entry. Hence we >> need

[Freeipa-devel] [PATCH 0242] Set the default attributes for RootDSE

2014-07-15 Thread Tomas Babej
://fedorahosted.org/freeipa/ticket/4288 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From c13810e99970ee38f7d22c087781b0c5d5f270a2 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Wed, 2 Jul 2014 02:55:01 +0200 Subject: [PATCH]

[Freeipa-devel] [PATCH 0241] trusts: Make cn=adtrust agents sysaccount nestedgroup

2014-07-14 Thread Tomas Babej
Hi, Since recent permissions work references this entry, we need to be able to have memberOf attributes created on this entry. Hence we need to include the nestedgroup objectclass. https://fedorahosted.org/freeipa/ticket/4433 -- Tomas Babej Associate Software Engineer | Red Hat | Identity

Re: [Freeipa-devel] [PATCH 0158] Extend ipa-range-check DS plugin to handle range types

2014-07-14 Thread Tomas Babej
On 07/12/2014 08:22 PM, Lukas Slebodnik wrote: > On (01/04/14 10:52), Tomas Babej wrote: >> On 04/01/2014 10:40 AM, Alexander Bokovoy wrote: >>> On Tue, 01 Apr 2014, Tomas Babej wrote: >>>> From 736b3f747188696fd4a46ca63d91a6cca942fd56 Mon Sep 17 00:00:00 2001 >

Re: [Freeipa-devel] [PATCH 0239] trusts: Validate missing trust secret properly

2014-07-14 Thread Tomas Babej
On 07/14/2014 07:58 AM, Jan Cholasta wrote: > On 10.7.2014 10:56, Tomas Babej wrote: >> Hi, >> >> Detect the situation if the user passes empty trust secret and >> error out properly. >> >> https://fedorahosted.org/freeipa/ticket/4266 > >

[Freeipa-devel] [PATCH 0240] ipatests: tasks: Fix dns configuration for trusts

2014-07-14 Thread Tomas Babej
Hi, Properly configure forwarders to the AD zone with respect to newly created ipa dnsforwardzone commands. https://fedorahosted.org/freeipa/ticket/4401 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >F

[Freeipa-devel] [PATCH 0239] trusts: Validate missing trust secret properly

2014-07-10 Thread Tomas Babej
Hi, Detect the situation if the user passes empty trust secret and error out properly. https://fedorahosted.org/freeipa/ticket/4266 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >F

Re: [Freeipa-devel] [PATCH 0236] ipaldap: Fallback to string if datetime conversion went wrong

2014-07-01 Thread Tomas Babej
On 07/01/2014 02:41 PM, Rob Crittenden wrote: > Tomas Babej wrote: >> On 07/01/2014 12:19 PM, Martin Kosek wrote: >>> On 06/26/2014 10:44 AM, Jan Cholasta wrote: >>>> On 26.6.2014 10:39, Petr Viktorin wrote: >>>>> On 06/26/2014 10:33 AM, Jan Ch

[Freeipa-devel] [PATCH 0238] ipaldap: Override conversion of nsds5replicalastupdatestart

2014-07-01 Thread Tomas Babej
II: This is a short-term fix from my point of view. Ticket to resolve the underlying issue has been filed to 389: https://fedorahosted.org/389/ticket/47836 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >F

Re: [Freeipa-devel] [PATCH 0236] ipaldap: Fallback to string if datetime conversion went wrong

2014-07-01 Thread Tomas Babej
3 AM, Jan Cholasta wrote: >>>>>> On 26.6.2014 09:21, Petr Viktorin wrote: >>>>>>> On 06/26/2014 08:30 AM, Jan Cholasta wrote: >>>>>>>> On 25.6.2014 18:25, Petr Viktorin wrote: >>>>>>>>>

[Freeipa-devel] [PATCH 0237] ipa-client-install: Restart nisdomain service instead of

2014-06-30 Thread Tomas Babej
Hi, To ensure new NIS domain name is loaded after ipa-client-install even in case when nisdomainname service is already running, we need to restart the service rather than starting it. https://fedorahosted.org/freeipa/ticket/4393 -- Tomas Babej Associate Software Engineer | Red Hat | Identity

Re: [Freeipa-devel] [PATCH] 470 Add python-yubico to BuildRequires

2014-06-30 Thread Tomas Babej
; Pushed to master under one-liner rule. > > Martin > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel -- Tomas Babej Associate Software Engineer | Red Hat |

Re: [Freeipa-devel] Design Review Keytab Retrieval

2014-06-26 Thread Tomas Babej
/2014 13:03:01 > cifs/vm-136.dom136.tbad.idm.lab.eng.brq.redhat@dom136.tbad.idm.lab.eng.brq.redhat.com > (etype 274) 1 06/26/2014 13:03:01 > cifs/vm-136.dom136.tbad.idm.lab.eng.brq.redhat@dom136.tbad.idm.lab.eng.brq.redhat.com > (etype 273) 1 06/26/2014 13:03:01 > cifs/vm-136.dom136.tbad.idm.lab.eng.brq.redhat@dom136.tbad.idm.lab.eng.brq.redhat.com > (etype 272) 1 06/26/2014 13:03:01 > cifs/vm-136.dom136.tbad.idm.lab.eng.brq.redhat@dom136.tbad.idm.lab.eng.brq.redhat.com > (etype 279) > Note that etype is unresolvable. In the build without these patches we > get something like > 1 06/23/2014 16:28:59 > cifs/vm-139.dom139.tbad.idm.lab.eng.brq.redhat@dom139.tbad.idm.lab.eng.brq.redhat.com > (aes256-cts-hmac-sha1-96) > So this patchset needs an improvement before release. FYI: I filed https://fedorahosted.org/freeipa/ticket/4404 , setting up this as blocker. -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCHES 202-222] Ipaplatform refactoring

2014-06-25 Thread Tomas Babej
On 06/25/2014 04:59 PM, Tomas Babej wrote: > > On 06/25/2014 04:13 PM, Tomas Babej wrote: >> >> On 06/25/2014 04:01 PM, Tomas Babej wrote: >>> >>> On 06/25/2014 10:48 AM, Petr Viktorin wrote: >>>> On 06/19/2014 03:52 PM, Tomas Babej wrote: >&

[Freeipa-devel] [PATCH 0236] ipaldap: Fallback to string if datetime conversion went wrong

2014-06-25 Thread Tomas Babej
icket/4350 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From f1ec7165b433056aafed8c14babf5033c896fde0 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Tue, 17 Jun 2014 17:17:08 +0200 Subject: [PATCH] ipaldap: Fallb

Re: [Freeipa-devel] [PATCHES 202-222] Ipaplatform refactoring

2014-06-25 Thread Tomas Babej
On 06/25/2014 04:13 PM, Tomas Babej wrote: > > On 06/25/2014 04:01 PM, Tomas Babej wrote: >> >> On 06/25/2014 10:48 AM, Petr Viktorin wrote: >>> On 06/19/2014 03:52 PM, Tomas Babej wrote: >>>> >>>> On 06/19/2014 12:52 PM, Tomas Babej wrote

Re: [Freeipa-devel] [PATCHES 202-222] Ipaplatform refactoring

2014-06-25 Thread Tomas Babej
On 06/25/2014 04:01 PM, Tomas Babej wrote: > > On 06/25/2014 10:48 AM, Petr Viktorin wrote: >> On 06/19/2014 03:52 PM, Tomas Babej wrote: >>> >>> On 06/19/2014 12:52 PM, Tomas Babej wrote: >>>> On 06/18/2014 10:52 AM, Petr Viktorin wrote: >>>>

Re: [Freeipa-devel] [PATCH 0233] trusts: Add more read attributes

2014-06-25 Thread Tomas Babej
On 06/25/2014 11:45 AM, Petr Viktorin wrote: > On 06/24/2014 08:15 PM, Tomas Babej wrote: >> Attaching patch 234, which resolves another ACI issue related to trusts. >> >> On 06/24/2014 02:50 PM, Tomas Babej wrote: >>> Hi, >>> >>> this is a fo

Re: [Freeipa-devel] [PATCH 0233] trusts: Add more read attributes

2014-06-24 Thread Tomas Babej
Attaching patch 234, which resolves another ACI issue related to trusts. On 06/24/2014 02:50 PM, Tomas Babej wrote: > Hi, > > this is a follow up patch for 232. Read access to additional attributes > is required for the t

[Freeipa-devel] [PATCH 0233] trusts: Add more read attributes

2014-06-24 Thread Tomas Babej
Hi, this is a follow up patch for 232. Read access to additional attributes is required for the trust objects. -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 8a0849d4bf59b61715ba7b055e980cc38a9fcd6a Mon Sep 17

[Freeipa-devel] [PATCH 0232] trusts: Allow reading ipaNTSecurityIdentifier in user and

2014-06-23 Thread Tomas Babej
Hi, this fixes initial findings of trust-after-aci-refactoring investigation. Consider this effort still WIP (not this patch though). https://fedorahosted.org/freeipa/ticket/4385 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej

Re: [Freeipa-devel] [PATCHES 202-222] Ipaplatform refactoring

2014-06-19 Thread Tomas Babej
On 06/19/2014 12:52 PM, Tomas Babej wrote: > On 06/18/2014 10:52 AM, Petr Viktorin wrote: >> On 06/17/2014 02:15 PM, Tomas Babej wrote: >>> On 06/17/2014 12:03 PM, Timo Aaltonen wrote: >>>> On 17.06.2014 11:16, Martin Kosek wrote: >>> Attached is a new ve

[Freeipa-devel] [PATCH 0229] dsinstance: Detect dynamic plugin support and restart server

2014-06-18 Thread Tomas Babej
://fedorahosted.org/freeipa/ticket/4203 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 8149018cfb81a3e9ec9cb164617f1875656d9354 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Tue, 17 Jun 2014 15:18:49 +0200 Subject: [PA

Re: [Freeipa-devel] [PATCHES 202-222] Ipaplatform refactoring

2014-06-17 Thread Tomas Babej
On 06/17/2014 03:12 PM, Petr Spacek wrote: > On 17.6.2014 14:50, Tomas Babej wrote: >> >> On 06/17/2014 02:44 PM, Petr Spacek wrote: >>> On 17.6.2014 14:15, Tomas Babej wrote: >>>> >>>> On 06/17/2014 12:03 PM, Timo Aaltonen wrote: >>>&g

Re: [Freeipa-devel] [PATCHES 202-222] Ipaplatform refactoring

2014-06-17 Thread Tomas Babej
On 06/17/2014 02:44 PM, Petr Spacek wrote: > On 17.6.2014 14:15, Tomas Babej wrote: >> >> On 06/17/2014 12:03 PM, Timo Aaltonen wrote: >>> On 17.06.2014 11:16, Martin Kosek wrote: >>>> On 06/16/2014 07:50 PM, Petr Viktorin wrote: >>>>> On 06/1

[Freeipa-devel] [PATCH 0227] sudorule: Allow unsetting sudoorder

2014-06-17 Thread Tomas Babej
Hi, After setting sudoorder, you are unable to unset it, since the check for uniqueness of order of sudorules is applied incorrectly. Fix the behaviour and cover it in the test suite. https://fedorahosted.org/freeipa/ticket/4360 -- Tomas Babej Associate Software Engineer | Red Hat | Identity

Re: [Freeipa-devel] [PATCH] #3859: Better mechanism to retrieve keytabs

2014-06-13 Thread Tomas Babej
quot;)(version 3.0; acl > "Admins are allowed to rekey any entity"; allow(write) groupdn="ldap > :///cn=admins,cn=groups,cn=accounts,$SUFFIX";) > > I tested this combination and it effectively stops admin from retrieving > all keys unless explicitly authorize

Re: [Freeipa-devel] [PATCH 0224] cainstance: Read CS.cfg for preop.pin in a loop

2014-06-12 Thread Tomas Babej
On 06/12/2014 04:45 PM, Nathaniel McCallum wrote: > On Thu, 2014-06-12 at 16:36 +0200, Tomas Babej wrote: >> On 06/12/2014 04:27 PM, Nathaniel McCallum wrote: >>> On Thu, 2014-06-12 at 16:20 +0200, Martin Kosek wrote: >>>> On 06/12/2014 03:15 PM, Tomas Babej wrote

Re: [Freeipa-devel] [PATCH 0224] cainstance: Read CS.cfg for preop.pin in a loop

2014-06-12 Thread Tomas Babej
On 06/12/2014 04:27 PM, Nathaniel McCallum wrote: > On Thu, 2014-06-12 at 16:20 +0200, Martin Kosek wrote: >> On 06/12/2014 03:15 PM, Tomas Babej wrote: >>> On 06/12/2014 02:37 PM, Nathaniel McCallum wrote: >>>> On Thu, 2014-06-12 at 13:29 +0200, Tomas Babej wrote

Re: [Freeipa-devel] [PATCH 0224] cainstance: Read CS.cfg for preop.pin in a loop

2014-06-12 Thread Tomas Babej
On 06/12/2014 02:37 PM, Nathaniel McCallum wrote: > On Thu, 2014-06-12 at 13:29 +0200, Tomas Babej wrote: >> On 06/12/2014 10:45 AM, Martin Kosek wrote: >>> On 06/11/2014 06:49 PM, Nathaniel McCallum wrote: >>>> On Wed, 2014-06-11 at 11:08 +0200, Tomas Babej wrote: &

Re: [Freeipa-devel] [PATCH 0224] cainstance: Read CS.cfg for preop.pin in a loop

2014-06-12 Thread Tomas Babej
On 06/12/2014 10:45 AM, Martin Kosek wrote: > On 06/11/2014 06:49 PM, Nathaniel McCallum wrote: >> On Wed, 2014-06-11 at 11:08 +0200, Tomas Babej wrote: >>> Hi, >>> >>> As due to possible race conditions, the preop.pin might not be >>> written in the

[Freeipa-devel] [PATCH 0224] cainstance: Read CS.cfg for preop.pin in a loop

2014-06-11 Thread Tomas Babej
Hi, As due to possible race conditions, the preop.pin might not be written in the CS.cfg at the time installer tries to read it. In case no value for preop.pin was found, retry until timeout was reached. https://fedorahosted.org/freeipa/ticket/3382 (applies on ipa-3-0 branch) -- Tomas Babej

Re: [Freeipa-devel] [PATCH] 630 rpcserver: login_password datetime fix in expiration check

2014-05-22 Thread Tomas Babej
On 05/07/2014 04:37 PM, Petr Vobornik wrote: > On 7.5.2014 16:30, Tomas Babej wrote: >> >> On 05/07/2014 04:26 PM, Petr Vobornik wrote: >>> On 7.5.2014 16:01, Tomas Babej wrote: >>>> >>>> On 05/07/2014 03:47 PM, Petr Vobornik wrote: >>>>

[Freeipa-devel] [PATCH 0004] freeipa-ci: Add sudo integration job

2014-05-14 Thread Tomas Babej
Hi, the sudo integration job is already in master, so it's time for the job to be pushed to the upstream test job repository. Tomas -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org

[Freeipa-devel] Sudorule schema inconsistencies

2014-05-12 Thread Tomas Babej
roups as users with % prefix (patch attached). What do you think? -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 67a1908ef2c6eeab382eb435ad4d41536e7d98e3 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Mon, 5 M

Re: [Freeipa-devel] [PATCH 0167] ipa-client-install: Configure sudo to use SSSD as data source

2014-05-07 Thread Tomas Babej
On 04/30/2014 02:44 PM, Jakub Hrozek wrote: > On Wed, Apr 30, 2014 at 11:05:52AM +0200, Tomas Babej wrote: >> On 03/24/2014 03:27 PM, Jan Pazdziora wrote: >>> On Mon, Mar 24, 2014 at 02:57:30PM +0100, Martin Kosek wrote: >>>> On 03/24/2014 02:47 PM, Jan Pazdziora wro

Re: [Freeipa-devel] [PATCH] 630 rpcserver: login_password datetime fix in expiration check

2014-05-07 Thread Tomas Babej
On 05/07/2014 04:26 PM, Petr Vobornik wrote: > On 7.5.2014 16:01, Tomas Babej wrote: >> >> On 05/07/2014 03:47 PM, Petr Vobornik wrote: >>> krbpasswordexpiration conversion to number of second since epoch failed >>> because now we get datetime object

Re: [Freeipa-devel] [PATCH] 630 rpcserver: login_password datetime fix in expiration check

2014-05-07 Thread Tomas Babej
= time.mktime(expiration.timetuple()) +if exp <= time.time(): to this: +if expiration <= datetime.datetime.now() -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org __

Re: [Freeipa-devel] [PATCH] 584 migration: fix import of wsgiref.util

2014-05-07 Thread Tomas Babej
ipattern seems needed even if the proper solution would > be to fix wsgi to properly export util. Is there bug filed for that. > > Ack based on reading the code and wsgiref documentation where the same > import style is used. > ACK, I did the functional tests as well, works fine

[Freeipa-devel] [PATCH 0003] freeipa-ci: Remove freeipa packages before distro-sync in build

2014-05-07 Thread Tomas Babej
Hi, this fixes the problem on builders, which do distro-sync while having freeipa packages present from previous build run. This causes unnecessary downgrades., which may result into failures (as now with the smartproxy pushed). -- Tomas Babej Associate Software Engineer | Red Hat | Identity

Re: [Freeipa-devel] [PATCH 0001] Adding verb to error message to make it less confusing

2014-05-06 Thread Tomas Babej
bit, hence this patch. > > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RH

Re: [Freeipa-devel] [PATCHES 180-182] ipatests: Improvements!

2014-05-06 Thread Tomas Babej
On 05/05/2014 06:08 PM, Alexander Bokovoy wrote: > On Fri, 02 May 2014, Jakub Hrozek wrote: >> On Wed, Apr 30, 2014 at 03:59:01PM +0200, Tomas Babej wrote: >>> Hi, >>> >>> * patch 180 fixes incorrect hostname usage when connecting to legacy >>> client

Re: [Freeipa-devel] [PATCH 0001] Fixed typo in ipa-test-task man page

2014-05-06 Thread Tomas Babej
ACK. On 05/06/2014 11:05 AM, Thorsten Scherf wrote: > > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel -- Tomas Babej Associate Software Engineer | Red Hat

Re: [Freeipa-devel] [PATCH 0001] Fixed various typos in ipa-client-install man page

2014-05-06 Thread Tomas Babej
ACK. On 05/06/2014 10:48 AM, Thorsten Scherf wrote: > > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel -- Tomas Babej Associate Software Engineer | Red Hat

Re: [Freeipa-devel] [PATCH 0137] ipalib: Add DateTime parameter

2014-04-30 Thread Tomas Babej
On 04/25/2014 11:08 AM, Jan Cholasta wrote: > On 22.4.2014 13:32, Tomas Babej wrote: >> Thank you for the suggestions. Updated, rebased patch is attached. >> > > This API.txt change from the next patch belongs in this patch: > > +capability: datetime_values 2.84 >

Re: [Freeipa-devel] [PATCH 0138] ipalib: Expose krbPrincipalExpiration in CLI

2014-04-30 Thread Tomas Babej
On 04/25/2014 11:10 AM, Jan Cholasta wrote: > On 22.4.2014 13:34, Tomas Babej wrote: >> Updated, rebased patch attached. >> > > This API.txt change belongs in the previous patch: > > +capability: datetime_values 2.84 > Fixed, updated patch attached. I also added sev

Re: [Freeipa-devel] [PATCH 0034] Deny LDAP binds for user accounts with expired principal

2014-04-30 Thread Tomas Babej
On 01/07/2014 01:47 PM, Tomas Babej wrote: > On 01/07/2014 07:23 AM, Alexander Bokovoy wrote: >> On Mon, 06 Jan 2014, Tomas Babej wrote: >>> On 01/06/2014 12:16 PM, Tomas Babej wrote: >>>> On 04/15/2013 12:43 PM, Tomas Babej wrote: >>>>> On 04/08/2013

[Freeipa-devel] [PATCHES 180-182] ipatests: Improvements!

2014-04-30 Thread Tomas Babej
Hi, * patch 180 fixes incorrect hostname usage when connecting to legacy clients * patch 181 sets up SSSD in debug_level 7 by default * patch 182 does the same, but on the legacy clients -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej

Re: [Freeipa-devel] [PATCH 0167] ipa-client-install: Configure sudo to use SSSD as data source

2014-04-30 Thread Tomas Babej
On 03/24/2014 03:27 PM, Jan Pazdziora wrote: > On Mon, Mar 24, 2014 at 02:57:30PM +0100, Martin Kosek wrote: >> On 03/24/2014 02:47 PM, Jan Pazdziora wrote: >>> On Mon, Mar 03, 2014 at 08:24:41PM +0100, Tomas Babej wrote: >>>> Hi, >>>> >>>&g

Re: [Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

2014-04-23 Thread Tomas Babej
On 04/22/2014 12:50 PM, Tomas Babej wrote: > On 04/17/2014 02:44 PM, Alexander Bokovoy wrote: >> You replace this by >> range->base_rid_set = (slapi_entry_attr_find(entry, IPA_BASE_RID, > &attr) == -1); > > You probably meant "== 0". Fixed. > >

Re: [Freeipa-devel] [PATCH 177] ipatests: Extend test suite for ID ranges

2014-04-23 Thread Tomas Babej
On 04/23/2014 12:17 PM, Martin Kosek wrote: > On 04/22/2014 12:53 PM, Tomas Babej wrote: >> Hi, >> >> Add tests coverage for recently added ID range checks dependant >> on the ID range types. >> >> Part of: https://fedorahosted.

Re: [Freeipa-devel] [PATCH 0138] ipalib: Expose krbPrincipalExpiration in CLI

2014-04-22 Thread Tomas Babej
On 03/05/2014 01:10 PM, Jan Cholasta wrote: > On 25.2.2014 08:34, Tomas Babej wrote: >> Rebased to current master. >> >> On 01/09/2014 04:31 PM, Tomas Babej wrote: >>> Hi, >>> >>> Adds a krbPrincipalExpiration attribute to the user class >

Re: [Freeipa-devel] [PATCH 0137] ipalib: Add DateTime parameter

2014-04-22 Thread Tomas Babej
On 03/05/2014 01:08 PM, Jan Cholasta wrote: > On 25.2.2014 11:15, Tomas Babej wrote: >> >> On 01/14/2014 10:19 AM, Petr Viktorin wrote: >>> On 01/14/2014 09:27 AM, Jan Cholasta wrote: >>>> On 13.1.2014 14:57, Petr Vobornik wrote: >>>>>

Re: [Freeipa-devel] Ipatests fixes

2014-04-22 Thread Tomas Babej
On 04/18/2014 01:14 PM, Petr Viktorin wrote: > On 04/17/2014 04:31 PM, Petr Viktorin wrote: >> On 04/17/2014 12:22 PM, Tomas Babej wrote: >>> On 04/09/2014 01:33 PM, Petr Viktorin wrote: >>>> On 04/09/2014 12:07 PM, Tomas Babej wrote: >>>>> Hi, &

[Freeipa-devel] [PATCH 177] ipatests: Extend test suite for ID ranges

2014-04-22 Thread Tomas Babej
Hi, Add tests coverage for recently added ID range checks dependant on the ID range types. Part of: https://fedorahosted.org/freeipa/ticket/4137 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >F

Re: [Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

2014-04-22 Thread Tomas Babej
t;); Fixed. Updated patchset attached. Tomas >From 4e2cd570a4387213d528575069b8d59098a6beae Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Tue, 22 Apr 2014 12:34:12 +0200 Subject: [PATCH] ipatests: Change range_check return values from int to range_check_result_t enum Using integers for return values that a

Re: [Freeipa-devel] [PATCHES] 255-259 Framework tweaks

2014-04-17 Thread Tomas Babej
that when using --raw, all the attribute > names should use letter casing as returned by python-ldap. Patch 259 > implements that. > > See commit messages for details. > > Honza > -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RH

[Freeipa-devel] [PATCHES 0172-0176] ipa_range_check improvements

2014-04-17 Thread Tomas Babej
Hi, This set of patches deals with bugs and extensions of ipa_range_check plugin. See commit messages for details. Parts of: https://fedorahosted.org/freeipa/ticket/4137 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org

Re: [Freeipa-devel] Ipatests fixes

2014-04-17 Thread Tomas Babej
On 04/09/2014 01:33 PM, Petr Viktorin wrote: > On 04/09/2014 12:07 PM, Tomas Babej wrote: >> Hi, >> >> the following batch deals with the following: >> >> * cleans up apache's semaphores prior to installing IPA (CA install can >> get stuck when IPA is

[Freeipa-devel] Ipatests fixes

2014-04-09 Thread Tomas Babej
ot be overridden by domain name * fixes incorrect assert for UIDs/GIDs in legacy client tests -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 160b3d5937f45fb3ea1d932f3260be70126dd703 Mon Sep 17 00:00:00 2001 From: Tomas Bab

[Freeipa-devel] [PATCH 0002] Use job prefix in install-built-rpms

2014-04-07 Thread Tomas Babej
Hi, this patch fixes the issue with using freeipa specific rpms when defining custom jobs. Tomas -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From fa75dd96908346d354c40fb6587fdf9b7b11870d Mon Sep 17 00:00:00 2

[Freeipa-devel] [PATCHES 163-166] Various ipatests fixes

2014-04-03 Thread Tomas Babej
Hi. these fix the following: * not properly removed PKI instance on IPA uninstall * improper usage of external hostname of AD subdomain in the legacy client tests * relax regex checks in legacy client tests * put 2 seconds of sleep after restart of SSSD when clearing the cache -- Tomas Babej

[Freeipa-devel] [PATCH 0001] Add basic trust and legacy client integration tests

2014-04-02 Thread Tomas Babej
Hi, this adds basic trust and legacy client integration tests to our Jenkins jobs repo. -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 3dc23d1f4ee312e01eafb9677af2d97fdc40845b Mon Sep 17 00:00:00 2001 From: To

[Freeipa-devel] [PATCH 0162] ipa-pwd-extop: Fix memory leak in ipapwd_pre_bind

2014-04-01 Thread Tomas Babej
Hi, We need to free the entry before returning from the function. https://fedorahosted.org/freeipa/ticket/4295 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 5149ce52f583ef234bde5e8b386567c377369e41 Mon Sep 17

Re: [Freeipa-devel] [PATCH 0158] Extend ipa-range-check DS plugin to handle range types

2014-04-01 Thread Tomas Babej
On 04/01/2014 10:40 AM, Alexander Bokovoy wrote: > On Tue, 01 Apr 2014, Tomas Babej wrote: >> From 736b3f747188696fd4a46ca63d91a6cca942fd56 Mon Sep 17 00:00:00 2001 >> From: Tomas Babej >> Date: Wed, 5 Mar 2014 12:28:18 +0100 >> Subject: [PATCH] Extend ipa-range-chec

Re: [Freeipa-devel] [PATCH 0158] Extend ipa-range-check DS plugin to handle range types

2014-04-01 Thread Tomas Babej
A slightly new version, properly adds new attributes of the range_info struct to the free_range_info method. Should be applied on top of my 161 patch. On 03/27/2014 01:11 PM, Tomas Babej wrote: > The updated version handles the ret variable properly. It also makes > sure the memory is pr

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-01 Thread Tomas Babej
On 04/01/2014 09:17 AM, Tomas Babej wrote: > On 04/01/2014 09:11 AM, Alexander Bokovoy wrote: >> On Tue, 01 Apr 2014, Jan Pazdziora wrote: >>> On Thu, Mar 27, 2014 at 01:14:52PM +0100, Tomas Babej wrote: >>>> Hi, >>>> >>>> When cleaning the ra

Re: [Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-04-01 Thread Tomas Babej
On 04/01/2014 09:11 AM, Alexander Bokovoy wrote: > On Tue, 01 Apr 2014, Jan Pazdziora wrote: >> On Thu, Mar 27, 2014 at 01:14:52PM +0100, Tomas Babej wrote: >>> Hi, >>> >>> When cleaning the range_info struct, simple free of the struct >>> is not enou

Re: [Freeipa-devel] [PATCH 0113] ipa-client: Set NIS domain name in the installer

2014-03-30 Thread Tomas Babej
On 03/28/2014 08:42 AM, Martin Kosek wrote: > On 03/26/2014 06:46 PM, Martin Kosek wrote: >> On 03/03/2014 08:16 PM, Tomas Babej wrote: >>> The updated patch addresses all the mentioned issues. >>> >>> Also enables systemd's specific domainname service in

[Freeipa-devel] [PATCH 0161] ipa-range-check: Fix memory leaks when freeing range object

2014-03-27 Thread Tomas Babej
Hi, When cleaning the range_info struct, simple free of the struct is not enough, we have to free contents of char pointers in the struct as well. https://fedorahosted.org/freeipa/ticket/4276 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC

Re: [Freeipa-devel] [PATCH 0158] Extend ipa-range-check DS plugin to handle range types

2014-03-27 Thread Tomas Babej
The updated version handles the ret variable properly. It also makes sure the memory is properly freed. On 03/18/2014 04:45 PM, Alexander Bokovoy wrote: > On Tue, 18 Mar 2014, Tomas Babej wrote: >> >> On 03/18/2014 09:19 AM, Alexander Bokovoy wrote: >>> On Mon, 17 Mar

[Freeipa-devel] [PATCH 0160] ipatests: Do not depend on the case of the attributes when

2014-03-26 Thread Tomas Babej
Hi, In test_trust.py, several tests did case sensitive search on the output of the ipa idrange-show command. This could cause false negatives. Part of: https://fedorahosted.org/freeipa/ticket/4267 -- Tomas Babej Associate Software Engeneer | Red Hat | Identity Management RHCE | Brno Site | IRC

Re: [Freeipa-devel] [PATCH] extdom: do not return results from the wrong domain

2014-03-25 Thread Tomas Babej
of the returned object. This patch should fix > https://fedorahosted.org/freeipa/ticket/4264 . > > bye, > Sumit > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/free

[Freeipa-devel] [PATCH 0159] ipatests: test_trust: Change expected home directories for

2014-03-20 Thread Tomas Babej
/freeipa/ticket/4184 -- Tomas Babej Associate Software Engeneer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From acadb5537c26b0f27065c172b7952f3e14474939 Mon Sep 17 00:00:00 2001 From: Tomas Babej Date: Thu, 27 Feb 2014 15:40:54 +0100 Subject: [PATCH] ipate

Re: [Freeipa-devel] [PATCH 0158] Extend ipa-range-check DS plugin to handle range types

2014-03-18 Thread Tomas Babej
On 03/18/2014 09:19 AM, Alexander Bokovoy wrote: > On Mon, 17 Mar 2014, Tomas Babej wrote: >> Hi, >> >> The ipa-range-check plugin used to determine the range type depending >> on the value of the attributes such as RID or secondary RID base. This >> approached c

[Freeipa-devel] [PATCH 0158] Extend ipa-range-check DS plugin to handle range types

2014-03-17 Thread Tomas Babej
ID mapping derivation capabilities. https://fedorahosted.org/freeipa/ticket/4137 Test coverage coming soon! -- Tomas Babej Associate Software Engeneer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 0d038fb71f02fab5320e4843be80feb34c5c3303 Mon Sep 17 00

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Tomas Babej
On 03/13/2014 04:28 PM, Tomas Babej wrote: > On 03/13/2014 01:47 PM, Alexander Bokovoy wrote: >> On Thu, 13 Mar 2014, Martin Kosek wrote: >>> On 03/13/2014 01:36 PM, Martin Kosek wrote: >>>> On 03/13/2014 01:33 PM, Alexander Bokovoy wrote: >>>>> On T

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Tomas Babej
.2014 13:20, Martin Kosek wrote: >>>>>> On 03/13/2014 01:10 PM, Alexander Bokovoy wrote: >>>>>>> On Thu, 13 Mar 2014, Martin Kosek wrote: >>>>>>>> On 03/13/2014 01:01 PM, Alexander Bokovoy wrote: >>>

<    1   2   3   4   5   6   7   8   9   10   >