[Freeipa-devel] [freeipa PR#153][comment] [ipa-4-4 only] disable warnings reported by pylint-1.6.4-1
URL: https://github.com/freeipa/freeipa/pull/153 Title: #153: [ipa-4-4 only] disable warnings reported by pylint-1.6.4-1 mbasti-rh commented: """ Fixed upstream ipa-4-4: https://fedorahosted.org/freeipa/changeset/2b2fc1abf1844b807e50b99f0912fa10d9169eca """ See the full comment at https://github.com/freeipa/freeipa/pull/153#issuecomment-253161249 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#153][closed] [ipa-4-4 only] disable warnings reported by pylint-1.6.4-1
URL: https://github.com/freeipa/freeipa/pull/153 Author: martbab Title: #153: [ipa-4-4 only] disable warnings reported by pylint-1.6.4-1 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/153/head:pr153 git checkout pr153 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#154][+pushed] [ipa-4-4] Rebase: Tests: Fix cert revocation tests
URL: https://github.com/freeipa/freeipa/pull/154 Title: #154: [ipa-4-4] Rebase: Tests: Fix cert revocation tests Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#154][closed] [ipa-4-4] Rebase: Tests: Fix cert revocation tests
URL: https://github.com/freeipa/freeipa/pull/154 Author: mirielka Title: #154: [ipa-4-4] Rebase: Tests: Fix cert revocation tests Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/154/head:pr154 git checkout pr154 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#142][+ack] CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling
URL: https://github.com/freeipa/freeipa/pull/142 Title: #142: CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#140][comment] Tests: Fix cert revocation tests
URL: https://github.com/freeipa/freeipa/pull/140 Title: #140: Tests: Fix cert revocation tests mbasti-rh commented: """ `Tests: Certificate revocation` doesn't apply to ipa-4-4 branch, please open separate PR against IPA 4.4 """ See the full comment at https://github.com/freeipa/freeipa/pull/140#issuecomment-253154655 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#152][+pushed] Fix warnings reported by pylint in rawhide
URL: https://github.com/freeipa/freeipa/pull/152 Title: #152: Fix warnings reported by pylint in rawhide Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#142][comment] CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling
URL: https://github.com/freeipa/freeipa/pull/142 Title: #142: CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/fb85230e25bd37a2a02a9d90793f337aad40a037 ipa-4-4: https://fedorahosted.org/freeipa/changeset/1b6ba5283e4980da7bd5f1d98b5518062a4c61ad """ See the full comment at https://github.com/freeipa/freeipa/pull/142#issuecomment-253154169 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#142][+pushed] CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling
URL: https://github.com/freeipa/freeipa/pull/142 Title: #142: CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#142][closed] CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling
URL: https://github.com/freeipa/freeipa/pull/142 Author: dkupka Title: #142: CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/142/head:pr142 git checkout pr142 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#154][comment] [ipa-4-4] Rebase: Tests: Fix cert revocation tests
URL: https://github.com/freeipa/freeipa/pull/154 Title: #154: [ipa-4-4] Rebase: Tests: Fix cert revocation tests mbasti-rh commented: """ Fixed upstream ipa-4-4: https://fedorahosted.org/freeipa/changeset/afabdd365a35e0e454997ff021152422bcbcf785 https://fedorahosted.org/freeipa/changeset/c8cdc6a9e6cf68f67d2e8df5aa7b22e13c26 """ See the full comment at https://github.com/freeipa/freeipa/pull/154#issuecomment-253180869 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#152][closed] Fix warnings reported by pylint in rawhide
URL: https://github.com/freeipa/freeipa/pull/152 Author: martbab Title: #152: Fix warnings reported by pylint in rawhide Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/152/head:pr152 git checkout pr152 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#152][comment] Fix warnings reported by pylint in rawhide
URL: https://github.com/freeipa/freeipa/pull/152 Title: #152: Fix warnings reported by pylint in rawhide mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/29829cc55a6be697abf881ea7867ef834bb66be7 https://fedorahosted.org/freeipa/changeset/71f642f75132fe30b40062ce5abc8558a275b9bb """ See the full comment at https://github.com/freeipa/freeipa/pull/152#issuecomment-253153404 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#137][comment] Test: disabled wrong client domain tests for domlevel 0
URL: https://github.com/freeipa/freeipa/pull/137 Title: #137: Test: disabled wrong client domain tests for domlevel 0 mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/8b0faa25d1c47f605bc6c91933469bb2370276c1 ipa-4-4: https://fedorahosted.org/freeipa/changeset/1a27d3037fa6fbbddcdfb08fe41690bf534e6f7b """ See the full comment at https://github.com/freeipa/freeipa/pull/137#issuecomment-253156632 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#137][+pushed] Test: disabled wrong client domain tests for domlevel 0
URL: https://github.com/freeipa/freeipa/pull/137 Title: #137: Test: disabled wrong client domain tests for domlevel 0 Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#137][closed] Test: disabled wrong client domain tests for domlevel 0
URL: https://github.com/freeipa/freeipa/pull/137 Author: ofayans Title: #137: Test: disabled wrong client domain tests for domlevel 0 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/137/head:pr137 git checkout pr137 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#153][+ack] [ipa-4-4 only] disable warnings reported by pylint-1.6.4-1
URL: https://github.com/freeipa/freeipa/pull/153 Title: #153: [ipa-4-4 only] disable warnings reported by pylint-1.6.4-1 Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#153][+pushed] [ipa-4-4 only] disable warnings reported by pylint-1.6.4-1
URL: https://github.com/freeipa/freeipa/pull/153 Title: #153: [ipa-4-4 only] disable warnings reported by pylint-1.6.4-1 Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#136][synchronized] Fix KRA install tests
URL: https://github.com/freeipa/freeipa/pull/136 Author: mbasti-rh Title: #136: Fix KRA install tests Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/136/head:pr136 git checkout pr136 From 4bc794329399344cd2218f71c408d096b2fc2f93 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Tue, 4 Oct 2016 23:08:19 +0200 Subject: [PATCH 1/3] CI: extend replication layouts tests with KRA KRA should be tested with warious replication topologies as well, mainly in domain level 0 https://fedorahosted.org/freeipa/ticket/6088 --- ipatests/test_integration/tasks.py | 18 ++-- .../test_integration/test_replication_layouts.py | 48 ++ 2 files changed, 63 insertions(+), 3 deletions(-) diff --git a/ipatests/test_integration/tasks.py b/ipatests/test_integration/tasks.py index 0b460b9..ef5078b 100644 --- a/ipatests/test_integration/tasks.py +++ b/ipatests/test_integration/tasks.py @@ -994,12 +994,20 @@ def double_circle_topo(master, replicas, site_size=6): def install_topo(topo, master, replicas, clients, domain_level=None, - skip_master=False, setup_replica_cas=True): + skip_master=False, setup_replica_cas=True, + setup_replica_kras=False): """Install IPA servers and clients in the given topology""" +if setup_replica_kras and not setup_replica_cas: +raise ValueError("Option 'setup_replica_kras' requires " + "'setup_replica_cas' set to True") replicas = list(replicas) installed = {master} if not skip_master: -install_master(master, domain_level=domain_level) +install_master( +master, +domain_level=domain_level, +setup_kra=setup_replica_kras +) add_a_records_for_hosts_in_master_domain(master) @@ -1009,7 +1017,11 @@ def install_topo(topo, master, replicas, clients, domain_level=None, connect_replica(parent, child) else: log.info('Installing replica %s from %s' % (parent, child)) -install_replica(parent, child, setup_ca=setup_replica_cas) +install_replica( +parent, child, +setup_ca=setup_replica_cas, +setup_kra=setup_replica_kras +) installed.add(child) install_clients([master] + replicas, clients) diff --git a/ipatests/test_integration/test_replication_layouts.py b/ipatests/test_integration/test_replication_layouts.py index c178815..53cae7d 100644 --- a/ipatests/test_integration/test_replication_layouts.py +++ b/ipatests/test_integration/test_replication_layouts.py @@ -52,6 +52,16 @@ def test_line_topology_with_ca(self): self.replication_is_working() +class TestLineTopologyWithCAKRA(LayoutsBaseTest): + +num_replicas = 3 + +def test_line_topology_with_ca_kra(self): +tasks.install_topo('line', self.master, self.replicas, [], + setup_replica_cas=True, setup_replica_kras=True) +self.replication_is_working() + + class TestStarTopologyWithoutCA(LayoutsBaseTest): num_replicas = 3 @@ -72,6 +82,16 @@ def test_star_topology_with_ca(self): self.replication_is_working() +class TestStarTopologyWithCAKRA(LayoutsBaseTest): + +num_replicas = 3 + +def test_star_topology_with_ca_kra(self): +tasks.install_topo('star', self.master, self.replicas, [], + setup_replica_cas=True, setup_replica_kras=True) +self.replication_is_working() + + class TestCompleteTopologyWithoutCA(LayoutsBaseTest): num_replicas = 3 @@ -92,6 +112,16 @@ def test_complete_topology_with_ca(self): self.replication_is_working() +class TestCompleteTopologyWithCAKRA(LayoutsBaseTest): + +num_replicas = 3 + +def test_complete_topology_with_ca_kra(self): +tasks.install_topo('complete', self.master, self.replicas, [], + setup_replica_cas=True, setup_replica_kras=True) +self.replication_is_working() + + @pytest.mark.skipif(config.domain_level == DOMAIN_LEVEL_0, reason='does not work on DOMAIN_LEVEL_0 by design') class Test2ConnectedTopologyWithoutCA(LayoutsBaseTest): @@ -112,6 +142,15 @@ def test_2_connected_topology_with_ca(self): self.replication_is_working() +class Test2ConnectedTopologyWithCAKRA(LayoutsBaseTest): +num_replicas = 33 + +def test_2_connected_topology_with_ca_kra(self): +tasks.install_topo('2-connected', self.master, self.replicas, [], + setup_replica_cas=True, setup_replica_kras=True) +self.replication_is_working() + + @pytest.mark.skipif(config.domain_level == DOMAIN_LEVEL_0, reason='does not work on DOMAIN_LEVEL_0 by design') class TestDoubleCir
[Freeipa-devel] [freeipa PR#127][comment] Move ipa-otpd to $libexecdir/ipa, purge ffextension
URL: https://github.com/freeipa/freeipa/pull/127 Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/6c53765ac1746ea3cb82554775a37fe43af062e8 https://fedorahosted.org/freeipa/changeset/6c09d6f8788b5436d6c9a5af4cc079a843f00e33 """ See the full comment at https://github.com/freeipa/freeipa/pull/127#issuecomment-253605497 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#127][closed] Move ipa-otpd to $libexecdir/ipa, purge ffextension
URL: https://github.com/freeipa/freeipa/pull/127 Author: tjaalton Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/127/head:pr127 git checkout pr127 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#127][+pushed] Move ipa-otpd to $libexecdir/ipa, purge ffextension
URL: https://github.com/freeipa/freeipa/pull/127 Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#156][+pushed] cert: add revocation reason back to cert-find output
URL: https://github.com/freeipa/freeipa/pull/156 Title: #156: cert: add revocation reason back to cert-find output Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#156][closed] cert: add revocation reason back to cert-find output
URL: https://github.com/freeipa/freeipa/pull/156 Author: jcholast Title: #156: cert: add revocation reason back to cert-find output Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/156/head:pr156 git checkout pr156 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#156][comment] cert: add revocation reason back to cert-find output
URL: https://github.com/freeipa/freeipa/pull/156 Title: #156: cert: add revocation reason back to cert-find output mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/16dad1c3cb09acee946bc5b2409447279a8bc0de ipa-4-4: https://fedorahosted.org/freeipa/changeset/30b478113e0dd7993f491c1582003567e9b20d13 """ See the full comment at https://github.com/freeipa/freeipa/pull/156#issuecomment-253607864 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#161][comment] CI: workaround: wait for dogtag before replica-prepare
URL: https://github.com/freeipa/freeipa/pull/161 Title: #161: CI: workaround: wait for dogtag before replica-prepare mbasti-rh commented: """ It looks that 30 seconds is not enough, majority of ipa-replica-prepare passed, but I had a few test where it is still failing (randomly) """ See the full comment at https://github.com/freeipa/freeipa/pull/161#issuecomment-253611853 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#127][+ack] Move ipa-otpd to $libexecdir/ipa, purge ffextension
URL: https://github.com/freeipa/freeipa/pull/127 Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#136][edited] Fix KRA install tests
URL: https://github.com/freeipa/freeipa/pull/136 Author: mbasti-rh Title: #136: Fix KRA install tests Action: edited Changed field: body Original value: """ - in test_installation testsuite KRA related tests were duplicated, this PR removes it - in test_installation test suite with domain level 0, some KRA tests must be skipped because does not work under domain level 0 by design - because in previous commits I decreased amount of replicas in test_installation, I added KRA tests into replication_layout test suite to test how KRA install works with more replicas and various layouts (needed mainly for domain level 0) https://fedorahosted.org/freeipa/ticket/6088 """ -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [bind-dyndb-ldap PR#2][comment] fix ldif syntax and add idnsTemplateAttribute
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/2 Title: #2: fix ldif syntax and add idnsTemplateAttribute mbasti-rh commented: """ Hello, I wrote inline comments. Please set proper author name in commit (no root please) """ See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/2#issuecomment-253430426 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#152][+ack] Fix warnings reported by pylint in rawhide
URL: https://github.com/freeipa/freeipa/pull/152 Title: #152: Fix warnings reported by pylint in rawhide Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#159][comment] spec file: clean up BuildRequires
URL: https://github.com/freeipa/freeipa/pull/159 Title: #159: spec file: clean up BuildRequires mbasti-rh commented: """ Please update BUILD.txt with how to run pylint with build, probably freeipa.org should be updated as well """ See the full comment at https://github.com/freeipa/freeipa/pull/159#issuecomment-253483810 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#127][comment] Move ipa-otpd to $libexecdir/ipa, purge ffextension
URL: https://github.com/freeipa/freeipa/pull/127 Title: #127: Move ipa-otpd to $libexecdir/ipa, purge ffextension mbasti-rh commented: """ Hello @tjaalton, I cannot apply second commit, it needs rebase. """ See the full comment at https://github.com/freeipa/freeipa/pull/127#issuecomment-253487937 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#160][edited] Reverted the assertion for replica uninstall returncode
URL: https://github.com/freeipa/freeipa/pull/160 Author: ofayans Title: #160: Reverted the assertion for replica uninstall returncode Action: edited Changed field: title Original value: """ Reverted the essertion for replica uninstall returncode """ -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#126][comment] Fix ipa migrate-ds when it finds a search reference
URL: https://github.com/freeipa/freeipa/pull/126 Title: #126: Fix ipa migrate-ds when it finds a search reference mbasti-rh commented: """ Hello, LGTM but PR needs rebase """ See the full comment at https://github.com/freeipa/freeipa/pull/126#issuecomment-253491876 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#148][comment] Unaccessible variable self.attrs in Tracker
URL: https://github.com/freeipa/freeipa/pull/148 Title: #148: Unaccessible variable self.attrs in Tracker mbasti-rh commented: """ You can check last step in this howto http://www.freeipa.org/page/Pull_request_on_Github """ See the full comment at https://github.com/freeipa/freeipa/pull/148#issuecomment-252827639 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#167][+pushed] Move ipa.1 man file
URL: https://github.com/freeipa/freeipa/pull/167 Title: #167: Move ipa.1 man file Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#157][comment] git: Add commit template
URL: https://github.com/freeipa/freeipa/pull/157 Title: #157: git: Add commit template mbasti-rh commented: """ I disagree here with Honza, I liked those comments more at bottom. Why do we even need that comments? git commit command with vim set as editor is doing that automatically. """ See the full comment at https://github.com/freeipa/freeipa/pull/157#issuecomment-254242928 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#167][closed] Move ipa.1 man file
URL: https://github.com/freeipa/freeipa/pull/167 Author: tiran Title: #167: Move ipa.1 man file Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/167/head:pr167 git checkout pr167 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#167][comment] Move ipa.1 man file
URL: https://github.com/freeipa/freeipa/pull/167 Title: #167: Move ipa.1 man file mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/b9d68b5c3503bb708f637be6bb173a742b4105b4 """ See the full comment at https://github.com/freeipa/freeipa/pull/167#issuecomment-254239607 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#155][comment] Build system cleanup
URL: https://github.com/freeipa/freeipa/pull/155 Title: #155: Build system cleanup mbasti-rh commented: """ Needs rebase """ See the full comment at https://github.com/freeipa/freeipa/pull/155#issuecomment-254240565 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements mbasti-rh commented: """ @tiran You can split patch to useful part and please send unneeded bumping of requires as separate pull request, we can continue with discussion there about bumping versions. It is unrelated part of patch and should be in separated commit anyway. """ See the full comment at https://github.com/freeipa/freeipa/pull/255#issuecomment-263547842 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#101][+rejected] Improved vault-show error message
URL: https://github.com/freeipa/freeipa/pull/101 Title: #101: Improved vault-show error message Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#101][closed] Improved vault-show error message
URL: https://github.com/freeipa/freeipa/pull/101 Author: stlaz Title: #101: Improved vault-show error message Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/101/head:pr101 git checkout pr101 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA mbasti-rh commented: """ > The passwords should have around the same entropy now. SHA-1 actually > produces 160bit outputs (hence 40-characters long hexadecimal digests), so I > recounted it for 20-bytes entropy. Sure, my bad As we discussed offline, due NSS FIPS requirements, we should get rid off base64 encoding. I wouldn't remove space from there, can you check if NSS supports it? """ See the full comment at https://github.com/freeipa/freeipa/pull/317#issuecomment-265713667 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#206][closed] Properly handle multiple cookies in rpcclient
URL: https://github.com/freeipa/freeipa/pull/206 Author: simo5 Title: #206: Properly handle multiple cookies in rpcclient Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/206/head:pr206 git checkout pr206 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#206][+pushed] Properly handle multiple cookies in rpcclient
URL: https://github.com/freeipa/freeipa/pull/206 Title: #206: Properly handle multiple cookies in rpcclient Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#206][comment] Properly handle multiple cookies in rpcclient
URL: https://github.com/freeipa/freeipa/pull/206 Title: #206: Properly handle multiple cookies in rpcclient mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/560ab9e3176af8e59163155207cc2c1d631915dd https://fedorahosted.org/freeipa/changeset/f1678693713dc2a573493e325e93f6f557a5ad5a """ See the full comment at https://github.com/freeipa/freeipa/pull/206#issuecomment-265714183 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#318][+pushed] server install: fix external CA install
URL: https://github.com/freeipa/freeipa/pull/318 Title: #318: server install: fix external CA install Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#318][closed] server install: fix external CA install
URL: https://github.com/freeipa/freeipa/pull/318 Author: jcholast Title: #318: server install: fix external CA install Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/318/head:pr318 git checkout pr318 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#318][comment] server install: fix external CA install
URL: https://github.com/freeipa/freeipa/pull/318 Title: #318: server install: fix external CA install mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/4fff09978eab520d130d87c0112b5caac907e651 """ See the full comment at https://github.com/freeipa/freeipa/pull/318#issuecomment-265715262 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#206][+ack] Properly handle multiple cookies in rpcclient
URL: https://github.com/freeipa/freeipa/pull/206 Title: #206: Properly handle multiple cookies in rpcclient Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA mbasti-rh commented: """ @tiran @simo5 If you read my comments properly I was happy with removing sha1() and I pointed out that ipa_generate_password() must generate entropy 160bits as was probably originally aimed by using sha1() @simo5 I'm fine with removing space then @simo5 Standa found out that when FIPS is enabled NSS is not willing to accept some password, it requires some special chars AFAIK @stlaz knows details @tiran I'm afraid we need to keep special chracters there as I mentioned above ^ @tiran thank you for nice code snippet @tiran AFAIK you misunderstood my comment, I wanted to "replace sha1 with something sane" or I don't understand what is wrong with my comment. """ See the full comment at https://github.com/freeipa/freeipa/pull/317#issuecomment-265786411 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#320][comment] add missing attribute to ipaca replica during CA topology update
URL: https://github.com/freeipa/freeipa/pull/320 Title: #320: add missing attribute to ipaca replica during CA topology update mbasti-rh commented: """ IMO #322 this might be related, @martbab can you please check it? """ See the full comment at https://github.com/freeipa/freeipa/pull/320#issuecomment-265823807 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA mbasti-rh commented: """ @tiran IMO you need check `length > uppercase + lowercase + num + special`, otherwise infinity loop but generally LGTM """ See the full comment at https://github.com/freeipa/freeipa/pull/317#issuecomment-265954172 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#313][comment] ipaclient.plugins: Use api_version from internally called commands
URL: https://github.com/freeipa/freeipa/pull/313 Title: #313: ipaclient.plugins: Use api_version from internally called commands mbasti-rh commented: """ Can you please provide better commit description in commit message? What, why and how it fixes? Think about our future us when we will be doing git archaeology """ See the full comment at https://github.com/freeipa/freeipa/pull/313#issuecomment-265976235 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ ACK, but travis runs tests under PY3 and should be, I tried locally and tests works for me (ipa-run-tests is still py2 by default), so there is an issue with travis tests. I prefer to fix travis first before pushing this to not blocking tests for other PRs. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265976899 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ ACK, but travis runs tests under PY3 and should be, I tried locally and tests works for me (ipa-run-tests is still py2 by default), so there is an issue with travis tests. I prefer to fix travis first before pushing this to not blocking tests for other PRs. """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-265976899 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#307][comment] Lowered the version of gettext
URL: https://github.com/freeipa/freeipa/pull/307 Title: #307: Lowered the version of gettext mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/e5686c0ccb4a71fa0ab460fd45280d9adba91cca """ See the full comment at https://github.com/freeipa/freeipa/pull/307#issuecomment-266008212 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#307][closed] Lowered the version of gettext
URL: https://github.com/freeipa/freeipa/pull/307 Author: pvomacka Title: #307: Lowered the version of gettext Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/307/head:pr307 git checkout pr307 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#307][+pushed] Lowered the version of gettext
URL: https://github.com/freeipa/freeipa/pull/307 Title: #307: Lowered the version of gettext Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ `make install` put `#!/usr/bin/python` into `ipa-run-tests` and it causes that on F25 our tests are running by default under PY3 Probably travis tests uses make install (haven't looked) """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266006874 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ @martbab Yes for this PR travis run tests under PY3, see tracebacks it is from python3.5 site-packages """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266009384 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#272][comment] Build: makerpms.sh generates Python 2 & 3 packages at the same time
URL: https://github.com/freeipa/freeipa/pull/272 Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time mbasti-rh commented: """ @martbab Yes for this PR travis run tests under PY3, see tracebacks it is from python3.5 site-packages """ See the full comment at https://github.com/freeipa/freeipa/pull/272#issuecomment-266009384 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA mbasti-rh commented: """ @tiran True, I would like to have there at least assert witch prevents devs to use more than let say 15% per class and more than 50% together, to prevent silly mistakes. It will also reduces possibility of starvation when too many password doesn't match requirements Do you want to send this as PR or are you fine by adding it to this PR by Standa? """ See the full comment at https://github.com/freeipa/freeipa/pull/317#issuecomment-266002689 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA mbasti-rh commented: """ @tiran True, I would like to have there at least assert witch prevents devs to use more than let say 15% per class and more than 50% together, to prevent silly mistakes. It will also reduces possibility of starvation when too many passwords don't match requirements Do you want to send this as PR or are you fine by adding it to this PR by Standa? """ See the full comment at https://github.com/freeipa/freeipa/pull/317#issuecomment-266002689 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#282][+ack] replicainstall: give correct error message on DL mismatch
URL: https://github.com/freeipa/freeipa/pull/282 Title: #282: replicainstall: give correct error message on DL mismatch Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#282][comment] replicainstall: give correct error message on DL mismatch
URL: https://github.com/freeipa/freeipa/pull/282 Title: #282: replicainstall: give correct error message on DL mismatch mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/2dcbc9416f1de708336a9afe92a138da9360ec5b """ See the full comment at https://github.com/freeipa/freeipa/pull/282#issuecomment-266044281 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#282][+pushed] replicainstall: give correct error message on DL mismatch
URL: https://github.com/freeipa/freeipa/pull/282 Title: #282: replicainstall: give correct error message on DL mismatch Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#282][closed] replicainstall: give correct error message on DL mismatch
URL: https://github.com/freeipa/freeipa/pull/282 Author: stlaz Title: #282: replicainstall: give correct error message on DL mismatch Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/282/head:pr282 git checkout pr282 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#323][opened] ipactl: pass api as argument to services
URL: https://github.com/freeipa/freeipa/pull/323 Author: mbasti-rh Title: #323: ipactl: pass api as argument to services Action: opened PR body: """ Commit 6409abf1 removes hard dependency of ipalib in ipalatform to avoid cyclic dependenies, this commit updates ipactl accordingly Removes ugly warnings: ``` [root@vm-028 ~]# ipactl stop /usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('ipa-dnskeysyncd', api=None) is deprecated. super(SystemdService, self).__init__(service_name, api=api) Stopping ipa-dnskeysyncd Service /usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('ipa-otpd', api=None) is deprecated. super(SystemdService, self).__init__(service_name, api=api) Stopping ipa-otpd Service /usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatCAService('pki-tomcatd', api=None) is deprecated. super(SystemdService, self).__init__(service_name, api=api) Stopping pki-tomcatd Service /usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('ntpd', api=None) is deprecated. super(SystemdService, self).__init__(service_name, api=api) Stopping ntpd Service /usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('ipa-custodia', api=None) is deprecated. super(SystemdService, self).__init__(service_name, api=api) Stopping ipa-custodia Service /usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('httpd', api=None) is deprecated. super(SystemdService, self).__init__(service_name, api=api) Stopping httpd Service /usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('ipa_memcached', api=None) is deprecated. super(SystemdService, self).__init__(service_name, api=api) Stopping ipa_memcached Service /usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('named', api=None) is deprecated. super(SystemdService, self).__init__(service_name, api=api) Stopping named Service /usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('kadmin', api=None) is deprecated. super(SystemdService, self).__init__(service_name, api=api) Stopping kadmin Service /usr/lib/python2.7/site-packages/ipaplatform/base/services.py:193: RuntimeWarning: RedHatService('krb5kdc', api=None) is deprecated. super(SystemdService, self).__init__(service_name, api=api) ``` """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/323/head:pr323 git checkout pr323 From f123ce502e333b53f0a87c5a35bb1659cc61456c Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Fri, 9 Dec 2016 11:05:03 +0100 Subject: [PATCH] ipactl: pass api as argument to services Commit 6409abf1 removes hard dependency of ipalib in ipalatform to avoid cyclic dependenies, this commit updates ipactl accordingly --- install/tools/ipactl | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/install/tools/ipactl b/install/tools/ipactl index db8ff62..c34f1cb 100755 --- a/install/tools/ipactl +++ b/install/tools/ipactl @@ -244,7 +244,7 @@ def get_config_from_file(): def stop_services(svc_list): for svc in svc_list: -svc_off = services.service(svc) +svc_off = services.service(svc, api=api) try: svc_off.stop(capture_output=False) except Exception: @@ -303,7 +303,7 @@ def ipa_start(options): svc_list = deduplicate(svc_list) for svc in svc_list: -svchandle = services.service(svc) +svchandle = services.service(svc, api=api) try: print("Starting %s Service" % svc) svchandle.start(capture_output=get_capture_output(svc, options.debug)) @@ -343,7 +343,7 @@ def ipa_stop(options): svc_list = deduplicate(svc_list) for svc in reversed(svc_list): -svchandle = services.service(svc) +svchandle = services.service(svc, api=api) try: print("Stopping %s Service" % svc) svchandle.stop(capture_output=False) @@ -421,7 +421,7 @@ def ipa_restart(options): # we need to definitely stop some services old_svc_list = deduplicate(old_svc_list) for svc in reversed(old_svc_list): -svchandle = services.service(svc) +svchandle = services.service(svc, api=api) try: print("Stopping %s Service" % svc) svchandle.stop(capture_output=False) @@ -446,7 +446,7 @@ def ipa_restart(options): # there are services to restart svc_list = deduplicate(svc_list) for svc in svc_list: -svchandle = services.service(svc) +svchandle = services.service(svc
[Freeipa-devel] [freeipa PR#320][+ack] add missing attribute to ipaca replica during CA topology update
URL: https://github.com/freeipa/freeipa/pull/320 Title: #320: add missing attribute to ipaca replica during CA topology update Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#317][comment] Unify password generation across FreeIPA
URL: https://github.com/freeipa/freeipa/pull/317 Title: #317: Unify password generation across FreeIPA mbasti-rh commented: """ It generates random tokens than can be used as: - passwords - anything else that should be random It is written in class docstring Yes we can randomly generate strings for each class with specified length, then generate randomly the rest, and finally make order of characters random. However I'm not sure if this is from crypto point of view equal to generate random string at once and then check validity, there can be something we don't see, but probably not. """ See the full comment at https://github.com/freeipa/freeipa/pull/317#issuecomment-266041887 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#334][opened] Py3: Fix ToASCII method
URL: https://github.com/freeipa/freeipa/pull/334 Author: mbasti-rh Title: #334: Py3: Fix ToASCII method Action: opened PR body: """ in Py2 to_text method returns Py2 non-unicode string, but in Py3 to_text method returns Py3 default (unicode) string. So only in Py2 we have to decode str to unicode. https://fedorahosted.org/freeipa/ticket/5887 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/334/head:pr334 git checkout pr334 From 17c866c4b170f45a414a65a2dfc3bc85dbf3281c Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 14 Dec 2016 10:12:05 +0100 Subject: [PATCH] Py3: Fix ToASCII method in Py2 to_text method returns Py2 non-unicode string, but in Py3 to_text method returns Py3 default (unicode) string. So only in Py2 we have to decode str to unicode. https://fedorahosted.org/freeipa/ticket/5887 --- freeipa.spec.in | 20 ++-- ipapython/dnsutil.py | 5 - ipasetup.py.in | 2 +- 3 files changed, 15 insertions(+), 12 deletions(-) diff --git a/freeipa.spec.in b/freeipa.spec.in index fbb3945..73210b7 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -126,8 +126,8 @@ BuildRequires: python-memcached BuildRequires: python-lxml # 5.0.0: QRCode.print_ascii BuildRequires: python-qrcode-core >= 5.0.0 -# 1.13: python-dns URI record support -BuildRequires: python-dns >= 1.13 +# 1.15: python-dns PY3 support (many improvements) +BuildRequires: python-dns >= 1.15 BuildRequires: jsl BuildRequires: python-yubico # pki Python package @@ -163,8 +163,8 @@ BuildRequires: python3-memcached BuildRequires: python3-lxml # 5.0.0: QRCode.print_ascii BuildRequires: python3-qrcode-core >= 5.0.0 -# 1.13: python-dns URI record support -BuildRequires: python3-dns >= 1.13 +# 1.15: python-dns PY3 support (many improvements) +BuildRequires: python3-dns >= 1.15 BuildRequires: python3-yubico # pki Python package # 10.2.1: crypto.NSSCryptoProvider(password_file) @@ -294,7 +294,7 @@ Requires: python-gssapi >= 1.2.0 Requires: python-sssdconfig Requires: python-pyasn1 Requires: dbus-python -Requires: python-dns >= 1.13 +Requires: python-dns >= 1.15 Requires: python-kdcproxy >= 0.3 Requires: rpm-libs @@ -323,7 +323,7 @@ Requires: python3-gssapi >= 1.2.0 Requires: python3-sssdconfig Requires: python3-pyasn1 Requires: python3-dbus -Requires: python3-dns >= 1.11.1 +Requires: python3-dns >= 1.15 Requires: python3-kdcproxy >= 0.3 Requires: rpm-libs @@ -482,7 +482,7 @@ BuildArch: noarch Requires: %{name}-client-common = %{version}-%{release} Requires: %{name}-common = %{version}-%{release} Requires: python2-ipalib = %{version}-%{release} -Requires: python-dns >= 1.13 +Requires: python-dns >= 1.15 %description -n python2-ipaclient IPA is an integrated solution to provide centrally managed Identity (users, @@ -504,7 +504,7 @@ BuildArch: noarch Requires: %{name}-client-common = %{version}-%{release} Requires: %{name}-common = %{version}-%{release} Requires: python3-ipalib = %{version}-%{release} -Requires: python3-dns >= 1.11.1 +Requires: python3-dns >= 1.15 %description -n python3-ipaclient IPA is an integrated solution to provide centrally managed Identity (users, @@ -598,7 +598,7 @@ Requires: python-cffi Requires: python-ldap >= 2.4.15 Requires: python-requests Requires: python-custodia -Requires: python-dns >= 1.13 +Requires: python-dns >= 1.15 Requires: python-enum34 Requires: python-netifaces >= 0.10.4 Requires: pyusb @@ -648,7 +648,7 @@ Requires: python3-cffi Requires: python3-pyldap >= 2.4.15 Requires: python3-custodia Requires: python3-requests -Requires: python3-dns >= 1.11.1 +Requires: python3-dns >= 1.15 Requires: python3-netifaces >= 0.10.4 Requires: python3-pyusb diff --git a/ipapython/dnsutil.py b/ipapython/dnsutil.py index 16549c8..ba0f0aa 100644 --- a/ipapython/dnsutil.py +++ b/ipapython/dnsutil.py @@ -71,7 +71,10 @@ def __str__(self): def ToASCII(self): #method named by RFC 3490 and python standard library -return self.to_text().decode('ascii') # must be unicode string +res = self.to_text() +if six.PY2: +return res.decode('ascii') # must be unicode string in Python 2 +return res def canonicalize(self): return DNSName(super(DNSName, self).canonicalize()) diff --git a/ipasetup.py.in b/ipasetup.py.in index 6a33fb8..c221e0d 100644 --- a/ipasetup.py.in +++ b/ipasetup.py.in @@ -64,7 +64,7 @@ if SETUPTOOLS_VERSION < (8, 0, 0): PACKAGE_VERSION = { 'cryptography': 'cryptography >= 1.3.1', -'dnspython': 'dnspython >= 1.13', +'dnspython': 'dnspython >= 1.15', 'gssapi': 'gssapi >= 1.2.0', 'ipaclient': 'ipaclient == {}'.format(VERSION), 'ipalib': 'ipalib == {}'.format(VERSION), -- Manage your subscription for the Fre
[Freeipa-devel] [freeipa PR#333][comment] Remove named-pkcs11 workarounds from DNSSEC tests.
URL: https://github.com/freeipa/freeipa/pull/333 Title: #333: Remove named-pkcs11 workarounds from DNSSEC tests. mbasti-rh commented: """ Please fix the issue reported by pylint ``` * Module ipatests.test_integration.test_dnssec ipatests/test_integration/test_dnssec.py:9: [W0611(unused-import), ] Unused import pytest) ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/333#issuecomment-267000804 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#334][synchronized] Py3: Fix ToASCII method
URL: https://github.com/freeipa/freeipa/pull/334 Author: mbasti-rh Title: #334: Py3: Fix ToASCII method Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/334/head:pr334 git checkout pr334 From e5825f44dafc4fb96965fb90d2f0442846970a71 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 14 Dec 2016 10:12:05 +0100 Subject: [PATCH] Py3: Fix ToASCII method in Py2 to_text method returns Py2 non-unicode string, but in Py3 to_text method returns Py3 default (unicode) string. So only in Py2 we have to decode str to unicode. https://fedorahosted.org/freeipa/ticket/5935 --- freeipa.spec.in | 20 ++-- ipapython/dnsutil.py | 5 - ipasetup.py.in | 2 +- 3 files changed, 15 insertions(+), 12 deletions(-) diff --git a/freeipa.spec.in b/freeipa.spec.in index fbb3945..73210b7 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -126,8 +126,8 @@ BuildRequires: python-memcached BuildRequires: python-lxml # 5.0.0: QRCode.print_ascii BuildRequires: python-qrcode-core >= 5.0.0 -# 1.13: python-dns URI record support -BuildRequires: python-dns >= 1.13 +# 1.15: python-dns PY3 support (many improvements) +BuildRequires: python-dns >= 1.15 BuildRequires: jsl BuildRequires: python-yubico # pki Python package @@ -163,8 +163,8 @@ BuildRequires: python3-memcached BuildRequires: python3-lxml # 5.0.0: QRCode.print_ascii BuildRequires: python3-qrcode-core >= 5.0.0 -# 1.13: python-dns URI record support -BuildRequires: python3-dns >= 1.13 +# 1.15: python-dns PY3 support (many improvements) +BuildRequires: python3-dns >= 1.15 BuildRequires: python3-yubico # pki Python package # 10.2.1: crypto.NSSCryptoProvider(password_file) @@ -294,7 +294,7 @@ Requires: python-gssapi >= 1.2.0 Requires: python-sssdconfig Requires: python-pyasn1 Requires: dbus-python -Requires: python-dns >= 1.13 +Requires: python-dns >= 1.15 Requires: python-kdcproxy >= 0.3 Requires: rpm-libs @@ -323,7 +323,7 @@ Requires: python3-gssapi >= 1.2.0 Requires: python3-sssdconfig Requires: python3-pyasn1 Requires: python3-dbus -Requires: python3-dns >= 1.11.1 +Requires: python3-dns >= 1.15 Requires: python3-kdcproxy >= 0.3 Requires: rpm-libs @@ -482,7 +482,7 @@ BuildArch: noarch Requires: %{name}-client-common = %{version}-%{release} Requires: %{name}-common = %{version}-%{release} Requires: python2-ipalib = %{version}-%{release} -Requires: python-dns >= 1.13 +Requires: python-dns >= 1.15 %description -n python2-ipaclient IPA is an integrated solution to provide centrally managed Identity (users, @@ -504,7 +504,7 @@ BuildArch: noarch Requires: %{name}-client-common = %{version}-%{release} Requires: %{name}-common = %{version}-%{release} Requires: python3-ipalib = %{version}-%{release} -Requires: python3-dns >= 1.11.1 +Requires: python3-dns >= 1.15 %description -n python3-ipaclient IPA is an integrated solution to provide centrally managed Identity (users, @@ -598,7 +598,7 @@ Requires: python-cffi Requires: python-ldap >= 2.4.15 Requires: python-requests Requires: python-custodia -Requires: python-dns >= 1.13 +Requires: python-dns >= 1.15 Requires: python-enum34 Requires: python-netifaces >= 0.10.4 Requires: pyusb @@ -648,7 +648,7 @@ Requires: python3-cffi Requires: python3-pyldap >= 2.4.15 Requires: python3-custodia Requires: python3-requests -Requires: python3-dns >= 1.11.1 +Requires: python3-dns >= 1.15 Requires: python3-netifaces >= 0.10.4 Requires: python3-pyusb diff --git a/ipapython/dnsutil.py b/ipapython/dnsutil.py index 16549c8..ba0f0aa 100644 --- a/ipapython/dnsutil.py +++ b/ipapython/dnsutil.py @@ -71,7 +71,10 @@ def __str__(self): def ToASCII(self): #method named by RFC 3490 and python standard library -return self.to_text().decode('ascii') # must be unicode string +res = self.to_text() +if six.PY2: +return res.decode('ascii') # must be unicode string in Python 2 +return res def canonicalize(self): return DNSName(super(DNSName, self).canonicalize()) diff --git a/ipasetup.py.in b/ipasetup.py.in index 6a33fb8..c221e0d 100644 --- a/ipasetup.py.in +++ b/ipasetup.py.in @@ -64,7 +64,7 @@ if SETUPTOOLS_VERSION < (8, 0, 0): PACKAGE_VERSION = { 'cryptography': 'cryptography >= 1.3.1', -'dnspython': 'dnspython >= 1.13', +'dnspython': 'dnspython >= 1.15', 'gssapi': 'gssapi >= 1.2.0', 'ipaclient': 'ipaclient == {}'.format(VERSION), 'ipalib': 'ipalib == {}'.format(VERSION), -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#334][edited] Py3: Fix ToASCII method
URL: https://github.com/freeipa/freeipa/pull/334 Author: mbasti-rh Title: #334: Py3: Fix ToASCII method Action: edited Changed field: body Original value: """ in Py2 to_text method returns Py2 non-unicode string, but in Py3 to_text method returns Py3 default (unicode) string. So only in Py2 we have to decode str to unicode. https://fedorahosted.org/freeipa/ticket/5887 """ -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#329][+rejected] experiment: did pull/177 break ci?
URL: https://github.com/freeipa/freeipa/pull/329 Title: #329: experiment: did pull/177 break ci? Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#313][comment] ipaclient.plugins: Use api_version from internally called commands
URL: https://github.com/freeipa/freeipa/pull/313 Title: #313: ipaclient.plugins: Use api_version from internally called commands mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/d841a79dc104521f736469eff7154c2f4266082b ipa-4-4: https://fedorahosted.org/freeipa/changeset/6ef666ed12fd73026f0f1d49faba152ae27d6082 """ See the full comment at https://github.com/freeipa/freeipa/pull/313#issuecomment-267003891 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#313][+pushed] ipaclient.plugins: Use api_version from internally called commands
URL: https://github.com/freeipa/freeipa/pull/313 Title: #313: ipaclient.plugins: Use api_version from internally called commands Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#313][closed] ipaclient.plugins: Use api_version from internally called commands
URL: https://github.com/freeipa/freeipa/pull/313 Author: dkupka Title: #313: ipaclient.plugins: Use api_version from internally called commands Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/313/head:pr313 git checkout pr313 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#334][synchronized] Py3: Fix ToASCII method
URL: https://github.com/freeipa/freeipa/pull/334 Author: mbasti-rh Title: #334: Py3: Fix ToASCII method Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/334/head:pr334 git checkout pr334 From e5825f44dafc4fb96965fb90d2f0442846970a71 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 14 Dec 2016 10:12:05 +0100 Subject: [PATCH 1/2] Py3: Fix ToASCII method in Py2 to_text method returns Py2 non-unicode string, but in Py3 to_text method returns Py3 default (unicode) string. So only in Py2 we have to decode str to unicode. https://fedorahosted.org/freeipa/ticket/5935 --- freeipa.spec.in | 20 ++-- ipapython/dnsutil.py | 5 - ipasetup.py.in | 2 +- 3 files changed, 15 insertions(+), 12 deletions(-) diff --git a/freeipa.spec.in b/freeipa.spec.in index fbb3945..73210b7 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -126,8 +126,8 @@ BuildRequires: python-memcached BuildRequires: python-lxml # 5.0.0: QRCode.print_ascii BuildRequires: python-qrcode-core >= 5.0.0 -# 1.13: python-dns URI record support -BuildRequires: python-dns >= 1.13 +# 1.15: python-dns PY3 support (many improvements) +BuildRequires: python-dns >= 1.15 BuildRequires: jsl BuildRequires: python-yubico # pki Python package @@ -163,8 +163,8 @@ BuildRequires: python3-memcached BuildRequires: python3-lxml # 5.0.0: QRCode.print_ascii BuildRequires: python3-qrcode-core >= 5.0.0 -# 1.13: python-dns URI record support -BuildRequires: python3-dns >= 1.13 +# 1.15: python-dns PY3 support (many improvements) +BuildRequires: python3-dns >= 1.15 BuildRequires: python3-yubico # pki Python package # 10.2.1: crypto.NSSCryptoProvider(password_file) @@ -294,7 +294,7 @@ Requires: python-gssapi >= 1.2.0 Requires: python-sssdconfig Requires: python-pyasn1 Requires: dbus-python -Requires: python-dns >= 1.13 +Requires: python-dns >= 1.15 Requires: python-kdcproxy >= 0.3 Requires: rpm-libs @@ -323,7 +323,7 @@ Requires: python3-gssapi >= 1.2.0 Requires: python3-sssdconfig Requires: python3-pyasn1 Requires: python3-dbus -Requires: python3-dns >= 1.11.1 +Requires: python3-dns >= 1.15 Requires: python3-kdcproxy >= 0.3 Requires: rpm-libs @@ -482,7 +482,7 @@ BuildArch: noarch Requires: %{name}-client-common = %{version}-%{release} Requires: %{name}-common = %{version}-%{release} Requires: python2-ipalib = %{version}-%{release} -Requires: python-dns >= 1.13 +Requires: python-dns >= 1.15 %description -n python2-ipaclient IPA is an integrated solution to provide centrally managed Identity (users, @@ -504,7 +504,7 @@ BuildArch: noarch Requires: %{name}-client-common = %{version}-%{release} Requires: %{name}-common = %{version}-%{release} Requires: python3-ipalib = %{version}-%{release} -Requires: python3-dns >= 1.11.1 +Requires: python3-dns >= 1.15 %description -n python3-ipaclient IPA is an integrated solution to provide centrally managed Identity (users, @@ -598,7 +598,7 @@ Requires: python-cffi Requires: python-ldap >= 2.4.15 Requires: python-requests Requires: python-custodia -Requires: python-dns >= 1.13 +Requires: python-dns >= 1.15 Requires: python-enum34 Requires: python-netifaces >= 0.10.4 Requires: pyusb @@ -648,7 +648,7 @@ Requires: python3-cffi Requires: python3-pyldap >= 2.4.15 Requires: python3-custodia Requires: python3-requests -Requires: python3-dns >= 1.11.1 +Requires: python3-dns >= 1.15 Requires: python3-netifaces >= 0.10.4 Requires: python3-pyusb diff --git a/ipapython/dnsutil.py b/ipapython/dnsutil.py index 16549c8..ba0f0aa 100644 --- a/ipapython/dnsutil.py +++ b/ipapython/dnsutil.py @@ -71,7 +71,10 @@ def __str__(self): def ToASCII(self): #method named by RFC 3490 and python standard library -return self.to_text().decode('ascii') # must be unicode string +res = self.to_text() +if six.PY2: +return res.decode('ascii') # must be unicode string in Python 2 +return res def canonicalize(self): return DNSName(super(DNSName, self).canonicalize()) diff --git a/ipasetup.py.in b/ipasetup.py.in index 6a33fb8..c221e0d 100644 --- a/ipasetup.py.in +++ b/ipasetup.py.in @@ -64,7 +64,7 @@ if SETUPTOOLS_VERSION < (8, 0, 0): PACKAGE_VERSION = { 'cryptography': 'cryptography >= 1.3.1', -'dnspython': 'dnspython >= 1.13', +'dnspython': 'dnspython >= 1.15', 'gssapi': 'gssapi >= 1.2.0', 'ipaclient': 'ipaclient == {}'.format(VERSION), 'ipalib': 'ipalib == {}'.format(VERSION), From d110bd8fd42e1546f8c8de2fe755b482d1b2cfdd Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 14 Dec 2016 12:09:34 +0100 Subject: [PATCH 2/2] zonemgr_callback: py3 fix str and bytes cannot be concatenated in Py3 https://fedorahosted.org/freeipa/ticket/
[Freeipa-devel] [freeipa PR#335][+ack] Add compatibility code to retrieve headers
URL: https://github.com/freeipa/freeipa/pull/335 Title: #335: Add compatibility code to retrieve headers Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#335][comment] Add compatibility code to retrieve headers
URL: https://github.com/freeipa/freeipa/pull/335 Title: #335: Add compatibility code to retrieve headers mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/397f2be9dfd6475127742c0b710b37b443d97d67 """ See the full comment at https://github.com/freeipa/freeipa/pull/335#issuecomment-267088796 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#335][+pushed] Add compatibility code to retrieve headers
URL: https://github.com/freeipa/freeipa/pull/335 Title: #335: Add compatibility code to retrieve headers Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#335][closed] Add compatibility code to retrieve headers
URL: https://github.com/freeipa/freeipa/pull/335 Author: simo5 Title: #335: Add compatibility code to retrieve headers Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/335/head:pr335 git checkout pr335 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#344][edited] [4.4] password policy: Add explicit default password policy for hosts and services
URL: https://github.com/freeipa/freeipa/pull/344 Author: dkupka Title: #344: [4.4] password policy: Add explicit default password policy for hosts and services Action: edited Changed field: title Original value: """ password policy: Add explicit default password policy for hosts and services """ -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#341][+ack] certprofile-mod: correctly authorise config update
URL: https://github.com/freeipa/freeipa/pull/341 Title: #341: certprofile-mod: correctly authorise config update Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#341][+pushed] certprofile-mod: correctly authorise config update
URL: https://github.com/freeipa/freeipa/pull/341 Title: #341: certprofile-mod: correctly authorise config update Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#341][comment] certprofile-mod: correctly authorise config update
URL: https://github.com/freeipa/freeipa/pull/341 Title: #341: certprofile-mod: correctly authorise config update mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/fec4c32ff15a96736740cf7d2f713a21af0b227e ipa-4-4: https://fedorahosted.org/freeipa/changeset/c12a52f0d78b30931713a3548b22e799d41f3622 """ See the full comment at https://github.com/freeipa/freeipa/pull/341#issuecomment-267093122 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#341][closed] certprofile-mod: correctly authorise config update
URL: https://github.com/freeipa/freeipa/pull/341 Author: mbasti-rh Title: #341: certprofile-mod: correctly authorise config update Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/341/head:pr341 git checkout pr341 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#343][+ack] [4.3] certprofile-mod: correctly authorise config update
URL: https://github.com/freeipa/freeipa/pull/343 Title: #343: [4.3] certprofile-mod: correctly authorise config update Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#343][closed] [4.3] certprofile-mod: correctly authorise config update
URL: https://github.com/freeipa/freeipa/pull/343 Author: mbasti-rh Title: #343: [4.3] certprofile-mod: correctly authorise config update Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/343/head:pr343 git checkout pr343 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#343][+pushed] [4.3] certprofile-mod: correctly authorise config update
URL: https://github.com/freeipa/freeipa/pull/343 Title: #343: [4.3] certprofile-mod: correctly authorise config update Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#343][comment] [4.3] certprofile-mod: correctly authorise config update
URL: https://github.com/freeipa/freeipa/pull/343 Title: #343: [4.3] certprofile-mod: correctly authorise config update mbasti-rh commented: """ Fixed upstream ipa-4-3: https://fedorahosted.org/freeipa/changeset/278d7cf4708f1c6ac05d5fcb21db582d9aa7bab3 """ See the full comment at https://github.com/freeipa/freeipa/pull/343#issuecomment-267093601 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#339][edited] freeipa-4.4.3: update translations
URL: https://github.com/freeipa/freeipa/pull/339 Author: mbasti-rh Title: #339: freeipa-4.4.3: update translations Action: edited Changed field: body Original value: """ """ -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#336][comment] [py3] pki: add missing depedency pki-base[-python3]
URL: https://github.com/freeipa/freeipa/pull/336 Title: #336: [py3] pki: add missing depedency pki-base[-python3] mbasti-rh commented: """ It has Py3 Build dependency Fixed. """ See the full comment at https://github.com/freeipa/freeipa/pull/336#issuecomment-267355819 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#336][synchronized] [py3] pki: add missing depedency pki-base[-python3]
URL: https://github.com/freeipa/freeipa/pull/336 Author: mbasti-rh Title: #336: [py3] pki: add missing depedency pki-base[-python3] Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/336/head:pr336 git checkout pr336 From b07b23c34698e196c8b4d93291074943e2172632 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 14 Dec 2016 12:28:25 +0100 Subject: [PATCH] [py3]pki: add missing depedency pki-base[-python3] FreeIPA server modules requires pki module https://fedorahosted.org/freeipa/ticket/4985 --- freeipa.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/freeipa.spec.in b/freeipa.spec.in index fbb3945..10af7f6 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -297,6 +297,7 @@ Requires: dbus-python Requires: python-dns >= 1.13 Requires: python-kdcproxy >= 0.3 Requires: rpm-libs +Requires: pki-base >= 10.2.1 %description -n python2-ipaserver IPA is an integrated solution to provide centrally managed Identity (users, @@ -326,6 +327,7 @@ Requires: python3-dbus Requires: python3-dns >= 1.11.1 Requires: python3-kdcproxy >= 0.3 Requires: rpm-libs +Requires: pki-base-python3 >= 10.2.1 %description -n python3-ipaserver IPA is an integrated solution to provide centrally managed Identity (users, -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#336][comment] [py3] pki: add missing depedency pki-base[-python3]
URL: https://github.com/freeipa/freeipa/pull/336 Title: #336: [py3] pki: add missing depedency pki-base[-python3] mbasti-rh commented: """ Ah my previous patch was right then. BuildRequires version is lower because build works with lower version. I can raise that version just to be sure that pylint is checking the right packages """ See the full comment at https://github.com/freeipa/freeipa/pull/336#issuecomment-267362994 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#336][synchronized] [py3] pki: add missing depedency pki-base[-python3]
URL: https://github.com/freeipa/freeipa/pull/336 Author: mbasti-rh Title: #336: [py3] pki: add missing depedency pki-base[-python3] Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/336/head:pr336 git checkout pr336 From 2cb2b373337bc6822c4c923c585d79b41d5ad5bc Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 14 Dec 2016 12:28:25 +0100 Subject: [PATCH] [py3]pki: add missing depedency pki-base[-python3] FreeIPA server modules requires pki module Bump build requires versions to force pylint to check with the versions used after installation https://fedorahosted.org/freeipa/ticket/4985 --- freeipa.spec.in | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/freeipa.spec.in b/freeipa.spec.in index fbb3945..810b1f1 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -131,8 +131,8 @@ BuildRequires: python-dns >= 1.13 BuildRequires: jsl BuildRequires: python-yubico # pki Python package -# 10.2.1: crypto.NSSCryptoProvider(password_file) -BuildRequires: pki-base >= 10.2.1 +# 10.3.5-6: to check the version that is used after install with pylint +BuildRequires: pki-base >= 10.3.5-6 BuildRequires: python-pytest-multihost BuildRequires: python-pytest-sourceorder BuildRequires: python-jwcrypto @@ -167,8 +167,8 @@ BuildRequires: python3-qrcode-core >= 5.0.0 BuildRequires: python3-dns >= 1.13 BuildRequires: python3-yubico # pki Python package -# 10.2.1: crypto.NSSCryptoProvider(password_file) -BuildRequires: pki-base-python3 >= 10.2.1 +# 10.3.5-6: to check the version that is used after install with pylint +BuildRequires: pki-base-python3 >= 10.3.5-6 BuildRequires: python3-pytest-multihost BuildRequires: python3-pytest-sourceorder BuildRequires: python3-jwcrypto @@ -297,6 +297,7 @@ Requires: dbus-python Requires: python-dns >= 1.13 Requires: python-kdcproxy >= 0.3 Requires: rpm-libs +Requires: pki-base >= 10.3.5-6 %description -n python2-ipaserver IPA is an integrated solution to provide centrally managed Identity (users, @@ -326,6 +327,7 @@ Requires: python3-dbus Requires: python3-dns >= 1.11.1 Requires: python3-kdcproxy >= 0.3 Requires: rpm-libs +Requires: pki-base-python3 >= 10.3.5-6 %description -n python3-ipaserver IPA is an integrated solution to provide centrally managed Identity (users, -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#336][synchronized] [py3] pki: add missing depedency pki-base[-python3]
URL: https://github.com/freeipa/freeipa/pull/336 Author: mbasti-rh Title: #336: [py3] pki: add missing depedency pki-base[-python3] Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/336/head:pr336 git checkout pr336 From 2cb2b373337bc6822c4c923c585d79b41d5ad5bc Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Wed, 14 Dec 2016 12:28:25 +0100 Subject: [PATCH 1/2] [py3]pki: add missing depedency pki-base[-python3] FreeIPA server modules requires pki module Bump build requires versions to force pylint to check with the versions used after installation https://fedorahosted.org/freeipa/ticket/4985 --- freeipa.spec.in | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/freeipa.spec.in b/freeipa.spec.in index fbb3945..810b1f1 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -131,8 +131,8 @@ BuildRequires: python-dns >= 1.13 BuildRequires: jsl BuildRequires: python-yubico # pki Python package -# 10.2.1: crypto.NSSCryptoProvider(password_file) -BuildRequires: pki-base >= 10.2.1 +# 10.3.5-6: to check the version that is used after install with pylint +BuildRequires: pki-base >= 10.3.5-6 BuildRequires: python-pytest-multihost BuildRequires: python-pytest-sourceorder BuildRequires: python-jwcrypto @@ -167,8 +167,8 @@ BuildRequires: python3-qrcode-core >= 5.0.0 BuildRequires: python3-dns >= 1.13 BuildRequires: python3-yubico # pki Python package -# 10.2.1: crypto.NSSCryptoProvider(password_file) -BuildRequires: pki-base-python3 >= 10.2.1 +# 10.3.5-6: to check the version that is used after install with pylint +BuildRequires: pki-base-python3 >= 10.3.5-6 BuildRequires: python3-pytest-multihost BuildRequires: python3-pytest-sourceorder BuildRequires: python3-jwcrypto @@ -297,6 +297,7 @@ Requires: dbus-python Requires: python-dns >= 1.13 Requires: python-kdcproxy >= 0.3 Requires: rpm-libs +Requires: pki-base >= 10.3.5-6 %description -n python2-ipaserver IPA is an integrated solution to provide centrally managed Identity (users, @@ -326,6 +327,7 @@ Requires: python3-dbus Requires: python3-dns >= 1.11.1 Requires: python3-kdcproxy >= 0.3 Requires: rpm-libs +Requires: pki-base-python3 >= 10.3.5-6 %description -n python3-ipaserver IPA is an integrated solution to provide centrally managed Identity (users, From 7ca86fbacfc9b753190aba2232f074f074cdae50 Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Thu, 15 Dec 2016 17:20:35 +0100 Subject: [PATCH 2/2] pki-base: use pki-base-python2 as dependency pki-base provides pki-base-python2, but we should depend directly on pki-base-python2 because in future pki-base may provide pki-base-python3 instead. Source: chei...@redhat.com https://fedorahosted.org/freeipa/ticket/4985 --- freeipa.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/freeipa.spec.in b/freeipa.spec.in index 810b1f1..0efc6bc 100644 --- a/freeipa.spec.in +++ b/freeipa.spec.in @@ -132,7 +132,7 @@ BuildRequires: jsl BuildRequires: python-yubico # pki Python package # 10.3.5-6: to check the version that is used after install with pylint -BuildRequires: pki-base >= 10.3.5-6 +BuildRequires: pki-base-python2 >= 10.3.5-6 BuildRequires: python-pytest-multihost BuildRequires: python-pytest-sourceorder BuildRequires: python-jwcrypto @@ -297,7 +297,7 @@ Requires: dbus-python Requires: python-dns >= 1.13 Requires: python-kdcproxy >= 0.3 Requires: rpm-libs -Requires: pki-base >= 10.3.5-6 +Requires: pki-base-python2 >= 10.3.5-6 %description -n python2-ipaserver IPA is an integrated solution to provide centrally managed Identity (users, -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code