[Freeipa-devel] [freeipa PR#181][+ack] Tests : User Tracker creation of user with minimal values

2016-12-15 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org

[Freeipa-devel] [freeipa PR#210][+ack] Tests: Stage User Tracker implementation

2016-12-15 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/210 Title: #210: Tests: Stage User Tracker implementation Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2016-12-06 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values mirielka commented: """ Please check inline comments. Also suggestion for more test cases: - try to create a user whose automatically generated uid would b

[Freeipa-devel] [freeipa PR#310][opened] WIP: CLI testing

2016-12-06 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/310 Author: mirielka Title: #310: WIP: CLI testing Action: opened PR body: """ Here is basic part of CLI testing for you to take a look at and provide feedback, before it's all done and polished up. How it works: so far it

[Freeipa-devel] [freeipa PR#294][comment] client, platform: Use paths.SSH* instead of get_config_dir().

2016-12-01 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/294 Title: #294: client, platform: Use paths.SSH* instead of get_config_dir(). mirielka commented: """ Build passes fine, pep8 does not: ./ipaclient/install/client.py:1006:80: E501 line too long (82 > 79 characters) ./ipaclient/inst

[Freeipa-devel] [freeipa PR#242][opened] [master] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/242 Author: mirielka Title: #242: [master] Tests: Providing trust tests with tree root domain Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6347 Note: This PR is rebased version of https://github.com/freeipa/f

[Freeipa-devel] [freeipa PR#119][edited] [ipa-4-4] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/119 Author: mirielka Title: #119: [ipa-4-4] Tests: Providing trust tests with tree root domain Action: edited Changed field: title Original value: """ Tests: Providing trust tests with tree root domain """ -- Ma

[Freeipa-devel] [freeipa PR#240][opened] Document make_delete_command method in UserTracker

2016-11-14 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/240 Author: mirielka Title: #240: Document make_delete_command method in UserTracker Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6485 """ To pull the PR as Git branch: git remote add ghfree

[Freeipa-devel] [freeipa PR#224][+ack] Integration tests for certs in idoverrides

2016-11-14 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/224 Title: #224: Integration tests for certs in idoverrides Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribut

[Freeipa-devel] [freeipa PR#210][comment] Tests: Stage User Tracker implementation

2016-11-13 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/210 Title: #210: Tests: Stage User Tracker implementation mirielka commented: """ Review notes: same as in https://github.com/freeipa/freeipa/pull/181 """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2016-11-13 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values mirielka commented: """ Having "None" default values for obligatory arguments does not seem to be a good idea. If the method was called with default

[Freeipa-devel] [freeipa PR#224][comment] Integration tests for certs in idoverrides

2016-11-10 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/224 Title: #224: Integration tests for certs in idoverrides mirielka commented: """ Functionally OK. Please extend commit message for the first commit and add links to tickets if applicable. Also ticket https://fedorahosted.org/free

[Freeipa-devel] [freeipa PR#208][edited] Tests: Fix integration sudo test

2016-11-02 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/208 Author: mirielka Title: #208: Tests: Fix integration sudo test Action: edited Changed field: body Original value: """ Tests with sudorules using only RunAsGroups attributes with empty RunAsUsers attribute fail due to different

[Freeipa-devel] [freeipa PR#208][opened] Tests: Fix integration sudo test

2016-11-02 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/208 Author: mirielka Title: #208: Tests: Fix integration sudo test Action: opened PR body: """ Tests with sudorules using only RunAsGroups attributes with empty RunAsUsers attribute fail due to different expected value than is really

[Freeipa-devel] [freeipa PR#194][opened] Tests: Verify that validity info is present in cert-show and cert-find command

2016-10-26 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/194 Author: mirielka Title: #194: Tests: Verify that validity info is present in cert-show and cert-find command Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6419 """ To pull the PR as Git br

[Freeipa-devel] [freeipa PR#181][comment] Tests : User Tracker creation of user with minimal values

2016-10-24 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/181 Title: #181: Tests : User Tracker creation of user with minimal values mirielka commented: """ The same minimal values apply for stageuser-add command, can you please modify the stageuser tracker as well? Also adding testcases fo

[Freeipa-devel] [freeipa PR#183][comment] Add __name__ == __main__ guards to setup.pys

2016-10-24 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/183 Title: #183: Add __name__ == __main__ guards to setup.pys mirielka commented: """ Thanks, this fixes setup.py related failure in intree tests. """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#165][comment] Tests: Verify that cert-find show CA without --all

2016-10-18 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/165 Title: #165: Tests: Verify that cert-find show CA without --all mirielka commented: """ Sorry for that, I created new ticket and changed commit message. """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#165][synchronized] Tests: Verify that cert-find show CA without --all

2016-10-18 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/165 Author: mirielka Title: #165: Tests: Verify that cert-find show CA without --all Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/165/head:pr165 git checkout

[Freeipa-devel] [freeipa PR#165][comment] Tests: Verify that cert-find show CA without --all

2016-10-17 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/165 Title: #165: Tests: Verify that cert-find show CA without --all mirielka commented: """ I added check for cert-show and cert-request (it was quite easy to add it to existing test). I'd prefer to add test for #6022 separ

[Freeipa-devel] [freeipa PR#165][synchronized] Tests: Verify that cert-find show CA without --all

2016-10-17 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/165 Author: mirielka Title: #165: Tests: Verify that cert-find show CA without --all Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/165/head:pr165 git checkout

[Freeipa-devel] [freeipa PR#165][synchronized] Tests: Verify that cert-find show CA without --all

2016-10-17 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/165 Author: mirielka Title: #165: Tests: Verify that cert-find show CA without --all Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/165/head:pr165 git checkout

[Freeipa-devel] [freeipa PR#165][opened] Tests: Verify that cert-find show CA without --all

2016-10-14 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/165 Author: mirielka Title: #165: Tests: Verify that cert-find show CA without --all Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6151 """ To pull the PR as Git branch: git remote add ghfree

[Freeipa-devel] [freeipa PR#164][comment] Trust AD cleanup

2016-10-14 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/164 Title: #164: Trust AD cleanup mirielka commented: """ Thanks for suggestion, I added separate commit for this. """ See the full comment at https://github.com/freeipa/freeipa/pull/164#issuecomment-253735992 -- Ma

[Freeipa-devel] [freeipa PR#164][synchronized] Trust AD cleanup

2016-10-14 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/164 Author: mirielka Title: #164: Trust AD cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/164/head:pr164 git checkout pr164 From

[Freeipa-devel] [freeipa PR#164][synchronized] Trust AD cleanup

2016-10-13 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/164 Author: mirielka Title: #164: Trust AD cleanup Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/164/head:pr164 git checkout pr164 From

[Freeipa-devel] [freeipa PR#164][opened] Trust AD cleanup

2016-10-13 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/164 Author: mirielka Title: #164: Trust AD cleanup Action: opened PR body: """ Adding operations that remove test related trust information from AD machines. Package samba-client is necessary for this operation, hence tests are

[Freeipa-devel] [freeipa PR#154][opened] [ipa-4-4] Rebase: Tests: Fix cert revocation tests

2016-10-12 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/154 Author: mirielka Title: #154: [ipa-4-4] Rebase: Tests: Fix cert revocation tests Action: opened PR body: """ """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch

[Freeipa-devel] [freeipa PR#140][synchronized] Tests: Remove invalid certplugin tests

2016-10-11 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/140 Author: mirielka Title: #140: Tests: Remove invalid certplugin tests Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/140/head:pr140 git checkout pr140 From

[Freeipa-devel] [freeipa PR#140][comment] Tests: Remove invalid certplugin tests

2016-10-06 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/140 Title: #140: Tests: Remove invalid certplugin tests mirielka commented: """ Ok, I will do it like Ales proposed and will sync this PR when new tests are ready. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#141][opened] Tests: Fix failing test_ipalib/test_parameters

2016-10-06 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/141 Author: mirielka Title: #141: Tests: Fix failing test_ipalib/test_parameters Action: opened PR body: """ Parameters test fails because of KeyError caused by improper manipulation with kwargs in Param.__init__ method. During ini

[Freeipa-devel] [freeipa PR#140][comment] Tests: Remove invalid certplugin tests

2016-10-06 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/140 Title: #140: Tests: Remove invalid certplugin tests mirielka commented: """ Hi, I discussed this with Rob who authored the tests and he said that these tests were there just as a kind of checking that no extra revoked certificates

[Freeipa-devel] [freeipa PR#140][opened] Tests: Remove invalid certplugin tests

2016-10-05 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/140 Author: mirielka Title: #140: Tests: Remove invalid certplugin tests Action: opened PR body: """ A bunch of certplugin tests were testing number of revoked certificates with various revocation reasons. Since existence of revok

[Freeipa-devel] [freeipa PR#129][+ack] Fix test_util.test_assert_deepequal test

2016-10-03 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/129 Title: #129: Fix test_util.test_assert_deepequal test Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/

[Freeipa-devel] [freeipa PR#123][opened] Tests: Remove silent deleting and creating entries by tracker

2016-09-27 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/123 Author: mirielka Title: #123: Tests: Remove silent deleting and creating entries by tracker Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6123 """ To pull the PR as Git branch: git remote ad

[Freeipa-devel] [freeipa PR#119][opened] Tests: Providing trust tests with tree root domain

2016-09-26 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/119 Author: mirielka Title: #119: Tests: Providing trust tests with tree root domain Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6347 """ To pull the PR as Git branch: git remote add ghfree

[Freeipa-devel] [freeipa PR#110][+ack] test_text: add test ipa.pot file for tests

2016-09-26 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/110 Title: #110: test_text: add test ipa.pot file for tests Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribut

[Freeipa-devel] [freeipa PR#99][opened] Tests: Remove --force options from tracker base class

2016-09-20 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/99 Author: mirielka Title: #99: Tests: Remove --force options from tracker base class Action: opened PR body: """ Removing --force option from tracker base class so it would not be required to be implemented in every specific track

[Freeipa-devel] [freeipa PR#95][opened] Tests: Remove unnecessary attributes from base tracker

2016-09-20 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/95 Author: mirielka Title: #95: Tests: Remove unnecessary attributes from base tracker Action: opened PR body: """ https://fedorahosted.org/freeipa/ticket/6128 """ To pull the PR as Git branch: git remote add ghfree

[Freeipa-devel] [freeipa PR#93][opened] Tests: Remove SSSD restart from integration tests

2016-09-20 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/93 Author: mirielka Title: #93: Tests: Remove SSSD restart from integration tests Action: opened PR body: """ SSSD restart has been mistakenly added to integration tests (test_integration/tasks.py::uninstall_master). When system s

[Freeipa-devel] [freeipa PR#77][synchronized] Tests: Update host test with ipa-join

2016-09-20 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/77 Author: mirielka Title: #77: Tests: Update host test with ipa-join Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/77/head:pr77 git checkout pr77 From

[Freeipa-devel] [freeipa PR#86][comment] Made sssd restart a non-raising opration

2016-09-19 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/86 Title: #86: Made sssd restart a non-raising opration mirielka commented: """ Hi, so sorry about this, but the necessity of sssd restart was caused by some leftover mess on the machines where I ran the trust related tests. If the c

[Freeipa-devel] [freeipa PR#77] Tests: Update host test with ipa-join (opened)

2016-09-13 Thread mirielka
mirielka's pull request #77: "Tests: Update host test with ipa-join" was opened PR body: """ Updating path to ipa-join command to allow execution of test_xmlrpc/test_host::TestHostFalsePwdChange::test_join_host. Fixing discrepancies in returned and checked attributes. https://fedorahosted.org/fre

[Freeipa-devel] [freeipa PR#75] Tests: Remove usage of krb5 ccache from test_ipaserver/test_ldap (opened)

2016-09-13 Thread mirielka
mirielka's pull request #75: "Tests: Remove usage of krb5 ccache from test_ipaserver/test_ldap" was opened PR body: """ In test_ipaserver/test_ldap::test_ldap::test_GSSAPI a krb5 ccache is used to connect to ldap. The test tries to locate this cache in /tmp/krb5cc_$UID file, which is not there du

[Freeipa-devel] [freeipa PR#74] [master, ipa-4-4] Tests: Add krb5kdc.service restart to integration trust tests (opened)

2016-09-12 Thread mirielka
mirielka's pull request #74: "[master, ipa-4-4] Tests: Add krb5kdc.service restart to integration trust tests" was opened PR body: """ krb5kdc.service restart is necessary for proper running of integration trust related tests. https://fedorahosted.org/freeipa/ticket/6322 """ See the full pull-r

[Freeipa-devel] [freeipa PR#70] [master, ipa-4-4] Tests: Fix failing ldap.backend test (edited)

2016-09-09 Thread mirielka
mirielka's pull request #70: "[master, ipa-4-4] Tests: Fix failing ldap.backend test" was edited See the full pull-request at https://github.com/freeipa/freeipa/pull/70 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/70/head:p

[Freeipa-devel] [freeipa PR#70] [Tests: Fix failing ldap.backend test (opened)

2016-09-09 Thread mirielka
mirielka's pull request #70: "[Tests: Fix failing ldap.backend test" was opened PR body: """ Test ipatests/test_ipaserver/test_ldap::test_Backend fails claiming service cannot be found. Fixing this by not using api with in_tree parameter. https://fedorahosted.org/freeipa/ticket/6312 """ See the

[Freeipa-devel] [freeipa PR#60] Tests: extend DNS cmdline tests with lowercased record type (+ack)

2016-09-07 Thread mirielka
mbasti-rh's pull request #60: "Tests: extend DNS cmdline tests with lowercased record type" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/60 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/f

[Freeipa-devel] [freeipa PR#66] [master, ipa-4-4] Tests: Add cleanup to integration trust tests (opened)

2016-09-07 Thread mirielka
mirielka's pull request #66: "[master, ipa-4-4] Tests: Add cleanup to integration trust tests" was opened PR body: """ Trust tests fail if they are executed after external trust tests. This is caused my missing cleanup. Providing cleanup that would enable correct execution of the tests regardless

[Freeipa-devel] [freeipa PR#43] Tests: Fix regex errors in integration trust tests (synchronize)

2016-09-07 Thread mirielka
mirielka's pull request #43: "Tests: Fix regex errors in integration trust tests" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/43 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/43/head:

[Freeipa-devel] [freeipa PR#43] Tests: Fix regex errors in integration trust tests (synchronize)

2016-09-05 Thread mirielka
mirielka's pull request #43: "Tests: Fix regex errors in integration trust tests" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/43 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/43/head:

[Freeipa-devel] [freeipa PR#43] Tests: Fix regex errors in integration trust tests (synchronize)

2016-09-02 Thread mirielka
mirielka's pull request #43: "Tests: Fix regex errors in integration trust tests" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/43 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/43/head:

[Freeipa-devel] [freeipa PR#51] Fix failing negative tests for deprecated params (+ack)

2016-09-02 Thread mirielka
martbab's pull request #51: "Fix failing negative tests for deprecated params" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/51 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#44] rpcserver: fix crash in XML-RPC system commands (+ack)

2016-09-01 Thread mirielka
jcholast's pull request #44: "rpcserver: fix crash in XML-RPC system commands" label *ack* has been added See the full pull-request at https://github.com/freeipa/freeipa/pull/44 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [freeipa PR#42] Tests: Avoid skipping tests due to missing files (synchronize)

2016-09-01 Thread mirielka
mirielka's pull request #42: "Tests: Avoid skipping tests due to missing files" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/42 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/42/head:pr

[Freeipa-devel] [freeipa PR#42] Tests: Avoid skipping tests due to missing files (comment)

2016-08-31 Thread mirielka
mirielka commented on a pull request """ So far these tests were skipped in outoftree jobs because they could not find the requested files. The reason is that intree the tests are run from parent directory of ipatests directory, whereas outoftree tests run from ipatests d

[Freeipa-devel] [freeipa PR#43] Tests: Fix regex errors in integration trust tests (opened)

2016-08-31 Thread mirielka
mirielka's pull request #43: "Tests: Fix regex errors in integration trust tests" was opened PR body: """ In integration trust tests some values are checked using regular expressions. Some of these expressions from recently added coverage have minor mistakes which causes the comparisons to fail.

[Freeipa-devel] [freeipa PR#42] Tests: Avoid skipping tests due to missing files (opened)

2016-08-31 Thread mirielka
mirielka's pull request #42: "Tests: Avoid skipping tests due to missing files" was opened PR body: """ When running test_install/test_updates and test_pkcs10/test_pkcs10 as outoftree, these are skipped with reason 'Unable to find test update files'. For outoftree tests wrong paths are checked fo

[Freeipa-devel] [freeipa PR#39] Tests: Add missing attributes to test_xmlrpc/test_trust tests (opened)

2016-08-30 Thread mirielka
mirielka's pull request #39: "Tests: Add missing attributes to test_xmlrpc/test_trust tests" was opened PR body: """ Several tests in test_xmlrpc/test_trust_plugin.py fail because some attributes are not expected. Fixing the tests so that the extra attributes are recognized. https://fedorahosted

[Freeipa-devel] [freeipa PR#27] [master, ipa-4-3] Tests: Fix integration sudo tests setup and checks (synchronize)

2016-08-29 Thread mirielka
mirielka's pull request #27: "[master, ipa-4-3] Tests: Fix integration sudo tests setup and checks" was synchronize See the full pull-request at https://github.com/freeipa/freeipa/pull/27 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfre

[Freeipa-devel] [freeipa PR#27] [master, ipa-4-3] Tests: Fix integration sudo tests setup and checks (comment)

2016-08-29 Thread mirielka
mirielka commented on a pull request """ Yes, I also though about not running e.g. `su -c "sudo -l" testuser` but `su -c "sudo -l -n" testuser` - it would report error `sudo: a password is required` instead of the previously pasted message that doesn't sa

[Freeipa-devel] [freeipa PR#27] [master, ipa-4-3] Tests: Fix integration sudo tests setup and checks (comment)

2016-08-29 Thread mirielka
mirielka commented on a pull request """ This PR is not intended to fix a failing test, but fix their execution and error checking. The negative tests for sudorule in master and ipa-4-3 (both with sssd-1.14.1-1.fc24, see jenkins jobs for master [1] and ipa-4-3 [2]) return fo

[Freeipa-devel] [freeipa PR#27] Tests: Fix integration sudo tests setup and checks (edited)

2016-08-26 Thread mirielka
mirielka's pull request #27: "Tests: Fix integration sudo tests setup and checks" was edited See the full pull-request at https://github.com/freeipa/freeipa/pull/27 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/27/head:pr27

[Freeipa-devel] [freeipa PR#27] Tests: Fix integration sudo tests setup and checks (opened)

2016-08-26 Thread mirielka
mirielka's pull request #27: "Tests: Fix integration sudo tests setup and checks" was opened PR body: """ Adding 'defaults' sudorule to prevent requesting further user authentication. Adding checks that if a user should be rejected access, a proper error message is displayed. https://fedorahoste

[Freeipa-devel] [freeipa PR#24] [master, ipa-4-3] Raise error when running ipa-adtrust-install with empty netbios--name (opened)

2016-08-25 Thread mirielka
mirielka's pull request #24: "[master, ipa-4-3] Raise error when running ipa-adtrust-install with empty netbios--name" was opened PR body: """ When running ipa-adtrust-install, a netbios-name option must be specified. Currently if an invalid netbios name in form of empty string is specified, the

[Freeipa-devel] [freeipa PR#24] [master, ipa-4-3] Raise error when running ipa-adtrust-install with empty netbios--name (edited)

2016-08-25 Thread mirielka
mirielka's pull request #24: "[master, ipa-4-3] Raise error when running ipa-adtrust-install with empty netbios--name" was edited See the full pull-request at https://github.com/freeipa/freeipa/pull/24 ... or pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa g

[Freeipa-devel] [freeipa PR#17] Tests: Random issuer certificate can be added to a service (opened)

2016-08-24 Thread mirielka
mirielka's pull request #17: "Tests: Random issuer certificate can be added to a service" was opened PR body: """ Changing negative test case that verified that a certificate with different than expected issuer cannot be added to a service to a positive one that verifies that this operation now p

[Freeipa-devel] [freeipa PR#14] Tests: Failing intree tests (opened)

2016-08-23 Thread mirielka
mirielka's pull request #14: "Tests: Failing intree tests" was opened PR body: Fixing failing tests in: test_ipalib/test_plugable test_ipalib/test_rpc test_ipaserver/test_ldap All issues were discussed with Jan Cholasta and are results of thin client implementation. See the full pull-request at