Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0072-rights-check.patch

2010-11-03 Thread Endi Sukma Dewata
On 11/1/2010 9:28 AM, Adam Young wrote: Check effective rights. If the right is not explicitly allowed, show the field as read only. It seems to be working, but I think it has to wait until the attributelevelrights is returned in the JSON response because without it the UI would become

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0072-rights-check.patch

2010-11-03 Thread Endi Sukma Dewata
On 11/3/2010 8:53 AM, Adam Young wrote: Still NACK. I have tested this again. It looks like the UI does not send the --rights parameter which is required to get the attributelevelrights. With this patch even the admin can't edit anything. Ah...that was because I did it as two commits, and only

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0072-rights-check.patch

2010-11-03 Thread Adam Young
On 11/03/2010 12:55 PM, Endi Sukma Dewata wrote: On 11/3/2010 8:53 AM, Adam Young wrote: Still NACK. I have tested this again. It looks like the UI does not send the --rights parameter which is required to get the attributelevelrights. With this patch even the admin can't edit anything.

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0072-rights-check.patch

2010-11-03 Thread Endi Sukma Dewata
On 11/3/2010 2:50 PM, Adam Young wrote: Now defaulting to rscwo, which means that some fields will show up editable even if the user can't change them, due to effectiverights not being returned on all fields. Could you rebase it against the latest in master? The patch cannot be applied.

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0072-rights-check.patch

2010-11-01 Thread Adam Young
On 10/29/2010 09:31 PM, Endi Sukma Dewata wrote: On 10/29/2010 2:50 PM, Adam Young wrote: Check effective rights. If the right is not explicitly allowed, show the field as read only. It seems to be working, but I think it has to wait until the attributelevelrights is returned in the JSON

Re: [Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0072-rights-check.patch

2010-10-29 Thread Endi Sukma Dewata
On 10/29/2010 2:50 PM, Adam Young wrote: Check effective rights. If the right is not explicitly allowed, show the field as read only. It seems to be working, but I think it has to wait until the attributelevelrights is returned in the JSON response because without it the UI would become