Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Martin Basti
On 13/03/15 11:55, Petr Spacek wrote: On 13.3.2015 11:34, Jan Cholasta wrote: Dne 13.3.2015 v 11:17 Martin Kosek napsal(a): On 03/13/2015 11:00 AM, Petr Spacek wrote: On 13.3.2015 10:42, Alexander Bokovoy wrote: On Fri, 13 Mar 2015, Petr Spacek wrote: On 13.3.2015 10:18, Martin Kosek wrote:

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Martin Kosek
On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test mode. This patch is a workaround, to

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Petr Spacek
On 13.3.2015 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Alexander Bokovoy
On Fri, 13 Mar 2015, Petr Spacek wrote: On 13.3.2015 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Petr Spacek
On 13.3.2015 10:42, Alexander Bokovoy wrote: On Fri, 13 Mar 2015, Petr Spacek wrote: On 13.3.2015 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Martin Kosek
On 03/13/2015 11:00 AM, Petr Spacek wrote: On 13.3.2015 10:42, Alexander Bokovoy wrote: On Fri, 13 Mar 2015, Petr Spacek wrote: On 13.3.2015 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Petr Spacek
On 13.3.2015 11:34, Jan Cholasta wrote: Dne 13.3.2015 v 11:17 Martin Kosek napsal(a): On 03/13/2015 11:00 AM, Petr Spacek wrote: On 13.3.2015 10:42, Alexander Bokovoy wrote: On Fri, 13 Mar 2015, Petr Spacek wrote: On 13.3.2015 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Jan Cholasta
Dne 13.3.2015 v 11:17 Martin Kosek napsal(a): On 03/13/2015 11:00 AM, Petr Spacek wrote: On 13.3.2015 10:42, Alexander Bokovoy wrote: On Fri, 13 Mar 2015, Petr Spacek wrote: On 13.3.2015 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Martin Basti
On 13/03/15 12:50, Jan Cholasta wrote: Dne 13.3.2015 v 12:08 Petr Spacek napsal(a): On 13.3.2015 12:01, Martin Basti wrote: On 13/03/15 11:55, Petr Spacek wrote: On 13.3.2015 11:34, Jan Cholasta wrote: Dne 13.3.2015 v 11:17 Martin Kosek napsal(a): On 03/13/2015 11:00 AM, Petr Spacek wrote:

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Martin Basti
On 13/03/15 10:18, Martin Kosek wrote: On 03/12/2015 05:10 PM, Rob Crittenden wrote: Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-13 Thread Rob Crittenden
Jan Cholasta wrote: Dne 13.3.2015 v 12:08 Petr Spacek napsal(a): On 13.3.2015 12:01, Martin Basti wrote: On 13/03/15 11:55, Petr Spacek wrote: On 13.3.2015 11:34, Jan Cholasta wrote: Dne 13.3.2015 v 11:17 Martin Kosek napsal(a): On 03/13/2015 11:00 AM, Petr Spacek wrote: On 13.3.2015 10:42,

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-12 Thread David Kupka
On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test mode. This patch is a workaround, to ensure update with --test option will not modify any LDAP data. https://fedorahosted.org/freeipa/ticket/3448 Patch attached.

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-12 Thread Petr Spacek
On 12.3.2015 17:05, Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test mode. This patch is a workaround, to ensure update with --test

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-12 Thread Rob Crittenden
David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test mode. This patch is a workaround, to ensure update with --test option will not modify any LDAP data. https://fedorahosted.org/freeipa/ticket/3448

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-12 Thread Rob Crittenden
Petr Spacek wrote: On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test mode. This patch is a workaround, to ensure update with --test option will not modify

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-12 Thread Petr Spacek
On 12.3.2015 16:23, Rob Crittenden wrote: David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test mode. This patch is a workaround, to ensure update with --test option will not modify any LDAP data.

[Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-06 Thread Martin Basti
Upgrade plugins which modify LDAP data directly should not be executed in --test mode. This patch is a workaround, to ensure update with --test option will not modify any LDAP data. https://fedorahosted.org/freeipa/ticket/3448 Patch attached. -- Martin Basti From