Re: [Freeipa-devel] [PATCH, slapi-nis] ID view-related patches to slapi-nis
On 29.10.2014 15:20, thierry bordaz wrote: On 10/29/2014 02:23 PM, Alexander Bokovoy wrote: On Wed, 29 Oct 2014, thierry bordaz wrote: The patches fixed the test case in https://bugzilla.redhat.com/show_bug.cgi?id=1157989. Hi Alexander, The patches are good to me. Ack thanks thierry was pushed to master: * https://git.fedorahosted.org/cgit/slapi-nis.git/commit/?id=778c95866f28d894822e37223b69816981d29529 * https://git.fedorahosted.org/cgit/slapi-nis.git/commit/?id=c9c9d1413a6950344bc842024fda84212cc7322f part of slapi-nis-0.54.1 -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH, slapi-nis] ID view-related patches to slapi-nis
On 10/28/2014 10:11 PM, Alexander Bokovoy wrote: Hi, two patches to slapi-nis are attached: - make sure only DNs from the schema-compat trees are targeted for ID view replacement. This solves issue of https://bugzilla.redhat.com/show_bug.cgi?id=1157989 found by Sumit. - support ID overrides in the BIND callback. So far the only thing we need is overriding uid. They need to be applied in this order, on top of 0.54 release version of slapi-nis. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Hi Alexander, The patches fixed the test case in https://bugzilla.redhat.com/show_bug.cgi?id=1157989. Few comments regarding the patch: * in backend_search_cb, it checks if the search is in one of the container. We need that cbdata.answer=FALSE at the end of the checking. Why not setting it systematically at the end. * in backend_locate, 'target' is a duplicate of cbdata.target. But then when calling idview_replace_target_dn it may be changed. Will not it lead to a leak ? Thanks thierry ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH, slapi-nis] ID view-related patches to slapi-nis
On 10/29/2014 02:23 PM, Alexander Bokovoy wrote: On Wed, 29 Oct 2014, thierry bordaz wrote: The patches fixed the test case in https://bugzilla.redhat.com/show_bug.cgi?id=1157989. Few comments regarding the patch: * in backend_search_cb, it checks if the search is in one of the container. We need that cbdata.answer=FALSE at the end of the checking. Why not setting it systematically at the end. I've moved it to the end of the block. * in backend_locate, 'target' is a duplicate of cbdata.target. But then when calling idview_replace_target_dn it may be changed. Will not it lead to a leak ? Good catch, thanks! Fixed version attached. Hi Alexander, The patches are good to me. Ack thanks thierry ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
