Re: [Freeipa-devel] [PATCHES 0442-0449] Pylint: sunday code cleanup

2016-03-22 Thread Martin Basti
On 21.03.2016 16:52, Petr Spacek wrote: On 21.3.2016 13:50, Lukas Slebodnik wrote: On (21/03/16 12:30), Martin Basti wrote: On 21.03.2016 10:33, Christian Heimes wrote: On 2016-03-21 10:29, Petr Spacek wrote: On 20.3.2016 21:56, Martin Basti wrote: Patches attached. I do not really like

Re: [Freeipa-devel] [PATCHES 0442-0449] Pylint: sunday code cleanup

2016-03-21 Thread Petr Spacek
On 21.3.2016 13:50, Lukas Slebodnik wrote: > On (21/03/16 12:30), Martin Basti wrote: >> On 21.03.2016 10:33, Christian Heimes wrote: >>> On 2016-03-21 10:29, Petr Spacek wrote: On 20.3.2016 21:56, Martin Basti wrote: > Patches attached. I do not really like

Re: [Freeipa-devel] [PATCHES 0442-0449] Pylint: sunday code cleanup

2016-03-21 Thread Lukas Slebodnik
On (21/03/16 12:30), Martin Basti wrote: >On 21.03.2016 10:33, Christian Heimes wrote: >>On 2016-03-21 10:29, Petr Spacek wrote: >>>On 20.3.2016 21:56, Martin Basti wrote: Patches attached. >>>I do not really like >>>freeipa-mbasti-0442-pylint-remove-bare-except >>>because it replaces most of

Re: [Freeipa-devel] [PATCHES 0442-0449] Pylint: sunday code cleanup

2016-03-21 Thread Martin Basti
On 21.03.2016 10:33, Christian Heimes wrote: On 2016-03-21 10:29, Petr Spacek wrote: On 20.3.2016 21:56, Martin Basti wrote: Patches attached. I do not really like freeipa-mbasti-0442-pylint-remove-bare-except because it replaces most of try: ... except: with try: ... except Exception:

Re: [Freeipa-devel] [PATCHES 0442-0449] Pylint: sunday code cleanup

2016-03-21 Thread Christian Heimes
On 2016-03-21 10:29, Petr Spacek wrote: > On 20.3.2016 21:56, Martin Basti wrote: >> Patches attached. > > I do not really like > freeipa-mbasti-0442-pylint-remove-bare-except > because it replaces most of > > try: ... except: > > with > > try: ... except Exception: > > > which AFAIK does

Re: [Freeipa-devel] [PATCHES 0442-0449] Pylint: sunday code cleanup

2016-03-21 Thread Petr Spacek
On 20.3.2016 21:56, Martin Basti wrote: > Patches attached. I do not really like freeipa-mbasti-0442-pylint-remove-bare-except because it replaces most of try: ... except: with try: ... except Exception: which AFAIK does not add any value. It would be better to replace Exception with more