Re: [Freeipa-devel] [PATCH] 0001 (update 2) provide more information for "ipa cert-revoke -h"

2016-06-02 Thread Martin Basti 



On 06.05.2016 14:45, Martin Basti wrote:




On 04.05.2016 14:30, Gabe Alford wrote:
On Wed, May 4, 2016 at 1:35 AM, Patrice Duc-Jacquet 
 wrote:


Hi everyone

this is a second update that take into account review feedback.

In case the proposal fix is K what are the next step to commit
this change. I'm not sure to really understand the process.
Thanks and regards


If the fix is good, you receive an ack and a core member of the 
FreeIPA team will take your ack'ed patch and push it to the official 
git repository.


ACK from me

Gabe

Pat


--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code




Hello, I agree with ACk, but I cannot apply the patch using git am -3, 
can you please send rebased version?


Martin^2



I rebased patch

Pushed to master: deb896768f395dc535ad72715bad4339c97a6a8b

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0001 (update 2) provide more information for "ipa cert-revoke -h"

2016-05-17 Thread Gabe Alford 
Patrice,

Can you please send rebased version of this patch?

Thanks,

Gabe

On Fri, May 6, 2016 at 6:45 AM, Martin Basti  wrote:

>
>
> On 04.05.2016 14:30, Gabe Alford wrote:
>
> On Wed, May 4, 2016 at 1:35 AM, Patrice Duc-Jacquet < 
> patdu...@gmail.com> wrote:
>
>> Hi everyone
>>
>> this is a second update that take into account review feedback.
>>
>> In case the proposal fix is K what are the next step to commit this
>> change. I'm not sure to really understand the process. Thanks and regards
>>
>
> If the fix is good, you receive an ack and a core member of the FreeIPA
> team will take your ack'ed patch and push it to the official git repository.
>
> ACK from me
>
> Gabe
>
> Pat
>>
>>
>> --
>> Manage your subscription for the Freeipa-devel mailing list:
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>> Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
>>
>
>
>
> Hello, I agree with ACk, but I cannot apply the patch using git am -3, can
> you please send rebased version?
>
> Martin^2
>
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0001 (update 2) provide more information for "ipa cert-revoke -h"

2016-05-06 Thread Martin Basti 



On 04.05.2016 14:30, Gabe Alford wrote:
On Wed, May 4, 2016 at 1:35 AM, Patrice Duc-Jacquet 
> wrote:


Hi everyone

this is a second update that take into account review feedback.

In case the proposal fix is K what are the next step to commit
this change. I'm not sure to really understand the process. Thanks
and regards


If the fix is good, you receive an ack and a core member of the 
FreeIPA team will take your ack'ed patch and push it to the official 
git repository.


ACK from me

Gabe

Pat


--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code




Hello, I agree with ACk, but I cannot apply the patch using git am -3, 
can you please send rebased version?


Martin^2
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0001 (update 2) provide more information for "ipa cert-revoke -h"

2016-05-04 Thread Gabe Alford 
On Wed, May 4, 2016 at 1:35 AM, Patrice Duc-Jacquet 
wrote:

> Hi everyone
>
> this is a second update that take into account review feedback.
>
> In case the proposal fix is K what are the next step to commit this
> change. I'm not sure to really understand the process. Thanks and regards
>

If the fix is good, you receive an ack and a core member of the FreeIPA
team will take your ack'ed patch and push it to the official git repository.

ACK from me

Gabe

Pat
>
>
> --
> Manage your subscription for the Freeipa-devel mailing list:
> https://www.redhat.com/mailman/listinfo/freeipa-devel
> Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
>
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH] 0001 (update 2) provide more information for "ipa cert-revoke -h"

2016-05-04 Thread Patrice Duc-Jacquet 

Hi everyone

this is a second update that take into account review feedback.

In case the proposal fix is K what are the next step to commit this 
change. I'm not sure to really understand the process. Thanks and regards


Pat

>From 0a2b0da4a1f2c517fae392ae3314796c0ebeee9a Mon Sep 17 00:00:00 2001
From: Patrice Duc-Jacquet 
Date: Wed, 4 May 2016 09:25:57 +0200
Subject: [PATCH] Add more information regarding where to find revocation
 reason in "ipa cert_revoke -h" and "ipa cert_find -h". According to review
 feedback, I changed the help message as follow

$ ipa cert_revoke -h
Usage: ipa [global-options] cert-revoke SERIAL-NUMBER [options]

Revoke a certificate.
Options:
  -h, --helpshow this help message and exit
  --revocation-reason=INT
Reason for revoking the certificate (0-10). Type "ipa
help cert" for revocation reason details.

https://fedorahosted.org/freeipa/ticket/5819
---
 ipalib/plugins/cert.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ipalib/plugins/cert.py b/ipalib/plugins/cert.py
index 4dc51c2bf81546766193c0d28f0dc47239a3910c..820069cb06407565c3593201dfe49452e6588a2e 100644
--- a/ipalib/plugins/cert.py
+++ b/ipalib/plugins/cert.py
@@ -665,7 +665,7 @@ class cert_revoke(VirtualCommand):
 takes_options = (
 Int('revocation_reason',
 label=_('Reason'),
-doc=_('Reason for revoking the certificate (0-10). See RFC 5280 (paragraph 5.3.1) for reason details'),
+doc=_('Reason for revoking the certificate (0-10). Type "ipa help cert" for revocation reason details.'),
 minvalue=0,
 maxvalue=10,
 default=0,
@@ -733,7 +733,7 @@ class cert_find(Command):
 ),
 Int('revocation_reason?',
 label=_('Reason'),
-doc=_('Reason for revoking the certificate (0-10). See RFC 5280 (paragraph 5.3.1) for reason details'),
+doc=_('Reason for revoking the certificate (0-10). Type "ipa help cert" for revocation reason details.'),
 minvalue=0,
 maxvalue=10,
 autofill=False,
-- 
2.5.0

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code