Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-11-29 Thread Endi Sukma Dewata
On 11/29/2011 9:17 AM, Simo Sorce wrote: I couldn't find a clear ACK for this patch but it has been pushed as well. Correct. Guys please try to better report on the list when patches are pushed and close the thread. Yes, sorry, sometimes I missed a few, my fault. -- Endi S. Dewata ___

Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-11-29 Thread Simo Sorce
I couldn't find a clear ACK for this patch but it has been pushed as well. Guys please try to better report on the list when patches are pushed and close the thread. Simo. On Thu, 2011-09-29 at 14:52 +0200, Petr Vobornik wrote: > On 09/27/2011 10:54 PM, Endi Sukma Dewata wrote: > > On 9/27/2011

Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-09-29 Thread Petr Vobornik
On 09/27/2011 10:54 PM, Endi Sukma Dewata wrote: On 9/27/2011 7:50 AM, Petr Vobornik wrote: I've added padding and unified font-weight in error-message style. The padding is added because text of the message was right on the border which wasn't much readable. Font-weight is added because sometim

Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-09-27 Thread Endi Sukma Dewata
On 9/27/2011 7:50 AM, Petr Vobornik wrote: I've added padding and unified font-weight in error-message style. The padding is added because text of the message was right on the border which wasn't much readable. Font-weight is added because sometimes it inherits font-weight from other style and so

Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-09-27 Thread Petr Vobornik
On 09/15/2011 01:51 AM, Endi Sukma Dewata wrote: On 9/14/2011 7:23 AM, Petr Vobornik wrote: Forgot to update tests - to address newly added validation row in table_widget. One issue, in all search and association facets we now have 2 rows of footer (there are 2 horizontal lines at the bottom).

Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-09-14 Thread Endi Sukma Dewata
On 9/14/2011 7:23 AM, Petr Vobornik wrote: Forgot to update tests - to address newly added validation row in table_widget. One issue, in all search and association facets we now have 2 rows of footer (there are 2 horizontal lines at the bottom). I think it would be better to use a single row

Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-09-14 Thread Petr Vobornik
Forgot to update tests - to address newly added validation row in table_widget. -- Petr Vobornik From 40382df3620607760e8a6033b93b178d149f9ed4 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Wed, 14 Sep 2011 13:01:25 +0200 Subject: [PATCH] Fixed: Some widgets do not have space for validatio