Re: [Freeipa-devel] [PATCH] HBAC details page enhancement

2010-11-15 Thread Adam Young
On 11/13/2010 11:14 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/107/ The HBAC details page has been enhanced to support Undo and Reset operations. The functionality is implemented in the base widget class so the behavior

Re: [Freeipa-devel] [PATCH] HBAC details page enhancement

2010-11-15 Thread Adam Young
On 11/15/2010 11:00 AM, Adam Young wrote: On 11/15/2010 10:58 AM, Adam Young wrote: On 11/13/2010 11:14 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! https://fedorahosted.org/reviewboard/r/107/ The HBAC details page has been enhanced to support Undo and Reset

Re: [Freeipa-devel] [PATCH] HBAC details page enhancement

2010-11-15 Thread Endi Sukma Dewata
On 11/15/2010 11:47 AM, Adam Young wrote: ACK Thanks. Pushed a new rebase to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] HBAC Details Page

2010-11-03 Thread Adam Young
On 11/03/2010 08:30 AM, Endi Sukma Dewata wrote: On 11/1/2010 12:35 PM, Adam Young wrote: NACK, based on the templating issues we discussed on the phone. TO lay out the issues for other people reading: we previously had a framework like what Endi is proposing here. We found that importing HTML

Re: [Freeipa-devel] [PATCH] HBAC Details Page

2010-11-03 Thread Adam Young
On 11/03/2010 10:48 AM, Adam Young wrote: On 11/03/2010 08:30 AM, Endi Sukma Dewata wrote: On 11/1/2010 12:35 PM, Adam Young wrote: NACK, based on the templating issues we discussed on the phone. TO lay out the issues for other people reading: we previously had a framework like what Endi is

Re: [Freeipa-devel] [PATCH] HBAC Details Page

2010-11-03 Thread Endi Sukma Dewata
On 11/3/2010 10:09 AM, Adam Young wrote: A few questions (and tweaks). Note that I have just given the code a read through, not applied the patch yet. Are you sure we want to implement our own Theme code? I'd rather try to keep theme stuff as part of JQUery.UI. At a mionimum, we risk name clash

Re: [Freeipa-devel] [PATCH] HBAC Details Page

2010-11-03 Thread Adam Young
On 11/03/2010 02:43 PM, Endi Sukma Dewata wrote: On 11/3/2010 10:09 AM, Adam Young wrote: A few questions (and tweaks). Note that I have just given the code a read through, not applied the patch yet. Are you sure we want to implement our own Theme code? I'd rather try to keep theme stuff as