Re: [Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Adam Young
On 11/08/2010 09:04 PM, Endi Sukma Dewata wrote: On 11/8/2010 5:44 PM, Endi Sukma Dewata wrote: The functionality works, but there are some issues: 1. The JSON files contain some trailing whitespaces. 2. The server seems to be using "true" and "False" for nsaccountlock value. So it might be s

Re: [Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Endi Sukma Dewata
On 11/8/2010 5:44 PM, Endi Sukma Dewata wrote: The functionality works, but there are some issues: 1. The JSON files contain some trailing whitespaces. 2. The server seems to be using "true" and "False" for nsaccountlock value. So it might be safer to use case-insensitive comparison or normali

Re: [Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Adam Young
On 11/08/2010 06:44 PM, Endi Sukma Dewata wrote: On 11/8/2010 12:01 PM, Adam Young wrote: The functionality works, but there are some issues: 1. The JSON files contain some trailing whitespaces. 2. The server seems to be using "true" and "False" for nsaccountlock value. So it might be safe

Re: [Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Endi Sukma Dewata
On 11/8/2010 12:01 PM, Adam Young wrote: The functionality works, but there are some issues: 1. The JSON files contain some trailing whitespaces. 2. The server seems to be using "true" and "False" for nsaccountlock value. So it might be safer to use case-insensitive comparison or normalize

[Freeipa-devel] [PATCH] admiyo-0077-Disable-Enable-user

2010-11-08 Thread Adam Young
From 321c0afc7d0998ce120c9c68bb20e4f3672c0c68 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 8 Nov 2010 12:57:16 -0500 Subject: [PATCH] Disable Enable user UI updated to use the enable and disable methods, and to correctly report them Implementation has a few shortcomings: 1. Status is d