On 11/28/2013 04:59 PM, Nathaniel McCallum wrote:
Everything looks good to me. +1
Pushed to master: a1f32fa9369109235dba041de9c972da09d8448a
--
Petr³
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
Everything looks good to me. +1
On Thu, 2013-11-28 at 12:18 +0100, Petr Viktorin wrote:
Thanks!
Just a bit of cleaning up now, sending a patch with proposed changes to
speed things up.
Patch needs a tiny rebase.
Points I missed:
- There are some unused imports.
- ValidationError takes
On 11/21/2013 09:54 PM, Dmitri Pal wrote:
On 11/21/2013 01:34 PM, Nathaniel McCallum wrote:
The password can be retrieved with radiusproxy-show --all, because it is
not blocked by LDAP ACIs. Is that intended?
Yes. But I'm torn as to whether or not this is a good idea. Regular
users can't see
Sorry for the late review!
On 11/21/2013 07:34 PM, Nathaniel McCallum wrote:
On Fri, 2013-11-15 at 12:34 +0100, Petr Viktorin wrote:
The password can be retrieved with radiusproxy-show --all, because it is
not blocked by LDAP ACIs. Is that intended?
Yes. But I'm torn as to whether or not
On Thu, 2013-11-21 at 15:54 -0500, Dmitri Pal wrote:
On 11/21/2013 01:34 PM, Nathaniel McCallum wrote:
The password can be retrieved with radiusproxy-show --all, because it is
not blocked by LDAP ACIs. Is that intended?
Yes. But I'm torn as to whether or not this is a good idea. Regular
On Wed, 2013-11-27 at 14:34 +, Simo Sorce wrote:
On Thu, 2013-11-21 at 15:54 -0500, Dmitri Pal wrote:
On 11/21/2013 01:34 PM, Nathaniel McCallum wrote:
The password can be retrieved with radiusproxy-show --all, because it is
not blocked by LDAP ACIs. Is that intended?
Yes. But
On Wed, 2013-11-27 at 15:12 -0500, Nathaniel McCallum wrote:
On Wed, 2013-11-27 at 14:34 +, Simo Sorce wrote:
On Thu, 2013-11-21 at 15:54 -0500, Dmitri Pal wrote:
On 11/21/2013 01:34 PM, Nathaniel McCallum wrote:
The password can be retrieved with radiusproxy-show --all, because it
On Wed, 2013-11-27 at 12:28 +0100, Petr Viktorin wrote:
ipatokenradiusserver is not validated. See validate_searchtimelimit in
the config plugin for an example validator. You can use validate_ipaddr
and validate_hostname from ipalib.util.
Fixed.
Now the validation is too strict, a
On Fri, 2013-11-15 at 12:34 +0100, Petr Viktorin wrote:
On 11/12/2013 12:17 AM, Nathaniel McCallum wrote:
On Fri, 2013-11-08 at 13:26 +0100, Petr Viktorin wrote:
On 09/25/2013 10:56 PM, Nathaniel McCallum wrote:
On Fri, 2013-09-20 at 12:38 -0400, Nathaniel McCallum wrote:
On Thu,
On 11/21/2013 01:34 PM, Nathaniel McCallum wrote:
The password can be retrieved with radiusproxy-show --all, because it is
not blocked by LDAP ACIs. Is that intended?
Yes. But I'm torn as to whether or not this is a good idea. Regular
users can't see radius proxy servers at all. Admins can
On 11/15/2013 12:34 PM, Petr Viktorin wrote:
On 11/12/2013 12:17 AM, Nathaniel McCallum wrote:
On Fri, 2013-11-08 at 13:26 +0100, Petr Viktorin wrote:
We've since decided that we'll carry LDAP content updates only in
update files, so you can leave indices.ldif referint-conf.ldif
unchanged.
On 11/12/2013 12:17 AM, Nathaniel McCallum wrote:
On Fri, 2013-11-08 at 13:26 +0100, Petr Viktorin wrote:
On 09/25/2013 10:56 PM, Nathaniel McCallum wrote:
On Fri, 2013-09-20 at 12:38 -0400, Nathaniel McCallum wrote:
On Thu, 2013-09-12 at 16:48 -0400, Nathaniel McCallum wrote:
On Thu,
On Fri, 2013-11-08 at 13:26 +0100, Petr Viktorin wrote:
On 09/25/2013 10:56 PM, Nathaniel McCallum wrote:
On Fri, 2013-09-20 at 12:38 -0400, Nathaniel McCallum wrote:
On Thu, 2013-09-12 at 16:48 -0400, Nathaniel McCallum wrote:
On Thu, 2013-09-05 at 00:06 -0400, Nathaniel McCallum wrote:
On Fri, 2013-09-20 at 12:38 -0400, Nathaniel McCallum wrote:
On Thu, 2013-09-12 at 16:48 -0400, Nathaniel McCallum wrote:
On Thu, 2013-09-05 at 00:06 -0400, Nathaniel McCallum wrote:
patch attached
Update for ./makeapi attached.
Version 3. This should fix all the current review
On 09/20/2013 09:38 AM, Nathaniel McCallum wrote:
On Thu, 2013-09-12 at 16:48 -0400, Nathaniel McCallum wrote:
On Thu, 2013-09-05 at 00:06 -0400, Nathaniel McCallum wrote:
patch attached
Update for ./makeapi attached.
Version 3. This should fix all the current review issues, including the
On Thu, 2013-09-12 at 16:48 -0400, Nathaniel McCallum wrote:
On Thu, 2013-09-05 at 00:06 -0400, Nathaniel McCallum wrote:
patch attached
Update for ./makeapi attached.
Version 3. This should fix all the current review issues, including the
use of the referential integrity plugin. I had to
On 13.9.2013 09:21, Jan Cholasta wrote:
Hi,
On 12.9.2013 22:48, Nathaniel McCallum wrote:
On Thu, 2013-09-05 at 00:06 -0400, Nathaniel McCallum wrote:
patch attached
Update for ./makeapi attached.
+if 'ipatokenradiusconfiglink' in entry_attrs:
+cl =
Hi,
On 12.9.2013 22:48, Nathaniel McCallum wrote:
On Thu, 2013-09-05 at 00:06 -0400, Nathaniel McCallum wrote:
patch attached
Update for ./makeapi attached.
+if 'ipatokenradiusconfiglink' in entry_attrs:
+cl = entry_attrs['ipatokenradiusconfiglink']
+if not
On 09/05/2013 12:29 AM, Nathaniel McCallum wrote:
I forgot to mention that this code ignores the design page in one area:
radius-show does not list the users attached to this server. How
important is this? user-find --radius=MyRADIUSServer should find all the
users.
Nathaniel
I forgot to mention that this code ignores the design page in one area:
radius-show does not list the users attached to this server. How
important is this? user-find --radius=MyRADIUSServer should find all the
users.
Nathaniel
___
Freeipa-devel mailing
20 matches
Mail list logo
