Re: [Freeipa-devel] [PATCH 0416][WIP] fix broken configuration of sidgen and extdom plugins

2016-02-19 Thread Alexander Bokovoy
On Fri, 19 Feb 2016, Martin Kosek wrote: On 02/19/2016 03:14 PM, Alexander Bokovoy wrote: On Fri, 19 Feb 2016, Martin Kosek wrote: Why trust-add? I'm not a big fan of cluttering existing commands(find, show, mod) with logic to fix one upgrade bug. But I understand a need to communicate it some

Re: [Freeipa-devel] [PATCH 0416][WIP] fix broken configuration of sidgen and extdom plugins

2016-02-19 Thread Martin Kosek
On 02/19/2016 03:14 PM, Alexander Bokovoy wrote: > On Fri, 19 Feb 2016, Martin Kosek wrote: Why trust-add? I'm not a big fan of cluttering existing commands(find, show, mod) with logic to fix one upgrade bug. But I understand a need to communicate it somehow. Wou

Re: [Freeipa-devel] [PATCH 0416][WIP] fix broken configuration of sidgen and extdom plugins

2016-02-19 Thread Alexander Bokovoy
On Fri, 19 Feb 2016, Martin Kosek wrote: Why trust-add? I'm not a big fan of cluttering existing commands(find, show, mod) with logic to fix one upgrade bug. But I understand a need to communicate it somehow. Would it make sense to move such logic to a separate command, e.g. trust-check/trust-v

Re: [Freeipa-devel] [PATCH 0416][WIP] fix broken configuration of sidgen and extdom plugins

2016-02-19 Thread Martin Kosek
On 02/19/2016 03:02 PM, Alexander Bokovoy wrote: > On Fri, 19 Feb 2016, Petr Vobornik wrote: >> On 02/19/2016 11:12 AM, Alexander Bokovoy wrote: >>> On Fri, 19 Feb 2016, Martin Basti wrote: WIP patch attached https://fedorahosted.org/freeipa/ticket/5665 >>> Comments inline. >>>

Re: [Freeipa-devel] [PATCH 0416][WIP] fix broken configuration of sidgen and extdom plugins

2016-02-19 Thread Alexander Bokovoy
On Fri, 19 Feb 2016, Petr Vobornik wrote: On 02/19/2016 11:12 AM, Alexander Bokovoy wrote: On Fri, 19 Feb 2016, Martin Basti wrote: WIP patch attached https://fedorahosted.org/freeipa/ticket/5665 Comments inline. +# we need to run sidgen task +sidgen_task_dn = DN("cn=sidgen

Re: [Freeipa-devel] [PATCH 0416][WIP] fix broken configuration of sidgen and extdom plugins

2016-02-19 Thread Petr Vobornik
On 02/19/2016 11:12 AM, Alexander Bokovoy wrote: On Fri, 19 Feb 2016, Martin Basti wrote: WIP patch attached https://fedorahosted.org/freeipa/ticket/5665 Comments inline. +# we need to run sidgen task +sidgen_task_dn = DN("cn=sidgen,cn=ipa-sidgen-task,cn=tasks," +

Re: [Freeipa-devel] [PATCH 0416][WIP] fix broken configuration of sidgen and extdom plugins

2016-02-19 Thread Alexander Bokovoy
On Fri, 19 Feb 2016, Martin Basti wrote: WIP patch attached https://fedorahosted.org/freeipa/ticket/5665 Comments inline. +# we need to run sidgen task +sidgen_task_dn = DN("cn=sidgen,cn=ipa-sidgen-task,cn=tasks," +"cn=config") +sidgen_task

[Freeipa-devel] [PATCH 0416][WIP] fix broken configuration of sidgen and extdom plugins

2016-02-19 Thread Martin Basti
WIP patch attached https://fedorahosted.org/freeipa/ticket/5665 From e576e73acdee6c5db15017b9c73bdeb3aaede534 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Thu, 18 Feb 2016 19:59:50 +0100 Subject: [PATCH] WIP: fix upgrade sidgen and extdom --- install/updates/90-post_upgrade_plugins.updat