Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-16 Thread Martin Kosek
On Fri, 2012-04-13 at 14:42 -0400, John Dennis wrote: On 04/13/2012 07:53 AM, Martin Kosek wrote: On Thu, 2012-04-12 at 10:03 -0400, John Dennis wrote: On 04/12/2012 04:17 AM, Martin Kosek wrote: On Wed, 2012-04-11 at 22:05 -0400, John Dennis wrote: Revised patch attached. We'll leave the

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-13 Thread Martin Kosek
On Thu, 2012-04-12 at 10:03 -0400, John Dennis wrote: On 04/12/2012 04:17 AM, Martin Kosek wrote: On Wed, 2012-04-11 at 22:05 -0400, John Dennis wrote: Revised patch attached. We'll leave the DN parameter changes till later. This is essentially the same as the original patch with the

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-13 Thread John Dennis
On 04/13/2012 07:53 AM, Martin Kosek wrote: On Thu, 2012-04-12 at 10:03 -0400, John Dennis wrote: On 04/12/2012 04:17 AM, Martin Kosek wrote: On Wed, 2012-04-11 at 22:05 -0400, John Dennis wrote: Revised patch attached. We'll leave the DN parameter changes till later. This is essentially the

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-12 Thread Martin Kosek
On Wed, 2012-04-11 at 22:05 -0400, John Dennis wrote: Revised patch attached. We'll leave the DN parameter changes till later. This is essentially the same as the original patch with the addition of the fixes necessary to support passing an empty container arg, an issue Martin discovered in

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-12 Thread John Dennis
On 04/12/2012 04:17 AM, Martin Kosek wrote: On Wed, 2012-04-11 at 22:05 -0400, John Dennis wrote: Revised patch attached. We'll leave the DN parameter changes till later. This is essentially the same as the original patch with the addition of the fixes necessary to support passing an empty

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-11 Thread John Dennis
Revised patch attached. We'll leave the DN parameter changes till later. This is essentially the same as the original patch with the addition of the fixes necessary to support passing an empty container arg, an issue Martin discovered in his review. FWIW the answer was not to make the param

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-10 Thread John Dennis
On 04/06/2012 10:11 AM, John Dennis wrote: On 04/06/2012 04:40 AM, Martin Kosek wrote: 1) We still crash when the parameter is empty. We may want to make it required (the same fix Rob did for cert rejection reason): # echo secret123 | ipa migrate-ds ldap://vm-054.idm.lab.bos.redhat.com

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-10 Thread Jan Cholasta
On 10.4.2012 17:03, John Dennis wrote: On 04/06/2012 10:11 AM, John Dennis wrote: On 04/06/2012 04:40 AM, Martin Kosek wrote: 1) We still crash when the parameter is empty. We may want to make it required (the same fix Rob did for cert rejection reason): # echo secret123 | ipa migrate-ds

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-10 Thread Martin Kosek
On Tue, 2012-04-10 at 11:03 -0400, John Dennis wrote: On 04/06/2012 10:11 AM, John Dennis wrote: On 04/06/2012 04:40 AM, Martin Kosek wrote: 1) We still crash when the parameter is empty. We may want to make it required (the same fix Rob did for cert rejection reason): # echo secret123

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-06 Thread Martin Kosek
On Thu, 2012-04-05 at 21:26 -0400, John Dennis wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel 1) We still crash when the parameter is empty. We may want to make it required (the

Re: [Freeipa-devel] [PATCH 72] Validate DN RDN parameters for migrate command

2012-04-06 Thread John Dennis
On 04/06/2012 04:40 AM, Martin Kosek wrote: 1) We still crash when the parameter is empty. We may want to make it required (the same fix Rob did for cert rejection reason): # echo secret123 | ipa migrate-ds ldap://vm-054.idm.lab.bos.redhat.com --with-compat --base-dn=dc=greyoak,dc=com