Re: [Freeipa-devel] [PATCHES] 198-202 Refactor indirect membership processing

2013-11-27 Thread Petr Viktorin
On 11/25/2013 03:27 PM, Jan Cholasta wrote: On 8.11.2013 17:56, Petr Viktorin wrote: Patch 198: Also update ipaldap's find_entries docstring, it no longer uses IPA defaults. Done. While you're touching this part of code, I had some other improvements in mind -- you can consider them: In

Re: [Freeipa-devel] [PATCHES] 198-202 Refactor indirect membership processing

2013-11-25 Thread Jan Cholasta
On 8.11.2013 17:56, Petr Viktorin wrote: Patch 198: Also update ipaldap's find_entries docstring, it no longer uses IPA defaults. Done. While you're touching this part of code, I had some other improvements in mind -- you can consider them: In find_entries, attrs_list = [a.lower()

Re: [Freeipa-devel] [PATCHES] 198-202 Refactor indirect membership processing

2013-11-08 Thread Petr Viktorin
On 10/31/2013 02:45 PM, Jan Cholasta wrote: Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/3971. Tested with 25000 users. Honza Patch 198: Also update ipaldap's find_entries docstring, it no longer uses IPA defaults. While you're touching this part of code, I had

Re: [Freeipa-devel] [PATCHES] 198-202 Refactor indirect membership processing

2013-11-08 Thread Petr Viktorin
I hid Send by mistake; continuing review: On 11/08/2013 03:14 PM, Petr Viktorin wrote: On 10/31/2013 02:45 PM, Jan Cholasta wrote: Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/3971. Tested with 25000 users. Honza Patch 198: Also update ipaldap's find_entries

[Freeipa-devel] [PATCHES] 198-202 Refactor indirect membership processing

2013-10-31 Thread Jan Cholasta
Hi, the attached patches fix https://fedorahosted.org/freeipa/ticket/3971. Tested with 25000 users. Honza -- Jan Cholasta From e4b1880a7159377fe9996d9353edce80d495e051 Mon Sep 17 00:00:00 2001 From: Jan Cholasta jchol...@redhat.com Date: Thu, 31 Oct 2013 11:47:53 + Subject: [PATCH 1/5]