URL: https://github.com/freeipa/freeipa/pull/134
Title: #134: DNS URI support
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/f363dfbeed7aeba51d694a60b29389d94c7bda44
https://fedorahosted.org/freeipa/changeset/bf96b80200c3e8d1795a913db4e0222ea558e609
URL: https://github.com/freeipa/freeipa/pull/134
Title: #134: DNS URI support
pspacek commented:
"""
I thought that messing with API numbers in VERSION is not be necessary anymore
after we introduced thin client. @jcholast ?
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/134
Title: #134: DNS URI support
mbasti-rh commented:
"""
I'm so sorry, I didn't noticed earlier, but you forgot to bump API in VERSION
Otherwise LGTM and works for me
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/134
Title: #134: DNS URI support
pspacek commented:
"""
I was playing with an idea of automatic escaping but it cannot be done with
current record format: There is no way to distinguish alredy escaped text from
a text which needs escaping. This
URL: https://github.com/freeipa/freeipa/pull/134
Title: #134: DNS URI support
mbasti-rh commented:
"""
I was able to add an invalid URI record
```
[root@vm-058-017 ~]# ipa dnsrecord-add test.zone. --uri-rec='0 0 trolo"lo'
Record name: test2
Record name: test2
URI record: 0 0 "trolo"lo"
URL: https://github.com/freeipa/freeipa/pull/134
Title: #134: DNS URI support
mbasti-rh commented:
"""
NACK, please see inline comments
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/134#issuecomment-251916849
--
Manage your subscription for the Freeipa-devel mailing
URL: https://github.com/freeipa/freeipa/pull/134
Title: #134: DNS URI support
mbasti-rh commented:
"""
jslint failed please fix it (you can leave pep8 as is, to be consistent with
current code)
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/134#issuecomment-251467798
--
