URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules
pvomacka commented:
"""
ipa-4-5:
* 28db6cd40100c6301121e3f82c074624fe53729c Reworked the renaming mechanism
* 85f2a19f88eef94ff080a42246658f572b5275f4 Allow renaming of the HBAC rule
objects
*
URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules
stlaz commented:
"""
Changelogs were updated.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/617#issuecomment-289440947
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules
MartinBasti commented:
"""
Please update release notes (changelog)
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/617#issuecomment-289423071
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules
stlaz commented:
"""
*sigh* there was a rogue space.
Split into three separate commits.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/617#issuecomment-289366812
--
URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules
stlaz commented:
"""
*sigh* there was a rogue space.
Split into three separate commits.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/617#issuecomment-289366812
--
URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules
MartinBasti commented:
"""
```
* Module ipatests.test_xmlrpc.test_sudorule_plugin
ipatests/test_xmlrpc/test_sudorule_plugin.py:786: [E0001(syntax-error), ]
unindent does not match
URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules
stlaz commented:
"""
Added the tests but did not test them so we may want to see what Travis has to
say about that.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules
MartinBasti commented:
"""
Please provide tests, LGTM otherwise
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/617#issuecomment-289027561
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules
abbra commented:
"""
I haven't seen any custom plugin that used `rdn_is_private_key`. We can
document the change in release notes.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules
MartinBasti commented:
"""
I like the `allow_rename` attribute, as it really explains what is happaning,
Also I like the reworked check if primary key is in DN because original
URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules
stlaz commented:
"""
For the record, and I might be wrong, I did a bit of researching, the
`rdn_is_primary_key` is actually misused in some cases, as RDN is the primary
key for e.g. `pwpolicy`
URL: https://github.com/freeipa/freeipa/pull/617
Title: #617: Allow renaming of sudo and HBAC rules
abbra commented:
"""
I like the idea but please address @HonzaCholasta comments.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/617#issuecomment-288411495
--
Manage your
12 matches
Mail list logo
