Re: [Freeipa-devel] C coding style guide update

2015-08-04 Thread Lukas Slebodnik
On (27/07/15 15:54), Michal Židek wrote: >On 07/26/2015 10:09 PM, Jakub Hrozek wrote: >> - Variable Length arrays are very helpful, but explicitly mention >> they should be used with caution, especially if array size might >> come from the user > >+1 >We overuse talloc for very smal

Re: [Freeipa-devel] C coding style guide update

2015-07-27 Thread Petr Vobornik
On 07/26/2015 10:09 PM, Jakub Hrozek wrote: On Thu, Jul 23, 2015 at 06:21:25PM +0200, Michal Židek wrote: Hi, in SSSD we use the freeipa coding guidelines which are located here: http://www.freeipa.org/page/Coding_Style However this coding style guide is already dated and there are some rules

Re: [Freeipa-devel] C coding style guide update

2015-07-27 Thread Jakub Hrozek
On Mon, Jul 27, 2015 at 03:54:22PM +0200, Michal Židek wrote: > > - Line-comments (//, aka C++ comments) should be still avoided, > > though > > I really do not know what people have against line comments, but > this is not the first time I see someone resisting them, so I > guess there

Re: [Freeipa-devel] C coding style guide update

2015-07-27 Thread Michal Židek
On 07/26/2015 10:09 PM, Jakub Hrozek wrote: On Thu, Jul 23, 2015 at 06:21:25PM +0200, Michal Židek wrote: Hi, in SSSD we use the freeipa coding guidelines which are located here: http://www.freeipa.org/page/Coding_Style However this coding style guide is already dated and there are some rules

Re: [Freeipa-devel] C coding style guide update

2015-07-26 Thread Jakub Hrozek
On Thu, Jul 23, 2015 at 06:21:25PM +0200, Michal Židek wrote: > Hi, > > in SSSD we use the freeipa coding guidelines which are located here: > http://www.freeipa.org/page/Coding_Style > > However this coding style guide is already dated and there are > some rules we follow in SSSD which are not m

[Freeipa-devel] C coding style guide update

2015-07-23 Thread Michal Židek
Hi, in SSSD we use the freeipa coding guidelines which are located here: http://www.freeipa.org/page/Coding_Style However this coding style guide is already dated and there are some rules we follow in SSSD which are not mentioned in the guide and also there are some C language features that we w