[Freeipa-devel] [freeipa PR#812][comment] Refactoring cert-find to use API call directly instead of using

2017-06-02 Thread MartinBasti via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/812 Title: #812: Refactoring cert-find to use API call directly instead of using MartinBasti commented: """ master: * 44bd5e358b027f8956b730f250854efb5087f05e Changing cert-find to do not use only primary key to search in LDAP. ipa-4-5: * df1276e

[Freeipa-devel] [freeipa PR#812][comment] Refactoring cert-find to use API call directly instead of using

2017-06-01 Thread felipevolpone via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/812 Title: #812: Refactoring cert-find to use API call directly instead of using felipevolpone commented: """ Done. @frasertweedale if there is something wrong with the commit message, please tell me. Thanks for reviewing :) """ See the full commen

[Freeipa-devel] [freeipa PR#812][comment] Refactoring cert-find to use API call directly instead of using

2017-06-01 Thread felipevolpone via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/812 Title: #812: Refactoring cert-find to use API call directly instead of using felipevolpone commented: """ Done. @frasertweedale if there is something wrong with the commit message, please tell me. Thanks for reviewing :) """ See the full commen

[Freeipa-devel] [freeipa PR#812][comment] Refactoring cert-find to use API call directly instead of using

2017-05-24 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/812 Title: #812: Refactoring cert-find to use API call directly instead of using stlaz commented: """ ``` * Module ipaserver.plugins.cert ipaserver/plugins/cert.py:1505: [C0303(trailing-whitespace), ] Trailing whitespace) ipaserver/plugin

[Freeipa-devel] [freeipa PR#812][comment] Refactoring cert-find to use API call directly instead of using

2017-05-24 Thread stlaz via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/812 Title: #812: Refactoring cert-find to use API call directly instead of using stlaz commented: """ ``` * Module ipaserver.plugins.cert ipaserver/plugins/cert.py:1505: [C0303(trailing-whitespace), ] Trailing whitespace) ipaserver/plugin

[Freeipa-devel] [freeipa PR#812][comment] Refactoring cert-find to use API call directly instead of using

2017-05-24 Thread HonzaCholasta via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/812 Title: #812: Refactoring cert-find to use API call directly instead of using HonzaCholasta commented: """ @simo5, it will. Same for hosts. @felipevolpone, one possible correct fix would be to modify `cert._owners` to: ```python def _owners(se

[Freeipa-devel] [freeipa PR#812][comment] Refactoring cert-find to use API call directly instead of using

2017-05-24 Thread simo5 via FreeIPA-devel
URL: https://github.com/freeipa/freeipa/pull/812 Title: #812: Refactoring cert-find to use API call directly instead of using simo5 commented: """ Won't this cause it to not find certificates associated to users ? Currently that works, this change is not replicating the same functionality of th