[Freeipa-devel] [PATCH] Fix incorrect imports in ipa-server-certinstall. [Was: consistent use of --help on CLI?]

2009-09-10 Thread Pavel Zuna
Fixed. Pavel Zuna wrote: Dmitri Pal wrote: Pavel, Rob, What do the CLI utils do when someone uses "--help" parameter? Is there a consistent behavior about this? Thanks Dmitri Yes there is, we use OptionParser from python optparse module everywhere as far as I know and it handles -h/--help by

[Freeipa-devel] Re: [PATCHES] Add support for different automount maps per location.

2009-09-10 Thread Rob Crittenden
Pavel Zůna wrote: 0007: Add support for different automount maps per location. This patch enabled us to have a different set of automount maps per location and to manage those locations via command plugins. To add a new location: ipa automountlocation-add Brno To add a map to this location:

[Freeipa-devel] Re: [PATCH] Fix typos and minor bugs in baseldap. Add --all to LDAPUpdate.

2009-09-10 Thread Rob Crittenden
Pavel Zůna wrote: Fixes some minor things in baseldap. It also add the --all options (to display all attribute) to LDAPUpdate. Pavel Why are you not returning failed anymore with post_callback? rob smime.p7s Description: S/MIME Cryptographic Signature _

[Freeipa-devel] Re: [PATCH] Automatically generate an auto.master map for new automount location.

2009-09-10 Thread Rob Crittenden
Pavel Zůna wrote: I thought that it might be a good idea to automatically generate the auto.master map for new locations. It depends on my previous automount patch. Pavel Question: do we need a method to return all maps? Jason might need this in the UI. ack and pushed to master smime.p

[Freeipa-devel] Re: [PATCH] Automatically generate an auto.master map for new automount location.

2009-09-10 Thread Pavel Zuna
Rob Crittenden wrote: Pavel Zůna wrote: I thought that it might be a good idea to automatically generate the auto.master map for new locations. It depends on my previous automount patch. Pavel Question: do we need a method to return all maps? Jason might need this in the UI. All maps for

[Freeipa-devel] Re: [PATCH] Fix typos and minor bugs in baseldap. Add --all to LDAPUpdate.

2009-09-10 Thread Pavel Zuna
Rob Crittenden wrote: Pavel Zůna wrote: Fixes some minor things in baseldap. It also add the --all options (to display all attribute) to LDAPUpdate. Pavel Why are you not returning failed anymore with post_callback? Because that was a mistake, I meant to return dn, but wrote failed for some

Re: [Freeipa-devel] [PATCH] 259 Fix selinux issue with ldapi

2009-09-10 Thread Rob Crittenden
Rob Crittenden wrote: The management framework wasn't working with SELinux over ldapi because it lacked permission to access the unix socket. This patch grants permission. Probably easier to review with the patch attached. rob freeipa-259-selinux.patch Description: application/mbox smim

Re: [Freeipa-devel] [PATCH] 259 Fix selinux issue with ldapi

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 10:20 -0400, Rob Crittenden wrote: > Rob Crittenden wrote: > > The management framework wasn't working with SELinux over ldapi because > > it lacked permission to access the unix socket. This patch grants > > permission. > > > > Probably easier to review with the patch atta

Re: [Freeipa-devel] [PATCH] 259 Fix selinux issue with ldapi

2009-09-10 Thread Jenny Galipeau
Simo Sorce wrote: On Thu, 2009-09-10 at 10:20 -0400, Rob Crittenden wrote: Rob Crittenden wrote: The management framework wasn't working with SELinux over ldapi because it lacked permission to access the unix socket. This patch grants permission. Probably easier to review wit

Re: [Freeipa-devel] [PATCH] 259 Fix selinux issue with ldapi

2009-09-10 Thread Nathan Kinder
On 09/10/2009 07:40 AM, Jenny Galipeau wrote: Simo Sorce wrote: On Thu, 2009-09-10 at 10:20 -0400, Rob Crittenden wrote: Rob Crittenden wrote: The management framework wasn't working with SELinux over ldapi because it lacked permission to access the unix socket. This patch grants permission.

Re: [Freeipa-devel] [PATCH] 259 Fix selinux issue with ldapi

2009-09-10 Thread Simo Sorce
On Fri, 2009-08-28 at 13:12 -0400, Rob Crittenden wrote: > The management framework wasn't working with SELinux over ldapi > because > it lacked permission to access the unix socket. This patch grants > permission. The patch itself looks good anyway, so it's an ACK for me. Simo. -- Simo Sorce

Re: [Freeipa-devel] [PATCH] 261 Many SELinux fixes

2009-09-10 Thread Simo Sorce
On Fri, 2009-08-28 at 18:06 -0400, Rob Crittenden wrote: > The ldapi code I committed yesterday didn't work with SELinux > enabled. > This patch addresses that. ACK, although the same question as for the other patch wrt initrd_t context for the socket remains. Simo. -- Simo Sorce * Red Hat, In

Re: [Freeipa-devel] [PATCH] 259 Fix selinux issue with ldapi

2009-09-10 Thread Rob Crittenden
Simo Sorce wrote: On Fri, 2009-08-28 at 13:12 -0400, Rob Crittenden wrote: The management framework wasn't working with SELinux over ldapi because it lacked permission to access the unix socket. This patch grants permission. The patch itself looks good anyway, so it's an ACK for me. Simo.

Re: [Freeipa-devel] [PATCH] 261 Many SELinux fixes

2009-09-10 Thread Rob Crittenden
Simo Sorce wrote: On Fri, 2009-08-28 at 18:06 -0400, Rob Crittenden wrote: The ldapi code I committed yesterday didn't work with SELinux enabled. This patch addresses that. ACK, although the same question as for the other patch wrt initrd_t context for the socket remains. Simo. Ok, pushed

Re: [Freeipa-devel] [PATCH] 259 Fix selinux issue with ldapi

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 08:16 -0700, Nathan Kinder wrote: > On 09/10/2009 07:40 AM, Jenny Galipeau wrote: > > Simo Sorce wrote: > >> On Thu, 2009-09-10 at 10:20 -0400, Rob Crittenden wrote: > >>> Rob Crittenden wrote: > The management framework wasn't working with SELinux over ldapi > beca

Re: [Freeipa-devel] [PATCH] 259 Fix selinux issue with ldapi

2009-09-10 Thread Nathan Kinder
On 09/10/2009 08:16 AM, Nathan Kinder wrote: On 09/10/2009 07:40 AM, Jenny Galipeau wrote: Simo Sorce wrote: On Thu, 2009-09-10 at 10:20 -0400, Rob Crittenden wrote: Rob Crittenden wrote: The management framework wasn't working with SELinux over ldapi because it lacked permission to access th

[Freeipa-devel] Re: [PATCH] Automatically generate an auto.master map for new automount location.

2009-09-10 Thread Rob Crittenden
Pavel Zuna wrote: Rob Crittenden wrote: Pavel Zůna wrote: I thought that it might be a good idea to automatically generate the auto.master map for new locations. It depends on my previous automount patch. Pavel Question: do we need a method to return all maps? Jason might need this in the

[Freeipa-devel] [PATCH] 266 remove deprecated comment

2009-09-10 Thread Rob Crittenden
Remove comment about plugin naming conventions. We've dumped this convention. rob freeipa-266-deprecated.patch Description: application/mbox smime.p7s Description: S/MIME Cryptographic Signature ___ Freeipa-devel mailing list Freeipa-devel@redhat.c

[Freeipa-devel] [PATCH] 267 fix virtual plugin

2009-09-10 Thread Rob Crittenden
Fix the virtual access plugin to work with the new backend. Also do a more explicit objectviolation catch. We will switch this to use GER when that is completed. rob freeipa-267-virtual.patch Description: application/mbox smime.p7s Description: S/MIME Cryptographic Signature ___

[Freeipa-devel] [PATCH] 268 explicitly set verbose to false in RPC client

2009-09-10 Thread Rob Crittenden
I've needed to set verbose to True in the rpc client and every time I have to do this I hunt around trying to figure out where to put it. This will make it easier to find next time :-) rob freeipa-268-rpc.patch Description: application/mbox smime.p7s Description: S/MIME Cryptographic Signat