Re: [Freeipa-devel] Some thoughts about login services

2010-10-18 Thread Rob Crittenden
Dmitri Pal wrote: Simo Sorce wrote: On Fri, 15 Oct 2010 14:12:22 -0400 Dmitri Pal wrote: Simo Sorce wrote: I'd go for the last one, may be ugly, but does not undo anything that already works and has the effect of simplifying the UI which is what you are after right now. Of course that al

Re: [Freeipa-devel] [PATCH] 581 remove enrolledBy when unenrolled

2010-10-18 Thread Rob Crittenden
Dmitri Pal wrote: Simo Sorce wrote: On Fri, 15 Oct 2010 17:27:07 -0400 Rob Crittenden wrote: Remove the enrolledBy when a host is unenrolled (which is the same as disabling the host). ticket 301 rob nack, if host can write enrolledBy it can fake info Simo. I agree. I think it should

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0056-removing-dead-files

2010-10-18 Thread Adam Young
On 10/15/2010 06:56 PM, Simo Sorce wrote: On Fri, 15 Oct 2010 14:32:18 -0400 (EDT) Endi Sukma Dewata wrote: - "Adam Young" wrote: Like the journey song, these should have been gone, long ago. ACKed and pushed to master. This patch broke the build ... fix coming

Re: [Freeipa-devel] [PATCH] Fix build

2010-10-18 Thread Adam Young
On 10/15/2010 07:09 PM, Simo Sorce wrote: patch to fix the build Simo. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK, pushed to master

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0056-removing-dead-files

2010-10-18 Thread Endi Sukma Dewata
On 10/18/2010 9:38 AM, Adam Young wrote: On 10/15/2010 06:56 PM, Simo Sorce wrote: Endi Sukma Dewata wrote: ACKed and pushed to master. >> This patch broke the build ... fix coming, but guys, please, verify stuff builds from scratch before pushing patches. Simo, very sorry about this. I've

[Freeipa-devel] [PATCH] #394 Fix ldappasswd on some OSs

2010-10-18 Thread Simo Sorce
Apparnetly my f14 test environment didn't need the host name but in some cases w/o it the passwd change will fail because SSL verification fails. The attached patch should fix the issue. Simo. -- Simo Sorce * Red Hat, Inc * New York >From e5b8ca3256010a7c3150befe02f53444cb63f152 Mon Sep 17 00:

[Freeipa-devel] [PATCH] fix pwd plugin logging

2010-10-18 Thread Simo Sorce
While reviewing the logging macros I realized that the log target was wrong for the LOG_TRACE and LOG_FATAL functions. I also took the liberty of simplifying the macros by removing unnecessary do {} while(0) loops given the final version didn't require more then one function invocation anyway. Si

[Freeipa-devel] [PATCH] beef up .gitignore

2010-10-18 Thread Simo Sorce
We are not ignoring enough stuff, every time you run make you get a ton of files in git status These changes returned to me a very clean git status at last :-) Simo. -- Simo Sorce * Red Hat, Inc * New York >From b37c2d5883714a4d86dfe6d610b8162f2c267ee3 Mon Sep 17 00:00:00 2001 From: Simo Sorce

Re: [Freeipa-devel] [PATCH] #394 Fix ldappasswd on some OSs

2010-10-18 Thread Rob Crittenden
Simo Sorce wrote: Apparnetly my f14 test environment didn't need the host name but in some cases w/o it the passwd change will fail because SSL verification fails. The attached patch should fix the issue. Simo. ack ___ Freeipa-devel mailing list F

Re: [Freeipa-devel] [PATCH] #394 Fix ldappasswd on some OSs

2010-10-18 Thread Simo Sorce
On Mon, 18 Oct 2010 11:56:10 -0400 Rob Crittenden wrote: > Simo Sorce wrote: > > > > Apparnetly my f14 test environment didn't need the host name but in > > some cases w/o it the passwd change will fail because SSL > > verification fails. > > > > The attached patch should fix the issue. > > > > S

Re: [Freeipa-devel] [PATCH] beef up .gitignore

2010-10-18 Thread Adam Young
On 10/18/2010 11:54 AM, Simo Sorce wrote: We are not ignoring enough stuff, every time you run make you get a ton of files in git status These changes returned to me a very clean git status at last :-) Simo. ___ Freeipa-devel mailing list Free

Re: [Freeipa-devel] [PATCH] beef up .gitignore

2010-10-18 Thread Simo Sorce
On Mon, 18 Oct 2010 12:07:08 -0400 Adam Young wrote: > On 10/18/2010 11:54 AM, Simo Sorce wrote: > > We are not ignoring enough stuff, every time you run make you get a > > ton of files in git status > > > > These changes returned to me a very clean git status at last :-) > > > ACK. Please add

Re: [Freeipa-devel] [PATCH] #319 better cope with ntp config files

2010-10-18 Thread Rob Crittenden
Simo Sorce wrote: On Fri, 15 Oct 2010 10:27:59 -0400 Simo Sorce wrote: Right, thanks for catching this, my python got a bit rusty in the last few months :) Ok, changed the patch according to your guidelines, and retested. Also caught a bug that didn't show up with the previous way I did stri

Re: [Freeipa-devel] [PATCH] #319 better cope with ntp config files

2010-10-18 Thread Simo Sorce
On Mon, 18 Oct 2010 13:42:13 -0400 Rob Crittenden wrote: > Works for me, ack. thanks, pushed to master Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/fre

Re: [Freeipa-devel] [PATCH] Service certificate status.

2010-10-18 Thread Adam Young
On 10/15/2010 08:39 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! The service details page has been modified to show certificate status using bullets. It will also show the revocation reason, and display the restore button only if the certificate is on hold. The bu

Re: [Freeipa-devel] [PATCH] Check if attribute is single-value before trying to add values to it.

2010-10-18 Thread Rob Crittenden
Rob Crittenden wrote: Pavel Zůna wrote: On 2010-10-14 19:20, Rob Crittenden wrote: Pavel Zuna wrote: On 10/14/2010 12:01 AM, Rob Crittenden wrote: Pavel Zuna wrote: This patch adds a check in ldap2 for single-value attributes. DS doesn't seem to care much about attributes being defined as SI

Re: [Freeipa-devel] [PATCH] Service certificate status.

2010-10-18 Thread Endi Sukma Dewata
On 10/18/2010 12:58 PM, Adam Young wrote: ACK. Please file a ticket for throwing the error message when installed without dogtag I see this has been pushed. Thanks! I closed this ticket: https://fedorahosted.org/freeipa/ticket/276 and opened these tickets: https://fedorahosted.org/freeipa/tic

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0058-password-dialog.patch

2010-10-18 Thread Adam Young
On 10/15/2010 03:23 PM, Adam Young wrote: On 10/15/2010 03:05 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Just realized that there is a bug in here. If the admin

[Freeipa-devel] [PATCH] 582 allow rdn changes

2010-10-18 Thread Rob Crittenden
Allow RDN changes for users, groups, rolegroups and taskgroups. To do a change right now you have to perform a setattr like: ipa user-mod --setattr uid=newuser olduser The RDN change is performed before the rest of the mods. If the RDN change is the only change done then the EmptyModlist that

[Freeipa-devel] [Fwd: [PATCH] 582 allow rdn changes]

2010-10-18 Thread Dmitri Pal
Do we plan/need to have a more convenient format? The setattr seems not intuitive. I seems it should be something like: ipa user-mod --login=newlogin oldlogin But I understand it will affect a lot of CLIs if we do it right for all renames. Well... may be exactly because of that we should do it soo

Re: [Freeipa-devel] [PATCH] 568 fix mutual exclusive comparison in hbac

2010-10-18 Thread Rob Crittenden
Adam Young wrote: On 10/11/2010 10:09 AM, Rob Crittenden wrote: Do better error checking in mutual exclusivity check in hbac plugin. This fixes the acceptance tests. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/

Re: [Freeipa-devel] [PATCH] 578 remove ldapi socket on uninstall

2010-10-18 Thread Rob Crittenden
Simo Sorce wrote: On Thu, 14 Oct 2010 14:50:18 -0400 Rob Crittenden wrote: Remove the directory server ldapi socket on uninstall. ticket 350 ACK Simo. This was pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://

Re: [Freeipa-devel] [PATCH] 580 admintools requires ipa-client, requires config

2010-10-18 Thread Rob Crittenden
Simo Sorce wrote: On Fri, 15 Oct 2010 09:36:29 -0400 Rob Crittenden wrote: Add Requires on ipa-client to ipa-admintools, ensure ipa client is configured. It makes little sense to install ipa-admintools without ipa-client, require it. Also see if the client has been configured. This is a bit t

[Freeipa-devel] [PATCH] fix merge_from_file test

2010-10-18 Thread Rob Crittenden
Pushed as 1-liner diff --git a/tests/test_ipalib/test_config.py b/tests/test_ipalib/test_config.py index d1ca55d..179ee1f 100644 --- a/tests/test_ipalib/test_config.py +++ b/tests/test_ipalib/test_config.py @@ -389,7 +389,7 @@ class test_Env(ClassChecker): assert o._merge_from_file(ove

Re: [Freeipa-devel] [Fwd: [PATCH] 582 allow rdn changes]

2010-10-18 Thread Rob Crittenden
Dmitri Pal wrote: Do we plan/need to have a more convenient format? The setattr seems not intuitive. I seems it should be something like: ipa user-mod --login=newlogin oldlogin But I understand it will affect a lot of CLIs if we do it right for all renames. Well... may be exactly because of that

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0058-password-dialog.patch

2010-10-18 Thread Endi Sukma Dewata
On 10/18/2010 1:53 PM, Adam Young wrote: Now check the principal prior to calling passwd, and add that as a parameter for non-selfservice case. ACK with note that there's an outstanding bug on password reset: https://fedorahosted.org/freeipa/ticket/390 -- Endi S. Dewata __

[Freeipa-devel] [PATCH] admiyo-freeipa-0060-Default-search-limit-to-100.patch

2010-10-18 Thread Adam Young
Trivial patch, coulda pushed under the 1 liner rule, but figured it was worth a second set of eyes. From 94bf11cd194f2b15972b0602ebc1d4e82f6cefae Mon Sep 17 00:00:00 2001 From: Adam Young Date: Mon, 18 Oct 2010 17:07:01 -0400 Subject: [PATCH] Default search limit to 100 --- install/share/bootst

[Freeipa-devel] [PATCH] #360 ipa-uuid plugin

2010-10-18 Thread Simo Sorce
These 2 patches configure and load a new plugin that uses internal DS functions to generate UUIDs. The plugin is similar to DNA but instead of generating sequential numbers it generates UUIDs (type 1). These patches do not yet remove the UUID code in the framework. Simo. -- Simo Sorce * Red Ha