Re: [Freeipa-devel] [PATCH] 932 Add support for storing MAC address in host entries.

2012-01-23 Thread Jan Cholasta
Dne 20.1.2012 21:15, Rob Crittenden napsal(a): macaddress is a multi-valued attribute and we allow multiple entries. This is from the objectclass ieee802device. This is added manually when doing a mod or add and not as a default to support existing host entries that do not have this objectclass.

Re: [Freeipa-devel] 389 systemd changes

2012-01-23 Thread Simo Sorce
On Mon, 2012-01-23 at 08:03 +0200, Alexander Bokovoy wrote: On Sun, 22 Jan 2012, Simo Sorce wrote: Shouldn't we just 'include' the original file and not copy it ? If we include it a change in the file will be automatically picked up. We can't due to systemd design and use of it in

Re: [Freeipa-devel] 389 systemd changes

2012-01-23 Thread Alexander Bokovoy
On Mon, 23 Jan 2012, Simo Sorce wrote: On Mon, 2012-01-23 at 08:03 +0200, Alexander Bokovoy wrote: On Sun, 22 Jan 2012, Simo Sorce wrote: Shouldn't we just 'include' the original file and not copy it ? If we include it a change in the file will be automatically picked up. We can't

Re: [Freeipa-devel] [PATCH] 340 Enabled paging on automount keys.

2012-01-23 Thread Petr Vobornik
On 01/19/2012 01:44 AM, Endi Sukma Dewata wrote: On 1/18/2012 10:21 AM, Endi Sukma Dewata wrote: The automount keys search facet has been modified to support paging. Since the automountkey-find command doesn't support --pkey-only option, the facet is configured such that during a refresh

Re: [Freeipa-devel] [PATCH] 342 Fixed inconsistent status labels.

2012-01-23 Thread Petr Vobornik
On 01/19/2012 07:04 AM, Endi Sukma Dewata wrote: This patch modifies the status attributes in users, DNS zones, HBAC/sudo rules, HBAC test, and SELinux User Map to use the same label (i.e. Status) and values (i.e. Enabled/Disabled). The method to change the status will be modified separately.

Re: [Freeipa-devel] [PATCH] 341 Show disabled entries in gray.

2012-01-23 Thread Petr Vobornik
On 01/19/2012 01:48 AM, Endi Sukma Dewata wrote: The users, HBAC/sudo rules, HBAC test, and SELinux list pages have been modified to show disabled entries in gray. Icons will be added separately. Ticket #1996 ACK and pushed to master, ipa-2-2 -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 931 ship ipa-upgradeconfig man page

2012-01-23 Thread Martin Kosek
On Fri, 2012-01-20 at 13:33 -0500, Rob Crittenden wrote: The ipa-upgradeconfig man page was not being packaged. I updated the man page to include info about the proxy config change and modified the tool so you have to be root to execute it. rob ACK. Pushed to master, ipa-2-2. Martin

Re: [Freeipa-devel] [PATCH] 932 Add support for storing MAC address in host entries.

2012-01-23 Thread Martin Kosek
On Mon, 2012-01-23 at 11:14 +0100, Jan Cholasta wrote: Dne 20.1.2012 21:15, Rob Crittenden napsal(a): macaddress is a multi-valued attribute and we allow multiple entries. This is from the objectclass ieee802device. This is added manually when doing a mod or add and not as a default to

Re: [Freeipa-devel] [PATCH] 932 Add support for storing MAC address in host entries.

2012-01-23 Thread Jan Cholasta
Dne 23.1.2012 16:24, Martin Kosek napsal(a): On Mon, 2012-01-23 at 11:14 +0100, Jan Cholasta wrote: Dne 20.1.2012 21:15, Rob Crittenden napsal(a): macaddress is a multi-valued attribute and we allow multiple entries. This is from the objectclass ieee802device. This is added manually when doing

Re: [Freeipa-devel] 389 systemd changes

2012-01-23 Thread Rich Megginson
On 01/23/2012 07:37 AM, Alexander Bokovoy wrote: On Mon, 23 Jan 2012, Simo Sorce wrote: On Mon, 2012-01-23 at 08:03 +0200, Alexander Bokovoy wrote: On Sun, 22 Jan 2012, Simo Sorce wrote: Shouldn't we just 'include' the original file and not copy it ? If we include it a change in the file will

Re: [Freeipa-devel] [PATCH] 927 fix deleting hbac rules when selinux user maps are involved

2012-01-23 Thread Martin Kosek
On Tue, 2012-01-17 at 17:59 -0500, Rob Crittenden wrote: When deleting an HBAC rule we need to ensure that an SELinux user map isn't pointing at it. The search for this didn't work well at all. This patch corrects the search and makes it more specific. I also tested that it works with the

Re: [Freeipa-devel] [PATCH] 932 Add support for storing MAC address in host entries.

2012-01-23 Thread Rob Crittenden
Jan Cholasta wrote: Dne 20.1.2012 21:15, Rob Crittenden napsal(a): macaddress is a multi-valued attribute and we allow multiple entries. This is from the objectclass ieee802device. This is added manually when doing a mod or add and not as a default to support existing host entries that do not

Re: [Freeipa-devel] [PATCH] 927 fix deleting hbac rules when selinux user maps are involved

2012-01-23 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2012-01-17 at 17:59 -0500, Rob Crittenden wrote: When deleting an HBAC rule we need to ensure that an SELinux user map isn't pointing at it. The search for this didn't work well at all. This patch corrects the search and makes it more specific. I also tested that

Re: [Freeipa-devel] [PATCH] 341 Show disabled entries in gray.

2012-01-23 Thread Dmitri Pal
On 01/23/2012 10:03 AM, Petr Vobornik wrote: On 01/23/2012 03:42 PM, Petr Vobornik wrote: On 01/19/2012 01:48 AM, Endi Sukma Dewata wrote: The users, HBAC/sudo rules, HBAC test, and SELinux list pages have been modified to show disabled entries in gray. Icons will be added separately.

[Freeipa-devel] [PATCH] 9 Don't set nsds5replicaupdateschedule in replication agreements

2012-01-23 Thread Ondrej Hamada
https://fedorahosted.org/freeipa/ticket/1482 The nsDS5ReplicaUpdateSchedule parameter is omitted what results in replication being run all the time. The parameter is still used for forcing replica update but after that action it is always deleted. -- Regards, Ondrej Hamada FreeIPA team jabber:

Re: [Freeipa-devel] [PATCH] 341 Show disabled entries in gray.

2012-01-23 Thread Endi Sukma Dewata
On 1/23/2012 11:23 AM, Dmitri Pal wrote: https://fedorahosted.org/freeipa/attachment/ticket/1996/deactivated_column.png I might be confused but the mockup above does not make much sense. Is it intended for user list rather than for HBAC because Account Status for HBAC does not make any sense?

Re: [Freeipa-devel] [PATCH] 200 Ease zonemgr restrictions

2012-01-23 Thread Rob Crittenden
Martin Kosek wrote: Admin e-mail validator currently requires an email to be in a second-level domain (hostmas...@example.com). This is too restrictive. Top level domain e-mails (hostmaster@testrelm) should also be allowed. This patch also fixes default zonemgr value in help texts and man

Re: [Freeipa-devel] [PATCH] 194 Fix ipa-server-install for dual NICs

2012-01-23 Thread Rob Crittenden
Martin Kosek wrote: On Thu, 2012-01-19 at 17:21 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-01-13 at 10:48 -0500, Rob Crittenden wrote: Martin Kosek wrote: It seems I sent two patches with number 189. Sending a patch with a correct number. Martin On Tue, 2012-01-10 at

Re: [Freeipa-devel] [PATCH] 189 Fix selfservice-find crashes

2012-01-23 Thread Rob Crittenden
Martin Kosek wrote: On Fri, 2012-01-13 at 10:55 -0500, Rob Crittenden wrote: Martin Kosek wrote: Ignore empty options when performing an ACI search so that the find command does not crash. https://fedorahosted.org/freeipa/ticket/2011 https://fedorahosted.org/freeipa/ticket/2012 I tested

Re: [Freeipa-devel] [PATCH] 924 display both hex and decimal serial numbers

2012-01-23 Thread Rob Crittenden
Jan Cholasta wrote: Dne 18.1.2012 00:04, Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 16.1.2012 22:02, Rob Crittenden napsal(a): Rob Crittenden wrote: Jan Cholasta wrote: Dne 13.1.2012 20:53, Rob Crittenden napsal(a): When viewing a certificate it will show the serial number as hex

Re: [Freeipa-devel] [PATCH 59] Modify spec file to add ipa_memcached service Install , control ipa_memcached instance

2012-01-23 Thread John Dennis
This patch supersedes the previous patch, it corrects two issue Rob raised in a later patch review The fixed issues are: * spec file did not install ipa_memcached SysV initscript on SvsV systems. * Typo in the name of the pid file variable in the ipa_memcached initscript -- John Dennis

Re: [Freeipa-devel] [PATCH 60] Implement session support in server, Manage sessions in WSGI

2012-01-23 Thread John Dennis
This patch is self NAK'ed because it's contents have been rolled into the rebased patch freeipa-jdennis-0061-1-add-session-manager-and-cache-krb-auth.patch -- John Dennis jden...@redhat.com Looking to carve out IT costs? www.redhat.com/carveoutcosts/

Re: [Freeipa-devel] [PATCH 61] Cache authentication in session

2012-01-23 Thread John Dennis
On 01/17/2012 04:37 PM, Rob Crittenden wrote: John Dennis wrote: Both of these are defined in ipalib/rpc.py (among others): +KRB5_CC_NOTFOUND = -1765328243 # Matching credential not found +KRB5_FCC_NOFILE = -1765328189 # No credentials cache found Perhaps all those defines should be

Re: [Freeipa-devel] 389 systemd changes

2012-01-23 Thread Rich Megginson
On 01/23/2012 07:37 AM, Alexander Bokovoy wrote: On Mon, 23 Jan 2012, Simo Sorce wrote: On Mon, 2012-01-23 at 08:03 +0200, Alexander Bokovoy wrote: On Sun, 22 Jan 2012, Simo Sorce wrote: Shouldn't we just 'include' the original file and not copy it ? If we include it a change in the file will

Re: [Freeipa-devel] [PATCH] 927 fix deleting hbac rules when selinux user maps are involved

2012-01-23 Thread Martin Kosek
On Mon, 2012-01-23 at 12:20 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Tue, 2012-01-17 at 17:59 -0500, Rob Crittenden wrote: When deleting an HBAC rule we need to ensure that an SELinux user map isn't pointing at it. The search for this didn't work well at all. This patch