Re: [Freeipa-devel] [PATCH 83] Cookie Expires date should be locale insensitive

2012-12-20 Thread Sumit Bose
On Wed, Dec 19, 2012 at 01:36:40PM -0500, John Dennis wrote: -- John Dennis jden...@redhat.com Looking to carve out IT costs? www.redhat.com/carveoutcosts/ Patch is working as expected and he code looks good to me. I just have a minor comment. I think 'import time' can be removed from

Re: [Freeipa-devel] [PATCH 83] Cookie Expires date should be locale insensitive

2012-12-20 Thread Martin Kosek
On 12/19/2012 07:36 PM, John Dennis wrote: I tested the patch on RHEL platform and it works fine and removes the annoying error. My comments on the patch: 1) I do not think its necessary to write target branches to commit message. Also there is a typo: ipapython/cooke.py 2) As for the tests

Re: [Freeipa-devel] [PATCH 83] Cookie Expires date should be locale insensitive

2012-12-20 Thread Petr Viktorin
On 12/19/2012 07:36 PM, John Dennis wrote: The Expires attribute in a cookie is supposed to follow the RFC 822 (superseded by RFC 1123) date format. That format includes a weekday abbreviation (e.g. Tue) which must be in English according to the RFC's. ipapython/cooke.py has methods to parse

Re: [Freeipa-devel] [PATCH] 0043 Allow-PKI-CA-Replica-Installs-when-CRL-exceeds-default

2012-12-20 Thread Ade Lee
On Wed, 2012-12-19 at 21:35 -0500, Simo Sorce wrote: On Wed, 2012-12-19 at 22:41 +, JR Aquino wrote: On Dec 19, 2012, at 2:32 PM, Simo Sorce wrote: On Wed, 2012-12-19 at 20:52 +, JR Aquino wrote: Due to a limitation with 389 DS, the nsslapd-maxbersize cannot be set

Re: [Freeipa-devel] [PATCH] 0043 Allow-PKI-CA-Replica-Installs-when-CRL-exceeds-default

2012-12-20 Thread Simo Sorce
On Thu, 2012-12-20 at 09:39 -0500, Ade Lee wrote: On Wed, 2012-12-19 at 21:35 -0500, Simo Sorce wrote: On Wed, 2012-12-19 at 22:41 +, JR Aquino wrote: On Dec 19, 2012, at 2:32 PM, Simo Sorce wrote: On Wed, 2012-12-19 at 20:52 +, JR Aquino wrote: Due to a limitation with

Re: [Freeipa-devel] [PATCH 83] Cookie Expires date should be locale insensitive

2012-12-20 Thread Martin Kosek
On 12/20/2012 12:35 PM, Petr Viktorin wrote: On 12/19/2012 07:36 PM, John Dennis wrote: The Expires attribute in a cookie is supposed to follow the RFC 822 (superseded by RFC 1123) date format. That format includes a weekday abbreviation (e.g. Tue) which must be in English according to the

Re: [Freeipa-devel] [PATCH] 0043 Allow-PKI-CA-Replica-Installs-when-CRL-exceeds-default

2012-12-20 Thread Andrew Wnuk
On 12/20/2012 06:49 AM, Simo Sorce wrote: On Thu, 2012-12-20 at 09:39 -0500, Ade Lee wrote: On Wed, 2012-12-19 at 21:35 -0500, Simo Sorce wrote: On Wed, 2012-12-19 at 22:41 +, JR Aquino wrote: On Dec 19, 2012, at 2:32 PM, Simo Sorce wrote: On Wed, 2012-12-19 at 20:52 +, JR Aquino