[Freeipa-devel] [PATCH] 0010 ipa-client-install does not clean up /etc/ipa/ca.crt after a failed attempt

2013-10-15 Thread Martin Basti
Added warning if cert. exists (client) https://fedorahosted.org/freeipa/ticket/3944 -- Martin Basti >From 934ebe5277005e314fd1ef7fb92525219429b7af Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Tue, 15 Oct 2013 11:31:49 +0200 Subject: [PATCH] Added warning if cert '/etc/ipa/ca.cert' exists h

Re: [Freeipa-devel] [PATCH] 448 Load updated Web UI files after server upgrade

2013-10-15 Thread Ana Krivokapic
On 10/02/2013 12:45 PM, Petr Vobornik wrote: > On 09/27/2013 09:16 AM, Ana Krivokapic wrote: >> On 08/30/2013 05:21 PM, Petr Vobornik wrote: > > snip > >>> >>> https://fedorahosted.org/freeipa/ticket/3798 >>> >> >> I tested the patch and it seems to work fine. Code-wise it looks good as >> well. >

Re: [Freeipa-devel] [PATCH] 451-458 Web UI devel and source code documentation

2013-10-15 Thread Ana Krivokapic
On 10/02/2013 02:20 PM, Petr Vobornik wrote: > On 09/16/2013 05:24 PM, Ana Krivokapic wrote: >> On 09/11/2013 12:44 PM, Petr Vobornik wrote: >>> Hello, >>> > > snip > >>> >> >> I looked into the documentation effort and (ruby dependency discussion >> aside) I >> don't have any major objections. I

Re: [Freeipa-devel] [PATCH] [DOC] 0003 Split text commands & descriptions into XML tables.

2013-10-15 Thread Martin Kosek
Thanks. It would be ideal, if this table is (in future) generated somehow semi-automatically as practically all this info can be gathered from FreeIPA code. But for now, this is great. I see some issues with the patch though: 1) Whitespaces before tabs I fixed some of them with sed -i "s/\+\t$/+

Re: [Freeipa-devel] [PATCHES] 0068-0070 Automember rebuild membership

2013-10-15 Thread Ana Krivokapic
On 09/30/2013 10:02 AM, Petr Viktorin wrote: > On 09/27/2013 03:12 PM, Martin Kosek wrote: >> On 09/27/2013 03:00 PM, Jan Cholasta wrote: >>> On 23.9.2013 19:41, Ana Krivokapic wrote: On 09/19/2013 03:29 PM, Ana Krivokapic wrote: >> ... >>> Patch 69: >>> >>> I think the changes in the update f

Re: [Freeipa-devel] [PATCH] [DOC] 0003 Split text commands & descriptions into XML tables.

2013-10-15 Thread Jérôme Fenal
kk2013/10/15 Martin Kosek : > Thanks. It would be ideal, if this table is (in future) generated somehow > semi-automatically as practically all this info can be gathered from FreeIPA > code. But for now, this is great. > > I see some issues with the patch though: > > 1) Whitespaces before tabs OK,

Re: [Freeipa-devel] [PATCHES 100-106] Initial implementation of AD integration tests

2013-10-15 Thread Alexander Bokovoy
On Mon, 14 Oct 2013, Tomas Babej wrote: +def estabilish_trust_with_ad(master, ad, extra_args=[]): +""" +Estabilishes trust with Active Directory. Trust type is detected depending +on the presence of SfU (Services for Unix) support on the AD. + +Use extra arguments to pass extra ar

Re: [Freeipa-devel] [PATCH] [DOC] 0003 Split text commands & descriptions into XML tables.

2013-10-15 Thread Martin Kosek
On 10/15/2013 06:19 PM, Jérôme Fenal wrote: > kk2013/10/15 Martin Kosek : >> Thanks. It would be ideal, if this table is (in future) generated somehow >> semi-automatically as practically all this info can be gathered from FreeIPA >> code. But for now, this is great. >> >> I see some issues with th