Re: [Freeipa-devel] [PATCH 0001] ipa-client-install: attempt to get host TGT several times before aborting client installation

On 01/12/2015 05:45 PM, Martin Babinsky wrote: > related to ticket https://fedorahosted.org/freeipa/ticket/4808 > > Patch attached. > > Martin^3 I think the --tgt-kinit-attempts approach is good one. Couple comments I have when reading the patch: 1) Function +def get_host_tgt(options, keytab, h

Re: [Freeipa-devel] [PATCH 0001] ipa-client-install: attempt to get host TGT several times before aborting client installation

Dne 13.1.2015 v 09:22 Martin Kosek napsal(a): On 01/12/2015 05:45 PM, Martin Babinsky wrote: related to ticket https://fedorahosted.org/freeipa/ticket/4808 Patch attached. Martin^3 I think the --tgt-kinit-attempts approach is good one. Couple comments I have when reading the patch: 1) Funct

Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases

On 01/12/2015 06:43 PM, Martin Basti wrote: > On 05/01/15 16:18, Martin Basti wrote: >> On 17/12/14 15:15, Martin Basti wrote: >>> On 16/12/14 17:14, Martin Basti wrote: On 15/12/14 20:15, Martin Basti wrote: > On 15/12/14 19:18, Martin Basti wrote: >> https://fedorahosted.org/freeipa/

[Freeipa-devel] [PATCH 0022] Fix default value type for wait_for_dns optio

Hello, Fix default value type for wait_for_dns option wait_for_dns value should be an integer so default value was changed from False to 0. -- Petr^2 Spacek From 15b0d338d7eb9b11cee7acfb1171367cbb8e723e Mon Sep 17 00:00:00 2001 From: Petr Spacek Date: Tue, 13 Jan 2015 10:14:43 +0100 Subject: [

Re: [Freeipa-devel] [PATCH] 797 rpcclient: use json_encode_binary for verbose output

On 01/12/2015 07:15 PM, Martin Basti wrote: On 12/01/15 16:29, Petr Vobornik wrote: `json.dumps` is not able to process some IPA's object types and therefore requires to preprocess it with `json_encode_binary` call. This step was not used in rpcclient's verbose output. https://fedorahosted.org

Re: [Freeipa-devel] [PATCH] 389 Fix ipa-restore on systems without IPA installed

On 01/12/2015 06:07 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza Is there a reason why `installutils.check_server_configuration() ` is called in `cert_restore_prepare`, ie., method which is not really connected with it, and not i

Re: [Freeipa-devel] [PATCH 0022] Fix default value type for wait_for_dns optio

On 01/13/2015 10:16 AM, Petr Spacek wrote: > Hello, > > Fix default value type for wait_for_dns option > > wait_for_dns value should be an integer so default value was changed from > False to 0. > Thanks. I stumbled on this value this morning, when setting it to True did not work. IMO, it woul

Re: [Freeipa-devel] [PATCH 0022] Fix default value type for wait_for_dns optio

On 13.1.2015 10:57, Martin Kosek wrote: > On 01/13/2015 10:16 AM, Petr Spacek wrote: >> Hello, >> >> Fix default value type for wait_for_dns option >> >> wait_for_dns value should be an integer so default value was changed from >> False to 0. >> > > Thanks. I stumbled on this value this morning, w

Re: [Freeipa-devel] [PATCH 0022] Fix default value type for wait_for_dns optio

On 01/13/2015 11:11 AM, Petr Spacek wrote: > On 13.1.2015 10:57, Martin Kosek wrote: >> On 01/13/2015 10:16 AM, Petr Spacek wrote: >>> Hello, >>> >>> Fix default value type for wait_for_dns option >>> >>> wait_for_dns value should be an integer so default value was changed from >>> False to 0. >>>

Re: [Freeipa-devel] [PATCH] 389 Fix ipa-restore on systems without IPA installed

Dne 13.1.2015 v 10:46 Petr Vobornik napsal(a): On 01/12/2015 06:07 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza Is there a reason why `installutils.check_server_configuration() ` is called in `cert_restore_prepare`, ie., method w

[Freeipa-devel] [PATCH] 390 Do not crash on unknown services in installutils.stopped_service

Hi, the attached patch fixes . Honza -- Jan Cholasta >From 09155e3546adbeededbd025dea631c2a5ac39cc6 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Tue, 13 Jan 2015 10:59:08 + Subject: [PATCH] Do not crash on unknown services in installutils

[Freeipa-devel] [PATCHES] 391-392 Make certificate renewal process synchronized

Hi, the attached patches fix . Note that if you want to test upgrades on CA-less, you need to apply my patch 390 as well: . Honza -- Jan Cholasta >From 9b6f5f227996fd4b5fb

[Freeipa-devel] FYI: LANGSEC: Sane protocol design and input parsing

Hello, FYI, I came across an interesting article/idea: "LANGSEC: Language-theoretic Security" The Language-theoretic approach (LANGSEC) regards the Internet insecurity epidemic as a consequence of ad hoc programming of input handling at all layers of network stacks, and in other kinds of software

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Note that --data with data-only backup and --logs-only with data-only restore are deliberately ignored and considered no-op. Honza 1. I'm not sure how relative path to ba

[Freeipa-devel] [PATCH] 0037 Remove ipanttrustauthincoming/ipanttrustauthoutgoing from ipa trust-add output.

https://fedorahosted.org/freeipa/ticket/4787 -- David Kupka From 801c2e16b2fca523cf1116095cdec530417e9ff0 Mon Sep 17 00:00:00 2001 From: David Kupka Date: Tue, 13 Jan 2015 13:23:16 +0100 Subject: [PATCH] Remove ipanttrustauthincoming/ipanttrustauthoutgoing from ipa trust-add output. https://fed

Re: [Freeipa-devel] [PATCH] 0037 Remove ipanttrustauthincoming/ipanttrustauthoutgoing from ipa trust-add output.

On 01/13/2015 01:33 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4787 Haven't try it, but: have you considered: result['result'].pop('ipanttrustauthincoming', None) ? -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-deve

Re: [Freeipa-devel] [PATCH] 0037 Remove ipanttrustauthincoming/ipanttrustauthoutgoing from ipa trust-add output.

On 01/13/2015 01:39 PM, Petr Vobornik wrote: On 01/13/2015 01:33 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4787 Haven't try it, but: have you considered: result['result'].pop('ipanttrustauthincoming', None) ? I haven't and it looks better, thanks. Fixed patch attach

[Freeipa-devel] [PATCH 0319] Fix crash caused by race condition during resolver cache flushing

Hello, This patch should be applied to v2 branch. Fix crash caused by race condition during resolver cache flushing. dns_view_flushcache() call has to be always done in single-thread mode. Locking around the call was missing in forwarder reconfiguration and zone deletion which could cause crash.

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Note that --data with data-only backup and --logs-only with data-only restore are deliberately ignored and considered no-op.

Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases

On 01/13/2015 01:36 PM, Martin Basti wrote: > On 13/01/15 10:04, Martin Kosek wrote: >> On 01/12/2015 06:43 PM, Martin Basti wrote: >>> On 05/01/15 16:18, Martin Basti wrote: On 17/12/14 15:15, Martin Basti wrote: > On 16/12/14 17:14, Martin Basti wrote: >> On 15/12/14 20:15, Martin B

Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases

On 01/13/2015 02:36 PM, Tomas Babej wrote: > > On 01/13/2015 01:36 PM, Martin Basti wrote: >> On 13/01/15 10:04, Martin Kosek wrote: >>> On 01/12/2015 06:43 PM, Martin Basti wrote: On 05/01/15 16:18, Martin Basti wrote: > On 17/12/14 15:15, Martin Basti wrote: >> On 16/12/14 17:14, Ma

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

On 01/12/2015 04:50 PM, Rob Crittenden wrote: Jan Cholasta wrote: Dne 12.1.2015 v 16:30 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 12.1.2015 v 13:37 David Kupka napsal(a): On 01/12/2015 01:14 PM, Jan Cholasta wrote: Dne 12.1.2015 v 13:08 Martin Kosek napsal(a): On 01/12/2015 12:53 PM

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

Dne 13.1.2015 v 14:44 David Kupka napsal(a): On 01/12/2015 04:50 PM, Rob Crittenden wrote: Jan Cholasta wrote: Dne 12.1.2015 v 16:30 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 12.1.2015 v 13:37 David Kupka napsal(a): On 01/12/2015 01:14 PM, Jan Cholasta wrote: Dne 12.1.2015 v 13:08 M

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

On 01/13/2015 02:57 PM, Jan Cholasta wrote: Dne 13.1.2015 v 14:44 David Kupka napsal(a): On 01/12/2015 04:50 PM, Rob Crittenden wrote: Jan Cholasta wrote: Dne 12.1.2015 v 16:30 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 12.1.2015 v 13:37 David Kupka napsal(a): On 01/12/2015 01:14 PM,

Re: [Freeipa-devel] [PATCH 0319] Fix crash caused by race condition during resolver cache flushing

On 13.1.2015 14:16, Petr Spacek wrote: > Hello, > > This patch should be applied to v2 branch. > > Fix crash caused by race condition during resolver cache flushing. > > dns_view_flushcache() call has to be always done in single-thread mode. > Locking around the call was missing in forwarder rec

Re: [Freeipa-devel] [PATCH] 0037 Remove ipanttrustauthincoming/ipanttrustauthoutgoing from ipa trust-add output.

On 01/13/2015 01:51 PM, David Kupka wrote: On 01/13/2015 01:39 PM, Petr Vobornik wrote: On 01/13/2015 01:33 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4787 Haven't try it, but: have you considered: result['result'].pop('ipanttrustauthincoming', None) ? I haven't and

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

On 01/13/2015 03:07 PM, David Kupka wrote: On 01/13/2015 02:57 PM, Jan Cholasta wrote: Dne 13.1.2015 v 14:44 David Kupka napsal(a): On 01/12/2015 04:50 PM, Rob Crittenden wrote: Jan Cholasta wrote: Dne 12.1.2015 v 16:30 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 12.1.2015 v 13:37 Dav

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

Dne 13.1.2015 v 15:54 David Kupka napsal(a): On 01/13/2015 03:07 PM, David Kupka wrote: On 01/13/2015 02:57 PM, Jan Cholasta wrote: Dne 13.1.2015 v 14:44 David Kupka napsal(a): On 01/12/2015 04:50 PM, Rob Crittenden wrote: Jan Cholasta wrote: Dne 12.1.2015 v 16:30 Rob Crittenden napsal(a):

Re: [Freeipa-devel] [PATCH 0001] ipa-client-install: attempt to get host TGT several times before aborting client installation

Jan Cholasta wrote: > Dne 13.1.2015 v 09:22 Martin Kosek napsal(a): >> On 01/12/2015 05:45 PM, Martin Babinsky wrote: >>> related to ticket https://fedorahosted.org/freeipa/ticket/4808 >>> >>> Patch attached. >>> >>> Martin^3 >> >> I think the --tgt-kinit-attempts approach is good one. Couple comme

Re: [Freeipa-devel] [PATCH 0286] baseldap: Handle missing parent objects properly in *-find

On 11/21/2014 01:46 PM, Jan Cholasta wrote: > Dne 21.11.2014 v 11:28 Tomas Babej napsal(a): >> >> On 11/20/2014 04:01 PM, Jan Cholasta wrote: >>> Dne 19.11.2014 v 15:12 Tomas Babej napsal(a): On 11/19/2014 02:03 PM, Jan Cholasta wrote: > Dne 19.11.2014 v 13:44 Tomas Babej napsal(a):

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

On 01/13/2015 02:26 PM, Jan Cholasta wrote: Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Note that --data with data-only backup and --logs-only with data-only restore are

Re: [Freeipa-devel] [PATCH] 389 Fix ipa-restore on systems without IPA installed

On 01/13/2015 11:54 AM, Jan Cholasta wrote: Dne 13.1.2015 v 10:46 Petr Vobornik napsal(a): On 01/12/2015 06:07 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza Is there a reason why `installutils.check_server_configuration() ` is ca

Re: [Freeipa-devel] [PATCH 0001] ipa-client-install: attempt to get host TGT several times before aborting client installation

On 01/13/2015 09:46 AM, Jan Cholasta wrote: Dne 13.1.2015 v 09:22 Martin Kosek napsal(a): On 01/12/2015 05:45 PM, Martin Babinsky wrote: related to ticket https://fedorahosted.org/freeipa/ticket/4808 Patch attached. Martin^3 I think the --tgt-kinit-attempts approach is good one. Couple comm

Re: [Freeipa-devel] [PATCH 0001] ipa-client-install: attempt to get host TGT several times before aborting client installation

On 01/13/2015 04:03 PM, Rob Crittenden wrote: Jan Cholasta wrote: Dne 13.1.2015 v 09:22 Martin Kosek napsal(a): On 01/12/2015 05:45 PM, Martin Babinsky wrote: related to ticket https://fedorahosted.org/freeipa/ticket/4808 Patch attached. Martin^3 I think the --tgt-kinit-attempts approach i

Re: [Freeipa-devel] [PATCH] 389 Fix ipa-restore on systems without IPA installed

Dne 13.1.2015 v 16:47 Petr Vobornik napsal(a): On 01/13/2015 11:54 AM, Jan Cholasta wrote: Dne 13.1.2015 v 10:46 Petr Vobornik napsal(a): On 01/12/2015 06:07 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza Is there a reason why `i

Re: [Freeipa-devel] [PATCH 0286] baseldap: Handle missing parent objects properly in *-find

Dne 13.1.2015 v 16:04 Tomas Babej napsal(a): On 11/21/2014 01:46 PM, Jan Cholasta wrote: Dne 21.11.2014 v 11:28 Tomas Babej napsal(a): On 11/20/2014 04:01 PM, Jan Cholasta wrote: Dne 19.11.2014 v 15:12 Tomas Babej napsal(a): On 11/19/2014 02:03 PM, Jan Cholasta wrote: Dne 19.11.2014 v 13:

Re: [Freeipa-devel] [PATCH] 389 Fix ipa-restore on systems without IPA installed

On 01/13/2015 05:06 PM, Jan Cholasta wrote: Dne 13.1.2015 v 16:47 Petr Vobornik napsal(a): On 01/13/2015 11:54 AM, Jan Cholasta wrote: Dne 13.1.2015 v 10:46 Petr Vobornik napsal(a): On 01/12/2015 06:07 PM, Jan Cholasta wrote: Hi, the attached patch fixes

Re: [Freeipa-devel] [PATCH] 389 Fix ipa-restore on systems without IPA installed

Dne 13.1.2015 v 17:20 Petr Vobornik napsal(a): On 01/13/2015 05:06 PM, Jan Cholasta wrote: Dne 13.1.2015 v 16:47 Petr Vobornik napsal(a): On 01/13/2015 11:54 AM, Jan Cholasta wrote: Dne 13.1.2015 v 10:46 Petr Vobornik napsal(a): On 01/12/2015 06:07 PM, Jan Cholasta wrote: Hi, the attached p

Re: [Freeipa-devel] [PATCH] 388 Remove RUV from LDIF files before using them in ipa-restore

On 01/12/2015 05:46 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza works for me, ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailma

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

Dne 13.1.2015 v 16:37 Petr Vobornik napsal(a): On 01/13/2015 02:26 PM, Jan Cholasta wrote: Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Note that --data with data-only b

Re: [Freeipa-devel] [PATCH] 390 Do not crash on unknown services in installutils.stopped_service

Dne 13.1.2015 v 12:12 Jan Cholasta napsal(a): Hi, the attached patch fixes . Honza Modified the fix to create only one service object in stopped_service. Updated patch attached. -- Jan Cholasta >From 2048ecf51b1bc40566abe7f267563aed7d46575e Mon

Re: [Freeipa-devel] [PATCH] 388 Remove RUV from LDIF files before using them in ipa-restore

Dne 13.1.2015 v 17:44 Petr Vobornik napsal(a): On 01/12/2015 05:46 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza works for me, ACK Thanks, pushed to: master: 05e6adecb51b93e9b9d2326df4eabee90c3dfe72 ipa-4-1: eb7917026d418a6d6a1e

Re: [Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

Dne 13.1.2015 v 17:45 Jan Cholasta napsal(a): Dne 13.1.2015 v 16:37 Petr Vobornik napsal(a): On 01/13/2015 02:26 PM, Jan Cholasta wrote: Dne 13.1.2015 v 13:01 Petr Vobornik napsal(a): On 01/12/2015 02:28 PM, Jan Cholasta wrote: Hi, the attached patch fixes

[Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

This is crude first version of the (working) fixes to fix Winsync/Passsync problems caused by the PermissionV2 refactoring. Simo/Petr3 or others, any concerns? -- Martin Kosek Supervisor, Software Engineering - Identity Management Team Red Hat Inc. From a22df9e17b22298c1409ec4f7830161364fedccd

Re: [Freeipa-devel] [PATCH] 386 Fix CA certificate renewal syslog alert

On 01/08/2015 05:04 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Hi! Thank

Re: [Freeipa-devel] [PATCH] 390 Do not crash on unknown services in installutils.stopped_service

On 01/13/2015 05:55 PM, Jan Cholasta wrote: Dne 13.1.2015 v 12:12 Jan Cholasta napsal(a): Hi, the attached patch fixes . Honza Modified the fix to create only one service object in stopped_service. Updated patch attached.

Re: [Freeipa-devel] [PATCHES] 391-392 Make certificate renewal process synchronized

On 01/13/2015 12:17 PM, Jan Cholasta wrote: Hi, the attached patches fix . Note that if you want to test upgrades on CA-less, you need to apply my patch 390 as well: . Honza

Re: [Freeipa-devel] [PATCH] 386 Fix CA certificate renewal syslog alert

Dne 13.1.2015 v 18:46 David Kupka napsal(a): On 01/08/2015 05:04 PM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.

Re: [Freeipa-devel] [PATCH] 390 Do not crash on unknown services in installutils.stopped_service

Dne 13.1.2015 v 18:46 David Kupka napsal(a): On 01/13/2015 05:55 PM, Jan Cholasta wrote: Dne 13.1.2015 v 12:12 Jan Cholasta napsal(a): Hi, the attached patch fixes . Honza Modified the fix to create only one service object in stopped_service. U

Re: [Freeipa-devel] [PATCHES] 391-392 Make certificate renewal process synchronized

Dne 13.1.2015 v 18:47 David Kupka napsal(a): On 01/13/2015 12:17 PM, Jan Cholasta wrote: Hi, the attached patches fix . Note that if you want to test upgrades on CA-less, you need to apply my patch 390 as well:

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

On Tue, 13 Jan 2015 18:16:11 +0100 Martin Kosek wrote: > This is crude first version of the (working) fixes to fix > Winsync/Passsync problems caused by the PermissionV2 refactoring. > > Simo/Petr3 or others, any concerns? > The first patch looks good the second looks .. broad ? Shouldn't you

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

On 01/13/2015 09:55 PM, Simo Sorce wrote: On Tue, 13 Jan 2015 18:16:11 +0100 Martin Kosek wrote: This is crude first version of the (working) fixes to fix Winsync/Passsync problems caused by the PermissionV2 refactoring. Simo/Petr3 or others, any concerns? The first patch looks good the se