Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-14 Thread Gabe Alford
Sounds good to me. Updated patch attached. On Mon, Sep 14, 2015 at 1:34 AM, Petr Spacek wrote: > On 14.9.2015 07:23, Jan Cholasta wrote: > > IMO it does, because saying just "-1 is default" is not entirely correct > and > > "0 is default" would be confusing, as you pointed

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-14 Thread Lenka Doudova
All good, ACK On 09/14/2015 11:54 AM, Milan Kubík wrote: On 09/14/2015 10:10 AM, Lenka Doudova wrote: NACK because: $ pep8 ipatests/test_xmlrpc/test_certprofile_plugin.py ipatests/test_xmlrpc/test_certprofile_plugin.py:213:8: E121 continuation line under-indented for hanging indent (just a

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-14 Thread Martin Basti
On 09/14/2015 01:49 PM, Lenka Doudova wrote: All good, ACK On 09/14/2015 11:54 AM, Milan Kubík wrote: On 09/14/2015 10:10 AM, Lenka Doudova wrote: NACK because: $ pep8 ipatests/test_xmlrpc/test_certprofile_plugin.py ipatests/test_xmlrpc/test_certprofile_plugin.py:213:8: E121 continuation

Re: [Freeipa-devel] [PATCHES 466-468] install: Add common base class for server and replica install

2015-09-14 Thread Jan Cholasta
On 10.8.2015 16:58, Martin Babinsky wrote: On 08/06/2015 08:22 AM, Jan Cholasta wrote: Hi, the attached patch fixes part of . See also Martin Babinsky's patch 51: . Honza

Re: [Freeipa-devel] [PATCH] 916 vault: add vault container commands

2015-09-14 Thread Jan Cholasta
On 9.9.2015 18:39, Petr Vobornik wrote: On 09/09/2015 10:52 AM, Jan Cholasta wrote: On 8.9.2015 23:06, Petr Vobornik wrote: On 09/03/2015 03:18 PM, Jan Cholasta wrote: On 2.9.2015 07:26, Endi Sukma Dewata wrote: On 9/1/2015 10:22 AM, Simo Sorce wrote: On Tue, 2015-09-01 at 17:15 +0200, Petr

[Freeipa-devel] Fwd: [dnsext] New RRtype "KREALM" in draft-vanrein-dnstxt-krb1-02: service->realm mapping

2015-09-14 Thread Petr Spacek
Hello, Kerberos experts might be interested in this draft. I did not have time to go through this yet. Discussion continues on dns...@ietf.org, please reply there. Petr^2 Spacek Forwarded Message Subject: [dnsext] New RRtype "KREALM" in draft-vanrein-dnstxt-krb1-02.txt Date:

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-14 Thread Petr Spacek
On 14.9.2015 07:23, Jan Cholasta wrote: > IMO it does, because saying just "-1 is default" is not entirely correct and > "0 is default" would be confusing, as you pointed out. You might say "0 or -1 > is unlimited" if you think it's clearer. my +1 to "0 or -1 is unlimited" variant Petr^2 Spacek

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-14 Thread Lenka Doudova
NACK because: $ pep8 ipatests/test_xmlrpc/test_certprofile_plugin.py ipatests/test_xmlrpc/test_certprofile_plugin.py:213:8: E121 continuation line under-indented for hanging indent (just a missing space in the indent) Lenka On 09/11/2015 01:47 PM, Milan Kubík wrote: On 09/11/2015 12:43 PM,

Re: [Freeipa-devel] cert profiles - test plan + patches

2015-09-14 Thread Milan Kubík
On 09/14/2015 10:10 AM, Lenka Doudova wrote: NACK because: $ pep8 ipatests/test_xmlrpc/test_certprofile_plugin.py ipatests/test_xmlrpc/test_certprofile_plugin.py:213:8: E121 continuation line under-indented for hanging indent (just a missing space in the indent) Lenka On 09/11/2015 01:47