Re: [Freeipa-devel] [PATCH 154] ipa-kdb: map_groups() consider all results

2016-02-02 Thread Alexander Bokovoy
On Mon, 01 Feb 2016, Jakub Hrozek wrote: On Tue, Jan 05, 2016 at 07:55:33PM +0100, Sumit Bose wrote: Hi, to find out to which local group a external user is mapped we do a dereference search over the external groups with the SIDs related to the external user. If a SID is mapped to more than one

Re: [Freeipa-devel] [PATCH 0132] always start certmonger during IPA server configuration upgrade

2016-02-02 Thread Jan Cholasta
On 1.2.2016 14:54, Martin Basti wrote: On 01.02.2016 13:55, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5655 LGTM, works for me, tested on both ca-less server and CA-full server. Because patch is touching certmonger I would like to get final ACK from Honza. This is s

[Freeipa-devel] [PATCH] CONFIGURE: Replace obsolete macros

2016-02-02 Thread Lukas Slebodnik
ehlo, The AC_PROG_LIBTOOL macro is obsoleted by since libtool-2.0 which is already in rhel6+ https://fedorahosted.org/FedoraReview/wiki/AutoTools simple patch is attached LS >From 079fbfa32cb7c70d76828d96f1db3ed05e7e10c0 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Tue, 2 Feb 2016 09:0

Re: [Freeipa-devel] [PATCH 0132] always start certmonger during IPA server configuration upgrade

2016-02-02 Thread Martin Babinsky
On 02/02/2016 09:33 AM, Jan Cholasta wrote: On 1.2.2016 14:54, Martin Basti wrote: On 01.02.2016 13:55, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5655 LGTM, works for me, tested on both ca-less server and CA-full server. Because patch is touching certmonger I would

Re: [Freeipa-devel] [PATCH 0132] always start certmonger during IPA server configuration upgrade

2016-02-02 Thread Jan Cholasta
On 2.2.2016 11:41, Martin Babinsky wrote: On 02/02/2016 09:33 AM, Jan Cholasta wrote: On 1.2.2016 14:54, Martin Basti wrote: On 01.02.2016 13:55, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5655 LGTM, works for me, tested on both ca-less server and CA-full server. Be

Re: [Freeipa-devel] [PATCH 0132] always start certmonger during IPA server configuration upgrade

2016-02-02 Thread Jan Cholasta
On 2.2.2016 11:46, Jan Cholasta wrote: On 2.2.2016 11:41, Martin Babinsky wrote: On 02/02/2016 09:33 AM, Jan Cholasta wrote: On 1.2.2016 14:54, Martin Basti wrote: On 01.02.2016 13:55, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5655 LGTM, works for me, tested on bot

Re: [Freeipa-devel] [PATCH 0011-0012][RFE] ipa-replica-manage: automatically clean dangling RUVs

2016-02-02 Thread Martin Basti
On 29.01.2016 08:42, Stanislav Laznicka wrote: On 01/26/2016 06:56 PM, Martin Basti wrote: On 25.01.2016 16:41, Stanislav Laznicka wrote: Hi, Worked those comments into the code. Also added a bit different info message in clean_ruv with ca=True (ipa-replica-manage:430). Also adding step

Re: [Freeipa-devel] [PATCH 0132] always start certmonger during IPA server configuration upgrade

2016-02-02 Thread Martin Basti
On 02.02.2016 12:18, Jan Cholasta wrote: On 2.2.2016 11:46, Jan Cholasta wrote: On 2.2.2016 11:41, Martin Babinsky wrote: On 02/02/2016 09:33 AM, Jan Cholasta wrote: On 1.2.2016 14:54, Martin Basti wrote: On 01.02.2016 13:55, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket

Re: [Freeipa-devel] [PATCH 0022-23] Coverity patches

2016-02-02 Thread Stanislav Laznicka
On 02/01/2016 02:24 PM, Jan Cholasta wrote: On 1.2.2016 12:11, Petr Spacek wrote: On 1.2.2016 09:03, Jan Cholasta wrote: Hi, On 29.1.2016 15:49, Martin Basti wrote: On 29.01.2016 15:49, Stanislav Laznicka wrote: Reworded the commits so that they better reflect what's going on in those. O

[Freeipa-devel] [PATCH 0133] re-add missing fixture import to the CA ACL plugin test

2016-02-02 Thread Martin Babinsky
This was causing some of the CA ACL plugin tests to fail/error. -- Martin^3 Babinsky From dd0f3a8523f3092034a863c2a525aef03672e5dd Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Tue, 2 Feb 2016 15:30:27 +0100 Subject: [PATCH] re-add missing fixture import to the CA ACL plugin test --- ip

Re: [Freeipa-devel] [PATCH 0133] re-add missing fixture import to the CA ACL plugin test

2016-02-02 Thread Milan KubĂ­k
On 02/02/2016 03:36 PM, Martin Babinsky wrote: This was causing some of the CA ACL plugin tests to fail/error. Possible NACK. This is not an officially supported way how to reuse fixtures. [1] I was working on a fix, that would contain all of the needed fixtures in the module that requires the

[Freeipa-devel] [PATCH] typo in service

2016-02-02 Thread Martin Basti
I acked&pushed patch attached to ticket: https://fedorahosted.org/freeipa/ticket/5659 Pushed to master: d85d70947361abd3822b8f42fa3de16e26e87d57 Martin^2 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [PATCH 0085] Fix ipa-adtrust-install to always generate SRV records with FQDN

2016-02-02 Thread Petr Spacek
Hello, Fix ipa-adtrust-install to always generate SRV records with FQDNs Previous code failed in following setup: * IPA domain = ipa.example.com * IPA master = vm1.example.com * IPA replica = vm2.example.com https://fedorahosted.org/freeipa/ticket/5663 -- Petr^2 Spacek From d4d13e003b9fb7153e2

Re: [Freeipa-devel] [PATCH] IPA-SAM: Fix build with samba 4.4

2016-02-02 Thread Lukas Slebodnik
On (29/01/16 12:12), Lukas Slebodnik wrote: >ehlo, > >attached patch shoudl fix build on fedora-24. >It blocks static analysis scan. > >Even though it unblock build on fedora-24 >the solution is not ideal. It's possible that some changes >need to be done in samba side as well. >(missing prototypes

Re: [Freeipa-devel] [PATCH] IPA-SAM: Fix build with samba 4.4

2016-02-02 Thread Alexander Bokovoy
On Tue, 02 Feb 2016, Lukas Slebodnik wrote: On (29/01/16 12:12), Lukas Slebodnik wrote: ehlo, attached patch shoudl fix build on fedora-24. It blocks static analysis scan. Even though it unblock build on fedora-24 the solution is not ideal. It's possible that some changes need to be done in sa

Re: [Freeipa-devel] [PATCH 0085] Fix ipa-adtrust-install to always generate SRV records with FQDN

2016-02-02 Thread Alexander Bokovoy
On Tue, 02 Feb 2016, Petr Spacek wrote: Hello, Fix ipa-adtrust-install to always generate SRV records with FQDNs Previous code failed in following setup: * IPA domain = ipa.example.com * IPA master = vm1.example.com * IPA replica = vm2.example.com https://fedorahosted.org/freeipa/ticket/5663

Re: [Freeipa-devel] [PATCH 154] ipa-kdb: map_groups() consider all results

2016-02-02 Thread Petr Vobornik
On 02/02/2016 09:21 AM, Alexander Bokovoy wrote: On Mon, 01 Feb 2016, Jakub Hrozek wrote: On Tue, Jan 05, 2016 at 07:55:33PM +0100, Sumit Bose wrote: Hi, to find out to which local group a external user is mapped we do a dereference search over the external groups with the SIDs related to the

Re: [Freeipa-devel] [PATCH 0085] Fix ipa-adtrust-install to always generate SRV records with FQDN

2016-02-02 Thread Petr Vobornik
On 02/02/2016 05:55 PM, Alexander Bokovoy wrote: On Tue, 02 Feb 2016, Petr Spacek wrote: Hello, Fix ipa-adtrust-install to always generate SRV records with FQDNs Previous code failed in following setup: * IPA domain = ipa.example.com * IPA master = vm1.example.com * IPA replica = vm2.example.c

Re: [Freeipa-devel] [PATCH] IPA-SAM: Fix build with samba 4.4

2016-02-02 Thread Petr Vobornik
On 02/02/2016 05:54 PM, Alexander Bokovoy wrote: On Tue, 02 Feb 2016, Lukas Slebodnik wrote: On (29/01/16 12:12), Lukas Slebodnik wrote: ehlo, attached patch shoudl fix build on fedora-24. It blocks static analysis scan. Even though it unblock build on fedora-24 the solution is not ideal. It'

Re: [Freeipa-devel] [PATCH] 0003 webui: Issue New Certificate dialogs validates data

2016-02-02 Thread Petr Vobornik
On 01/29/2016 10:58 AM, Pavel Vomacka wrote: On 01/28/2016 07:28 PM, Petr Vobornik wrote: Hi, there are few issues, NACK. 1. this patch uses tabs instead of spaces, previous was correct Fixed. 2. code which focuses first invalid field could be replaced by: widget_mod.focus_invalid(that);