[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-11-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management mbasti-rh commented: """ INFO related to LDAPError: ``` -> desc = e.args[0]['desc'].strip() (Pdb) print e LDAPError(2, 'No such file or directory') (Pdb) print self.ldap_uri 'master.ipa.test'

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-11-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management mbasti-rh commented: """ @jcholast how? With this patchset you have to set `None` to time_limit/size_limit to apply `ipa config` limits because `_missing` means "unlimited" ``` if

[Freeipa-devel] [freeipa PR#202][comment] ipa-getkeytab enhancements

2016-11-04 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/202 Title: #202: ipa-getkeytab enhancements martbab commented: """ Bump for review, this is prerequisite to further installer refactoring work. """ See the full comment at https://github.com/freeipa/freeipa/pull/202#issuecomment-258369401 --

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-11-04 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management jcholast commented: """ @mbasti: Because if the argument default values were constants as you suggested, they would take precedence over `ipa config` limits. """ See the full comment at

[Freeipa-devel] [freeipa PR#207][synchronized] Provide user hint about IP address in IPA install

2016-11-04 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/207 Author: Akasurde Title: #207: Provide user hint about IP address in IPA install Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/207/head:pr207 git checkout

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-11-04 Thread jcholast
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management jcholast commented: """ @mbasti: YDUC, that would break `ipa config`-defined limits. """ See the full comment at https://github.com/freeipa/freeipa/pull/145#issuecomment-258357216 -- Manage

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-11-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management mbasti-rh commented: """ NACK Multiple tests are failing with: ``` TypeError: 'int' object has no attribute '__getitem__' self = def test_full_backup_and_restore(self):

[Freeipa-devel] [freeipa PR#202][synchronized] ipa-getkeytab enhancements

2016-11-04 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/202 Author: martbab Title: #202: ipa-getkeytab enhancements Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/202/head:pr202 git checkout pr202 From

[Freeipa-devel] [freeipa PR#145][comment] Refactoring: LDAP Connection Management

2016-11-04 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management pvoborni commented: """ We have a lot of refactoring patches which needs to be serialized and pushed and we don't have much time for it. If the remaining issue doesn't break everything else

[Freeipa-devel] [freeipa PR#212][opened] KRA: don't add KRA container when KRA replica

2016-11-04 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/212 Author: mbasti-rh Title: #212: KRA: don't add KRA container when KRA replica Action: opened PR body: """ Regression in master branch only This fixes regression caused by c56256e2a29f076e6afa559225a66f58b0773eb5 """ [9/11]: add vault