URL: https://github.com/freeipa/freeipa/pull/145 Title: #145: Refactoring: LDAP Connection Management
mbasti-rh commented: """ NACK Multiple tests are failing with: ``` TypeError: 'int' object has no attribute '__getitem__' self = <ipatests.test_integration.test_backup_and_restore.TestBackupAndRestore object at 0x7f61d7dade10> def test_full_backup_and_restore(self): """backup, uninstall, restore""" > with restore_checker(self.master): test_integration/test_backup_and_restore.py:146: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ /usr/lib64/python2.7/contextlib.py:17: in __enter__ return self.gen.next() test_integration/test_backup_and_restore.py:114: in restore_checker results.append(check(host)) test_integration/test_backup_and_restore.py:53: in check_admin_in_ldap ldap = host.ldap_connect() test_integration/host.py:47: in ldap_connect ldap_uri = ipaldap.LDAPClient(self.external_hostname) ../ipapython/ipaldap.py:747: in __init__ self._conn = self._connect() ../ipapython/ipaldap.py:1120: in _connect conn.start_tls_s() /usr/lib64/python2.7/contextlib.py:35: in __exit__ self.gen.throw(type, value, traceback) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <ipapython.ipaldap.LDAPClient object at 0x7f61d7d8d8d0>, arg_desc = None @contextlib.contextmanager def error_handler(self, arg_desc=None): """Context manager that handles LDAPErrors """ try: try: yield except ldap.TIMEOUT: raise errors.DatabaseTimeout() except ldap.LDAPError as e: > desc = e.args[0]['desc'].strip() E TypeError: 'int' object has no attribute '__getitem__' ../ipapython/ipaldap.py:995: TypeError ``` and replica installations fails in some cases with ``` <DEBUG>: [5/7]: enable GSSAPI for replication <DEBUG>: [error] OBJECT_CLASS_VIOLATION: {'desc': 'Object class violation'} <DEBUG>: ipa.ipapython.install.cli.install_tool(Replica): ERROR {'desc': 'Object class violation'} <DEBUG>: ipa.ipapython.install.cli.install_tool(Replica): ERROR The ipa-replica-install command failed. See /var/log/ipareplica-install.log for more information ``` None of above is happening in master branch tests. """ See the full comment at https://github.com/freeipa/freeipa/pull/145#issuecomment-258419460
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code