[Freeipa-devel] [freeipa PR#677][synchronized] cert: defer cert-find result post-processing

2017-04-18 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/677 Author: HonzaCholasta Title: #677: cert: defer cert-find result post-processing Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/677/head:pr677 git checkout p

[Freeipa-devel] [freeipa PR#718][opened] configure: fix AC_CHECK_LIB usage

2017-04-18 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/718 Author: HonzaCholasta Title: #718: configure: fix AC_CHECK_LIB usage Action: opened PR body: """ Replace empty string with a single space in the third argument of `AC_CHECK_LIB` (`action-if-found`) where applicable. Empty string in the argument

[Freeipa-devel] [freeipa PR#718][comment] configure: fix AC_CHECK_LIB usage

2017-04-18 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/718 Title: #718: configure: fix AC_CHECK_LIB usage tiran commented: """ Is this peculiar behavior of ```AC_CHECK_LIB``` documented somewhere? """ See the full comment at https://github.com/freeipa/freeipa/pull/718#issuecomment-294823623 -- Manage y

[Freeipa-devel] [freeipa PR#718][comment] configure: fix AC_CHECK_LIB usage

2017-04-18 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/718 Title: #718: configure: fix AC_CHECK_LIB usage HonzaCholasta commented: """ `info autoconf Libraries` says: > If ACTION-IF-FOUND is not > specified, the default action prepends `-lLIBRARY' to `LIBS' and > defines `HAVE_LIBLIBRARY' (in all capitals

[Freeipa-devel] [freeipa PR#718][comment] configure: fix AC_CHECK_LIB usage

2017-04-18 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/718 Title: #718: configure: fix AC_CHECK_LIB usage lslebodn commented: """ >It does not explicitly say what constitutes an unspecified value though. ```[]``` means default action. BTW it is not peculiar behaviour because most project define custom LI

[Freeipa-devel] [freeipa PR#718][comment] configure: fix AC_CHECK_LIB usage

2017-04-18 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/718 Title: #718: configure: fix AC_CHECK_LIB usage lslebodn commented: """ >It does not explicitly say what constitutes an unspecified value though. ```, , ``` or ``` , [] ,``` are considered as unspecified values and therefore default action was us

[Freeipa-devel] [freeipa PR#718][comment] configure: fix AC_CHECK_LIB usage

2017-04-18 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/718 Title: #718: configure: fix AC_CHECK_LIB usage lslebodn commented: """ A little bit offtopic. It is interesting that you look for the function `main` in libkrad. Because it does not exist there. I've just noticed it. ``` sh# nm --defined-only --d

[Freeipa-devel] [freeipa PR#694][synchronized] RFC: implement local PKINIT deployment in server/replica install

2017-04-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/694 Author: martbab Title: #694: RFC: implement local PKINIT deployment in server/replica install Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/694/head:pr694

[Freeipa-devel] [freeipa PR#694][comment] RFC: implement local PKINIT deployment in server/replica install

2017-04-18 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/694 Title: #694: RFC: implement local PKINIT deployment in server/replica install martbab commented: """ I have added comments to the "hidden" PKINIT setup steps. I would also like @simo5 and @abbra to answer further comments regarding thid PR. It wa

[Freeipa-devel] [freeipa PR#719][opened] External CA fixes

2017-04-18 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/719 Author: stlaz Title: #719: External CA fixes Action: opened PR body: """ External CA installation would have failed for 2 reasons: - Trying to perform Kerberos install twice (for some reason our QA forgot to tell us that) - Rewriting the CA cer

[Freeipa-devel] [freeipa PR#716][comment] Fix minor typos

2017-04-18 Thread realsobek
URL: https://github.com/freeipa/freeipa/pull/716 Title: #716: Fix minor typos realsobek commented: """ > There are no tickets associated with these changes. On the other hand, if the ticket is required for giving attribution, I will create it. """ See the full comment at https://github.com/fr

[Freeipa-devel] [freeipa PR#716][comment] Fix minor typos

2017-04-18 Thread realsobek
URL: https://github.com/freeipa/freeipa/pull/716 Title: #716: Fix minor typos realsobek commented: """ > There are no tickets associated with these changes. On the other hand, if the ticket is required for giving attribution, I will create it. """ See the full comment at https://github.com/fr

[Freeipa-devel] [freeipa PR#719][edited] External CA fixes

2017-04-18 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/719 Author: stlaz Title: #719: External CA fixes Action: edited Changed field: body Original value: """ External CA installation would have failed for 2 reasons: - Trying to perform Kerberos install twice (for some reason our QA forgot to tell us