Re: [Freeipa-devel] [PATCH] 0002 Fix/add options in ipa-managed-entries man page
On 02/06/2012 06:51 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/06/2012 10:26 AM, Martin Kosek wrote: On Mon, 2012-02-06 at 10:22 -0500, Rob Crittenden wrote: Petr Viktorin wrote: This fixes the name of the --entry option in the man page (https://fedorahosted.org/freeipa/ticket/2277), and adds options that were missing. I think Martin noticed while looking at one of my patches that we shouldn't be calling: config.add_standard_options(parser) That will remove --server, --realm and --domain which aren't actually used by the tool so should be removed. rob Yes, these are not used in ipa-managed-entries. We should either remove them from the script at all (if it is OK to change CLI API) or modify ipa-managed-entries to use them correctly. So far these options are used only in install/tools/ipa-compat-manage install/tools/ipa-nis-manage We are deprecating those, right? If so then remove and doc. We're deprecating neither the options or the tools. The options were inadvertently added to at tool that doesn't need them. We'll remove them from ipa-managed-entries. They are currently undocumented. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Attaching updated patch. This one only fixes --entry and adds --help. From dc835f88a8e005733caeb1e205219da61d3731a7 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Mon, 6 Feb 2012 07:59:47 -0500 Subject: [PATCH] Fix/add options in ipa-managed-entries man page * The --entry option was wrongly listed as --entries; fix that. https://fedorahosted.org/freeipa/ticket/2277 * Add the --help option --- install/tools/man/ipa-managed-entries.1 |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/install/tools/man/ipa-managed-entries.1 b/install/tools/man/ipa-managed-entries.1 index 24d8d56c97873c163760cadfe02893cacc6fc4b2..59b04c39477b2115fd458f520573185a72a293df 100644 --- a/install/tools/man/ipa-managed-entries.1 +++ b/install/tools/man/ipa-managed-entries.1 @@ -16,7 +16,7 @@ .\ .\ Author: Jr Aquino jr.aqu...@citrix.com .\ -.TH ipa-managed-entries 1 Sept 15 2011 FreeIPA FreeIPA Manual +.TH ipa-managed-entries 1 Feb 06 2012 FreeIPA FreeIPA Manual Pages .SH NAME ipa\-managed\-entries \- Enables or disables the schema Managed Entry plugins @@ -35,10 +35,13 @@ Directory Server will need to be restarted after the Managed Entry plugin has be .SH OPTIONS .TP +\fB\-h\fR, \fB\-\-help\fR +Show a help message and exit +.TP \fB\-d\fR, \fB\-\-debug\fR Enable debug logging when more verbose output is needed .TP -\fB\-e\fR, \fB\-\-entries\fR +\fB\-e\fR, \fB\-\-entry\fR DN for the Managed Entry Definition .TP \fB\-l\fR, \fB-\-list\fR -- 1.7.7.6 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0002 Fix/add options in ipa-managed-entries man page
On Tue, 2012-02-07 at 09:20 +0100, Petr Viktorin wrote: On 02/06/2012 06:51 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/06/2012 10:26 AM, Martin Kosek wrote: On Mon, 2012-02-06 at 10:22 -0500, Rob Crittenden wrote: Petr Viktorin wrote: This fixes the name of the --entry option in the man page (https://fedorahosted.org/freeipa/ticket/2277), and adds options that were missing. I think Martin noticed while looking at one of my patches that we shouldn't be calling: config.add_standard_options(parser) That will remove --server, --realm and --domain which aren't actually used by the tool so should be removed. rob Yes, these are not used in ipa-managed-entries. We should either remove them from the script at all (if it is OK to change CLI API) or modify ipa-managed-entries to use them correctly. So far these options are used only in install/tools/ipa-compat-manage install/tools/ipa-nis-manage We are deprecating those, right? If so then remove and doc. We're deprecating neither the options or the tools. The options were inadvertently added to at tool that doesn't need them. We'll remove them from ipa-managed-entries. They are currently undocumented. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Attaching updated patch. This one only fixes --entry and adds --help. ACK. Pushed to master, ipa-2-2. I will send a patch to remove these redundant options from ipa-managed-entries. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
[Freeipa-devel] [PATCH] 0002 Fix/add options in ipa-managed-entries man page
This fixes the name of the --entry option in the man page (https://fedorahosted.org/freeipa/ticket/2277), and adds options that were missing. From 69836c87eb5f4bcee1664dcc0cf71c53862f7341 Mon Sep 17 00:00:00 2001 From: Petr Viktorin pvikt...@redhat.com Date: Mon, 6 Feb 2012 07:59:47 -0500 Subject: [PATCH] Fix/add options in ipa-managed-entries man page * The --entry option was wrongly listed as --entries; fix that. https://fedorahosted.org/freeipa/ticket/2277 * Add the --realm, --server, and --domain options, as listed by `ipa-managed-entries -h`. --- install/tools/man/ipa-managed-entries.1 | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/install/tools/man/ipa-managed-entries.1 b/install/tools/man/ipa-managed-entries.1 index 24d8d56c97873c163760cadfe02893cacc6fc4b2..10ec3592f6ba1f3b2e8edd081c7c0add9e93d801 100644 --- a/install/tools/man/ipa-managed-entries.1 +++ b/install/tools/man/ipa-managed-entries.1 @@ -16,7 +16,7 @@ .\ .\ Author: Jr Aquino jr.aqu...@citrix.com .\ -.TH ipa-managed-entries 1 Sept 15 2011 FreeIPA FreeIPA Manual +.TH ipa-managed-entries 1 Feb 06 2012 FreeIPA FreeIPA Manual Pages .SH NAME ipa\-managed\-entries \- Enables or disables the schema Managed Entry plugins @@ -35,10 +35,13 @@ Directory Server will need to be restarted after the Managed Entry plugin has be .SH OPTIONS .TP +\fB\-h\fR, \fB\-\-help\fR +Show a help message and exit +.TP \fB\-d\fR, \fB\-\-debug\fR Enable debug logging when more verbose output is needed .TP -\fB\-e\fR, \fB\-\-entries\fR +\fB\-e\fR, \fB\-\-entry\fR DN for the Managed Entry Definition .TP \fB\-l\fR, \fB-\-list\fR @@ -46,6 +49,15 @@ List available Managed Entries .TP \fB\-p\fR \fIDM_PASSWORD\fR, \fB\-\-password\fR=\fIDM_PASSWORD\fR The Directory Manager password to use for authentication +.TP +\fB\-\-realm\fR=\fIREALM\fR +Override default IPA realm +.TP +\fB\-\-server\fR=\fISERVER\fR +Override default IPA server +.TP +\fB\-\-domain\fR=\fIDOMAIN\fR +Override default IPA DNS domain .SH EXIT STATUS 0 if the command was successful -- 1.7.7.6 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0002 Fix/add options in ipa-managed-entries man page
Petr Viktorin wrote: This fixes the name of the --entry option in the man page (https://fedorahosted.org/freeipa/ticket/2277), and adds options that were missing. I think Martin noticed while looking at one of my patches that we shouldn't be calling: config.add_standard_options(parser) That will remove --server, --realm and --domain which aren't actually used by the tool so should be removed. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0002 Fix/add options in ipa-managed-entries man page
On Mon, 2012-02-06 at 10:22 -0500, Rob Crittenden wrote: Petr Viktorin wrote: This fixes the name of the --entry option in the man page (https://fedorahosted.org/freeipa/ticket/2277), and adds options that were missing. I think Martin noticed while looking at one of my patches that we shouldn't be calling: config.add_standard_options(parser) That will remove --server, --realm and --domain which aren't actually used by the tool so should be removed. rob Yes, these are not used in ipa-managed-entries. We should either remove them from the script at all (if it is OK to change CLI API) or modify ipa-managed-entries to use them correctly. So far these options are used only in install/tools/ipa-compat-manage install/tools/ipa-nis-manage Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0002 Fix/add options in ipa-managed-entries man page
On 02/06/2012 10:26 AM, Martin Kosek wrote: On Mon, 2012-02-06 at 10:22 -0500, Rob Crittenden wrote: Petr Viktorin wrote: This fixes the name of the --entry option in the man page (https://fedorahosted.org/freeipa/ticket/2277), and adds options that were missing. I think Martin noticed while looking at one of my patches that we shouldn't be calling: config.add_standard_options(parser) That will remove --server, --realm and --domain which aren't actually used by the tool so should be removed. rob Yes, these are not used in ipa-managed-entries. We should either remove them from the script at all (if it is OK to change CLI API) or modify ipa-managed-entries to use them correctly. So far these options are used only in install/tools/ipa-compat-manage install/tools/ipa-nis-manage We are deprecating those, right? If so then remove and doc. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel -- Thank you, Dmitri Pal Sr. Engineering Manager IPA project, Red Hat Inc. --- Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0002 Fix/add options in ipa-managed-entries man page
Dmitri Pal wrote: On 02/06/2012 10:26 AM, Martin Kosek wrote: On Mon, 2012-02-06 at 10:22 -0500, Rob Crittenden wrote: Petr Viktorin wrote: This fixes the name of the --entry option in the man page (https://fedorahosted.org/freeipa/ticket/2277), and adds options that were missing. I think Martin noticed while looking at one of my patches that we shouldn't be calling: config.add_standard_options(parser) That will remove --server, --realm and --domain which aren't actually used by the tool so should be removed. rob Yes, these are not used in ipa-managed-entries. We should either remove them from the script at all (if it is OK to change CLI API) or modify ipa-managed-entries to use them correctly. So far these options are used only in install/tools/ipa-compat-manage install/tools/ipa-nis-manage We are deprecating those, right? If so then remove and doc. We're deprecating neither the options or the tools. The options were inadvertently added to at tool that doesn't need them. We'll remove them from ipa-managed-entries. They are currently undocumented. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
