Re: [Freeipa-devel] [PATCH] 0201 Add support for an external trust to Active Directory domain

2016-06-09 Thread Martin Basti
On 09.06.2016 18:03, Martin Babinsky wrote: On 06/07/2016 10:25 PM, Alexander Bokovoy wrote: On Tue, 07 Jun 2016, Alexander Bokovoy wrote: > del attrs['ipanttrusttype'] > +if attributes: > +del attrs['ipanttrustattributes'] > """ Updated

Re: [Freeipa-devel] [PATCH] 0201 Add support for an external trust to Active Directory domain

2016-06-09 Thread Martin Babinsky
On 06/07/2016 10:25 PM, Alexander Bokovoy wrote: On Tue, 07 Jun 2016, Alexander Bokovoy wrote: > del attrs['ipanttrusttype'] > +if attributes: > +del attrs['ipanttrustattributes'] > """ Updated patch is attached. Another update, forgot one

Re: [Freeipa-devel] [PATCH] 0201 Add support for an external trust to Active Directory domain

2016-06-07 Thread Alexander Bokovoy
On Tue, 07 Jun 2016, Alexander Bokovoy wrote: > del attrs['ipanttrusttype'] > +if attributes: > +del attrs['ipanttrustattributes'] > """ Updated patch is attached. Another update, forgot one space in the allow_behavior(). I also spent some

Re: [Freeipa-devel] [PATCH] 0201 Add support for an external trust to Active Directory domain

2016-06-07 Thread Alexander Bokovoy
On Tue, 07 Jun 2016, Martin Babinsky wrote: Again, we only require contributors to follow PEP8 when adding new code/directly touching old one. Please note that there are more serious transgressions than a couple of long lines that should _definitely_ be fixed (indentation errors, whitespace

Re: [Freeipa-devel] [PATCH] 0201 Add support for an external trust to Active Directory domain

2016-06-07 Thread Martin Babinsky
On 06/07/2016 06:00 PM, Alexander Bokovoy wrote: On Tue, 07 Jun 2016, Martin Babinsky wrote: On 06/06/2016 12:33 PM, Alexander Bokovoy wrote: Hi, this patch adds support for external trust to Active Directory. External trust is a trust that can be created between Active Directory domains

Re: [Freeipa-devel] [PATCH] 0201 Add support for an external trust to Active Directory domain

2016-06-07 Thread Alexander Bokovoy
On Tue, 07 Jun 2016, Martin Babinsky wrote: On 06/06/2016 12:33 PM, Alexander Bokovoy wrote: Hi, this patch adds support for external trust to Active Directory. External trust is a trust that can be created between Active Directory domains that are in different forests or between an Active

Re: [Freeipa-devel] [PATCH] 0201 Add support for an external trust to Active Directory domain

2016-06-07 Thread Martin Babinsky
On 06/06/2016 12:33 PM, Alexander Bokovoy wrote: Hi, this patch adds support for external trust to Active Directory. External trust is a trust that can be created between Active Directory domains that are in different forests or between an Active Directory domain. Since FreeIPA does not

[Freeipa-devel] [PATCH] 0201 Add support for an external trust to Active Directory domain

2016-06-06 Thread Alexander Bokovoy
Hi, this patch adds support for external trust to Active Directory. External trust is a trust that can be created between Active Directory domains that are in different forests or between an Active Directory domain. Since FreeIPA does not support non-Kerberos means of communication, external