Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-07 Thread Endi Sukma Dewata
On 7/7/2011 4:57 PM, Adam Young wrote: No longer testing on blur, as it was causing to many issues. Now checking upon click of the add button. ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https:

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-07 Thread Adam Young
On 07/07/2011 04:46 PM, Adam Young wrote: No longer testing on blur, as it was causing to many issues. Now checking upon click of the add button. On 07/07/2011 12:05 AM, Endi Sukma Dewata wrote: On 7/6/2011 7:56 PM, Adam Young wrote: 1. The check_required() is only called in blur events.

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-07 Thread Adam Young
No longer testing on blur, as it was causing to many issues. Now checking upon click of the add button. On 07/07/2011 12:05 AM, Endi Sukma Dewata wrote: On 7/6/2011 7:56 PM, Adam Young wrote: 1. The check_required() is only called in blur events. It's not called on Add/Update. Fixed. Loo

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-06 Thread Endi Sukma Dewata
On 7/6/2011 7:56 PM, Adam Young wrote: 1. The check_required() is only called in blur events. It's not called on Add/Update. Fixed. Looks like this works even for checkboxes. There seems to be a race condition. Open the group adder dialog, then click Add. Sometimes only group name gets an er

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-06 Thread Adam Young
On 07/06/2011 08:55 PM, Adam Young wrote: On 07/06/2011 08:12 PM, Endi Sukma Dewata wrote: On 7/6/2011 4:32 PM, Adam Young wrote: Some issues: 1. The check_required() is only called in blur events. It's not called on Add/Update. Fixed. Looks like this works even for checkboxes. To te

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-06 Thread Adam Young
On 07/06/2011 08:12 PM, Endi Sukma Dewata wrote: On 7/6/2011 4:32 PM, Adam Young wrote: Some issues: 1. The check_required() is only called in blur events. It's not called on Add/Update. Fixed. Looks like this works even for checkboxes. To test, open user's adder dialog, don't enter a

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-06 Thread Endi Sukma Dewata
On 7/6/2011 4:32 PM, Adam Young wrote: Some issues: 1. The check_required() is only called in blur events. It's not called on Add/Update. To test, open user's adder dialog, don't enter anything, just click Add. The server will return an error (i.e. check_required() not called). Another

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-06 Thread Adam Young
On 07/06/2011 03:44 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel From d6148920eb1b079e935162e930c81fb66c6cdaa6 Mon Sep 17 00:00:00 2001 From: Adam Young Date: We

[Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-06 Thread Adam Young
From cd7badadc666745ea4283f96f463140a626984b9 Mon Sep 17 00:00:00 2001 From: Adam Young Date: Wed, 6 Jul 2011 15:43:50 -0400 Subject: [PATCH] check required on blur previsouly was checked on key down, but that does the check too soon. https://fedorahosted.org/freeipa/ticket/1437 --- install/u